QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/third_party/quiche/src/quic/core/http/quic_spdy_stream.h" |
| 6 | |
| 7 | #include <memory> |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 8 | #include <string> |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 9 | #include <utility> |
| 10 | |
| 11 | #include "net/third_party/quiche/src/quic/core/http/http_encoder.h" |
| 12 | #include "net/third_party/quiche/src/quic/core/http/spdy_utils.h" |
| 13 | #include "net/third_party/quiche/src/quic/core/quic_connection.h" |
| 14 | #include "net/third_party/quiche/src/quic/core/quic_stream_sequencer_buffer.h" |
| 15 | #include "net/third_party/quiche/src/quic/core/quic_utils.h" |
| 16 | #include "net/third_party/quiche/src/quic/core/quic_versions.h" |
| 17 | #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 18 | #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" |
| 19 | #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" |
| 20 | #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 21 | #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" |
bnc | 7e9155d | 2019-11-21 17:50:40 -0800 | [diff] [blame] | 22 | #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 23 | #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 24 | #include "net/third_party/quiche/src/quic/test_tools/quic_connection_peer.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 25 | #include "net/third_party/quiche/src/quic/test_tools/quic_flow_controller_peer.h" |
| 26 | #include "net/third_party/quiche/src/quic/test_tools/quic_session_peer.h" |
| 27 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_session_peer.h" |
| 28 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_stream_peer.h" |
| 29 | #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" |
| 30 | #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 31 | #include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 32 | #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" |
| 33 | #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 34 | |
| 35 | using spdy::kV3HighestPriority; |
| 36 | using spdy::kV3LowestPriority; |
| 37 | using spdy::SpdyHeaderBlock; |
| 38 | using spdy::SpdyPriority; |
| 39 | using testing::_; |
| 40 | using testing::AtLeast; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 41 | using testing::ElementsAre; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 42 | using testing::Invoke; |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 43 | using testing::InvokeWithoutArgs; |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 44 | using testing::MatchesRegex; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 45 | using testing::Pair; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 46 | using testing::Return; |
| 47 | using testing::StrictMock; |
| 48 | |
| 49 | namespace quic { |
| 50 | namespace test { |
| 51 | namespace { |
| 52 | |
| 53 | const bool kShouldProcessData = true; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 54 | const char kDataFramePayload[] = "some data"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 55 | |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 56 | class TestCryptoStream : public QuicCryptoStream, public QuicCryptoHandshaker { |
| 57 | public: |
| 58 | explicit TestCryptoStream(QuicSession* session) |
| 59 | : QuicCryptoStream(session), |
| 60 | QuicCryptoHandshaker(this, session), |
| 61 | encryption_established_(false), |
| 62 | one_rtt_keys_available_(false), |
| 63 | params_(new QuicCryptoNegotiatedParameters) { |
| 64 | // Simulate a negotiated cipher_suite with a fake value. |
| 65 | params_->cipher_suite = 1; |
| 66 | } |
| 67 | |
| 68 | void OnHandshakeMessage(const CryptoHandshakeMessage& /*message*/) override { |
| 69 | encryption_established_ = true; |
| 70 | one_rtt_keys_available_ = true; |
| 71 | QuicErrorCode error; |
| 72 | std::string error_details; |
| 73 | session()->config()->SetInitialStreamFlowControlWindowToSend( |
| 74 | kInitialStreamFlowControlWindowForTest); |
| 75 | session()->config()->SetInitialSessionFlowControlWindowToSend( |
| 76 | kInitialSessionFlowControlWindowForTest); |
| 77 | if (session()->connection()->version().handshake_protocol == |
| 78 | PROTOCOL_TLS1_3) { |
| 79 | TransportParameters transport_parameters; |
| 80 | EXPECT_TRUE( |
| 81 | session()->config()->FillTransportParameters(&transport_parameters)); |
| 82 | error = session()->config()->ProcessTransportParameters( |
| 83 | transport_parameters, CLIENT, &error_details); |
| 84 | } else { |
| 85 | CryptoHandshakeMessage msg; |
| 86 | session()->config()->ToHandshakeMessage(&msg, transport_version()); |
| 87 | error = |
| 88 | session()->config()->ProcessPeerHello(msg, CLIENT, &error_details); |
| 89 | } |
| 90 | EXPECT_THAT(error, IsQuicNoError()); |
| 91 | session()->OnConfigNegotiated(); |
| 92 | session()->SetDefaultEncryptionLevel(ENCRYPTION_FORWARD_SECURE); |
| 93 | session()->DiscardOldEncryptionKey(ENCRYPTION_INITIAL); |
| 94 | } |
| 95 | |
| 96 | // QuicCryptoStream implementation |
| 97 | bool encryption_established() const override { |
| 98 | return encryption_established_; |
| 99 | } |
| 100 | bool one_rtt_keys_available() const override { |
| 101 | return one_rtt_keys_available_; |
| 102 | } |
| 103 | HandshakeState GetHandshakeState() const override { |
| 104 | return one_rtt_keys_available() ? HANDSHAKE_COMPLETE : HANDSHAKE_START; |
| 105 | } |
| 106 | const QuicCryptoNegotiatedParameters& crypto_negotiated_params() |
| 107 | const override { |
| 108 | return *params_; |
| 109 | } |
| 110 | CryptoMessageParser* crypto_message_parser() override { |
| 111 | return QuicCryptoHandshaker::crypto_message_parser(); |
| 112 | } |
| 113 | void OnPacketDecrypted(EncryptionLevel /*level*/) override {} |
| 114 | void OnOneRttPacketAcknowledged() override {} |
| 115 | void OnHandshakeDoneReceived() override {} |
| 116 | |
| 117 | MOCK_METHOD0(OnCanWrite, void()); |
| 118 | |
| 119 | bool HasPendingCryptoRetransmission() const override { return false; } |
| 120 | |
| 121 | MOCK_CONST_METHOD0(HasPendingRetransmission, bool()); |
| 122 | |
| 123 | private: |
| 124 | using QuicCryptoStream::session; |
| 125 | |
| 126 | bool encryption_established_; |
| 127 | bool one_rtt_keys_available_; |
| 128 | QuicReferenceCountedPointer<QuicCryptoNegotiatedParameters> params_; |
| 129 | }; |
| 130 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 131 | class TestStream : public QuicSpdyStream { |
| 132 | public: |
| 133 | TestStream(QuicStreamId id, |
| 134 | QuicSpdySession* session, |
| 135 | bool should_process_data) |
| 136 | : QuicSpdyStream(id, session, BIDIRECTIONAL), |
| 137 | should_process_data_(should_process_data) {} |
| 138 | ~TestStream() override = default; |
| 139 | |
| 140 | using QuicSpdyStream::set_ack_listener; |
| 141 | using QuicStream::CloseWriteSide; |
| 142 | using QuicStream::WriteOrBufferData; |
| 143 | |
| 144 | void OnBodyAvailable() override { |
| 145 | if (!should_process_data_) { |
| 146 | return; |
| 147 | } |
| 148 | char buffer[2048]; |
| 149 | struct iovec vec; |
| 150 | vec.iov_base = buffer; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 151 | vec.iov_len = QUICHE_ARRAYSIZE(buffer); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 152 | size_t bytes_read = Readv(&vec, 1); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 153 | data_ += std::string(buffer, bytes_read); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 154 | } |
| 155 | |
| 156 | MOCK_METHOD1(WriteHeadersMock, void(bool fin)); |
| 157 | |
| 158 | size_t WriteHeadersImpl(spdy::SpdyHeaderBlock header_block, |
| 159 | bool fin, |
| 160 | QuicReferenceCountedPointer<QuicAckListenerInterface> |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 161 | /*ack_listener*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 162 | saved_headers_ = std::move(header_block); |
| 163 | WriteHeadersMock(fin); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 164 | if (VersionUsesHttp3(transport_version())) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 165 | // In this case, call QuicSpdyStream::WriteHeadersImpl() that does the |
| 166 | // actual work of closing the stream. |
| 167 | QuicSpdyStream::WriteHeadersImpl(saved_headers_.Clone(), fin, nullptr); |
| 168 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 169 | return 0; |
| 170 | } |
| 171 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 172 | const std::string& data() const { return data_; } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 173 | const spdy::SpdyHeaderBlock& saved_headers() const { return saved_headers_; } |
| 174 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 175 | // Expose protected accessor. |
| 176 | const QuicStreamSequencer* sequencer() const { |
| 177 | return QuicStream::sequencer(); |
| 178 | } |
| 179 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 180 | private: |
| 181 | bool should_process_data_; |
| 182 | spdy::SpdyHeaderBlock saved_headers_; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 183 | std::string data_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 184 | }; |
| 185 | |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 186 | class TestSession : public MockQuicSpdySession { |
| 187 | public: |
| 188 | explicit TestSession(QuicConnection* connection) |
| 189 | : MockQuicSpdySession(connection, /*create_mock_crypto_stream=*/false), |
| 190 | crypto_stream_(this) {} |
| 191 | |
| 192 | TestCryptoStream* GetMutableCryptoStream() override { |
| 193 | return &crypto_stream_; |
| 194 | } |
| 195 | |
| 196 | const TestCryptoStream* GetCryptoStream() const override { |
| 197 | return &crypto_stream_; |
| 198 | } |
| 199 | |
| 200 | private: |
| 201 | StrictMock<TestCryptoStream> crypto_stream_; |
| 202 | }; |
| 203 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 204 | class TestMockUpdateStreamSession : public MockQuicSpdySession { |
| 205 | public: |
| 206 | explicit TestMockUpdateStreamSession(QuicConnection* connection) |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 207 | : MockQuicSpdySession(connection), |
| 208 | expected_precedence_( |
| 209 | spdy::SpdyStreamPrecedence(QuicStream::kDefaultPriority)) {} |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 210 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 211 | void UpdateStreamPriority( |
| 212 | QuicStreamId id, |
| 213 | const spdy::SpdyStreamPrecedence& precedence) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 214 | EXPECT_EQ(id, expected_stream_->id()); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 215 | EXPECT_EQ(expected_precedence_, precedence); |
| 216 | EXPECT_EQ(expected_precedence_, expected_stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 217 | } |
| 218 | |
| 219 | void SetExpectedStream(QuicSpdyStream* stream) { expected_stream_ = stream; } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 220 | void SetExpectedPriority(const spdy::SpdyStreamPrecedence& precedence) { |
| 221 | expected_precedence_ = precedence; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 222 | } |
| 223 | |
| 224 | private: |
| 225 | QuicSpdyStream* expected_stream_; |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 226 | spdy::SpdyStreamPrecedence expected_precedence_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 227 | }; |
| 228 | |
| 229 | class QuicSpdyStreamTest : public QuicTestWithParam<ParsedQuicVersion> { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 230 | protected: |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 231 | QuicSpdyStreamTest() { |
| 232 | headers_[":host"] = "www.google.com"; |
| 233 | headers_[":path"] = "/index.hml"; |
| 234 | headers_[":scheme"] = "https"; |
| 235 | headers_["cookie"] = |
| 236 | "__utma=208381060.1228362404.1372200928.1372200928.1372200928.1; " |
| 237 | "__utmc=160408618; " |
| 238 | "GX=DQAAAOEAAACWJYdewdE9rIrW6qw3PtVi2-d729qaa-74KqOsM1NVQblK4VhX" |
| 239 | "hoALMsy6HOdDad2Sz0flUByv7etmo3mLMidGrBoljqO9hSVA40SLqpG_iuKKSHX" |
| 240 | "RW3Np4bq0F0SDGDNsW0DSmTS9ufMRrlpARJDS7qAI6M3bghqJp4eABKZiRqebHT" |
| 241 | "pMU-RXvTI5D5oCF1vYxYofH_l1Kviuiy3oQ1kS1enqWgbhJ2t61_SNdv-1XJIS0" |
| 242 | "O3YeHLmVCs62O6zp89QwakfAWK9d3IDQvVSJzCQsvxvNIvaZFa567MawWlXg0Rh" |
| 243 | "1zFMi5vzcns38-8_Sns; " |
| 244 | "GA=v*2%2Fmem*57968640*47239936%2Fmem*57968640*47114716%2Fno-nm-" |
| 245 | "yj*15%2Fno-cc-yj*5%2Fpc-ch*133685%2Fpc-s-cr*133947%2Fpc-s-t*1339" |
| 246 | "47%2Fno-nm-yj*4%2Fno-cc-yj*1%2Fceft-as*1%2Fceft-nqas*0%2Fad-ra-c" |
| 247 | "v_p%2Fad-nr-cv_p-f*1%2Fad-v-cv_p*859%2Fad-ns-cv_p-f*1%2Ffn-v-ad%" |
| 248 | "2Fpc-t*250%2Fpc-cm*461%2Fpc-s-cr*722%2Fpc-s-t*722%2Fau_p*4" |
| 249 | "SICAID=AJKiYcHdKgxum7KMXG0ei2t1-W4OD1uW-ecNsCqC0wDuAXiDGIcT_HA2o1" |
| 250 | "3Rs1UKCuBAF9g8rWNOFbxt8PSNSHFuIhOo2t6bJAVpCsMU5Laa6lewuTMYI8MzdQP" |
| 251 | "ARHKyW-koxuhMZHUnGBJAM1gJODe0cATO_KGoX4pbbFxxJ5IicRxOrWK_5rU3cdy6" |
| 252 | "edlR9FsEdH6iujMcHkbE5l18ehJDwTWmBKBzVD87naobhMMrF6VvnDGxQVGp9Ir_b" |
| 253 | "Rgj3RWUoPumQVCxtSOBdX0GlJOEcDTNCzQIm9BSfetog_eP_TfYubKudt5eMsXmN6" |
| 254 | "QnyXHeGeK2UINUzJ-D30AFcpqYgH9_1BvYSpi7fc7_ydBU8TaD8ZRxvtnzXqj0RfG" |
| 255 | "tuHghmv3aD-uzSYJ75XDdzKdizZ86IG6Fbn1XFhYZM-fbHhm3mVEXnyRW4ZuNOLFk" |
| 256 | "Fas6LMcVC6Q8QLlHYbXBpdNFuGbuZGUnav5C-2I_-46lL0NGg3GewxGKGHvHEfoyn" |
| 257 | "EFFlEYHsBQ98rXImL8ySDycdLEFvBPdtctPmWCfTxwmoSMLHU2SCVDhbqMWU5b0yr" |
| 258 | "JBCScs_ejbKaqBDoB7ZGxTvqlrB__2ZmnHHjCr8RgMRtKNtIeuZAo "; |
| 259 | } |
| 260 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 261 | ~QuicSpdyStreamTest() override = default; |
| 262 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 263 | // Return QPACK-encoded header block without using the dynamic table. |
| 264 | std::string EncodeQpackHeaders( |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 265 | std::vector<std::pair<quiche::QuicheStringPiece, |
| 266 | quiche::QuicheStringPiece>> headers) { |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 267 | SpdyHeaderBlock header_block; |
| 268 | for (const auto& header_field : headers) { |
| 269 | header_block.AppendValueOrAddHeader(header_field.first, |
| 270 | header_field.second); |
| 271 | } |
| 272 | |
| 273 | return EncodeQpackHeaders(header_block); |
| 274 | } |
| 275 | |
| 276 | // Return QPACK-encoded header block without using the dynamic table. |
| 277 | std::string EncodeQpackHeaders(const SpdyHeaderBlock& header) { |
renjietang | c2aa5cb | 2019-06-20 12:22:53 -0700 | [diff] [blame] | 278 | NoopQpackStreamSenderDelegate encoder_stream_sender_delegate; |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 279 | auto qpack_encoder = std::make_unique<QpackEncoder>(session_.get()); |
renjietang | 8a2df8f | 2019-08-07 10:43:52 -0700 | [diff] [blame] | 280 | qpack_encoder->set_qpack_stream_sender_delegate( |
| 281 | &encoder_stream_sender_delegate); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 282 | // QpackEncoder does not use the dynamic table by default, |
| 283 | // therefore the value of |stream_id| does not matter. |
bnc | 609c24e | 2019-09-10 05:24:32 -0700 | [diff] [blame] | 284 | return qpack_encoder->EncodeHeaderList(/* stream_id = */ 0, header, |
| 285 | nullptr); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 286 | } |
| 287 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 288 | void Initialize(bool stream_should_process_data) { |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 289 | InitializeWithPerspective(stream_should_process_data, |
| 290 | Perspective::IS_SERVER); |
| 291 | } |
| 292 | |
| 293 | void InitializeWithPerspective(bool stream_should_process_data, |
| 294 | Perspective perspective) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 295 | connection_ = new StrictMock<MockQuicConnection>( |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 296 | &helper_, &alarm_factory_, perspective, SupportedVersions(GetParam())); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 297 | session_ = std::make_unique<StrictMock<TestSession>>(connection_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 298 | session_->Initialize(); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 299 | ON_CALL(*session_, WritevData(_, _, _, _, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 300 | .WillByDefault( |
| 301 | Invoke(session_.get(), &MockQuicSpdySession::ConsumeData)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 302 | |
| 303 | stream_ = |
| 304 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(0), |
| 305 | session_.get(), stream_should_process_data); |
| 306 | session_->ActivateStream(QuicWrapUnique(stream_)); |
| 307 | stream2_ = |
| 308 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(1), |
| 309 | session_.get(), stream_should_process_data); |
| 310 | session_->ActivateStream(QuicWrapUnique(stream2_)); |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 311 | QuicConfigPeer::SetReceivedInitialSessionFlowControlWindow( |
| 312 | session_->config(), kMinimumFlowControlSendWindow); |
dschinazi | 18cdf13 | 2019-10-09 16:08:18 -0700 | [diff] [blame] | 313 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesUnidirectional( |
| 314 | session_->config(), kMinimumFlowControlSendWindow); |
| 315 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesIncomingBidirectional( |
| 316 | session_->config(), kMinimumFlowControlSendWindow); |
| 317 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesOutgoingBidirectional( |
| 318 | session_->config(), kMinimumFlowControlSendWindow); |
renjietang | e6d9467 | 2020-01-07 10:30:10 -0800 | [diff] [blame] | 319 | QuicConfigPeer::SetReceivedMaxUnidirectionalStreams(session_->config(), 10); |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 320 | session_->OnConfigNegotiated(); |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 321 | if (UsesHttp3()) { |
renjietang | d6e461b | 2020-02-04 16:16:35 -0800 | [diff] [blame] | 322 | // The control stream will write the stream type, a greased frame, and |
| 323 | // SETTINGS frame. |
| 324 | int num_control_stream_writes = 3; |
rch | 4cd745d | 2019-12-03 13:19:41 -0800 | [diff] [blame] | 325 | if (session_->perspective() == Perspective::IS_CLIENT) { |
| 326 | // The control stream also writes the max push id frame. |
| 327 | num_control_stream_writes++; |
| 328 | } |
bnc | cd3c4b5 | 2020-01-10 11:13:18 -0800 | [diff] [blame] | 329 | auto send_control_stream = |
| 330 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 331 | EXPECT_CALL(*session_, |
| 332 | WritevData(send_control_stream->id(), _, _, _, _, _)) |
rch | 4cd745d | 2019-12-03 13:19:41 -0800 | [diff] [blame] | 333 | .Times(num_control_stream_writes); |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 334 | auto qpack_decoder_stream = |
| 335 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 336 | EXPECT_CALL(*session_, |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 337 | WritevData(qpack_decoder_stream->id(), 1, 0, _, _, _)); |
renjietang | 296cfa3 | 2019-11-27 12:49:46 -0800 | [diff] [blame] | 338 | auto qpack_encoder_stream = |
| 339 | QuicSpdySessionPeer::GetQpackEncoderSendStream(session_.get()); |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 340 | EXPECT_CALL(*session_, |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 341 | WritevData(qpack_encoder_stream->id(), 1, 0, _, _, _)); |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 342 | } |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 343 | TestCryptoStream* crypto_stream = session_->GetMutableCryptoStream(); |
| 344 | EXPECT_CALL(*crypto_stream, HasPendingRetransmission()) |
| 345 | .Times(testing::AnyNumber()); |
| 346 | |
| 347 | if (connection_->version().HasHandshakeDone() && |
| 348 | session_->perspective() == Perspective::IS_SERVER) { |
| 349 | EXPECT_CALL(*connection_, SendControlFrame(_)) |
| 350 | .WillOnce(Invoke(&ClearControlFrame)); |
| 351 | } |
| 352 | CryptoHandshakeMessage message; |
| 353 | session_->GetMutableCryptoStream()->OnHandshakeMessage(message); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 354 | } |
| 355 | |
| 356 | QuicHeaderList ProcessHeaders(bool fin, const SpdyHeaderBlock& headers) { |
| 357 | QuicHeaderList h = AsHeaderList(headers); |
| 358 | stream_->OnStreamHeaderList(fin, h.uncompressed_header_bytes(), h); |
| 359 | return h; |
| 360 | } |
| 361 | |
| 362 | QuicStreamId GetNthClientInitiatedBidirectionalId(int n) { |
| 363 | return GetNthClientInitiatedBidirectionalStreamId( |
| 364 | connection_->transport_version(), n); |
| 365 | } |
| 366 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 367 | bool UsesHttp3() const { |
| 368 | return VersionUsesHttp3(GetParam().transport_version); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 369 | } |
| 370 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 371 | // Construct HEADERS frame with QPACK-encoded |headers| without using the |
| 372 | // dynamic table. |
| 373 | std::string HeadersFrame( |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 374 | std::vector<std::pair<quiche::QuicheStringPiece, |
| 375 | quiche::QuicheStringPiece>> headers) { |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 376 | return HeadersFrame(EncodeQpackHeaders(headers)); |
| 377 | } |
| 378 | |
| 379 | // Construct HEADERS frame with QPACK-encoded |headers| without using the |
| 380 | // dynamic table. |
| 381 | std::string HeadersFrame(const SpdyHeaderBlock& headers) { |
| 382 | return HeadersFrame(EncodeQpackHeaders(headers)); |
| 383 | } |
| 384 | |
| 385 | // Construct HEADERS frame with given payload. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 386 | std::string HeadersFrame(quiche::QuicheStringPiece payload) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 387 | std::unique_ptr<char[]> headers_buffer; |
| 388 | QuicByteCount headers_frame_header_length = |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 389 | HttpEncoder::SerializeHeadersFrameHeader(payload.length(), |
| 390 | &headers_buffer); |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 391 | quiche::QuicheStringPiece headers_frame_header(headers_buffer.get(), |
| 392 | headers_frame_header_length); |
| 393 | return quiche::QuicheStrCat(headers_frame_header, payload); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 394 | } |
| 395 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 396 | std::string DataFrame(quiche::QuicheStringPiece payload) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 397 | std::unique_ptr<char[]> data_buffer; |
| 398 | QuicByteCount data_frame_header_length = |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 399 | HttpEncoder::SerializeDataFrameHeader(payload.length(), &data_buffer); |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 400 | quiche::QuicheStringPiece data_frame_header(data_buffer.get(), |
| 401 | data_frame_header_length); |
| 402 | return quiche::QuicheStrCat(data_frame_header, payload); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 403 | } |
| 404 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 405 | std::string UnknownFrame(uint64_t frame_type, |
| 406 | quiche::QuicheStringPiece payload) { |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 407 | std::string frame; |
| 408 | const size_t length = QuicDataWriter::GetVarInt62Len(frame_type) + |
| 409 | QuicDataWriter::GetVarInt62Len(payload.size()) + |
| 410 | payload.size(); |
| 411 | frame.resize(length); |
| 412 | |
fayang | f0041ed | 2019-07-31 02:39:45 -0700 | [diff] [blame] | 413 | QuicDataWriter writer(length, const_cast<char*>(frame.data())); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 414 | writer.WriteVarInt62(frame_type); |
| 415 | writer.WriteStringPieceVarInt62(payload); |
| 416 | // Even though integers can be encoded with different lengths, |
| 417 | // QuicDataWriter is expected to produce an encoding in Write*() of length |
| 418 | // promised in GetVarInt62Len(). |
| 419 | DCHECK_EQ(length, writer.length()); |
| 420 | |
| 421 | return frame; |
| 422 | } |
| 423 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 424 | MockQuicConnectionHelper helper_; |
| 425 | MockAlarmFactory alarm_factory_; |
| 426 | MockQuicConnection* connection_; |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 427 | std::unique_ptr<TestSession> session_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 428 | |
| 429 | // Owned by the |session_|. |
| 430 | TestStream* stream_; |
| 431 | TestStream* stream2_; |
| 432 | |
| 433 | SpdyHeaderBlock headers_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 434 | }; |
| 435 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 436 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 437 | QuicSpdyStreamTest, |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 438 | ::testing::ValuesIn(AllSupportedVersions()), |
| 439 | ::testing::PrintToStringParamName()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 440 | |
| 441 | TEST_P(QuicSpdyStreamTest, ProcessHeaderList) { |
| 442 | Initialize(kShouldProcessData); |
| 443 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 444 | stream_->OnStreamHeadersPriority( |
| 445 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 446 | ProcessHeaders(false, headers_); |
| 447 | EXPECT_EQ("", stream_->data()); |
| 448 | EXPECT_FALSE(stream_->header_list().empty()); |
| 449 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 450 | } |
| 451 | |
| 452 | TEST_P(QuicSpdyStreamTest, ProcessTooLargeHeaderList) { |
| 453 | Initialize(kShouldProcessData); |
| 454 | |
bnc | 446887e | 2019-11-27 13:08:28 -0800 | [diff] [blame] | 455 | if (!UsesHttp3()) { |
| 456 | QuicHeaderList headers; |
| 457 | stream_->OnStreamHeadersPriority( |
| 458 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 459 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 460 | EXPECT_CALL(*session_, |
| 461 | SendRstStream(stream_->id(), QUIC_HEADERS_TOO_LARGE, 0)); |
bnc | 446887e | 2019-11-27 13:08:28 -0800 | [diff] [blame] | 462 | stream_->OnStreamHeaderList(false, 1 << 20, headers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 463 | |
bnc | c576950 | 2019-11-27 10:01:44 -0800 | [diff] [blame] | 464 | EXPECT_THAT(stream_->stream_error(), IsStreamError(QUIC_HEADERS_TOO_LARGE)); |
bnc | 446887e | 2019-11-27 13:08:28 -0800 | [diff] [blame] | 465 | |
| 466 | return; |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 467 | } |
bnc | 446887e | 2019-11-27 13:08:28 -0800 | [diff] [blame] | 468 | |
| 469 | // Header list size includes 32 bytes for overhead per header field. |
| 470 | session_->set_max_inbound_header_list_size(40); |
| 471 | std::string headers = |
| 472 | HeadersFrame({std::make_pair("foo", "too long headers")}); |
| 473 | |
| 474 | QuicStreamFrame frame(stream_->id(), false, 0, headers); |
| 475 | |
| 476 | EXPECT_CALL( |
| 477 | *connection_, |
| 478 | CloseConnection(QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE, |
| 479 | MatchesRegex("Too large headers received on stream \\d+"), |
| 480 | _)); |
| 481 | |
| 482 | stream_->OnStreamFrame(frame); |
| 483 | |
| 484 | EXPECT_TRUE(stream_->header_list().empty()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 485 | } |
| 486 | |
| 487 | TEST_P(QuicSpdyStreamTest, ProcessHeaderListWithFin) { |
| 488 | Initialize(kShouldProcessData); |
| 489 | |
| 490 | size_t total_bytes = 0; |
| 491 | QuicHeaderList headers; |
| 492 | for (auto p : headers_) { |
| 493 | headers.OnHeader(p.first, p.second); |
| 494 | total_bytes += p.first.size() + p.second.size(); |
| 495 | } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 496 | stream_->OnStreamHeadersPriority( |
| 497 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 498 | stream_->OnStreamHeaderList(true, total_bytes, headers); |
| 499 | EXPECT_EQ("", stream_->data()); |
| 500 | EXPECT_FALSE(stream_->header_list().empty()); |
| 501 | EXPECT_FALSE(stream_->IsDoneReading()); |
renjietang | 6c06656 | 2019-11-04 17:05:59 -0800 | [diff] [blame] | 502 | EXPECT_TRUE(stream_->HasReceivedFinalOffset()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 503 | } |
| 504 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 505 | // A valid status code should be 3-digit integer. The first digit should be in |
| 506 | // the range of [1, 5]. All the others are invalid. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 507 | TEST_P(QuicSpdyStreamTest, ParseHeaderStatusCode) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 508 | Initialize(kShouldProcessData); |
| 509 | int status_code = 0; |
| 510 | |
| 511 | // Valid status codes. |
| 512 | headers_[":status"] = "404"; |
| 513 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 514 | EXPECT_EQ(404, status_code); |
| 515 | |
| 516 | headers_[":status"] = "100"; |
| 517 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 518 | EXPECT_EQ(100, status_code); |
| 519 | |
| 520 | headers_[":status"] = "599"; |
| 521 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 522 | EXPECT_EQ(599, status_code); |
| 523 | |
| 524 | // Invalid status codes. |
| 525 | headers_[":status"] = "010"; |
| 526 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 527 | |
| 528 | headers_[":status"] = "600"; |
| 529 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 530 | |
| 531 | headers_[":status"] = "200 ok"; |
| 532 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 533 | |
| 534 | headers_[":status"] = "2000"; |
| 535 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 536 | |
| 537 | headers_[":status"] = "+200"; |
| 538 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 539 | |
| 540 | headers_[":status"] = "+20"; |
| 541 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 542 | |
| 543 | headers_[":status"] = "-10"; |
| 544 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 545 | |
| 546 | headers_[":status"] = "-100"; |
| 547 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 548 | |
| 549 | // Leading or trailing spaces are also invalid. |
| 550 | headers_[":status"] = " 200"; |
| 551 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 552 | |
| 553 | headers_[":status"] = "200 "; |
| 554 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 555 | |
| 556 | headers_[":status"] = " 200 "; |
| 557 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 558 | |
| 559 | headers_[":status"] = " "; |
| 560 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 561 | } |
| 562 | |
| 563 | TEST_P(QuicSpdyStreamTest, MarkHeadersConsumed) { |
| 564 | Initialize(kShouldProcessData); |
| 565 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 566 | std::string body = "this is the body"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 567 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 568 | EXPECT_EQ(headers, stream_->header_list()); |
| 569 | |
| 570 | stream_->ConsumeHeaderList(); |
| 571 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 572 | } |
| 573 | |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 574 | TEST_P(QuicSpdyStreamTest, ProcessWrongFramesOnSpdyStream) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 575 | if (!UsesHttp3()) { |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 576 | return; |
| 577 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 578 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 579 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 580 | testing::InSequence s; |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 581 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 582 | GoAwayFrame goaway; |
| 583 | goaway.stream_id = 0x1; |
| 584 | std::unique_ptr<char[]> buffer; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 585 | QuicByteCount header_length = |
| 586 | HttpEncoder::SerializeGoAwayFrame(goaway, &buffer); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 587 | std::string data = std::string(buffer.get(), header_length); |
| 588 | |
| 589 | EXPECT_EQ("", stream_->data()); |
| 590 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 591 | EXPECT_EQ(headers, stream_->header_list()); |
| 592 | stream_->ConsumeHeaderList(); |
| 593 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 594 | quiche::QuicheStringPiece(data)); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 595 | |
bnc | dfabdfb | 2020-01-17 17:46:40 -0800 | [diff] [blame] | 596 | EXPECT_CALL(*connection_, |
| 597 | CloseConnection(QUIC_HTTP_FRAME_UNEXPECTED_ON_SPDY_STREAM, _, _)) |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 598 | .WillOnce( |
| 599 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 600 | ConnectionCloseBehavior connection_close_behavior) { |
| 601 | connection_->ReallyCloseConnection(error, error_details, |
| 602 | connection_close_behavior); |
| 603 | }))); |
ianswett | dc1e7ab | 2019-05-03 16:10:44 -0700 | [diff] [blame] | 604 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 605 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 606 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 607 | ConnectionCloseSource source) { |
| 608 | session_->ReallyOnConnectionClosed(frame, source); |
| 609 | })); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 610 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 611 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 612 | |
| 613 | stream_->OnStreamFrame(frame); |
| 614 | } |
| 615 | |
bnc | dfabdfb | 2020-01-17 17:46:40 -0800 | [diff] [blame] | 616 | TEST_P(QuicSpdyStreamTest, Http3FrameError) { |
| 617 | if (!UsesHttp3()) { |
| 618 | return; |
| 619 | } |
| 620 | |
| 621 | Initialize(kShouldProcessData); |
| 622 | |
| 623 | // PUSH_PROMISE frame with empty payload is considered invalid. |
| 624 | std::string invalid_http3_frame = quiche::QuicheTextUtils::HexDecode("0500"); |
| 625 | QuicStreamFrame stream_frame(stream_->id(), /* fin = */ false, |
| 626 | /* offset = */ 0, invalid_http3_frame); |
| 627 | |
| 628 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_FRAME_ERROR, _, _)); |
| 629 | stream_->OnStreamFrame(stream_frame); |
| 630 | } |
| 631 | |
| 632 | TEST_P(QuicSpdyStreamTest, UnexpectedHttp3Frame) { |
| 633 | if (!UsesHttp3()) { |
| 634 | return; |
| 635 | } |
| 636 | |
| 637 | Initialize(kShouldProcessData); |
| 638 | |
| 639 | // SETTINGS frame with empty payload. |
| 640 | std::string settings = quiche::QuicheTextUtils::HexDecode("0400"); |
| 641 | QuicStreamFrame stream_frame(stream_->id(), /* fin = */ false, |
| 642 | /* offset = */ 0, settings); |
| 643 | |
| 644 | EXPECT_CALL(*connection_, |
| 645 | CloseConnection(QUIC_HTTP_FRAME_UNEXPECTED_ON_SPDY_STREAM, _, _)); |
| 646 | stream_->OnStreamFrame(stream_frame); |
| 647 | } |
| 648 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 649 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBody) { |
| 650 | Initialize(kShouldProcessData); |
| 651 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 652 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 653 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 654 | |
| 655 | EXPECT_EQ("", stream_->data()); |
| 656 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 657 | EXPECT_EQ(headers, stream_->header_list()); |
| 658 | stream_->ConsumeHeaderList(); |
| 659 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 660 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 661 | stream_->OnStreamFrame(frame); |
| 662 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 663 | EXPECT_EQ(body, stream_->data()); |
| 664 | } |
| 665 | |
| 666 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragments) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 667 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 668 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 669 | |
| 670 | for (size_t fragment_size = 1; fragment_size < data.size(); ++fragment_size) { |
| 671 | Initialize(kShouldProcessData); |
| 672 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 673 | ASSERT_EQ(headers, stream_->header_list()); |
| 674 | stream_->ConsumeHeaderList(); |
| 675 | for (size_t offset = 0; offset < data.size(); offset += fragment_size) { |
| 676 | size_t remaining_data = data.size() - offset; |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 677 | quiche::QuicheStringPiece fragment( |
| 678 | data.data() + offset, std::min(fragment_size, remaining_data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 679 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 680 | offset, quiche::QuicheStringPiece(fragment)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 681 | stream_->OnStreamFrame(frame); |
| 682 | } |
| 683 | ASSERT_EQ(body, stream_->data()) << "fragment_size: " << fragment_size; |
| 684 | } |
| 685 | } |
| 686 | |
| 687 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragmentsSplit) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 688 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 689 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 690 | |
| 691 | for (size_t split_point = 1; split_point < data.size() - 1; ++split_point) { |
| 692 | Initialize(kShouldProcessData); |
| 693 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 694 | ASSERT_EQ(headers, stream_->header_list()); |
| 695 | stream_->ConsumeHeaderList(); |
| 696 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 697 | quiche::QuicheStringPiece fragment1(data.data(), split_point); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 698 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 699 | quiche::QuicheStringPiece(fragment1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 700 | stream_->OnStreamFrame(frame1); |
| 701 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 702 | quiche::QuicheStringPiece fragment2(data.data() + split_point, |
| 703 | data.size() - split_point); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 704 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 705 | split_point, quiche::QuicheStringPiece(fragment2)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 706 | stream_->OnStreamFrame(frame2); |
| 707 | |
| 708 | ASSERT_EQ(body, stream_->data()) << "split_point: " << split_point; |
| 709 | } |
| 710 | } |
| 711 | |
| 712 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyReadv) { |
| 713 | Initialize(!kShouldProcessData); |
| 714 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 715 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 716 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 717 | |
| 718 | ProcessHeaders(false, headers_); |
| 719 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 720 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 721 | stream_->OnStreamFrame(frame); |
| 722 | stream_->ConsumeHeaderList(); |
| 723 | |
| 724 | char buffer[2048]; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 725 | ASSERT_LT(data.length(), QUICHE_ARRAYSIZE(buffer)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 726 | struct iovec vec; |
| 727 | vec.iov_base = buffer; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 728 | vec.iov_len = QUICHE_ARRAYSIZE(buffer); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 729 | |
| 730 | size_t bytes_read = stream_->Readv(&vec, 1); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 731 | QuicStreamPeer::CloseReadSide(stream_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 732 | EXPECT_EQ(body.length(), bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 733 | EXPECT_EQ(body, std::string(buffer, bytes_read)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 734 | } |
| 735 | |
| 736 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndLargeBodySmallReadv) { |
| 737 | Initialize(kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 738 | std::string body(12 * 1024, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 739 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 740 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 741 | ProcessHeaders(false, headers_); |
| 742 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 743 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 744 | stream_->OnStreamFrame(frame); |
| 745 | stream_->ConsumeHeaderList(); |
| 746 | char buffer[2048]; |
| 747 | char buffer2[2048]; |
| 748 | struct iovec vec[2]; |
| 749 | vec[0].iov_base = buffer; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 750 | vec[0].iov_len = QUICHE_ARRAYSIZE(buffer); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 751 | vec[1].iov_base = buffer2; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 752 | vec[1].iov_len = QUICHE_ARRAYSIZE(buffer2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 753 | size_t bytes_read = stream_->Readv(vec, 2); |
| 754 | EXPECT_EQ(2048u * 2, bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 755 | EXPECT_EQ(body.substr(0, 2048), std::string(buffer, 2048)); |
| 756 | EXPECT_EQ(body.substr(2048, 2048), std::string(buffer2, 2048)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 757 | } |
| 758 | |
| 759 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyMarkConsumed) { |
| 760 | Initialize(!kShouldProcessData); |
| 761 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 762 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 763 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 764 | |
| 765 | ProcessHeaders(false, headers_); |
| 766 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 767 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 768 | stream_->OnStreamFrame(frame); |
| 769 | stream_->ConsumeHeaderList(); |
| 770 | |
| 771 | struct iovec vec; |
| 772 | |
| 773 | EXPECT_EQ(1, stream_->GetReadableRegions(&vec, 1)); |
| 774 | EXPECT_EQ(body.length(), vec.iov_len); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 775 | EXPECT_EQ(body, std::string(static_cast<char*>(vec.iov_base), vec.iov_len)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 776 | |
| 777 | stream_->MarkConsumed(body.length()); |
| 778 | EXPECT_EQ(data.length(), stream_->flow_controller()->bytes_consumed()); |
| 779 | } |
| 780 | |
| 781 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndConsumeMultipleBody) { |
| 782 | Initialize(!kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 783 | std::string body1 = "this is body 1"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 784 | std::string data1 = UsesHttp3() ? DataFrame(body1) : body1; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 785 | std::string body2 = "body 2"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 786 | std::string data2 = UsesHttp3() ? DataFrame(body2) : body2; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 787 | |
| 788 | ProcessHeaders(false, headers_); |
| 789 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 790 | quiche::QuicheStringPiece(data1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 791 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 792 | data1.length(), quiche::QuicheStringPiece(data2)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 793 | stream_->OnStreamFrame(frame1); |
| 794 | stream_->OnStreamFrame(frame2); |
| 795 | stream_->ConsumeHeaderList(); |
| 796 | |
| 797 | stream_->MarkConsumed(body1.length() + body2.length()); |
| 798 | EXPECT_EQ(data1.length() + data2.length(), |
| 799 | stream_->flow_controller()->bytes_consumed()); |
| 800 | } |
| 801 | |
| 802 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyIncrementalReadv) { |
| 803 | Initialize(!kShouldProcessData); |
| 804 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 805 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 806 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 807 | |
| 808 | ProcessHeaders(false, headers_); |
| 809 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 810 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 811 | stream_->OnStreamFrame(frame); |
| 812 | stream_->ConsumeHeaderList(); |
| 813 | |
| 814 | char buffer[1]; |
| 815 | struct iovec vec; |
| 816 | vec.iov_base = buffer; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 817 | vec.iov_len = QUICHE_ARRAYSIZE(buffer); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 818 | |
| 819 | for (size_t i = 0; i < body.length(); ++i) { |
| 820 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 821 | ASSERT_EQ(1u, bytes_read); |
| 822 | EXPECT_EQ(body.data()[i], buffer[0]); |
| 823 | } |
| 824 | } |
| 825 | |
| 826 | TEST_P(QuicSpdyStreamTest, ProcessHeadersUsingReadvWithMultipleIovecs) { |
| 827 | Initialize(!kShouldProcessData); |
| 828 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 829 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 830 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 831 | |
| 832 | ProcessHeaders(false, headers_); |
| 833 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 834 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 835 | stream_->OnStreamFrame(frame); |
| 836 | stream_->ConsumeHeaderList(); |
| 837 | |
| 838 | char buffer1[1]; |
| 839 | char buffer2[1]; |
| 840 | struct iovec vec[2]; |
| 841 | vec[0].iov_base = buffer1; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 842 | vec[0].iov_len = QUICHE_ARRAYSIZE(buffer1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 843 | vec[1].iov_base = buffer2; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 844 | vec[1].iov_len = QUICHE_ARRAYSIZE(buffer2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 845 | |
| 846 | for (size_t i = 0; i < body.length(); i += 2) { |
| 847 | size_t bytes_read = stream_->Readv(vec, 2); |
| 848 | ASSERT_EQ(2u, bytes_read) << i; |
| 849 | ASSERT_EQ(body.data()[i], buffer1[0]) << i; |
| 850 | ASSERT_EQ(body.data()[i + 1], buffer2[0]) << i; |
| 851 | } |
| 852 | } |
| 853 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 854 | // Tests that we send a BLOCKED frame to the peer when we attempt to write, but |
| 855 | // are flow control blocked. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 856 | TEST_P(QuicSpdyStreamTest, StreamFlowControlBlocked) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 857 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 858 | testing::InSequence seq; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 859 | |
| 860 | // Set a small flow control limit. |
| 861 | const uint64_t kWindow = 36; |
| 862 | QuicFlowControllerPeer::SetSendWindowOffset(stream_->flow_controller(), |
| 863 | kWindow); |
| 864 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::SendWindowOffset( |
| 865 | stream_->flow_controller())); |
| 866 | |
| 867 | // Try to send more data than the flow control limit allows. |
| 868 | const uint64_t kOverflow = 15; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 869 | std::string body(kWindow + kOverflow, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 870 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 871 | const uint64_t kHeaderLength = UsesHttp3() ? 2 : 0; |
| 872 | if (UsesHttp3()) { |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 873 | EXPECT_CALL(*session_, WritevData(_, kHeaderLength, _, NO_FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 874 | } |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 875 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)) |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 876 | .WillOnce(Return(QuicConsumedData(kWindow - kHeaderLength, true))); |
| 877 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 878 | stream_->WriteOrBufferBody(body, false); |
| 879 | |
| 880 | // Should have sent as much as possible, resulting in no send window left. |
| 881 | EXPECT_EQ(0u, |
| 882 | QuicFlowControllerPeer::SendWindowSize(stream_->flow_controller())); |
| 883 | |
| 884 | // And we should have queued the overflowed data. |
bnc | c7d9e0c | 2019-04-16 10:22:15 -0700 | [diff] [blame] | 885 | EXPECT_EQ(kOverflow + kHeaderLength, stream_->BufferedDataBytes()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 886 | } |
| 887 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 888 | // The flow control receive window decreases whenever we add new bytes to the |
| 889 | // sequencer, whether they are consumed immediately or buffered. However we only |
| 890 | // send WINDOW_UPDATE frames based on increasing number of bytes consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 891 | TEST_P(QuicSpdyStreamTest, StreamFlowControlNoWindowUpdateIfNotConsumed) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 892 | // Don't process data - it will be buffered instead. |
| 893 | Initialize(!kShouldProcessData); |
| 894 | |
| 895 | // Expect no WINDOW_UPDATE frames to be sent. |
| 896 | EXPECT_CALL(*connection_, SendWindowUpdate(_, _)).Times(0); |
| 897 | |
| 898 | // Set a small flow control receive window. |
| 899 | const uint64_t kWindow = 36; |
| 900 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 901 | kWindow); |
| 902 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 903 | kWindow); |
| 904 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 905 | stream_->flow_controller())); |
| 906 | |
| 907 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 908 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 909 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 910 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 911 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 912 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 913 | std::unique_ptr<char[]> buffer; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 914 | header_length = |
| 915 | HttpEncoder::SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 916 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 917 | data = header + body; |
| 918 | } else { |
| 919 | data = body; |
| 920 | } |
| 921 | |
| 922 | ProcessHeaders(false, headers_); |
| 923 | |
| 924 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 925 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 926 | stream_->OnStreamFrame(frame1); |
| 927 | EXPECT_EQ( |
| 928 | kWindow - (kWindow / 3) - header_length, |
| 929 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 930 | |
| 931 | // Now receive another frame which results in the receive window being over |
| 932 | // half full. This should all be buffered, decreasing the receive window but |
| 933 | // not sending WINDOW_UPDATE. |
| 934 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 935 | kWindow / 3 + header_length, |
| 936 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 937 | stream_->OnStreamFrame(frame2); |
| 938 | EXPECT_EQ( |
| 939 | kWindow - (2 * kWindow / 3) - 2 * header_length, |
| 940 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 941 | } |
| 942 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 943 | // Tests that on receipt of data, the stream updates its receive window offset |
| 944 | // appropriately, and sends WINDOW_UPDATE frames when its receive window drops |
| 945 | // too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 946 | TEST_P(QuicSpdyStreamTest, StreamFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 947 | Initialize(kShouldProcessData); |
| 948 | |
| 949 | // Set a small flow control limit. |
| 950 | const uint64_t kWindow = 36; |
| 951 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 952 | kWindow); |
| 953 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 954 | kWindow); |
| 955 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 956 | stream_->flow_controller())); |
| 957 | |
| 958 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 959 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 960 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 961 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 962 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 963 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 964 | std::unique_ptr<char[]> buffer; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 965 | header_length = |
| 966 | HttpEncoder::SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 967 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 968 | data = header + body; |
| 969 | } else { |
| 970 | data = body; |
| 971 | } |
| 972 | |
| 973 | ProcessHeaders(false, headers_); |
| 974 | stream_->ConsumeHeaderList(); |
| 975 | |
| 976 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 977 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 978 | stream_->OnStreamFrame(frame1); |
| 979 | EXPECT_EQ( |
| 980 | kWindow - (kWindow / 3) - header_length, |
| 981 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 982 | |
| 983 | // Now receive another frame which results in the receive window being over |
| 984 | // half full. This will trigger the stream to increase its receive window |
| 985 | // offset and send a WINDOW_UPDATE. The result will be again an available |
| 986 | // window of kWindow bytes. |
| 987 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 988 | kWindow / 3 + header_length, |
| 989 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 990 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 991 | stream_->OnStreamFrame(frame2); |
| 992 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowSize( |
| 993 | stream_->flow_controller())); |
| 994 | } |
| 995 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 996 | // Tests that on receipt of data, the connection updates its receive window |
| 997 | // offset appropriately, and sends WINDOW_UPDATE frames when its receive window |
| 998 | // drops too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 999 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1000 | Initialize(kShouldProcessData); |
| 1001 | |
| 1002 | // Set a small flow control limit for streams and connection. |
| 1003 | const uint64_t kWindow = 36; |
| 1004 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 1005 | kWindow); |
| 1006 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 1007 | kWindow); |
| 1008 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream2_->flow_controller(), |
| 1009 | kWindow); |
| 1010 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream2_->flow_controller(), |
| 1011 | kWindow); |
| 1012 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 1013 | kWindow); |
| 1014 | QuicFlowControllerPeer::SetMaxReceiveWindow(session_->flow_controller(), |
| 1015 | kWindow); |
| 1016 | |
| 1017 | // Supply headers to both streams so that they are happy to receive data. |
| 1018 | auto headers = AsHeaderList(headers_); |
| 1019 | stream_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 1020 | headers); |
| 1021 | stream_->ConsumeHeaderList(); |
| 1022 | stream2_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 1023 | headers); |
| 1024 | stream2_->ConsumeHeaderList(); |
| 1025 | |
| 1026 | // Each stream gets a quarter window of data. This should not trigger a |
| 1027 | // WINDOW_UPDATE for either stream, nor for the connection. |
| 1028 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1029 | std::string body; |
| 1030 | std::string data; |
| 1031 | std::string data2; |
| 1032 | std::string body2(1, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1033 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1034 | if (UsesHttp3()) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1035 | body = std::string(kWindow / 4 - 2, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1036 | std::unique_ptr<char[]> buffer; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 1037 | header_length = |
| 1038 | HttpEncoder::SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1039 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1040 | data = header + body; |
| 1041 | std::unique_ptr<char[]> buffer2; |
| 1042 | QuicByteCount header_length2 = |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 1043 | HttpEncoder::SerializeDataFrameHeader(body2.length(), &buffer2); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1044 | std::string header2 = std::string(buffer2.get(), header_length2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1045 | data2 = header2 + body2; |
| 1046 | } else { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1047 | body = std::string(kWindow / 4, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1048 | data = body; |
| 1049 | data2 = body2; |
| 1050 | } |
| 1051 | |
| 1052 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1053 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1054 | stream_->OnStreamFrame(frame1); |
| 1055 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(1), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1056 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1057 | stream2_->OnStreamFrame(frame2); |
| 1058 | |
| 1059 | // Now receive a further single byte on one stream - again this does not |
| 1060 | // trigger a stream WINDOW_UPDATE, but now the connection flow control window |
| 1061 | // is over half full and thus a connection WINDOW_UPDATE is sent. |
| 1062 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 1063 | QuicStreamFrame frame3(GetNthClientInitiatedBidirectionalId(0), false, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1064 | body.length() + header_length, |
| 1065 | quiche::QuicheStringPiece(data2)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1066 | stream_->OnStreamFrame(frame3); |
| 1067 | } |
| 1068 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1069 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 1070 | // protocol), then we terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1071 | TEST_P(QuicSpdyStreamTest, StreamFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1072 | // Stream should not process data, so that data gets buffered in the |
| 1073 | // sequencer, triggering flow control limits. |
| 1074 | Initialize(!kShouldProcessData); |
| 1075 | |
| 1076 | // Set a small flow control limit. |
| 1077 | const uint64_t kWindow = 50; |
| 1078 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 1079 | kWindow); |
| 1080 | |
| 1081 | ProcessHeaders(false, headers_); |
| 1082 | |
| 1083 | // Receive data to overflow the window, violating flow control. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1084 | std::string body(kWindow + 1, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1085 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1086 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1087 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1088 | EXPECT_CALL(*connection_, |
| 1089 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 1090 | stream_->OnStreamFrame(frame); |
| 1091 | } |
| 1092 | |
| 1093 | TEST_P(QuicSpdyStreamTest, TestHandlingQuicRstStreamNoError) { |
| 1094 | Initialize(kShouldProcessData); |
| 1095 | ProcessHeaders(false, headers_); |
| 1096 | |
| 1097 | stream_->OnStreamReset(QuicRstStreamFrame( |
| 1098 | kInvalidControlFrameId, stream_->id(), QUIC_STREAM_NO_ERROR, 0)); |
| 1099 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1100 | EXPECT_FALSE(stream_->reading_stopped()); |
| 1101 | } |
| 1102 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1103 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 1104 | // protocol), at the connection level (rather than the stream level) then we |
| 1105 | // terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1106 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1107 | // Stream should not process data, so that data gets buffered in the |
| 1108 | // sequencer, triggering flow control limits. |
| 1109 | Initialize(!kShouldProcessData); |
| 1110 | |
| 1111 | // Set a small flow control window on streams, and connection. |
| 1112 | const uint64_t kStreamWindow = 50; |
| 1113 | const uint64_t kConnectionWindow = 10; |
| 1114 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 1115 | kStreamWindow); |
| 1116 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 1117 | kConnectionWindow); |
| 1118 | |
| 1119 | ProcessHeaders(false, headers_); |
| 1120 | |
| 1121 | // Send enough data to overflow the connection level flow control window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1122 | std::string body(kConnectionWindow + 1, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1123 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1124 | |
| 1125 | EXPECT_LT(data.size(), kStreamWindow); |
| 1126 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1127 | quiche::QuicheStringPiece(data)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1128 | |
| 1129 | EXPECT_CALL(*connection_, |
| 1130 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 1131 | stream_->OnStreamFrame(frame); |
| 1132 | } |
| 1133 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1134 | // An attempt to write a FIN with no data should not be flow control blocked, |
| 1135 | // even if the send window is 0. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1136 | TEST_P(QuicSpdyStreamTest, StreamFlowControlFinNotBlocked) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1137 | Initialize(kShouldProcessData); |
| 1138 | |
| 1139 | // Set a flow control limit of zero. |
| 1140 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), 0); |
| 1141 | EXPECT_EQ(0u, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 1142 | stream_->flow_controller())); |
| 1143 | |
| 1144 | // Send a frame with a FIN but no data. This should not be blocked. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1145 | std::string body = ""; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1146 | bool fin = true; |
| 1147 | |
| 1148 | EXPECT_CALL(*connection_, |
| 1149 | SendBlocked(GetNthClientInitiatedBidirectionalId(0))) |
| 1150 | .Times(0); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1151 | EXPECT_CALL(*session_, WritevData(_, 0, _, FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1152 | |
| 1153 | stream_->WriteOrBufferBody(body, fin); |
| 1154 | } |
| 1155 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1156 | // Test that receiving trailing headers from the peer via OnStreamHeaderList() |
| 1157 | // works, and can be read from the stream and consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1158 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersViaHeaderList) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1159 | Initialize(kShouldProcessData); |
| 1160 | |
| 1161 | // Receive initial headers. |
| 1162 | size_t total_bytes = 0; |
| 1163 | QuicHeaderList headers; |
| 1164 | for (const auto& p : headers_) { |
| 1165 | headers.OnHeader(p.first, p.second); |
| 1166 | total_bytes += p.first.size() + p.second.size(); |
| 1167 | } |
| 1168 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1169 | stream_->OnStreamHeadersPriority( |
| 1170 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1171 | stream_->OnStreamHeaderList(/*fin=*/false, total_bytes, headers); |
| 1172 | stream_->ConsumeHeaderList(); |
| 1173 | |
| 1174 | // Receive trailing headers. |
| 1175 | SpdyHeaderBlock trailers_block; |
| 1176 | trailers_block["key1"] = "value1"; |
| 1177 | trailers_block["key2"] = "value2"; |
| 1178 | trailers_block["key3"] = "value3"; |
| 1179 | SpdyHeaderBlock trailers_block_with_final_offset = trailers_block.Clone(); |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1180 | if (!UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1181 | // :final-offset pseudo-header is only added if trailers are sent |
| 1182 | // on the headers stream. |
| 1183 | trailers_block_with_final_offset[kFinalOffsetHeaderKey] = "0"; |
| 1184 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1185 | total_bytes = 0; |
| 1186 | QuicHeaderList trailers; |
| 1187 | for (const auto& p : trailers_block_with_final_offset) { |
| 1188 | trailers.OnHeader(p.first, p.second); |
| 1189 | total_bytes += p.first.size() + p.second.size(); |
| 1190 | } |
| 1191 | stream_->OnStreamHeaderList(/*fin=*/true, total_bytes, trailers); |
| 1192 | |
| 1193 | // The trailers should be decompressed, and readable from the stream. |
| 1194 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1195 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1196 | |
| 1197 | // IsDoneReading() returns false until trailers marked consumed. |
| 1198 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 1199 | stream_->MarkTrailersConsumed(); |
| 1200 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1201 | } |
| 1202 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1203 | // Test that when receiving trailing headers with an offset before response |
| 1204 | // body, stream is closed at the right offset. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1205 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1206 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 1207 | // request/response stream. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1208 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1209 | return; |
| 1210 | } |
| 1211 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1212 | Initialize(kShouldProcessData); |
| 1213 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1214 | // Receive initial headers. |
| 1215 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 1216 | stream_->ConsumeHeaderList(); |
| 1217 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1218 | const std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1219 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1220 | |
| 1221 | // Receive trailing headers. |
| 1222 | SpdyHeaderBlock trailers_block; |
| 1223 | trailers_block["key1"] = "value1"; |
| 1224 | trailers_block["key2"] = "value2"; |
| 1225 | trailers_block["key3"] = "value3"; |
| 1226 | trailers_block[kFinalOffsetHeaderKey] = |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1227 | quiche::QuicheTextUtils::Uint64ToString(data.size()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1228 | |
| 1229 | QuicHeaderList trailers = ProcessHeaders(true, trailers_block); |
| 1230 | |
| 1231 | // The trailers should be decompressed, and readable from the stream. |
| 1232 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1233 | |
| 1234 | // The final offset trailer will be consumed by QUIC. |
| 1235 | trailers_block.erase(kFinalOffsetHeaderKey); |
| 1236 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1237 | |
| 1238 | // Consuming the trailers erases them from the stream. |
| 1239 | stream_->MarkTrailersConsumed(); |
| 1240 | EXPECT_TRUE(stream_->FinishedReadingTrailers()); |
| 1241 | |
| 1242 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 1243 | // Receive and consume body. |
| 1244 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/false, |
| 1245 | 0, data); |
| 1246 | stream_->OnStreamFrame(frame); |
| 1247 | EXPECT_EQ(body, stream_->data()); |
| 1248 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1249 | } |
| 1250 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1251 | // Test that receiving trailers without a final offset field is an error. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1252 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1253 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 1254 | // request/response stream. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1255 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1256 | return; |
| 1257 | } |
| 1258 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1259 | Initialize(kShouldProcessData); |
| 1260 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1261 | // Receive initial headers. |
| 1262 | ProcessHeaders(false, headers_); |
| 1263 | stream_->ConsumeHeaderList(); |
| 1264 | |
| 1265 | // Receive trailing headers, without kFinalOffsetHeaderKey. |
| 1266 | SpdyHeaderBlock trailers_block; |
| 1267 | trailers_block["key1"] = "value1"; |
| 1268 | trailers_block["key2"] = "value2"; |
| 1269 | trailers_block["key3"] = "value3"; |
| 1270 | auto trailers = AsHeaderList(trailers_block); |
| 1271 | |
| 1272 | // Verify that the trailers block didn't contain a final offset. |
| 1273 | EXPECT_EQ("", trailers_block[kFinalOffsetHeaderKey].as_string()); |
| 1274 | |
| 1275 | // Receipt of the malformed trailers will close the connection. |
| 1276 | EXPECT_CALL(*connection_, |
| 1277 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1278 | .Times(1); |
| 1279 | stream_->OnStreamHeaderList(/*fin=*/true, |
| 1280 | trailers.uncompressed_header_bytes(), trailers); |
| 1281 | } |
| 1282 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1283 | // Test that received Trailers must always have the FIN set. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1284 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1285 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
| 1286 | // HEADERS frame. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1287 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1288 | return; |
| 1289 | } |
| 1290 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1291 | Initialize(kShouldProcessData); |
| 1292 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1293 | // Receive initial headers. |
| 1294 | auto headers = AsHeaderList(headers_); |
| 1295 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1296 | headers.uncompressed_header_bytes(), headers); |
| 1297 | stream_->ConsumeHeaderList(); |
| 1298 | |
| 1299 | // Receive trailing headers with FIN deliberately set to false. |
| 1300 | SpdyHeaderBlock trailers_block; |
| 1301 | trailers_block["foo"] = "bar"; |
| 1302 | auto trailers = AsHeaderList(trailers_block); |
| 1303 | |
| 1304 | EXPECT_CALL(*connection_, |
| 1305 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1306 | .Times(1); |
| 1307 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1308 | trailers.uncompressed_header_bytes(), trailers); |
| 1309 | } |
| 1310 | |
| 1311 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterHeadersWithFin) { |
| 1312 | // If headers are received with a FIN, no trailers should then arrive. |
| 1313 | Initialize(kShouldProcessData); |
| 1314 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1315 | // If HEADERS frames are sent on the request/response stream, then the |
| 1316 | // sequencer will signal an error if any stream data arrives after a FIN, |
| 1317 | // so QuicSpdyStream does not need to. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1318 | if (UsesHttp3()) { |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1319 | return; |
| 1320 | } |
| 1321 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1322 | // Receive initial headers with FIN set. |
| 1323 | ProcessHeaders(true, headers_); |
| 1324 | stream_->ConsumeHeaderList(); |
| 1325 | |
| 1326 | // Receive trailing headers after FIN already received. |
| 1327 | SpdyHeaderBlock trailers_block; |
| 1328 | trailers_block["foo"] = "bar"; |
| 1329 | EXPECT_CALL(*connection_, |
| 1330 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1331 | .Times(1); |
| 1332 | ProcessHeaders(true, trailers_block); |
| 1333 | } |
| 1334 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1335 | // If body data are received with a FIN, no trailers should then arrive. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1336 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterBodyWithFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1337 | // If HEADERS frames are sent on the request/response stream, |
| 1338 | // then the sequencer will block them from reaching QuicSpdyStream |
| 1339 | // after the stream is closed. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1340 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1341 | return; |
| 1342 | } |
| 1343 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1344 | Initialize(kShouldProcessData); |
| 1345 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1346 | // Receive initial headers without FIN set. |
| 1347 | ProcessHeaders(false, headers_); |
| 1348 | stream_->ConsumeHeaderList(); |
| 1349 | |
| 1350 | // Receive body data, with FIN. |
| 1351 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1352 | 0, "body"); |
| 1353 | stream_->OnStreamFrame(frame); |
| 1354 | |
| 1355 | // Receive trailing headers after FIN already received. |
| 1356 | SpdyHeaderBlock trailers_block; |
| 1357 | trailers_block["foo"] = "bar"; |
| 1358 | EXPECT_CALL(*connection_, |
| 1359 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1360 | .Times(1); |
| 1361 | ProcessHeaders(true, trailers_block); |
| 1362 | } |
| 1363 | |
| 1364 | TEST_P(QuicSpdyStreamTest, ClosingStreamWithNoTrailers) { |
| 1365 | // Verify that a stream receiving headers, body, and no trailers is correctly |
| 1366 | // marked as done reading on consumption of headers and body. |
| 1367 | Initialize(kShouldProcessData); |
| 1368 | |
| 1369 | // Receive and consume initial headers with FIN not set. |
| 1370 | auto h = AsHeaderList(headers_); |
| 1371 | stream_->OnStreamHeaderList(/*fin=*/false, h.uncompressed_header_bytes(), h); |
| 1372 | stream_->ConsumeHeaderList(); |
| 1373 | |
| 1374 | // Receive and consume body with FIN set, and no trailers. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1375 | std::string body(1024, 'x'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1376 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1377 | |
| 1378 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1379 | 0, data); |
| 1380 | stream_->OnStreamFrame(frame); |
| 1381 | |
| 1382 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1383 | } |
| 1384 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1385 | // Test that writing trailers will send a FIN, as Trailers are the last thing to |
| 1386 | // be sent on a stream. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1387 | TEST_P(QuicSpdyStreamTest, WritingTrailersSendsAFin) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1388 | Initialize(kShouldProcessData); |
| 1389 | |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1390 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1391 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
bnc | cd3c4b5 | 2020-01-10 11:13:18 -0800 | [diff] [blame] | 1392 | // Four writes on the request stream: HEADERS frame header and payload both |
| 1393 | // for headers and trailers. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1394 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)).Times(4); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1395 | } |
| 1396 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1397 | // Write the initial headers, without a FIN. |
| 1398 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1399 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1400 | |
| 1401 | // Writing trailers implicitly sends a FIN. |
| 1402 | SpdyHeaderBlock trailers; |
| 1403 | trailers["trailer key"] = "trailer value"; |
| 1404 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1405 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1406 | EXPECT_TRUE(stream_->fin_sent()); |
| 1407 | } |
| 1408 | |
bnc | b8abf38 | 2020-01-30 11:26:12 -0800 | [diff] [blame] | 1409 | TEST_P(QuicSpdyStreamTest, DoNotSendPriorityUpdateWithDefaultUrgency) { |
| 1410 | if (!UsesHttp3()) { |
| 1411 | return; |
| 1412 | } |
| 1413 | |
| 1414 | InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT); |
| 1415 | |
| 1416 | // Four writes on the request stream: HEADERS frame header and payload both |
| 1417 | // for headers and trailers. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1418 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)).Times(4); |
bnc | b8abf38 | 2020-01-30 11:26:12 -0800 | [diff] [blame] | 1419 | |
bnc | 5f20251 | 2020-02-01 18:43:02 -0800 | [diff] [blame] | 1420 | // No PRIORITY_UPDATE frames on the control stream, |
| 1421 | // because the stream has default priority. |
bnc | b8abf38 | 2020-01-30 11:26:12 -0800 | [diff] [blame] | 1422 | auto send_control_stream = |
| 1423 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1424 | EXPECT_CALL(*session_, WritevData(send_control_stream->id(), _, _, _, _, _)) |
bnc | b8abf38 | 2020-01-30 11:26:12 -0800 | [diff] [blame] | 1425 | .Times(0); |
| 1426 | |
| 1427 | // Write the initial headers, without a FIN. |
| 1428 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1429 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1430 | |
| 1431 | // Writing trailers implicitly sends a FIN. |
| 1432 | SpdyHeaderBlock trailers; |
| 1433 | trailers["trailer key"] = "trailer value"; |
| 1434 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1435 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1436 | EXPECT_TRUE(stream_->fin_sent()); |
| 1437 | } |
| 1438 | |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1439 | TEST_P(QuicSpdyStreamTest, ChangePriority) { |
| 1440 | if (!UsesHttp3()) { |
| 1441 | return; |
| 1442 | } |
| 1443 | |
| 1444 | InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT); |
| 1445 | |
| 1446 | // Two writes on the request stream: HEADERS frame header and payload. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1447 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)).Times(2); |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1448 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
bnc | 5f20251 | 2020-02-01 18:43:02 -0800 | [diff] [blame] | 1449 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1450 | |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1451 | // PRIORITY_UPDATE frame on the control stream. |
| 1452 | auto send_control_stream = |
| 1453 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1454 | EXPECT_CALL(*session_, WritevData(send_control_stream->id(), _, _, _, _, _)); |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1455 | stream_->SetPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1456 | } |
| 1457 | |
| 1458 | TEST_P(QuicSpdyStreamTest, ChangePriorityBeforeWritingHeaders) { |
| 1459 | if (!UsesHttp3()) { |
| 1460 | return; |
| 1461 | } |
| 1462 | |
| 1463 | InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT); |
| 1464 | |
| 1465 | // PRIORITY_UPDATE frame sent on the control stream as soon as SetPriority() |
| 1466 | // is called, before HEADERS frame is sent. |
| 1467 | auto send_control_stream = |
| 1468 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1469 | EXPECT_CALL(*session_, WritevData(send_control_stream->id(), _, _, _, _, _)); |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1470 | |
| 1471 | stream_->SetPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1472 | testing::Mock::VerifyAndClearExpectations(session_.get()); |
| 1473 | |
| 1474 | // Two writes on the request stream: HEADERS frame header and payload. |
| 1475 | // PRIORITY_UPDATE frame is not sent this time, because one is already sent. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1476 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)).Times(2); |
bnc | cf09f95 | 2020-01-30 17:35:59 -0800 | [diff] [blame] | 1477 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1478 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/true, nullptr); |
| 1479 | } |
| 1480 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1481 | // Test that when writing trailers, the trailers that are actually sent to the |
| 1482 | // peer contain the final offset field indicating last byte of data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1483 | TEST_P(QuicSpdyStreamTest, WritingTrailersFinalOffset) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1484 | Initialize(kShouldProcessData); |
| 1485 | |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1486 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1487 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
bnc | cd3c4b5 | 2020-01-10 11:13:18 -0800 | [diff] [blame] | 1488 | // HEADERS frame header and payload on the request stream. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1489 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)).Times(2); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1490 | } |
| 1491 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1492 | // Write the initial headers. |
| 1493 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1494 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1495 | |
| 1496 | // Write non-zero body data to force a non-zero final offset. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1497 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1498 | std::string body(1024, 'x'); // 1 kB |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1499 | QuicByteCount header_length = 0; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1500 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1501 | std::unique_ptr<char[]> buf; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 1502 | header_length = HttpEncoder::SerializeDataFrameHeader(body.length(), &buf); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1503 | } |
| 1504 | |
| 1505 | stream_->WriteOrBufferBody(body, false); |
| 1506 | |
| 1507 | // The final offset field in the trailing headers is populated with the |
| 1508 | // number of body bytes written (including queued bytes). |
| 1509 | SpdyHeaderBlock trailers; |
| 1510 | trailers["trailer key"] = "trailer value"; |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1511 | |
| 1512 | SpdyHeaderBlock expected_trailers(trailers.Clone()); |
| 1513 | // :final-offset pseudo-header is only added if trailers are sent |
| 1514 | // on the headers stream. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1515 | if (!UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1516 | expected_trailers[kFinalOffsetHeaderKey] = |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1517 | quiche::QuicheTextUtils::Uint64ToString(body.length() + header_length); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1518 | } |
| 1519 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1520 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1521 | stream_->WriteTrailers(std::move(trailers), nullptr); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1522 | EXPECT_EQ(expected_trailers, stream_->saved_headers()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1523 | } |
| 1524 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1525 | // Test that if trailers are written after all other data has been written |
| 1526 | // (headers and body), that this closes the stream for writing. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1527 | TEST_P(QuicSpdyStreamTest, WritingTrailersClosesWriteSide) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1528 | Initialize(kShouldProcessData); |
| 1529 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1530 | // Expect data being written on the stream. In addition to that, headers are |
| 1531 | // also written on the stream in case of IETF QUIC. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1532 | EXPECT_CALL(*session_, WritevData(stream_->id(), _, _, _, _, _)) |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1533 | .Times(AtLeast(1)); |
| 1534 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1535 | // Write the initial headers. |
| 1536 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1537 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1538 | |
| 1539 | // Write non-zero body data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1540 | const int kBodySize = 1 * 1024; // 1 kB |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1541 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1542 | EXPECT_EQ(0u, stream_->BufferedDataBytes()); |
| 1543 | |
| 1544 | // Headers and body have been fully written, there is no queued data. Writing |
| 1545 | // trailers marks the end of this stream, and thus the write side is closed. |
| 1546 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1547 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1548 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1549 | } |
| 1550 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1551 | // Test that the stream is not closed for writing when trailers are sent while |
| 1552 | // there are still body bytes queued. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1553 | TEST_P(QuicSpdyStreamTest, WritingTrailersWithQueuedBytes) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1554 | // This test exercises sending trailers on the headers stream while data is |
| 1555 | // still queued on the response/request stream. In IETF QUIC, data and |
| 1556 | // trailers are sent on the same stream, so this test does not apply. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1557 | if (UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1558 | return; |
| 1559 | } |
| 1560 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1561 | testing::InSequence seq; |
| 1562 | Initialize(kShouldProcessData); |
| 1563 | |
| 1564 | // Write the initial headers. |
| 1565 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1566 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1567 | |
| 1568 | // Write non-zero body data, but only consume partially, ensuring queueing. |
| 1569 | const int kBodySize = 1 * 1024; // 1 kB |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1570 | if (UsesHttp3()) { |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1571 | EXPECT_CALL(*session_, WritevData(_, 3, _, NO_FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1572 | } |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1573 | EXPECT_CALL(*session_, WritevData(_, kBodySize, _, NO_FIN, _, _)) |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1574 | .WillOnce(Return(QuicConsumedData(kBodySize - 1, false))); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1575 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1576 | EXPECT_EQ(1u, stream_->BufferedDataBytes()); |
| 1577 | |
| 1578 | // Writing trailers will send a FIN, but not close the write side of the |
| 1579 | // stream as there are queued bytes. |
| 1580 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1581 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1582 | EXPECT_TRUE(stream_->fin_sent()); |
| 1583 | EXPECT_FALSE(stream_->write_side_closed()); |
| 1584 | |
| 1585 | // Writing the queued bytes will close the write side of the stream. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1586 | EXPECT_CALL(*session_, WritevData(_, 1, _, NO_FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1587 | stream_->OnCanWrite(); |
| 1588 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1589 | } |
| 1590 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1591 | // Test that it is not possible to write Trailers after a FIN has been sent. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1592 | TEST_P(QuicSpdyStreamTest, WritingTrailersAfterFIN) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1593 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
bnc | 01de0b8 | 2020-02-25 11:36:51 -0800 | [diff] [blame] | 1594 | // HEADERS frame. |
| 1595 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1596 | return; |
| 1597 | } |
| 1598 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1599 | Initialize(kShouldProcessData); |
| 1600 | |
| 1601 | // Write the initial headers, with a FIN. |
| 1602 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1603 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/true, nullptr); |
| 1604 | EXPECT_TRUE(stream_->fin_sent()); |
| 1605 | |
| 1606 | // Writing Trailers should fail, as the FIN has already been sent. |
| 1607 | // populated with the number of body bytes written. |
| 1608 | EXPECT_QUIC_BUG(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr), |
| 1609 | "Trailers cannot be sent after a FIN"); |
| 1610 | } |
| 1611 | |
| 1612 | TEST_P(QuicSpdyStreamTest, HeaderStreamNotiferCorrespondingSpdyStream) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1613 | // There is no headers stream if QPACK is used. |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1614 | if (UsesHttp3()) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1615 | return; |
| 1616 | } |
| 1617 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1618 | const char kHeader1[] = "Header1"; |
| 1619 | const char kHeader2[] = "Header2"; |
| 1620 | const char kBody1[] = "Test1"; |
| 1621 | const char kBody2[] = "Test2"; |
| 1622 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1623 | Initialize(kShouldProcessData); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1624 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1625 | testing::InSequence s; |
| 1626 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 1627 | new MockAckListener()); |
| 1628 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 1629 | new MockAckListener()); |
| 1630 | stream_->set_ack_listener(ack_listener1); |
| 1631 | stream2_->set_ack_listener(ack_listener2); |
| 1632 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1633 | session_->headers_stream()->WriteOrBufferData(kHeader1, false, ack_listener1); |
| 1634 | stream_->WriteOrBufferBody(kBody1, true); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1635 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1636 | session_->headers_stream()->WriteOrBufferData(kHeader2, false, ack_listener2); |
| 1637 | stream2_->WriteOrBufferBody(kBody2, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1638 | |
| 1639 | QuicStreamFrame frame1( |
| 1640 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 0, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1641 | kHeader1); |
| 1642 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1643 | std::string data1 = UsesHttp3() ? DataFrame(kBody1) : kBody1; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1644 | QuicStreamFrame frame2(stream_->id(), true, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1645 | QuicStreamFrame frame3( |
| 1646 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 7, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1647 | kHeader2); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1648 | std::string data2 = UsesHttp3() ? DataFrame(kBody2) : kBody2; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1649 | QuicStreamFrame frame4(stream2_->id(), false, 0, data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1650 | |
| 1651 | EXPECT_CALL(*ack_listener1, OnPacketRetransmitted(7)); |
| 1652 | session_->OnStreamFrameRetransmitted(frame1); |
| 1653 | |
| 1654 | EXPECT_CALL(*ack_listener1, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1655 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame1), QuicTime::Delta::Zero(), |
| 1656 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1657 | EXPECT_CALL(*ack_listener1, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1658 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1659 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1660 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1661 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1662 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1663 | EXPECT_CALL(*ack_listener2, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1664 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame4), QuicTime::Delta::Zero(), |
| 1665 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1666 | } |
| 1667 | |
| 1668 | TEST_P(QuicSpdyStreamTest, StreamBecomesZombieWithWriteThatCloses) { |
| 1669 | Initialize(kShouldProcessData); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1670 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1671 | QuicStreamPeer::CloseReadSide(stream_); |
| 1672 | // This write causes stream to be closed. |
| 1673 | stream_->WriteOrBufferBody("Test1", true); |
| 1674 | // stream_ has unacked data and should become zombie. |
| 1675 | EXPECT_TRUE(QuicContainsKey(QuicSessionPeer::zombie_streams(session_.get()), |
| 1676 | stream_->id())); |
| 1677 | EXPECT_TRUE(QuicSessionPeer::closed_streams(session_.get()).empty()); |
| 1678 | } |
| 1679 | |
| 1680 | TEST_P(QuicSpdyStreamTest, OnPriorityFrame) { |
| 1681 | Initialize(kShouldProcessData); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1682 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1683 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1684 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1685 | } |
| 1686 | |
| 1687 | TEST_P(QuicSpdyStreamTest, OnPriorityFrameAfterSendingData) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1688 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 1689 | testing::InSequence seq; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1690 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1691 | if (UsesHttp3()) { |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1692 | EXPECT_CALL(*session_, WritevData(_, 2, _, NO_FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1693 | } |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1694 | EXPECT_CALL(*session_, WritevData(_, 4, _, FIN, _, _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1695 | stream_->WriteOrBufferBody("data", true); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1696 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1697 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1698 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1699 | } |
| 1700 | |
| 1701 | TEST_P(QuicSpdyStreamTest, SetPriorityBeforeUpdateStreamPriority) { |
| 1702 | MockQuicConnection* connection = new StrictMock<MockQuicConnection>( |
| 1703 | &helper_, &alarm_factory_, Perspective::IS_SERVER, |
| 1704 | SupportedVersions(GetParam())); |
| 1705 | std::unique_ptr<TestMockUpdateStreamSession> session( |
| 1706 | new StrictMock<TestMockUpdateStreamSession>(connection)); |
renjietang | d1d0085 | 2019-09-06 10:43:12 -0700 | [diff] [blame] | 1707 | auto stream = |
| 1708 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalStreamId( |
| 1709 | session->transport_version(), 0), |
| 1710 | session.get(), |
| 1711 | /*should_process_data=*/true); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1712 | session->ActivateStream(QuicWrapUnique(stream)); |
| 1713 | |
| 1714 | // QuicSpdyStream::SetPriority() should eventually call UpdateStreamPriority() |
| 1715 | // on the session. Make sure stream->priority() returns the updated priority |
| 1716 | // if called within UpdateStreamPriority(). This expectation is enforced in |
| 1717 | // TestMockUpdateStreamSession::UpdateStreamPriority(). |
| 1718 | session->SetExpectedStream(stream); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1719 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1720 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1721 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1722 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
| 1723 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1724 | } |
| 1725 | |
| 1726 | TEST_P(QuicSpdyStreamTest, StreamWaitsForAcks) { |
| 1727 | Initialize(kShouldProcessData); |
| 1728 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1729 | new StrictMock<MockAckListener>); |
| 1730 | stream_->set_ack_listener(mock_ack_listener); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1731 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1732 | // Stream is not waiting for acks initially. |
| 1733 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1734 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1735 | |
| 1736 | // Send kData1. |
| 1737 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1738 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1739 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1740 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1741 | QuicByteCount newly_acked_length = 0; |
| 1742 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1743 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1744 | &newly_acked_length)); |
| 1745 | // Stream is not waiting for acks as all sent data is acked. |
| 1746 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1747 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1748 | |
| 1749 | // Send kData2. |
| 1750 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1751 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1752 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1753 | // Send FIN. |
| 1754 | stream_->WriteOrBufferData("", true, nullptr); |
| 1755 | // Fin only frame is not stored in send buffer. |
| 1756 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1757 | |
| 1758 | // kData2 is retransmitted. |
| 1759 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(9)); |
| 1760 | stream_->OnStreamFrameRetransmitted(9, 9, false); |
| 1761 | |
| 1762 | // kData2 is acked. |
| 1763 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1764 | EXPECT_TRUE(stream_->OnStreamFrameAcked(9, 9, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1765 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1766 | &newly_acked_length)); |
| 1767 | // Stream is waiting for acks as FIN is not acked. |
| 1768 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1769 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1770 | |
| 1771 | // FIN is acked. |
| 1772 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1773 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 0, true, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1774 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1775 | &newly_acked_length)); |
| 1776 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1777 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1778 | } |
| 1779 | |
| 1780 | TEST_P(QuicSpdyStreamTest, StreamDataGetAckedMultipleTimes) { |
| 1781 | Initialize(kShouldProcessData); |
| 1782 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1783 | new StrictMock<MockAckListener>); |
| 1784 | stream_->set_ack_listener(mock_ack_listener); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1785 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1786 | // Send [0, 27) and fin. |
| 1787 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1788 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1789 | stream_->WriteOrBufferData("FooAndBar", true, nullptr); |
| 1790 | |
| 1791 | // Ack [0, 9), [5, 22) and [18, 26) |
| 1792 | // Verify [0, 9) 9 bytes are acked. |
| 1793 | QuicByteCount newly_acked_length = 0; |
| 1794 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1795 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1796 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1797 | &newly_acked_length)); |
| 1798 | EXPECT_EQ(2u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1799 | // Verify [9, 22) 13 bytes are acked. |
| 1800 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(13, _)); |
| 1801 | EXPECT_TRUE(stream_->OnStreamFrameAcked(5, 17, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1802 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1803 | &newly_acked_length)); |
| 1804 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1805 | // Verify [22, 26) 4 bytes are acked. |
| 1806 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(4, _)); |
| 1807 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 8, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1808 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1809 | &newly_acked_length)); |
| 1810 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1811 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1812 | |
| 1813 | // Ack [0, 27). |
| 1814 | // Verify [26, 27) 1 byte is acked. |
| 1815 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(1, _)); |
| 1816 | EXPECT_TRUE(stream_->OnStreamFrameAcked(26, 1, false, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1817 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1818 | &newly_acked_length)); |
| 1819 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1820 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1821 | |
| 1822 | // Ack Fin. Verify OnPacketAcked is called. |
| 1823 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1824 | EXPECT_TRUE(stream_->OnStreamFrameAcked(27, 0, true, QuicTime::Delta::Zero(), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1825 | QuicTime::Zero(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1826 | &newly_acked_length)); |
| 1827 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1828 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1829 | |
| 1830 | // Ack [10, 27) and fin. |
| 1831 | // No new data is acked, verify OnPacketAcked is not called. |
| 1832 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(_, _)).Times(0); |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 1833 | EXPECT_FALSE( |
| 1834 | stream_->OnStreamFrameAcked(10, 17, true, QuicTime::Delta::Zero(), |
| 1835 | QuicTime::Zero(), &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1836 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1837 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1838 | } |
| 1839 | |
| 1840 | // HTTP/3 only. |
| 1841 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteOrBufferBody) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1842 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1843 | return; |
| 1844 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1845 | |
| 1846 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1847 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1848 | new StrictMock<MockAckListener>); |
| 1849 | stream_->set_ack_listener(mock_ack_listener); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1850 | std::string body = "Test1"; |
| 1851 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1852 | |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1853 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1854 | stream_->WriteOrBufferBody(body, false); |
| 1855 | stream_->WriteOrBufferBody(body2, true); |
| 1856 | |
| 1857 | std::unique_ptr<char[]> buffer; |
| 1858 | QuicByteCount header_length = |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 1859 | HttpEncoder::SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1860 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1861 | |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 1862 | header_length = |
| 1863 | HttpEncoder::SerializeDataFrameHeader(body2.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1864 | std::string header2 = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1865 | |
| 1866 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body.length(), _)); |
| 1867 | QuicStreamFrame frame(stream_->id(), false, 0, header + body); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1868 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1869 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1870 | |
| 1871 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1872 | QuicStreamFrame frame2(stream_->id(), false, header.length() + body.length(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1873 | header2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1874 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1875 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1876 | |
| 1877 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body2.length(), _)); |
| 1878 | QuicStreamFrame frame3(stream_->id(), true, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1879 | header.length() + body.length() + header2.length(), |
| 1880 | body2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1881 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1882 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1883 | |
| 1884 | EXPECT_TRUE( |
| 1885 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1886 | } |
| 1887 | |
| 1888 | // HTTP/3 only. |
| 1889 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteBodySlices) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1890 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1891 | return; |
| 1892 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1893 | |
| 1894 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1895 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1896 | new StrictMock<MockAckListener>); |
| 1897 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1898 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1899 | std::string body2(100, 'x'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1900 | struct iovec body1_iov = {const_cast<char*>(body1.data()), body1.length()}; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1901 | struct iovec body2_iov = {const_cast<char*>(body2.data()), body2.length()}; |
| 1902 | QuicMemSliceStorage storage(&body1_iov, 1, |
| 1903 | helper_.GetStreamSendBufferAllocator(), 1024); |
| 1904 | QuicMemSliceStorage storage2(&body2_iov, 1, |
| 1905 | helper_.GetStreamSendBufferAllocator(), 1024); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1906 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1907 | stream_->WriteBodySlices(storage.ToSpan(), false); |
| 1908 | stream_->WriteBodySlices(storage2.ToSpan(), true); |
| 1909 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1910 | std::string data1 = DataFrame(body1); |
| 1911 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1912 | |
| 1913 | EXPECT_CALL(*mock_ack_listener, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1914 | OnPacketAcked(body1.length() + body2.length(), _)); |
| 1915 | QuicStreamFrame frame(stream_->id(), true, 0, data1 + data2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1916 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1917 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1918 | |
| 1919 | EXPECT_TRUE( |
| 1920 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1921 | } |
| 1922 | |
| 1923 | // HTTP/3 only. |
| 1924 | TEST_P(QuicSpdyStreamTest, HeaderBytesNotReportedOnRetransmission) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1925 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1926 | return; |
| 1927 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1928 | |
| 1929 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1930 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1931 | new StrictMock<MockAckListener>); |
| 1932 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1933 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1934 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1935 | |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 1936 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).Times(AtLeast(1)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1937 | stream_->WriteOrBufferBody(body1, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1938 | stream_->WriteOrBufferBody(body2, true); |
| 1939 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1940 | std::string data1 = DataFrame(body1); |
| 1941 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1942 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1943 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body1.length())); |
| 1944 | QuicStreamFrame frame(stream_->id(), false, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1945 | session_->OnStreamFrameRetransmitted(frame); |
| 1946 | |
| 1947 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body2.length())); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1948 | QuicStreamFrame frame2(stream_->id(), true, data1.length(), data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1949 | session_->OnStreamFrameRetransmitted(frame2); |
| 1950 | |
| 1951 | EXPECT_FALSE( |
| 1952 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1953 | } |
| 1954 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1955 | TEST_P(QuicSpdyStreamTest, HeadersFrameOnRequestStream) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1956 | if (!UsesHttp3()) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1957 | return; |
| 1958 | } |
| 1959 | |
| 1960 | Initialize(kShouldProcessData); |
| 1961 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1962 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1963 | std::string data = DataFrame(kDataFramePayload); |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1964 | std::string trailers = |
| 1965 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1966 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 1967 | std::string stream_frame_payload = |
| 1968 | quiche::QuicheStrCat(headers, data, trailers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1969 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1970 | stream_->OnStreamFrame(frame); |
| 1971 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1972 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1973 | |
| 1974 | // QuicSpdyStream only calls OnBodyAvailable() |
| 1975 | // after the header list has been consumed. |
| 1976 | EXPECT_EQ("", stream_->data()); |
| 1977 | stream_->ConsumeHeaderList(); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1978 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1979 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1980 | EXPECT_THAT(stream_->received_trailers(), |
| 1981 | ElementsAre(Pair("custom-key", "custom-value"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1982 | } |
| 1983 | |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1984 | TEST_P(QuicSpdyStreamTest, ProcessBodyAfterTrailers) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 1985 | if (!UsesHttp3()) { |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1986 | return; |
| 1987 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1988 | |
| 1989 | Initialize(!kShouldProcessData); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1990 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1991 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1992 | std::string data = DataFrame(kDataFramePayload); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1993 | |
| 1994 | // A header block that will take more than one block of sequencer buffer. |
| 1995 | // This ensures that when the trailers are consumed, some buffer buckets will |
| 1996 | // be freed. |
| 1997 | SpdyHeaderBlock trailers_block; |
| 1998 | trailers_block["key1"] = std::string(10000, 'x'); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 1999 | std::string trailers = HeadersFrame(trailers_block); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 2000 | |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 2001 | // Feed all three HTTP/3 frames in a single stream frame. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2002 | std::string stream_frame_payload = |
| 2003 | quiche::QuicheStrCat(headers, data, trailers); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 2004 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 2005 | stream_->OnStreamFrame(frame); |
| 2006 | |
| 2007 | stream_->ConsumeHeaderList(); |
| 2008 | stream_->MarkTrailersConsumed(); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 2009 | |
| 2010 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2011 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 2012 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 2013 | EXPECT_TRUE(stream_->HasBytesToRead()); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 2014 | |
| 2015 | // Consume data. |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 2016 | char buffer[2048]; |
| 2017 | struct iovec vec; |
| 2018 | vec.iov_base = buffer; |
bnc | 4e9283d | 2019-12-17 07:08:57 -0800 | [diff] [blame] | 2019 | vec.iov_len = QUICHE_ARRAYSIZE(buffer); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 2020 | size_t bytes_read = stream_->Readv(&vec, 1); |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2021 | EXPECT_EQ(kDataFramePayload, quiche::QuicheStringPiece(buffer, bytes_read)); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 2022 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 2023 | EXPECT_FALSE(stream_->HasBytesToRead()); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 2024 | } |
| 2025 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 2026 | // The test stream will receive a stream frame containing malformed headers and |
| 2027 | // normal body. Make sure the http decoder stops processing body after the |
| 2028 | // connection shuts down. |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2029 | TEST_P(QuicSpdyStreamTest, MalformedHeadersStopHttpDecoder) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2030 | if (!UsesHttp3()) { |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2031 | return; |
| 2032 | } |
| 2033 | |
| 2034 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 2035 | testing::InSequence s; |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2036 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 2037 | |
| 2038 | // Random bad headers. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 2039 | std::string headers = |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2040 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("00002a94e7036261")); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 2041 | std::string data = DataFrame(kDataFramePayload); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2042 | |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2043 | std::string stream_frame_payload = quiche::QuicheStrCat(headers, data); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2044 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 2045 | |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 2046 | EXPECT_CALL( |
| 2047 | *connection_, |
bnc | 232ff9b | 2019-11-13 18:38:22 -0800 | [diff] [blame] | 2048 | CloseConnection(QUIC_QPACK_DECOMPRESSION_FAILED, |
| 2049 | MatchesRegex("Error decoding headers on stream \\d+: " |
| 2050 | "Incomplete header block."), |
| 2051 | _)) |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2052 | .WillOnce( |
| 2053 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 2054 | ConnectionCloseBehavior connection_close_behavior) { |
| 2055 | connection_->ReallyCloseConnection(error, error_details, |
| 2056 | connection_close_behavior); |
| 2057 | }))); |
| 2058 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 2059 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 2060 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 2061 | ConnectionCloseSource source) { |
| 2062 | session_->ReallyOnConnectionClosed(frame, source); |
| 2063 | })); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 2064 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 2065 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 2066 | stream_->OnStreamFrame(frame); |
| 2067 | } |
| 2068 | |
bnc | f9ff46b | 2019-11-26 10:32:09 -0800 | [diff] [blame] | 2069 | // Regression test for https://crbug.com/1027895: a HEADERS frame triggers an |
| 2070 | // error in QuicSpdyStream::OnHeadersFramePayload(). This closes the |
| 2071 | // connection, freeing the buffer of QuicStreamSequencer. Therefore |
| 2072 | // QuicStreamSequencer::MarkConsumed() must not be called from |
| 2073 | // QuicSpdyStream::OnHeadersFramePayload(). |
| 2074 | TEST_P(QuicSpdyStreamTest, DoNotMarkConsumedAfterQpackDecodingError) { |
| 2075 | if (!UsesHttp3()) { |
| 2076 | return; |
| 2077 | } |
| 2078 | |
| 2079 | Initialize(kShouldProcessData); |
| 2080 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 2081 | |
| 2082 | testing::InSequence s; |
| 2083 | EXPECT_CALL( |
| 2084 | *connection_, |
| 2085 | CloseConnection(QUIC_QPACK_DECOMPRESSION_FAILED, |
| 2086 | MatchesRegex("Error decoding headers on stream \\d+: " |
| 2087 | "Invalid relative index."), |
| 2088 | _)) |
| 2089 | .WillOnce( |
| 2090 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 2091 | ConnectionCloseBehavior connection_close_behavior) { |
| 2092 | connection_->ReallyCloseConnection(error, error_details, |
| 2093 | connection_close_behavior); |
| 2094 | }))); |
| 2095 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
| 2096 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 2097 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 2098 | ConnectionCloseSource source) { |
| 2099 | session_->ReallyOnConnectionClosed(frame, source); |
| 2100 | })); |
| 2101 | EXPECT_CALL(*session_, SendRstStream(stream_->id(), _, _)); |
| 2102 | EXPECT_CALL(*session_, SendRstStream(stream2_->id(), _, _)); |
| 2103 | |
| 2104 | // Invalid headers: Required Insert Count is zero, but the header block |
| 2105 | // contains a dynamic table reference. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2106 | std::string headers = |
| 2107 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("000080")); |
bnc | f9ff46b | 2019-11-26 10:32:09 -0800 | [diff] [blame] | 2108 | QuicStreamFrame frame(stream_->id(), false, 0, headers); |
| 2109 | stream_->OnStreamFrame(frame); |
| 2110 | } |
| 2111 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2112 | TEST_P(QuicSpdyStreamTest, ImmediateHeaderDecodingWithDynamicTableEntries) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2113 | if (!UsesHttp3()) { |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2114 | return; |
| 2115 | } |
| 2116 | |
| 2117 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 2118 | testing::InSequence s; |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 2119 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2120 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2121 | auto decoder_send_stream = |
| 2122 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 2123 | |
| 2124 | // The stream byte will be written in the first byte. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2125 | EXPECT_CALL(*session_, WritevData(decoder_send_stream->id(), _, _, _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2126 | // Deliver dynamic table entry to decoder. |
| 2127 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 2128 | |
| 2129 | // HEADERS frame referencing first dynamic table entry. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2130 | std::string headers = |
| 2131 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("020080")); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2132 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2133 | |
| 2134 | // Headers can be decoded immediately. |
| 2135 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 2136 | |
| 2137 | // Verify headers. |
| 2138 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2139 | stream_->ConsumeHeaderList(); |
| 2140 | |
| 2141 | // DATA frame. |
| 2142 | std::string data = DataFrame(kDataFramePayload); |
| 2143 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 2144 | headers.length(), data)); |
| 2145 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2146 | |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2147 | EXPECT_CALL(*session_, WritevData(decoder_send_stream->id(), _, _, _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2148 | // Deliver second dynamic table entry to decoder. |
| 2149 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
| 2150 | |
| 2151 | // Trailing HEADERS frame referencing second dynamic table entry. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2152 | std::string trailers = |
| 2153 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("030080")); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2154 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 2155 | headers.length() + data.length(), |
| 2156 | trailers)); |
| 2157 | |
| 2158 | // Trailers can be decoded immediately. |
| 2159 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2160 | |
| 2161 | // Verify trailers. |
| 2162 | EXPECT_THAT(stream_->received_trailers(), |
| 2163 | ElementsAre(Pair("trailing", "foobar"))); |
| 2164 | stream_->MarkTrailersConsumed(); |
| 2165 | } |
| 2166 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2167 | TEST_P(QuicSpdyStreamTest, BlockedHeaderDecoding) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2168 | if (!UsesHttp3()) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2169 | return; |
| 2170 | } |
| 2171 | |
| 2172 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 2173 | testing::InSequence s; |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 2174 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2175 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2176 | // HEADERS frame referencing first dynamic table entry. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2177 | std::string headers = |
| 2178 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2179 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2180 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2181 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2182 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2183 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2184 | auto decoder_send_stream = |
| 2185 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 2186 | |
| 2187 | // The stream byte will be written in the first byte. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2188 | EXPECT_CALL(*session_, WritevData(decoder_send_stream->id(), _, _, _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2189 | // Deliver dynamic table entry to decoder. |
| 2190 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2191 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 2192 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2193 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2194 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2195 | stream_->ConsumeHeaderList(); |
| 2196 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2197 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2198 | std::string data = DataFrame(kDataFramePayload); |
| 2199 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 2200 | headers.length(), data)); |
| 2201 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2202 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2203 | // Trailing HEADERS frame referencing second dynamic table entry. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2204 | std::string trailers = |
| 2205 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("030080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2206 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 2207 | headers.length() + data.length(), |
| 2208 | trailers)); |
| 2209 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2210 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2211 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 2212 | |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2213 | EXPECT_CALL(*session_, WritevData(decoder_send_stream->id(), _, _, _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2214 | // Deliver second dynamic table entry to decoder. |
| 2215 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2216 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2217 | |
| 2218 | // Verify trailers. |
| 2219 | EXPECT_THAT(stream_->received_trailers(), |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2220 | ElementsAre(Pair("trailing", "foobar"))); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2221 | stream_->MarkTrailersConsumed(); |
| 2222 | } |
| 2223 | |
| 2224 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingHeaders) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2225 | if (!UsesHttp3()) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2226 | return; |
| 2227 | } |
| 2228 | |
| 2229 | Initialize(kShouldProcessData); |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 2230 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2231 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2232 | // HEADERS frame only referencing entry with absolute index 0 but with |
| 2233 | // Required Insert Count = 2, which is incorrect. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2234 | std::string headers = |
| 2235 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2236 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2237 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2238 | // Even though entire header block is received and every referenced entry is |
| 2239 | // available, decoding is blocked until insert count reaches the Required |
| 2240 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2241 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2242 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2243 | EXPECT_CALL( |
| 2244 | *connection_, |
bnc | 232ff9b | 2019-11-13 18:38:22 -0800 | [diff] [blame] | 2245 | CloseConnection(QUIC_QPACK_DECOMPRESSION_FAILED, |
| 2246 | MatchesRegex("Error decoding headers on stream \\d+: " |
| 2247 | "Required Insert Count too large."), |
| 2248 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2249 | |
| 2250 | // Deliver two dynamic table entries to decoder |
| 2251 | // to trigger decoding of header block. |
| 2252 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 2253 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2254 | } |
| 2255 | |
bnc | fb4f4fc | 2019-11-18 17:14:56 -0800 | [diff] [blame] | 2256 | // Regression test for https://crbug.com/1024263 and for |
| 2257 | // https://crbug.com/1025209#c11. |
| 2258 | TEST_P(QuicSpdyStreamTest, BlockedHeaderDecodingUnblockedWithBufferedError) { |
| 2259 | if (!UsesHttp3()) { |
| 2260 | return; |
| 2261 | } |
| 2262 | |
| 2263 | Initialize(kShouldProcessData); |
| 2264 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
| 2265 | |
| 2266 | // Relative index 2 is invalid because it is larger than or equal to the Base. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2267 | std::string headers = |
| 2268 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("020082")); |
bnc | fb4f4fc | 2019-11-18 17:14:56 -0800 | [diff] [blame] | 2269 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2270 | |
| 2271 | // Decoding is blocked. |
| 2272 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2273 | |
| 2274 | EXPECT_CALL( |
| 2275 | *connection_, |
| 2276 | CloseConnection(QUIC_QPACK_DECOMPRESSION_FAILED, |
| 2277 | MatchesRegex("Error decoding headers on stream \\d+: " |
| 2278 | "Invalid relative index."), |
| 2279 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
| 2280 | |
| 2281 | // Deliver one dynamic table entry to decoder |
| 2282 | // to trigger decoding of header block. |
| 2283 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 2284 | } |
| 2285 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2286 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingTrailers) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2287 | if (!UsesHttp3()) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2288 | return; |
| 2289 | } |
| 2290 | |
| 2291 | Initialize(kShouldProcessData); |
fayang | 8790d29 | 2020-03-18 13:17:23 -0700 | [diff] [blame] | 2292 | testing::InSequence s; |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 2293 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2294 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2295 | // HEADERS frame referencing first dynamic table entry. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2296 | std::string headers = |
| 2297 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2298 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2299 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2300 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2301 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2302 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2303 | auto decoder_send_stream = |
| 2304 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 2305 | |
| 2306 | // The stream byte will be written in the first byte. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2307 | EXPECT_CALL(*session_, WritevData(decoder_send_stream->id(), _, _, _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2308 | // Deliver dynamic table entry to decoder. |
| 2309 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2310 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 2311 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2312 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2313 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2314 | stream_->ConsumeHeaderList(); |
| 2315 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2316 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2317 | std::string data = DataFrame(kDataFramePayload); |
| 2318 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 2319 | headers.length(), data)); |
| 2320 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2321 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2322 | // Trailing HEADERS frame only referencing entry with absolute index 0 but |
| 2323 | // with Required Insert Count = 2, which is incorrect. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2324 | std::string trailers = |
| 2325 | HeadersFrame(quiche::QuicheTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2326 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 2327 | headers.length() + data.length(), |
| 2328 | trailers)); |
| 2329 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2330 | // Even though entire header block is received and every referenced entry is |
| 2331 | // available, decoding is blocked until insert count reaches the Required |
| 2332 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2333 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 2334 | |
bnc | 232ff9b | 2019-11-13 18:38:22 -0800 | [diff] [blame] | 2335 | EXPECT_CALL( |
| 2336 | *connection_, |
| 2337 | CloseConnection(QUIC_QPACK_DECOMPRESSION_FAILED, |
| 2338 | MatchesRegex("Error decoding trailers on stream \\d+: " |
| 2339 | "Required Insert Count too large."), |
| 2340 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2341 | |
| 2342 | // Deliver second dynamic table entry to decoder |
| 2343 | // to trigger decoding of trailing header block. |
| 2344 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2345 | } |
| 2346 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2347 | class QuicSpdyStreamIncrementalConsumptionTest : public QuicSpdyStreamTest { |
| 2348 | protected: |
| 2349 | QuicSpdyStreamIncrementalConsumptionTest() : offset_(0), consumed_bytes_(0) {} |
| 2350 | ~QuicSpdyStreamIncrementalConsumptionTest() override = default; |
| 2351 | |
| 2352 | // Create QuicStreamFrame with |payload| |
| 2353 | // and pass it to stream_->OnStreamFrame(). |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2354 | void OnStreamFrame(quiche::QuicheStringPiece payload) { |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2355 | QuicStreamFrame frame(stream_->id(), /* fin = */ false, offset_, payload); |
| 2356 | stream_->OnStreamFrame(frame); |
| 2357 | offset_ += payload.size(); |
| 2358 | } |
| 2359 | |
| 2360 | // Return number of bytes marked consumed with sequencer |
| 2361 | // since last NewlyConsumedBytes() call. |
| 2362 | QuicStreamOffset NewlyConsumedBytes() { |
| 2363 | QuicStreamOffset previously_consumed_bytes = consumed_bytes_; |
| 2364 | consumed_bytes_ = stream_->sequencer()->NumBytesConsumed(); |
| 2365 | return consumed_bytes_ - previously_consumed_bytes; |
| 2366 | } |
| 2367 | |
| 2368 | // Read |size| bytes from the stream. |
| 2369 | std::string ReadFromStream(QuicByteCount size) { |
| 2370 | std::string buffer; |
| 2371 | buffer.resize(size); |
| 2372 | |
| 2373 | struct iovec vec; |
| 2374 | vec.iov_base = const_cast<char*>(buffer.data()); |
| 2375 | vec.iov_len = size; |
| 2376 | |
| 2377 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 2378 | EXPECT_EQ(bytes_read, size); |
| 2379 | |
| 2380 | return buffer; |
| 2381 | } |
| 2382 | |
| 2383 | private: |
| 2384 | QuicStreamOffset offset_; |
| 2385 | QuicStreamOffset consumed_bytes_; |
| 2386 | }; |
| 2387 | |
| 2388 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 2389 | QuicSpdyStreamIncrementalConsumptionTest, |
dschinazi | 38cc1ee | 2020-02-28 14:33:58 -0800 | [diff] [blame] | 2390 | ::testing::ValuesIn(AllSupportedVersions()), |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 2391 | ::testing::PrintToStringParamName()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2392 | |
| 2393 | // Test that stream bytes are consumed (by calling |
| 2394 | // sequencer()->MarkConsumed()) incrementally, as soon as possible. |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2395 | TEST_P(QuicSpdyStreamIncrementalConsumptionTest, OnlyKnownFrames) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2396 | if (!UsesHttp3()) { |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2397 | return; |
| 2398 | } |
| 2399 | |
| 2400 | Initialize(!kShouldProcessData); |
| 2401 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2402 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2403 | |
| 2404 | // All HEADERS frame bytes are consumed even if the frame is not received |
bnc | 7deaf37 | 2019-07-25 18:00:40 -0700 | [diff] [blame] | 2405 | // completely. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2406 | OnStreamFrame( |
| 2407 | quiche::QuicheStringPiece(headers).substr(0, headers.size() - 1)); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2408 | EXPECT_EQ(headers.size() - 1, NewlyConsumedBytes()); |
| 2409 | |
| 2410 | // The rest of the HEADERS frame is also consumed immediately. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2411 | OnStreamFrame(quiche::QuicheStringPiece(headers).substr(headers.size() - 1)); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2412 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2413 | |
| 2414 | // Verify headers. |
| 2415 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2416 | stream_->ConsumeHeaderList(); |
| 2417 | |
| 2418 | // DATA frame. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2419 | quiche::QuicheStringPiece data_payload(kDataFramePayload); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2420 | std::string data_frame = DataFrame(data_payload); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2421 | QuicByteCount data_frame_header_length = |
| 2422 | data_frame.size() - data_payload.size(); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2423 | |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2424 | // DATA frame header is consumed. |
| 2425 | // DATA frame payload is not consumed because payload has to be buffered. |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2426 | OnStreamFrame(data_frame); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2427 | EXPECT_EQ(data_frame_header_length, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2428 | |
| 2429 | // Consume all but last byte of data. |
| 2430 | EXPECT_EQ(data_payload.substr(0, data_payload.size() - 1), |
| 2431 | ReadFromStream(data_payload.size() - 1)); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2432 | EXPECT_EQ(data_payload.size() - 1, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2433 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2434 | std::string trailers = |
| 2435 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2436 | |
| 2437 | // No bytes are consumed, because last byte of DATA payload is still buffered. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2438 | OnStreamFrame( |
| 2439 | quiche::QuicheStringPiece(trailers).substr(0, trailers.size() - 1)); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2440 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2441 | |
| 2442 | // Reading last byte of DATA payload triggers consumption of all data received |
| 2443 | // so far, even though last HEADERS frame has not been received completely. |
| 2444 | EXPECT_EQ(data_payload.substr(data_payload.size() - 1), ReadFromStream(1)); |
| 2445 | EXPECT_EQ(1 + trailers.size() - 1, NewlyConsumedBytes()); |
| 2446 | |
| 2447 | // Last byte of trailers is immediately consumed. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2448 | OnStreamFrame( |
| 2449 | quiche::QuicheStringPiece(trailers).substr(trailers.size() - 1)); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2450 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2451 | |
| 2452 | // Verify trailers. |
| 2453 | EXPECT_THAT(stream_->received_trailers(), |
| 2454 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2455 | } |
| 2456 | |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2457 | TEST_P(QuicSpdyStreamIncrementalConsumptionTest, UnknownFramesInterleaved) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2458 | if (!UsesHttp3()) { |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2459 | return; |
| 2460 | } |
| 2461 | |
| 2462 | Initialize(!kShouldProcessData); |
| 2463 | |
| 2464 | // Unknown frame of reserved type before HEADERS is consumed immediately. |
| 2465 | std::string unknown_frame1 = UnknownFrame(0x21, "foo"); |
| 2466 | OnStreamFrame(unknown_frame1); |
| 2467 | EXPECT_EQ(unknown_frame1.size(), NewlyConsumedBytes()); |
| 2468 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2469 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2470 | |
| 2471 | // All HEADERS frame bytes are consumed even if the frame is not received |
| 2472 | // completely. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2473 | OnStreamFrame( |
| 2474 | quiche::QuicheStringPiece(headers).substr(0, headers.size() - 1)); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2475 | EXPECT_EQ(headers.size() - 1, NewlyConsumedBytes()); |
| 2476 | |
| 2477 | // The rest of the HEADERS frame is also consumed immediately. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2478 | OnStreamFrame(quiche::QuicheStringPiece(headers).substr(headers.size() - 1)); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2479 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2480 | |
| 2481 | // Verify headers. |
| 2482 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2483 | stream_->ConsumeHeaderList(); |
| 2484 | |
| 2485 | // Frame of unknown, not reserved type between HEADERS and DATA is consumed |
| 2486 | // immediately. |
| 2487 | std::string unknown_frame2 = UnknownFrame(0x3a, ""); |
| 2488 | OnStreamFrame(unknown_frame2); |
| 2489 | EXPECT_EQ(unknown_frame2.size(), NewlyConsumedBytes()); |
| 2490 | |
| 2491 | // DATA frame. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2492 | quiche::QuicheStringPiece data_payload(kDataFramePayload); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2493 | std::string data_frame = DataFrame(data_payload); |
| 2494 | QuicByteCount data_frame_header_length = |
| 2495 | data_frame.size() - data_payload.size(); |
| 2496 | |
| 2497 | // DATA frame header is consumed. |
| 2498 | // DATA frame payload is not consumed because payload has to be buffered. |
| 2499 | OnStreamFrame(data_frame); |
| 2500 | EXPECT_EQ(data_frame_header_length, NewlyConsumedBytes()); |
| 2501 | |
| 2502 | // Frame of unknown, not reserved type is not consumed because DATA payload is |
| 2503 | // still buffered. |
| 2504 | std::string unknown_frame3 = UnknownFrame(0x39, "bar"); |
| 2505 | OnStreamFrame(unknown_frame3); |
| 2506 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2507 | |
| 2508 | // Consume all but last byte of data. |
| 2509 | EXPECT_EQ(data_payload.substr(0, data_payload.size() - 1), |
| 2510 | ReadFromStream(data_payload.size() - 1)); |
| 2511 | EXPECT_EQ(data_payload.size() - 1, NewlyConsumedBytes()); |
| 2512 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2513 | std::string trailers = |
| 2514 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2515 | |
| 2516 | // No bytes are consumed, because last byte of DATA payload is still buffered. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2517 | OnStreamFrame( |
| 2518 | quiche::QuicheStringPiece(trailers).substr(0, trailers.size() - 1)); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2519 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2520 | |
| 2521 | // Reading last byte of DATA payload triggers consumption of all data received |
| 2522 | // so far, even though last HEADERS frame has not been received completely. |
| 2523 | EXPECT_EQ(data_payload.substr(data_payload.size() - 1), ReadFromStream(1)); |
| 2524 | EXPECT_EQ(1 + unknown_frame3.size() + trailers.size() - 1, |
| 2525 | NewlyConsumedBytes()); |
| 2526 | |
| 2527 | // Last byte of trailers is immediately consumed. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2528 | OnStreamFrame( |
| 2529 | quiche::QuicheStringPiece(trailers).substr(trailers.size() - 1)); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2530 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2531 | |
| 2532 | // Verify trailers. |
| 2533 | EXPECT_THAT(stream_->received_trailers(), |
| 2534 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2535 | |
| 2536 | // Unknown frame of reserved type after trailers is consumed immediately. |
| 2537 | std::string unknown_frame4 = UnknownFrame(0x40, ""); |
| 2538 | OnStreamFrame(unknown_frame4); |
| 2539 | EXPECT_EQ(unknown_frame4.size(), NewlyConsumedBytes()); |
| 2540 | } |
| 2541 | |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2542 | TEST_P(QuicSpdyStreamTest, PushPromiseOnDataStream) { |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2543 | Initialize(kShouldProcessData); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2544 | if (!UsesHttp3()) { |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2545 | return; |
| 2546 | } |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2547 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2548 | std::string headers = EncodeQpackHeaders({{"foo", "bar"}}); |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2549 | |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2550 | PushPromiseFrame push_promise; |
| 2551 | push_promise.push_id = 0x01; |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2552 | push_promise.headers = headers; |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2553 | std::unique_ptr<char[]> buffer; |
bnc | 4694272 | 2019-10-29 11:56:21 -0700 | [diff] [blame] | 2554 | uint64_t length = HttpEncoder::SerializePushPromiseFrameWithOnlyPushId( |
| 2555 | push_promise, &buffer); |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2556 | std::string data = std::string(buffer.get(), length) + headers; |
| 2557 | QuicStreamFrame frame(stream_->id(), false, 0, data); |
| 2558 | |
| 2559 | EXPECT_CALL(*session_, |
| 2560 | OnPromiseHeaderList(stream_->id(), push_promise.push_id, |
| 2561 | headers.length(), _)); |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2562 | stream_->OnStreamFrame(frame); |
| 2563 | } |
| 2564 | |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2565 | // Close connection if a DATA frame is received before a HEADERS frame. |
| 2566 | TEST_P(QuicSpdyStreamTest, DataBeforeHeaders) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2567 | if (!UsesHttp3()) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2568 | return; |
| 2569 | } |
| 2570 | |
| 2571 | Initialize(kShouldProcessData); |
| 2572 | |
| 2573 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2574 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2575 | EXPECT_CALL( |
| 2576 | *connection_, |
bnc | 3e8fe7c | 2020-03-10 17:44:58 -0700 | [diff] [blame] | 2577 | CloseConnection(QUIC_HTTP_INVALID_FRAME_SEQUENCE_ON_SPDY_STREAM, |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2578 | "Unexpected DATA frame received.", |
| 2579 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2580 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2581 | |
| 2582 | std::string data = DataFrame(kDataFramePayload); |
| 2583 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, data)); |
| 2584 | } |
| 2585 | |
| 2586 | // Close connection if a HEADERS frame is received after the trailing HEADERS. |
| 2587 | TEST_P(QuicSpdyStreamTest, TrailersAfterTrailers) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2588 | if (!UsesHttp3()) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2589 | return; |
| 2590 | } |
| 2591 | |
| 2592 | Initialize(kShouldProcessData); |
| 2593 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2594 | // Receive and consume headers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2595 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2596 | QuicStreamOffset offset = 0; |
| 2597 | stream_->OnStreamFrame( |
| 2598 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2599 | offset += headers.size(); |
| 2600 | |
| 2601 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2602 | stream_->ConsumeHeaderList(); |
| 2603 | |
| 2604 | // Receive data. It is consumed by TestStream. |
| 2605 | std::string data = DataFrame(kDataFramePayload); |
| 2606 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data)); |
| 2607 | offset += data.size(); |
| 2608 | |
| 2609 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2610 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2611 | // Receive and consume trailers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2612 | std::string trailers1 = |
| 2613 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2614 | stream_->OnStreamFrame( |
| 2615 | QuicStreamFrame(stream_->id(), false, offset, trailers1)); |
| 2616 | offset += trailers1.size(); |
| 2617 | |
| 2618 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2619 | EXPECT_THAT(stream_->received_trailers(), |
| 2620 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2621 | |
| 2622 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2623 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2624 | EXPECT_CALL( |
| 2625 | *connection_, |
bnc | 3e8fe7c | 2020-03-10 17:44:58 -0700 | [diff] [blame] | 2626 | CloseConnection(QUIC_HTTP_INVALID_FRAME_SEQUENCE_ON_SPDY_STREAM, |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2627 | "HEADERS frame received after trailing HEADERS.", |
| 2628 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2629 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2630 | |
| 2631 | // Receive another HEADERS frame, with no header fields. |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2632 | std::string trailers2 = HeadersFrame(SpdyHeaderBlock()); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2633 | stream_->OnStreamFrame( |
| 2634 | QuicStreamFrame(stream_->id(), false, offset, trailers2)); |
| 2635 | } |
| 2636 | |
| 2637 | // Regression test for https://crbug.com/978733. |
| 2638 | // Close connection if a DATA frame is received after the trailing HEADERS. |
| 2639 | TEST_P(QuicSpdyStreamTest, DataAfterTrailers) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2640 | if (!UsesHttp3()) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2641 | return; |
| 2642 | } |
| 2643 | |
| 2644 | Initialize(kShouldProcessData); |
| 2645 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2646 | // Receive and consume headers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2647 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2648 | QuicStreamOffset offset = 0; |
| 2649 | stream_->OnStreamFrame( |
| 2650 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2651 | offset += headers.size(); |
| 2652 | |
| 2653 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2654 | stream_->ConsumeHeaderList(); |
| 2655 | |
| 2656 | // Receive data. It is consumed by TestStream. |
| 2657 | std::string data1 = DataFrame(kDataFramePayload); |
| 2658 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data1)); |
| 2659 | offset += data1.size(); |
| 2660 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2661 | |
| 2662 | // Receive trailers, with single header field "custom-key: custom-value". |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2663 | std::string trailers = |
| 2664 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2665 | stream_->OnStreamFrame( |
| 2666 | QuicStreamFrame(stream_->id(), false, offset, trailers)); |
| 2667 | offset += trailers.size(); |
| 2668 | |
| 2669 | EXPECT_THAT(stream_->received_trailers(), |
| 2670 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2671 | |
| 2672 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2673 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2674 | EXPECT_CALL( |
| 2675 | *connection_, |
bnc | 3e8fe7c | 2020-03-10 17:44:58 -0700 | [diff] [blame] | 2676 | CloseConnection(QUIC_HTTP_INVALID_FRAME_SEQUENCE_ON_SPDY_STREAM, |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2677 | "Unexpected DATA frame received.", |
| 2678 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2679 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2680 | |
| 2681 | // Receive more data. |
| 2682 | std::string data2 = DataFrame("This payload should not be proccessed."); |
| 2683 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data2)); |
| 2684 | } |
| 2685 | |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2686 | // SETTINGS frames are invalid on bidirectional streams. If one is received, |
| 2687 | // the connection is closed. No more data should be processed. |
| 2688 | TEST_P(QuicSpdyStreamTest, StopProcessingIfConnectionClosed) { |
renjietang | e47e15f | 2019-10-29 14:19:30 -0700 | [diff] [blame] | 2689 | if (!UsesHttp3()) { |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2690 | return; |
| 2691 | } |
| 2692 | |
| 2693 | Initialize(kShouldProcessData); |
| 2694 | |
| 2695 | // SETTINGS frame with empty payload. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2696 | std::string settings = quiche::QuicheTextUtils::HexDecode("0400"); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2697 | |
| 2698 | // HEADERS frame. |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2699 | // Since it arrives after a SETTINGS frame, it should never be read. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2700 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2701 | |
| 2702 | // Combine the two frames to make sure they are processed in a single |
| 2703 | // QuicSpdyStream::OnDataAvailable() call. |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 2704 | std::string frames = quiche::QuicheStrCat(settings, headers); |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2705 | |
| 2706 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2707 | |
bnc | dfabdfb | 2020-01-17 17:46:40 -0800 | [diff] [blame] | 2708 | EXPECT_CALL(*connection_, |
| 2709 | CloseConnection(QUIC_HTTP_FRAME_UNEXPECTED_ON_SPDY_STREAM, _, _)) |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2710 | .WillOnce( |
| 2711 | Invoke(connection_, &MockQuicConnection::ReallyCloseConnection)); |
| 2712 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
| 2713 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)); |
| 2714 | |
| 2715 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), /* fin = */ false, |
| 2716 | /* offset = */ 0, frames)); |
| 2717 | |
| 2718 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2719 | } |
| 2720 | |
bnc | 6f18a82 | 2019-11-27 17:50:38 -0800 | [diff] [blame] | 2721 | // Stream Cancellation instruction is sent on QPACK decoder stream |
| 2722 | // when stream is reset. |
bnc | 84aa7e5 | 2019-12-13 05:25:21 -0800 | [diff] [blame] | 2723 | TEST_P(QuicSpdyStreamTest, StreamCancellationWhenStreamReset) { |
bnc | 6f18a82 | 2019-11-27 17:50:38 -0800 | [diff] [blame] | 2724 | if (!UsesHttp3()) { |
| 2725 | return; |
| 2726 | } |
| 2727 | |
| 2728 | Initialize(kShouldProcessData); |
| 2729 | |
| 2730 | auto qpack_decoder_stream = |
| 2731 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2732 | EXPECT_CALL(*session_, WritevData(qpack_decoder_stream->id(), 1, 1, _, _, _)); |
bnc | 6f18a82 | 2019-11-27 17:50:38 -0800 | [diff] [blame] | 2733 | EXPECT_CALL(*session_, |
| 2734 | SendRstStream(stream_->id(), QUIC_STREAM_CANCELLED, 0)); |
| 2735 | |
| 2736 | stream_->Reset(QUIC_STREAM_CANCELLED); |
| 2737 | } |
| 2738 | |
| 2739 | // Stream Cancellation instruction is sent on QPACK decoder stream |
| 2740 | // when RESET_STREAM frame is received. |
bnc | 84aa7e5 | 2019-12-13 05:25:21 -0800 | [diff] [blame] | 2741 | TEST_P(QuicSpdyStreamTest, StreamCancellationOnResetReceived) { |
bnc | 6f18a82 | 2019-11-27 17:50:38 -0800 | [diff] [blame] | 2742 | if (!UsesHttp3()) { |
| 2743 | return; |
| 2744 | } |
| 2745 | |
| 2746 | Initialize(kShouldProcessData); |
| 2747 | |
| 2748 | auto qpack_decoder_stream = |
| 2749 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 2750 | EXPECT_CALL(*session_, WritevData(qpack_decoder_stream->id(), 1, 1, _, _, _)); |
bnc | 6f18a82 | 2019-11-27 17:50:38 -0800 | [diff] [blame] | 2751 | |
| 2752 | stream_->OnStreamReset(QuicRstStreamFrame( |
| 2753 | kInvalidControlFrameId, stream_->id(), QUIC_STREAM_CANCELLED, 0)); |
| 2754 | } |
| 2755 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 2756 | } // namespace |
| 2757 | } // namespace test |
| 2758 | } // namespace quic |