| commit | d48a92e533a0b7f45400f7f2686041161c23c8cd | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Tue Jun 18 19:24:58 2019 -0700 |
| committer | Bence Béky <bnc@google.com> | Wed Jun 19 14:24:13 2019 +0000 |
| tree | 12bafaba1ae8ac0b9ecd2593ddab03a8644f1478 | |
| parent | bf82b02e888d7acb087655103b7c86b7534e8249 [diff] |
Add DCHECK to v99 code path in QuicSpdyStream. We really should not feed any data to HttpDecoder if sequencer is closed, that is, at least |close_offset_| bytes have been consumed. See https://cs.corp.google.com/quiche/quic/core/quic_stream_sequencer.cc?l=199. Remove QuicSpdyStreamTest.ReceivingTrailersOnRequestStream test which violates this assumption because it feeds trailers into the stream before data. If order is fixed, this test becomes redundant with QuicSpdyStreamTest.ProcessBodyAfterTrailers, which this CL improves a bit. This came up during my investigation of https://crbug.com/969391, where the input data found by the fuzzer would trip over this new DCHECK. PiperOrigin-RevId: 253916860 Change-Id: I489710f132c7b6d1b00a203d871701bc2b52685c
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.
The code is currently in process of being moved from https://cs.chromium.org/chromium/src/net/third_party/ into this repository. Please excuse our appearance while we're under construction.