QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/third_party/quiche/src/quic/core/http/quic_spdy_stream.h" |
| 6 | |
| 7 | #include <memory> |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 8 | #include <string> |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 9 | #include <utility> |
| 10 | |
| 11 | #include "net/third_party/quiche/src/quic/core/http/http_encoder.h" |
| 12 | #include "net/third_party/quiche/src/quic/core/http/spdy_utils.h" |
| 13 | #include "net/third_party/quiche/src/quic/core/quic_connection.h" |
| 14 | #include "net/third_party/quiche/src/quic/core/quic_stream_sequencer_buffer.h" |
| 15 | #include "net/third_party/quiche/src/quic/core/quic_utils.h" |
| 16 | #include "net/third_party/quiche/src/quic/core/quic_versions.h" |
| 17 | #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" |
| 18 | #include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" |
| 19 | #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" |
| 20 | #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" |
| 21 | #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 22 | #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" |
| 23 | #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" |
| 24 | #include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h" |
| 25 | #include "net/third_party/quiche/src/quic/test_tools/quic_flow_controller_peer.h" |
| 26 | #include "net/third_party/quiche/src/quic/test_tools/quic_session_peer.h" |
| 27 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_session_peer.h" |
| 28 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_stream_peer.h" |
| 29 | #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" |
| 30 | #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" |
| 31 | |
| 32 | using spdy::kV3HighestPriority; |
| 33 | using spdy::kV3LowestPriority; |
| 34 | using spdy::SpdyHeaderBlock; |
| 35 | using spdy::SpdyPriority; |
| 36 | using testing::_; |
| 37 | using testing::AtLeast; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 38 | using testing::ElementsAre; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 39 | using testing::Invoke; |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 40 | using testing::InvokeWithoutArgs; |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 41 | using testing::MatchesRegex; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 42 | using testing::Pair; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 43 | using testing::Return; |
| 44 | using testing::StrictMock; |
| 45 | |
| 46 | namespace quic { |
| 47 | namespace test { |
| 48 | namespace { |
| 49 | |
| 50 | const bool kShouldProcessData = true; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 51 | const char kDataFramePayload[] = "some data"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 52 | |
| 53 | class TestStream : public QuicSpdyStream { |
| 54 | public: |
| 55 | TestStream(QuicStreamId id, |
| 56 | QuicSpdySession* session, |
| 57 | bool should_process_data) |
| 58 | : QuicSpdyStream(id, session, BIDIRECTIONAL), |
| 59 | should_process_data_(should_process_data) {} |
| 60 | ~TestStream() override = default; |
| 61 | |
| 62 | using QuicSpdyStream::set_ack_listener; |
| 63 | using QuicStream::CloseWriteSide; |
| 64 | using QuicStream::WriteOrBufferData; |
| 65 | |
| 66 | void OnBodyAvailable() override { |
| 67 | if (!should_process_data_) { |
| 68 | return; |
| 69 | } |
| 70 | char buffer[2048]; |
| 71 | struct iovec vec; |
| 72 | vec.iov_base = buffer; |
| 73 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 74 | size_t bytes_read = Readv(&vec, 1); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 75 | data_ += std::string(buffer, bytes_read); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 76 | } |
| 77 | |
| 78 | MOCK_METHOD1(WriteHeadersMock, void(bool fin)); |
| 79 | |
| 80 | size_t WriteHeadersImpl(spdy::SpdyHeaderBlock header_block, |
| 81 | bool fin, |
| 82 | QuicReferenceCountedPointer<QuicAckListenerInterface> |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 83 | /*ack_listener*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 84 | saved_headers_ = std::move(header_block); |
| 85 | WriteHeadersMock(fin); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 86 | if (VersionUsesQpack(transport_version())) { |
| 87 | // In this case, call QuicSpdyStream::WriteHeadersImpl() that does the |
| 88 | // actual work of closing the stream. |
| 89 | QuicSpdyStream::WriteHeadersImpl(saved_headers_.Clone(), fin, nullptr); |
| 90 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 91 | return 0; |
| 92 | } |
| 93 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 94 | const std::string& data() const { return data_; } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 95 | const spdy::SpdyHeaderBlock& saved_headers() const { return saved_headers_; } |
| 96 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 97 | // Expose protected accessor. |
| 98 | const QuicStreamSequencer* sequencer() const { |
| 99 | return QuicStream::sequencer(); |
| 100 | } |
| 101 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 102 | private: |
| 103 | bool should_process_data_; |
| 104 | spdy::SpdyHeaderBlock saved_headers_; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 105 | std::string data_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 106 | }; |
| 107 | |
| 108 | class TestMockUpdateStreamSession : public MockQuicSpdySession { |
| 109 | public: |
| 110 | explicit TestMockUpdateStreamSession(QuicConnection* connection) |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 111 | : MockQuicSpdySession(connection), |
| 112 | expected_precedence_( |
| 113 | spdy::SpdyStreamPrecedence(QuicStream::kDefaultPriority)) {} |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 114 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 115 | void UpdateStreamPriority( |
| 116 | QuicStreamId id, |
| 117 | const spdy::SpdyStreamPrecedence& precedence) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 118 | EXPECT_EQ(id, expected_stream_->id()); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 119 | EXPECT_EQ(expected_precedence_, precedence); |
| 120 | EXPECT_EQ(expected_precedence_, expected_stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 121 | } |
| 122 | |
| 123 | void SetExpectedStream(QuicSpdyStream* stream) { expected_stream_ = stream; } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 124 | void SetExpectedPriority(const spdy::SpdyStreamPrecedence& precedence) { |
| 125 | expected_precedence_ = precedence; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 126 | } |
| 127 | |
| 128 | private: |
| 129 | QuicSpdyStream* expected_stream_; |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 130 | spdy::SpdyStreamPrecedence expected_precedence_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 131 | }; |
| 132 | |
| 133 | class QuicSpdyStreamTest : public QuicTestWithParam<ParsedQuicVersion> { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 134 | protected: |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 135 | QuicSpdyStreamTest() { |
| 136 | headers_[":host"] = "www.google.com"; |
| 137 | headers_[":path"] = "/index.hml"; |
| 138 | headers_[":scheme"] = "https"; |
| 139 | headers_["cookie"] = |
| 140 | "__utma=208381060.1228362404.1372200928.1372200928.1372200928.1; " |
| 141 | "__utmc=160408618; " |
| 142 | "GX=DQAAAOEAAACWJYdewdE9rIrW6qw3PtVi2-d729qaa-74KqOsM1NVQblK4VhX" |
| 143 | "hoALMsy6HOdDad2Sz0flUByv7etmo3mLMidGrBoljqO9hSVA40SLqpG_iuKKSHX" |
| 144 | "RW3Np4bq0F0SDGDNsW0DSmTS9ufMRrlpARJDS7qAI6M3bghqJp4eABKZiRqebHT" |
| 145 | "pMU-RXvTI5D5oCF1vYxYofH_l1Kviuiy3oQ1kS1enqWgbhJ2t61_SNdv-1XJIS0" |
| 146 | "O3YeHLmVCs62O6zp89QwakfAWK9d3IDQvVSJzCQsvxvNIvaZFa567MawWlXg0Rh" |
| 147 | "1zFMi5vzcns38-8_Sns; " |
| 148 | "GA=v*2%2Fmem*57968640*47239936%2Fmem*57968640*47114716%2Fno-nm-" |
| 149 | "yj*15%2Fno-cc-yj*5%2Fpc-ch*133685%2Fpc-s-cr*133947%2Fpc-s-t*1339" |
| 150 | "47%2Fno-nm-yj*4%2Fno-cc-yj*1%2Fceft-as*1%2Fceft-nqas*0%2Fad-ra-c" |
| 151 | "v_p%2Fad-nr-cv_p-f*1%2Fad-v-cv_p*859%2Fad-ns-cv_p-f*1%2Ffn-v-ad%" |
| 152 | "2Fpc-t*250%2Fpc-cm*461%2Fpc-s-cr*722%2Fpc-s-t*722%2Fau_p*4" |
| 153 | "SICAID=AJKiYcHdKgxum7KMXG0ei2t1-W4OD1uW-ecNsCqC0wDuAXiDGIcT_HA2o1" |
| 154 | "3Rs1UKCuBAF9g8rWNOFbxt8PSNSHFuIhOo2t6bJAVpCsMU5Laa6lewuTMYI8MzdQP" |
| 155 | "ARHKyW-koxuhMZHUnGBJAM1gJODe0cATO_KGoX4pbbFxxJ5IicRxOrWK_5rU3cdy6" |
| 156 | "edlR9FsEdH6iujMcHkbE5l18ehJDwTWmBKBzVD87naobhMMrF6VvnDGxQVGp9Ir_b" |
| 157 | "Rgj3RWUoPumQVCxtSOBdX0GlJOEcDTNCzQIm9BSfetog_eP_TfYubKudt5eMsXmN6" |
| 158 | "QnyXHeGeK2UINUzJ-D30AFcpqYgH9_1BvYSpi7fc7_ydBU8TaD8ZRxvtnzXqj0RfG" |
| 159 | "tuHghmv3aD-uzSYJ75XDdzKdizZ86IG6Fbn1XFhYZM-fbHhm3mVEXnyRW4ZuNOLFk" |
| 160 | "Fas6LMcVC6Q8QLlHYbXBpdNFuGbuZGUnav5C-2I_-46lL0NGg3GewxGKGHvHEfoyn" |
| 161 | "EFFlEYHsBQ98rXImL8ySDycdLEFvBPdtctPmWCfTxwmoSMLHU2SCVDhbqMWU5b0yr" |
| 162 | "JBCScs_ejbKaqBDoB7ZGxTvqlrB__2ZmnHHjCr8RgMRtKNtIeuZAo "; |
| 163 | } |
| 164 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 165 | ~QuicSpdyStreamTest() override = default; |
| 166 | |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 167 | std::string EncodeQpackHeaders(QuicStreamId id, SpdyHeaderBlock* header) { |
renjietang | c2aa5cb | 2019-06-20 12:22:53 -0700 | [diff] [blame] | 168 | NoopQpackStreamSenderDelegate encoder_stream_sender_delegate; |
| 169 | auto qpack_encoder = QuicMakeUnique<QpackEncoder>( |
| 170 | session_.get(), &encoder_stream_sender_delegate); |
bnc | f21c1ad | 2019-06-20 20:09:50 -0700 | [diff] [blame] | 171 | return qpack_encoder->EncodeHeaderList(id, header); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 172 | } |
| 173 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 174 | void Initialize(bool stream_should_process_data) { |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 175 | InitializeWithPerspective(stream_should_process_data, |
| 176 | Perspective::IS_SERVER); |
| 177 | } |
| 178 | |
| 179 | void InitializeWithPerspective(bool stream_should_process_data, |
| 180 | Perspective perspective) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 181 | connection_ = new StrictMock<MockQuicConnection>( |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 182 | &helper_, &alarm_factory_, perspective, SupportedVersions(GetParam())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 183 | session_ = QuicMakeUnique<StrictMock<MockQuicSpdySession>>(connection_); |
| 184 | session_->Initialize(); |
| 185 | ON_CALL(*session_, WritevData(_, _, _, _, _)) |
| 186 | .WillByDefault(Invoke(MockQuicSession::ConsumeData)); |
| 187 | |
| 188 | stream_ = |
| 189 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(0), |
| 190 | session_.get(), stream_should_process_data); |
| 191 | session_->ActivateStream(QuicWrapUnique(stream_)); |
| 192 | stream2_ = |
| 193 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(1), |
| 194 | session_.get(), stream_should_process_data); |
| 195 | session_->ActivateStream(QuicWrapUnique(stream2_)); |
| 196 | } |
| 197 | |
| 198 | QuicHeaderList ProcessHeaders(bool fin, const SpdyHeaderBlock& headers) { |
| 199 | QuicHeaderList h = AsHeaderList(headers); |
| 200 | stream_->OnStreamHeaderList(fin, h.uncompressed_header_bytes(), h); |
| 201 | return h; |
| 202 | } |
| 203 | |
| 204 | QuicStreamId GetNthClientInitiatedBidirectionalId(int n) { |
| 205 | return GetNthClientInitiatedBidirectionalStreamId( |
| 206 | connection_->transport_version(), n); |
| 207 | } |
| 208 | |
| 209 | bool HasFrameHeader() const { |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 210 | return VersionHasDataFrameHeader(GetParam().transport_version); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 211 | } |
| 212 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 213 | std::string HeadersFrame(QuicStringPiece payload) { |
| 214 | std::unique_ptr<char[]> headers_buffer; |
| 215 | QuicByteCount headers_frame_header_length = |
| 216 | encoder_.SerializeHeadersFrameHeader(payload.length(), &headers_buffer); |
| 217 | QuicStringPiece headers_frame_header(headers_buffer.get(), |
| 218 | headers_frame_header_length); |
| 219 | return QuicStrCat(headers_frame_header, payload); |
| 220 | } |
| 221 | |
| 222 | std::string DataFrame(QuicStringPiece payload) { |
| 223 | std::unique_ptr<char[]> data_buffer; |
| 224 | QuicByteCount data_frame_header_length = |
| 225 | encoder_.SerializeDataFrameHeader(payload.length(), &data_buffer); |
| 226 | QuicStringPiece data_frame_header(data_buffer.get(), |
| 227 | data_frame_header_length); |
| 228 | return QuicStrCat(data_frame_header, payload); |
| 229 | } |
| 230 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 231 | MockQuicConnectionHelper helper_; |
| 232 | MockAlarmFactory alarm_factory_; |
| 233 | MockQuicConnection* connection_; |
| 234 | std::unique_ptr<MockQuicSpdySession> session_; |
| 235 | |
| 236 | // Owned by the |session_|. |
| 237 | TestStream* stream_; |
| 238 | TestStream* stream2_; |
| 239 | |
| 240 | SpdyHeaderBlock headers_; |
| 241 | |
| 242 | HttpEncoder encoder_; |
| 243 | }; |
| 244 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 245 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 246 | QuicSpdyStreamTest, |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 247 | ::testing::ValuesIn(AllSupportedVersions())); |
| 248 | |
| 249 | TEST_P(QuicSpdyStreamTest, ProcessHeaderList) { |
| 250 | Initialize(kShouldProcessData); |
| 251 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 252 | stream_->OnStreamHeadersPriority( |
| 253 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 254 | ProcessHeaders(false, headers_); |
| 255 | EXPECT_EQ("", stream_->data()); |
| 256 | EXPECT_FALSE(stream_->header_list().empty()); |
| 257 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 258 | } |
| 259 | |
| 260 | TEST_P(QuicSpdyStreamTest, ProcessTooLargeHeaderList) { |
| 261 | Initialize(kShouldProcessData); |
| 262 | |
| 263 | QuicHeaderList headers; |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 264 | stream_->OnStreamHeadersPriority( |
| 265 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 266 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 267 | const bool version_uses_qpack = |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 268 | VersionUsesQpack(GetParam().transport_version); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 269 | |
| 270 | if (version_uses_qpack) { |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 271 | EXPECT_CALL( |
| 272 | *connection_, |
dschinazi | 7ae3d60 | 2019-06-19 11:04:29 -0700 | [diff] [blame] | 273 | CloseConnection( |
| 274 | QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 275 | MatchesRegex("Too large headers received on stream \\d+"), _)); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 276 | } else { |
| 277 | EXPECT_CALL(*session_, |
| 278 | SendRstStream(stream_->id(), QUIC_HEADERS_TOO_LARGE, 0)); |
| 279 | } |
| 280 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 281 | stream_->OnStreamHeaderList(false, 1 << 20, headers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 282 | |
| 283 | if (!version_uses_qpack) { |
| 284 | EXPECT_EQ(QUIC_HEADERS_TOO_LARGE, stream_->stream_error()); |
| 285 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 286 | } |
| 287 | |
| 288 | TEST_P(QuicSpdyStreamTest, ProcessHeaderListWithFin) { |
| 289 | Initialize(kShouldProcessData); |
| 290 | |
| 291 | size_t total_bytes = 0; |
| 292 | QuicHeaderList headers; |
| 293 | for (auto p : headers_) { |
| 294 | headers.OnHeader(p.first, p.second); |
| 295 | total_bytes += p.first.size() + p.second.size(); |
| 296 | } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 297 | stream_->OnStreamHeadersPriority( |
| 298 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 299 | stream_->OnStreamHeaderList(true, total_bytes, headers); |
| 300 | EXPECT_EQ("", stream_->data()); |
| 301 | EXPECT_FALSE(stream_->header_list().empty()); |
| 302 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 303 | EXPECT_TRUE(stream_->HasFinalReceivedByteOffset()); |
| 304 | } |
| 305 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 306 | // A valid status code should be 3-digit integer. The first digit should be in |
| 307 | // the range of [1, 5]. All the others are invalid. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 308 | TEST_P(QuicSpdyStreamTest, ParseHeaderStatusCode) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 309 | Initialize(kShouldProcessData); |
| 310 | int status_code = 0; |
| 311 | |
| 312 | // Valid status codes. |
| 313 | headers_[":status"] = "404"; |
| 314 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 315 | EXPECT_EQ(404, status_code); |
| 316 | |
| 317 | headers_[":status"] = "100"; |
| 318 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 319 | EXPECT_EQ(100, status_code); |
| 320 | |
| 321 | headers_[":status"] = "599"; |
| 322 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 323 | EXPECT_EQ(599, status_code); |
| 324 | |
| 325 | // Invalid status codes. |
| 326 | headers_[":status"] = "010"; |
| 327 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 328 | |
| 329 | headers_[":status"] = "600"; |
| 330 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 331 | |
| 332 | headers_[":status"] = "200 ok"; |
| 333 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 334 | |
| 335 | headers_[":status"] = "2000"; |
| 336 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 337 | |
| 338 | headers_[":status"] = "+200"; |
| 339 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 340 | |
| 341 | headers_[":status"] = "+20"; |
| 342 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 343 | |
| 344 | headers_[":status"] = "-10"; |
| 345 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 346 | |
| 347 | headers_[":status"] = "-100"; |
| 348 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 349 | |
| 350 | // Leading or trailing spaces are also invalid. |
| 351 | headers_[":status"] = " 200"; |
| 352 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 353 | |
| 354 | headers_[":status"] = "200 "; |
| 355 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 356 | |
| 357 | headers_[":status"] = " 200 "; |
| 358 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 359 | |
| 360 | headers_[":status"] = " "; |
| 361 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 362 | } |
| 363 | |
| 364 | TEST_P(QuicSpdyStreamTest, MarkHeadersConsumed) { |
| 365 | Initialize(kShouldProcessData); |
| 366 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 367 | std::string body = "this is the body"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 368 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 369 | EXPECT_EQ(headers, stream_->header_list()); |
| 370 | |
| 371 | stream_->ConsumeHeaderList(); |
| 372 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 373 | } |
| 374 | |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 375 | TEST_P(QuicSpdyStreamTest, ProcessWrongFramesOnSpdyStream) { |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 376 | if (!HasFrameHeader()) { |
| 377 | return; |
| 378 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 379 | |
| 380 | testing::InSequence s; |
| 381 | Initialize(kShouldProcessData); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 382 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 383 | GoAwayFrame goaway; |
| 384 | goaway.stream_id = 0x1; |
| 385 | std::unique_ptr<char[]> buffer; |
| 386 | QuicByteCount header_length = encoder_.SerializeGoAwayFrame(goaway, &buffer); |
| 387 | std::string data = std::string(buffer.get(), header_length); |
| 388 | |
| 389 | EXPECT_EQ("", stream_->data()); |
| 390 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 391 | EXPECT_EQ(headers, stream_->header_list()); |
| 392 | stream_->ConsumeHeaderList(); |
| 393 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 394 | QuicStringPiece(data)); |
| 395 | |
| 396 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_DECODER_ERROR, _, _)) |
| 397 | .WillOnce( |
| 398 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 399 | ConnectionCloseBehavior connection_close_behavior) { |
| 400 | connection_->ReallyCloseConnection(error, error_details, |
| 401 | connection_close_behavior); |
| 402 | }))); |
ianswett | dc1e7ab | 2019-05-03 16:10:44 -0700 | [diff] [blame] | 403 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 404 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 405 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 406 | ConnectionCloseSource source) { |
| 407 | session_->ReallyOnConnectionClosed(frame, source); |
| 408 | })); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 409 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 410 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 411 | |
| 412 | stream_->OnStreamFrame(frame); |
| 413 | } |
| 414 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 415 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBody) { |
| 416 | Initialize(kShouldProcessData); |
| 417 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 418 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 419 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 420 | |
| 421 | EXPECT_EQ("", stream_->data()); |
| 422 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 423 | EXPECT_EQ(headers, stream_->header_list()); |
| 424 | stream_->ConsumeHeaderList(); |
| 425 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 426 | QuicStringPiece(data)); |
| 427 | stream_->OnStreamFrame(frame); |
| 428 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 429 | EXPECT_EQ(body, stream_->data()); |
| 430 | } |
| 431 | |
| 432 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragments) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 433 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 434 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 435 | |
| 436 | for (size_t fragment_size = 1; fragment_size < data.size(); ++fragment_size) { |
| 437 | Initialize(kShouldProcessData); |
| 438 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 439 | ASSERT_EQ(headers, stream_->header_list()); |
| 440 | stream_->ConsumeHeaderList(); |
| 441 | for (size_t offset = 0; offset < data.size(); offset += fragment_size) { |
| 442 | size_t remaining_data = data.size() - offset; |
| 443 | QuicStringPiece fragment(data.data() + offset, |
| 444 | std::min(fragment_size, remaining_data)); |
| 445 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, |
| 446 | offset, QuicStringPiece(fragment)); |
| 447 | stream_->OnStreamFrame(frame); |
| 448 | } |
| 449 | ASSERT_EQ(body, stream_->data()) << "fragment_size: " << fragment_size; |
| 450 | } |
| 451 | } |
| 452 | |
| 453 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragmentsSplit) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 454 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 455 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 456 | |
| 457 | for (size_t split_point = 1; split_point < data.size() - 1; ++split_point) { |
| 458 | Initialize(kShouldProcessData); |
| 459 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 460 | ASSERT_EQ(headers, stream_->header_list()); |
| 461 | stream_->ConsumeHeaderList(); |
| 462 | |
| 463 | QuicStringPiece fragment1(data.data(), split_point); |
| 464 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 465 | QuicStringPiece(fragment1)); |
| 466 | stream_->OnStreamFrame(frame1); |
| 467 | |
| 468 | QuicStringPiece fragment2(data.data() + split_point, |
| 469 | data.size() - split_point); |
| 470 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 471 | split_point, QuicStringPiece(fragment2)); |
| 472 | stream_->OnStreamFrame(frame2); |
| 473 | |
| 474 | ASSERT_EQ(body, stream_->data()) << "split_point: " << split_point; |
| 475 | } |
| 476 | } |
| 477 | |
| 478 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyReadv) { |
| 479 | Initialize(!kShouldProcessData); |
| 480 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 481 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 482 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 483 | |
| 484 | ProcessHeaders(false, headers_); |
| 485 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 486 | QuicStringPiece(data)); |
| 487 | stream_->OnStreamFrame(frame); |
| 488 | stream_->ConsumeHeaderList(); |
| 489 | |
| 490 | char buffer[2048]; |
| 491 | ASSERT_LT(data.length(), QUIC_ARRAYSIZE(buffer)); |
| 492 | struct iovec vec; |
| 493 | vec.iov_base = buffer; |
| 494 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 495 | |
| 496 | size_t bytes_read = stream_->Readv(&vec, 1); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 497 | QuicStreamPeer::CloseReadSide(stream_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 498 | EXPECT_EQ(body.length(), bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 499 | EXPECT_EQ(body, std::string(buffer, bytes_read)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 500 | } |
| 501 | |
| 502 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndLargeBodySmallReadv) { |
| 503 | Initialize(kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 504 | std::string body(12 * 1024, 'a'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 505 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
| 506 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 507 | ProcessHeaders(false, headers_); |
| 508 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 509 | QuicStringPiece(data)); |
| 510 | stream_->OnStreamFrame(frame); |
| 511 | stream_->ConsumeHeaderList(); |
| 512 | char buffer[2048]; |
| 513 | char buffer2[2048]; |
| 514 | struct iovec vec[2]; |
| 515 | vec[0].iov_base = buffer; |
| 516 | vec[0].iov_len = QUIC_ARRAYSIZE(buffer); |
| 517 | vec[1].iov_base = buffer2; |
| 518 | vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); |
| 519 | size_t bytes_read = stream_->Readv(vec, 2); |
| 520 | EXPECT_EQ(2048u * 2, bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 521 | EXPECT_EQ(body.substr(0, 2048), std::string(buffer, 2048)); |
| 522 | EXPECT_EQ(body.substr(2048, 2048), std::string(buffer2, 2048)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 523 | } |
| 524 | |
| 525 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyMarkConsumed) { |
| 526 | Initialize(!kShouldProcessData); |
| 527 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 528 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 529 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 530 | |
| 531 | ProcessHeaders(false, headers_); |
| 532 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 533 | QuicStringPiece(data)); |
| 534 | stream_->OnStreamFrame(frame); |
| 535 | stream_->ConsumeHeaderList(); |
| 536 | |
| 537 | struct iovec vec; |
| 538 | |
| 539 | EXPECT_EQ(1, stream_->GetReadableRegions(&vec, 1)); |
| 540 | EXPECT_EQ(body.length(), vec.iov_len); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 541 | EXPECT_EQ(body, std::string(static_cast<char*>(vec.iov_base), vec.iov_len)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 542 | |
| 543 | stream_->MarkConsumed(body.length()); |
| 544 | EXPECT_EQ(data.length(), stream_->flow_controller()->bytes_consumed()); |
| 545 | } |
| 546 | |
| 547 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndConsumeMultipleBody) { |
| 548 | Initialize(!kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 549 | std::string body1 = "this is body 1"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 550 | std::string data1 = HasFrameHeader() ? DataFrame(body1) : body1; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 551 | std::string body2 = "body 2"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 552 | std::string data2 = HasFrameHeader() ? DataFrame(body2) : body2; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 553 | |
| 554 | ProcessHeaders(false, headers_); |
| 555 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 556 | QuicStringPiece(data1)); |
| 557 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 558 | data1.length(), QuicStringPiece(data2)); |
| 559 | stream_->OnStreamFrame(frame1); |
| 560 | stream_->OnStreamFrame(frame2); |
| 561 | stream_->ConsumeHeaderList(); |
| 562 | |
| 563 | stream_->MarkConsumed(body1.length() + body2.length()); |
| 564 | EXPECT_EQ(data1.length() + data2.length(), |
| 565 | stream_->flow_controller()->bytes_consumed()); |
| 566 | } |
| 567 | |
| 568 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyIncrementalReadv) { |
| 569 | Initialize(!kShouldProcessData); |
| 570 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 571 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 572 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 573 | |
| 574 | ProcessHeaders(false, headers_); |
| 575 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 576 | QuicStringPiece(data)); |
| 577 | stream_->OnStreamFrame(frame); |
| 578 | stream_->ConsumeHeaderList(); |
| 579 | |
| 580 | char buffer[1]; |
| 581 | struct iovec vec; |
| 582 | vec.iov_base = buffer; |
| 583 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 584 | |
| 585 | for (size_t i = 0; i < body.length(); ++i) { |
| 586 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 587 | ASSERT_EQ(1u, bytes_read); |
| 588 | EXPECT_EQ(body.data()[i], buffer[0]); |
| 589 | } |
| 590 | } |
| 591 | |
| 592 | TEST_P(QuicSpdyStreamTest, ProcessHeadersUsingReadvWithMultipleIovecs) { |
| 593 | Initialize(!kShouldProcessData); |
| 594 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 595 | std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 596 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 597 | |
| 598 | ProcessHeaders(false, headers_); |
| 599 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 600 | QuicStringPiece(data)); |
| 601 | stream_->OnStreamFrame(frame); |
| 602 | stream_->ConsumeHeaderList(); |
| 603 | |
| 604 | char buffer1[1]; |
| 605 | char buffer2[1]; |
| 606 | struct iovec vec[2]; |
| 607 | vec[0].iov_base = buffer1; |
| 608 | vec[0].iov_len = QUIC_ARRAYSIZE(buffer1); |
| 609 | vec[1].iov_base = buffer2; |
| 610 | vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); |
| 611 | |
| 612 | for (size_t i = 0; i < body.length(); i += 2) { |
| 613 | size_t bytes_read = stream_->Readv(vec, 2); |
| 614 | ASSERT_EQ(2u, bytes_read) << i; |
| 615 | ASSERT_EQ(body.data()[i], buffer1[0]) << i; |
| 616 | ASSERT_EQ(body.data()[i + 1], buffer2[0]) << i; |
| 617 | } |
| 618 | } |
| 619 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 620 | // Tests that we send a BLOCKED frame to the peer when we attempt to write, but |
| 621 | // are flow control blocked. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 622 | TEST_P(QuicSpdyStreamTest, StreamFlowControlBlocked) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 623 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 624 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 625 | // enabled and fix it. |
| 626 | return; |
| 627 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 628 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 629 | testing::InSequence seq; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 630 | Initialize(kShouldProcessData); |
| 631 | |
| 632 | // Set a small flow control limit. |
| 633 | const uint64_t kWindow = 36; |
| 634 | QuicFlowControllerPeer::SetSendWindowOffset(stream_->flow_controller(), |
| 635 | kWindow); |
| 636 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::SendWindowOffset( |
| 637 | stream_->flow_controller())); |
| 638 | |
| 639 | // Try to send more data than the flow control limit allows. |
| 640 | const uint64_t kOverflow = 15; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 641 | std::string body(kWindow + kOverflow, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 642 | |
| 643 | const uint64_t kHeaderLength = HasFrameHeader() ? 2 : 0; |
| 644 | if (HasFrameHeader()) { |
| 645 | EXPECT_CALL(*session_, WritevData(_, _, kHeaderLength, _, NO_FIN)); |
| 646 | } |
| 647 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)) |
| 648 | .WillOnce(Return(QuicConsumedData(kWindow - kHeaderLength, true))); |
| 649 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 650 | stream_->WriteOrBufferBody(body, false); |
| 651 | |
| 652 | // Should have sent as much as possible, resulting in no send window left. |
| 653 | EXPECT_EQ(0u, |
| 654 | QuicFlowControllerPeer::SendWindowSize(stream_->flow_controller())); |
| 655 | |
| 656 | // And we should have queued the overflowed data. |
bnc | c7d9e0c | 2019-04-16 10:22:15 -0700 | [diff] [blame] | 657 | EXPECT_EQ(kOverflow + kHeaderLength, stream_->BufferedDataBytes()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 658 | } |
| 659 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 660 | // The flow control receive window decreases whenever we add new bytes to the |
| 661 | // sequencer, whether they are consumed immediately or buffered. However we only |
| 662 | // send WINDOW_UPDATE frames based on increasing number of bytes consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 663 | TEST_P(QuicSpdyStreamTest, StreamFlowControlNoWindowUpdateIfNotConsumed) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 664 | // Don't process data - it will be buffered instead. |
| 665 | Initialize(!kShouldProcessData); |
| 666 | |
| 667 | // Expect no WINDOW_UPDATE frames to be sent. |
| 668 | EXPECT_CALL(*connection_, SendWindowUpdate(_, _)).Times(0); |
| 669 | |
| 670 | // Set a small flow control receive window. |
| 671 | const uint64_t kWindow = 36; |
| 672 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 673 | kWindow); |
| 674 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 675 | kWindow); |
| 676 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 677 | stream_->flow_controller())); |
| 678 | |
| 679 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 680 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 681 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 682 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 683 | |
| 684 | if (HasFrameHeader()) { |
| 685 | std::unique_ptr<char[]> buffer; |
| 686 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 687 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 688 | data = header + body; |
| 689 | } else { |
| 690 | data = body; |
| 691 | } |
| 692 | |
| 693 | ProcessHeaders(false, headers_); |
| 694 | |
| 695 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 696 | QuicStringPiece(data)); |
| 697 | stream_->OnStreamFrame(frame1); |
| 698 | EXPECT_EQ( |
| 699 | kWindow - (kWindow / 3) - header_length, |
| 700 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 701 | |
| 702 | // Now receive another frame which results in the receive window being over |
| 703 | // half full. This should all be buffered, decreasing the receive window but |
| 704 | // not sending WINDOW_UPDATE. |
| 705 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 706 | kWindow / 3 + header_length, QuicStringPiece(data)); |
| 707 | stream_->OnStreamFrame(frame2); |
| 708 | EXPECT_EQ( |
| 709 | kWindow - (2 * kWindow / 3) - 2 * header_length, |
| 710 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 711 | } |
| 712 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 713 | // Tests that on receipt of data, the stream updates its receive window offset |
| 714 | // appropriately, and sends WINDOW_UPDATE frames when its receive window drops |
| 715 | // too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 716 | TEST_P(QuicSpdyStreamTest, StreamFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 717 | Initialize(kShouldProcessData); |
| 718 | |
| 719 | // Set a small flow control limit. |
| 720 | const uint64_t kWindow = 36; |
| 721 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 722 | kWindow); |
| 723 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 724 | kWindow); |
| 725 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 726 | stream_->flow_controller())); |
| 727 | |
| 728 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 729 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 730 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 731 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 732 | |
| 733 | if (HasFrameHeader()) { |
| 734 | std::unique_ptr<char[]> buffer; |
| 735 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 736 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 737 | data = header + body; |
| 738 | } else { |
| 739 | data = body; |
| 740 | } |
| 741 | |
| 742 | ProcessHeaders(false, headers_); |
| 743 | stream_->ConsumeHeaderList(); |
| 744 | |
| 745 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 746 | QuicStringPiece(data)); |
| 747 | stream_->OnStreamFrame(frame1); |
| 748 | EXPECT_EQ( |
| 749 | kWindow - (kWindow / 3) - header_length, |
| 750 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 751 | |
| 752 | // Now receive another frame which results in the receive window being over |
| 753 | // half full. This will trigger the stream to increase its receive window |
| 754 | // offset and send a WINDOW_UPDATE. The result will be again an available |
| 755 | // window of kWindow bytes. |
| 756 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 757 | kWindow / 3 + header_length, QuicStringPiece(data)); |
| 758 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 759 | stream_->OnStreamFrame(frame2); |
| 760 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowSize( |
| 761 | stream_->flow_controller())); |
| 762 | } |
| 763 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 764 | // Tests that on receipt of data, the connection updates its receive window |
| 765 | // offset appropriately, and sends WINDOW_UPDATE frames when its receive window |
| 766 | // drops too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 767 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 768 | Initialize(kShouldProcessData); |
| 769 | |
| 770 | // Set a small flow control limit for streams and connection. |
| 771 | const uint64_t kWindow = 36; |
| 772 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 773 | kWindow); |
| 774 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 775 | kWindow); |
| 776 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream2_->flow_controller(), |
| 777 | kWindow); |
| 778 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream2_->flow_controller(), |
| 779 | kWindow); |
| 780 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 781 | kWindow); |
| 782 | QuicFlowControllerPeer::SetMaxReceiveWindow(session_->flow_controller(), |
| 783 | kWindow); |
| 784 | |
| 785 | // Supply headers to both streams so that they are happy to receive data. |
| 786 | auto headers = AsHeaderList(headers_); |
| 787 | stream_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 788 | headers); |
| 789 | stream_->ConsumeHeaderList(); |
| 790 | stream2_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 791 | headers); |
| 792 | stream2_->ConsumeHeaderList(); |
| 793 | |
| 794 | // Each stream gets a quarter window of data. This should not trigger a |
| 795 | // WINDOW_UPDATE for either stream, nor for the connection. |
| 796 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 797 | std::string body; |
| 798 | std::string data; |
| 799 | std::string data2; |
| 800 | std::string body2(1, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 801 | |
| 802 | if (HasFrameHeader()) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 803 | body = std::string(kWindow / 4 - 2, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 804 | std::unique_ptr<char[]> buffer; |
| 805 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 806 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 807 | data = header + body; |
| 808 | std::unique_ptr<char[]> buffer2; |
| 809 | QuicByteCount header_length2 = |
| 810 | encoder_.SerializeDataFrameHeader(body2.length(), &buffer2); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 811 | std::string header2 = std::string(buffer2.get(), header_length2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 812 | data2 = header2 + body2; |
| 813 | } else { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 814 | body = std::string(kWindow / 4, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 815 | data = body; |
| 816 | data2 = body2; |
| 817 | } |
| 818 | |
| 819 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 820 | QuicStringPiece(data)); |
| 821 | stream_->OnStreamFrame(frame1); |
| 822 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(1), false, 0, |
| 823 | QuicStringPiece(data)); |
| 824 | stream2_->OnStreamFrame(frame2); |
| 825 | |
| 826 | // Now receive a further single byte on one stream - again this does not |
| 827 | // trigger a stream WINDOW_UPDATE, but now the connection flow control window |
| 828 | // is over half full and thus a connection WINDOW_UPDATE is sent. |
| 829 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 830 | QuicStreamFrame frame3(GetNthClientInitiatedBidirectionalId(0), false, |
| 831 | body.length() + header_length, QuicStringPiece(data2)); |
| 832 | stream_->OnStreamFrame(frame3); |
| 833 | } |
| 834 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 835 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 836 | // protocol), then we terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 837 | TEST_P(QuicSpdyStreamTest, StreamFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 838 | // Stream should not process data, so that data gets buffered in the |
| 839 | // sequencer, triggering flow control limits. |
| 840 | Initialize(!kShouldProcessData); |
| 841 | |
| 842 | // Set a small flow control limit. |
| 843 | const uint64_t kWindow = 50; |
| 844 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 845 | kWindow); |
| 846 | |
| 847 | ProcessHeaders(false, headers_); |
| 848 | |
| 849 | // Receive data to overflow the window, violating flow control. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 850 | std::string body(kWindow + 1, 'a'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 851 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 852 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 853 | QuicStringPiece(data)); |
| 854 | EXPECT_CALL(*connection_, |
| 855 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 856 | stream_->OnStreamFrame(frame); |
| 857 | } |
| 858 | |
| 859 | TEST_P(QuicSpdyStreamTest, TestHandlingQuicRstStreamNoError) { |
| 860 | Initialize(kShouldProcessData); |
| 861 | ProcessHeaders(false, headers_); |
| 862 | |
| 863 | stream_->OnStreamReset(QuicRstStreamFrame( |
| 864 | kInvalidControlFrameId, stream_->id(), QUIC_STREAM_NO_ERROR, 0)); |
| 865 | EXPECT_TRUE(stream_->write_side_closed()); |
| 866 | EXPECT_FALSE(stream_->reading_stopped()); |
| 867 | } |
| 868 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 869 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 870 | // protocol), at the connection level (rather than the stream level) then we |
| 871 | // terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 872 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 873 | // Stream should not process data, so that data gets buffered in the |
| 874 | // sequencer, triggering flow control limits. |
| 875 | Initialize(!kShouldProcessData); |
| 876 | |
| 877 | // Set a small flow control window on streams, and connection. |
| 878 | const uint64_t kStreamWindow = 50; |
| 879 | const uint64_t kConnectionWindow = 10; |
| 880 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 881 | kStreamWindow); |
| 882 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 883 | kConnectionWindow); |
| 884 | |
| 885 | ProcessHeaders(false, headers_); |
| 886 | |
| 887 | // Send enough data to overflow the connection level flow control window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 888 | std::string body(kConnectionWindow + 1, 'a'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 889 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 890 | |
| 891 | EXPECT_LT(data.size(), kStreamWindow); |
| 892 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 893 | QuicStringPiece(data)); |
| 894 | |
| 895 | EXPECT_CALL(*connection_, |
| 896 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 897 | stream_->OnStreamFrame(frame); |
| 898 | } |
| 899 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 900 | // An attempt to write a FIN with no data should not be flow control blocked, |
| 901 | // even if the send window is 0. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 902 | TEST_P(QuicSpdyStreamTest, StreamFlowControlFinNotBlocked) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 903 | Initialize(kShouldProcessData); |
| 904 | |
| 905 | // Set a flow control limit of zero. |
| 906 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), 0); |
| 907 | EXPECT_EQ(0u, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 908 | stream_->flow_controller())); |
| 909 | |
| 910 | // Send a frame with a FIN but no data. This should not be blocked. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 911 | std::string body = ""; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 912 | bool fin = true; |
| 913 | |
| 914 | EXPECT_CALL(*connection_, |
| 915 | SendBlocked(GetNthClientInitiatedBidirectionalId(0))) |
| 916 | .Times(0); |
| 917 | EXPECT_CALL(*session_, WritevData(_, _, 0, _, FIN)); |
| 918 | |
| 919 | stream_->WriteOrBufferBody(body, fin); |
| 920 | } |
| 921 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 922 | // Test that receiving trailing headers from the peer via OnStreamHeaderList() |
| 923 | // works, and can be read from the stream and consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 924 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersViaHeaderList) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 925 | Initialize(kShouldProcessData); |
| 926 | |
| 927 | // Receive initial headers. |
| 928 | size_t total_bytes = 0; |
| 929 | QuicHeaderList headers; |
| 930 | for (const auto& p : headers_) { |
| 931 | headers.OnHeader(p.first, p.second); |
| 932 | total_bytes += p.first.size() + p.second.size(); |
| 933 | } |
| 934 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 935 | stream_->OnStreamHeadersPriority( |
| 936 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 937 | stream_->OnStreamHeaderList(/*fin=*/false, total_bytes, headers); |
| 938 | stream_->ConsumeHeaderList(); |
| 939 | |
| 940 | // Receive trailing headers. |
| 941 | SpdyHeaderBlock trailers_block; |
| 942 | trailers_block["key1"] = "value1"; |
| 943 | trailers_block["key2"] = "value2"; |
| 944 | trailers_block["key3"] = "value3"; |
| 945 | SpdyHeaderBlock trailers_block_with_final_offset = trailers_block.Clone(); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 946 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 947 | // :final-offset pseudo-header is only added if trailers are sent |
| 948 | // on the headers stream. |
| 949 | trailers_block_with_final_offset[kFinalOffsetHeaderKey] = "0"; |
| 950 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 951 | total_bytes = 0; |
| 952 | QuicHeaderList trailers; |
| 953 | for (const auto& p : trailers_block_with_final_offset) { |
| 954 | trailers.OnHeader(p.first, p.second); |
| 955 | total_bytes += p.first.size() + p.second.size(); |
| 956 | } |
| 957 | stream_->OnStreamHeaderList(/*fin=*/true, total_bytes, trailers); |
| 958 | |
| 959 | // The trailers should be decompressed, and readable from the stream. |
| 960 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 961 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 962 | |
| 963 | // IsDoneReading() returns false until trailers marked consumed. |
| 964 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 965 | stream_->MarkTrailersConsumed(); |
| 966 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 967 | } |
| 968 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 969 | // Test that when receiving trailing headers with an offset before response |
| 970 | // body, stream is closed at the right offset. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 971 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 972 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 973 | // request/response stream. |
| 974 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 975 | return; |
| 976 | } |
| 977 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 978 | Initialize(kShouldProcessData); |
| 979 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 980 | // Receive initial headers. |
| 981 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 982 | stream_->ConsumeHeaderList(); |
| 983 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 984 | const std::string body = "this is the body"; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 985 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 986 | |
| 987 | // Receive trailing headers. |
| 988 | SpdyHeaderBlock trailers_block; |
| 989 | trailers_block["key1"] = "value1"; |
| 990 | trailers_block["key2"] = "value2"; |
| 991 | trailers_block["key3"] = "value3"; |
| 992 | trailers_block[kFinalOffsetHeaderKey] = |
| 993 | QuicTextUtils::Uint64ToString(data.size()); |
| 994 | |
| 995 | QuicHeaderList trailers = ProcessHeaders(true, trailers_block); |
| 996 | |
| 997 | // The trailers should be decompressed, and readable from the stream. |
| 998 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 999 | |
| 1000 | // The final offset trailer will be consumed by QUIC. |
| 1001 | trailers_block.erase(kFinalOffsetHeaderKey); |
| 1002 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1003 | |
| 1004 | // Consuming the trailers erases them from the stream. |
| 1005 | stream_->MarkTrailersConsumed(); |
| 1006 | EXPECT_TRUE(stream_->FinishedReadingTrailers()); |
| 1007 | |
| 1008 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 1009 | // Receive and consume body. |
| 1010 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/false, |
| 1011 | 0, data); |
| 1012 | stream_->OnStreamFrame(frame); |
| 1013 | EXPECT_EQ(body, stream_->data()); |
| 1014 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1015 | } |
| 1016 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1017 | // Test that receiving trailers without a final offset field is an error. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1018 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1019 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 1020 | // request/response stream. |
| 1021 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1022 | return; |
| 1023 | } |
| 1024 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1025 | Initialize(kShouldProcessData); |
| 1026 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1027 | // Receive initial headers. |
| 1028 | ProcessHeaders(false, headers_); |
| 1029 | stream_->ConsumeHeaderList(); |
| 1030 | |
| 1031 | // Receive trailing headers, without kFinalOffsetHeaderKey. |
| 1032 | SpdyHeaderBlock trailers_block; |
| 1033 | trailers_block["key1"] = "value1"; |
| 1034 | trailers_block["key2"] = "value2"; |
| 1035 | trailers_block["key3"] = "value3"; |
| 1036 | auto trailers = AsHeaderList(trailers_block); |
| 1037 | |
| 1038 | // Verify that the trailers block didn't contain a final offset. |
| 1039 | EXPECT_EQ("", trailers_block[kFinalOffsetHeaderKey].as_string()); |
| 1040 | |
| 1041 | // Receipt of the malformed trailers will close the connection. |
| 1042 | EXPECT_CALL(*connection_, |
| 1043 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1044 | .Times(1); |
| 1045 | stream_->OnStreamHeaderList(/*fin=*/true, |
| 1046 | trailers.uncompressed_header_bytes(), trailers); |
| 1047 | } |
| 1048 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1049 | // Test that received Trailers must always have the FIN set. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1050 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1051 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
| 1052 | // HEADERS frame. |
| 1053 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1054 | return; |
| 1055 | } |
| 1056 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1057 | Initialize(kShouldProcessData); |
| 1058 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1059 | // Receive initial headers. |
| 1060 | auto headers = AsHeaderList(headers_); |
| 1061 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1062 | headers.uncompressed_header_bytes(), headers); |
| 1063 | stream_->ConsumeHeaderList(); |
| 1064 | |
| 1065 | // Receive trailing headers with FIN deliberately set to false. |
| 1066 | SpdyHeaderBlock trailers_block; |
| 1067 | trailers_block["foo"] = "bar"; |
| 1068 | auto trailers = AsHeaderList(trailers_block); |
| 1069 | |
| 1070 | EXPECT_CALL(*connection_, |
| 1071 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1072 | .Times(1); |
| 1073 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1074 | trailers.uncompressed_header_bytes(), trailers); |
| 1075 | } |
| 1076 | |
| 1077 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterHeadersWithFin) { |
| 1078 | // If headers are received with a FIN, no trailers should then arrive. |
| 1079 | Initialize(kShouldProcessData); |
| 1080 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1081 | // If HEADERS frames are sent on the request/response stream, then the |
| 1082 | // sequencer will signal an error if any stream data arrives after a FIN, |
| 1083 | // so QuicSpdyStream does not need to. |
| 1084 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1085 | return; |
| 1086 | } |
| 1087 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1088 | // Receive initial headers with FIN set. |
| 1089 | ProcessHeaders(true, headers_); |
| 1090 | stream_->ConsumeHeaderList(); |
| 1091 | |
| 1092 | // Receive trailing headers after FIN already received. |
| 1093 | SpdyHeaderBlock trailers_block; |
| 1094 | trailers_block["foo"] = "bar"; |
| 1095 | EXPECT_CALL(*connection_, |
| 1096 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1097 | .Times(1); |
| 1098 | ProcessHeaders(true, trailers_block); |
| 1099 | } |
| 1100 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1101 | // If body data are received with a FIN, no trailers should then arrive. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1102 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterBodyWithFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1103 | // If HEADERS frames are sent on the request/response stream, |
| 1104 | // then the sequencer will block them from reaching QuicSpdyStream |
| 1105 | // after the stream is closed. |
| 1106 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1107 | return; |
| 1108 | } |
| 1109 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1110 | Initialize(kShouldProcessData); |
| 1111 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1112 | // Receive initial headers without FIN set. |
| 1113 | ProcessHeaders(false, headers_); |
| 1114 | stream_->ConsumeHeaderList(); |
| 1115 | |
| 1116 | // Receive body data, with FIN. |
| 1117 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1118 | 0, "body"); |
| 1119 | stream_->OnStreamFrame(frame); |
| 1120 | |
| 1121 | // Receive trailing headers after FIN already received. |
| 1122 | SpdyHeaderBlock trailers_block; |
| 1123 | trailers_block["foo"] = "bar"; |
| 1124 | EXPECT_CALL(*connection_, |
| 1125 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1126 | .Times(1); |
| 1127 | ProcessHeaders(true, trailers_block); |
| 1128 | } |
| 1129 | |
| 1130 | TEST_P(QuicSpdyStreamTest, ClosingStreamWithNoTrailers) { |
| 1131 | // Verify that a stream receiving headers, body, and no trailers is correctly |
| 1132 | // marked as done reading on consumption of headers and body. |
| 1133 | Initialize(kShouldProcessData); |
| 1134 | |
| 1135 | // Receive and consume initial headers with FIN not set. |
| 1136 | auto h = AsHeaderList(headers_); |
| 1137 | stream_->OnStreamHeaderList(/*fin=*/false, h.uncompressed_header_bytes(), h); |
| 1138 | stream_->ConsumeHeaderList(); |
| 1139 | |
| 1140 | // Receive and consume body with FIN set, and no trailers. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1141 | std::string body(1024, 'x'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1142 | std::string data = HasFrameHeader() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1143 | |
| 1144 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1145 | 0, data); |
| 1146 | stream_->OnStreamFrame(frame); |
| 1147 | |
| 1148 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1149 | } |
| 1150 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1151 | // Test that writing trailers will send a FIN, as Trailers are the last thing to |
| 1152 | // be sent on a stream. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1153 | TEST_P(QuicSpdyStreamTest, WritingTrailersSendsAFin) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1154 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1155 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1156 | // enabled and fix it. |
| 1157 | return; |
| 1158 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1159 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1160 | Initialize(kShouldProcessData); |
| 1161 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1162 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1163 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1164 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1165 | .Times(AtLeast(1)); |
| 1166 | } |
| 1167 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1168 | // Write the initial headers, without a FIN. |
| 1169 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1170 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1171 | |
| 1172 | // Writing trailers implicitly sends a FIN. |
| 1173 | SpdyHeaderBlock trailers; |
| 1174 | trailers["trailer key"] = "trailer value"; |
| 1175 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1176 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1177 | EXPECT_TRUE(stream_->fin_sent()); |
| 1178 | } |
| 1179 | |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1180 | TEST_P(QuicSpdyStreamTest, ClientWritesPriority) { |
| 1181 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1182 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1183 | // enabled and fix it. |
| 1184 | return; |
| 1185 | } |
| 1186 | |
| 1187 | InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT); |
| 1188 | |
| 1189 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1190 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1191 | // Six writes include priority for headers, headers frame header, headers |
| 1192 | // frame, priority of trailers, trailing headers frame header, and trailers. |
| 1193 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1194 | .Times(4); |
| 1195 | auto send_control_stream = |
| 1196 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
| 1197 | // The control stream will write 3 times, including stream type, settings |
| 1198 | // frame, priority for headers. |
| 1199 | EXPECT_CALL(*session_, WritevData(send_control_stream, |
| 1200 | send_control_stream->id(), _, _, _)) |
| 1201 | .Times(3); |
| 1202 | } |
| 1203 | |
| 1204 | // Write the initial headers, without a FIN. |
| 1205 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1206 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1207 | |
| 1208 | // Writing trailers implicitly sends a FIN. |
| 1209 | SpdyHeaderBlock trailers; |
| 1210 | trailers["trailer key"] = "trailer value"; |
| 1211 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1212 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1213 | EXPECT_TRUE(stream_->fin_sent()); |
| 1214 | } |
| 1215 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1216 | // Test that when writing trailers, the trailers that are actually sent to the |
| 1217 | // peer contain the final offset field indicating last byte of data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1218 | TEST_P(QuicSpdyStreamTest, WritingTrailersFinalOffset) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1219 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1220 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1221 | // enabled and fix it. |
| 1222 | return; |
| 1223 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1224 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1225 | Initialize(kShouldProcessData); |
| 1226 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1227 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1228 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1229 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1230 | .Times(AtLeast(1)); |
| 1231 | } |
| 1232 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1233 | // Write the initial headers. |
| 1234 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1235 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1236 | |
| 1237 | // Write non-zero body data to force a non-zero final offset. |
| 1238 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1239 | std::string body(1024, 'x'); // 1 kB |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1240 | QuicByteCount header_length = 0; |
| 1241 | if (HasFrameHeader()) { |
| 1242 | std::unique_ptr<char[]> buf; |
| 1243 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buf); |
| 1244 | } |
| 1245 | |
| 1246 | stream_->WriteOrBufferBody(body, false); |
| 1247 | |
| 1248 | // The final offset field in the trailing headers is populated with the |
| 1249 | // number of body bytes written (including queued bytes). |
| 1250 | SpdyHeaderBlock trailers; |
| 1251 | trailers["trailer key"] = "trailer value"; |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1252 | |
| 1253 | SpdyHeaderBlock expected_trailers(trailers.Clone()); |
| 1254 | // :final-offset pseudo-header is only added if trailers are sent |
| 1255 | // on the headers stream. |
| 1256 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1257 | expected_trailers[kFinalOffsetHeaderKey] = |
| 1258 | QuicTextUtils::Uint64ToString(body.length() + header_length); |
| 1259 | } |
| 1260 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1261 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1262 | stream_->WriteTrailers(std::move(trailers), nullptr); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1263 | EXPECT_EQ(expected_trailers, stream_->saved_headers()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1264 | } |
| 1265 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1266 | // Test that if trailers are written after all other data has been written |
| 1267 | // (headers and body), that this closes the stream for writing. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1268 | TEST_P(QuicSpdyStreamTest, WritingTrailersClosesWriteSide) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1269 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1270 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1271 | // enabled and fix it. |
| 1272 | return; |
| 1273 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1274 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1275 | Initialize(kShouldProcessData); |
| 1276 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1277 | // Expect data being written on the stream. In addition to that, headers are |
| 1278 | // also written on the stream in case of IETF QUIC. |
| 1279 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1280 | .Times(AtLeast(1)); |
| 1281 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1282 | // Write the initial headers. |
| 1283 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1284 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1285 | |
| 1286 | // Write non-zero body data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1287 | const int kBodySize = 1 * 1024; // 1 kB |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1288 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1289 | EXPECT_EQ(0u, stream_->BufferedDataBytes()); |
| 1290 | |
| 1291 | // Headers and body have been fully written, there is no queued data. Writing |
| 1292 | // trailers marks the end of this stream, and thus the write side is closed. |
| 1293 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1294 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1295 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1296 | } |
| 1297 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1298 | // Test that the stream is not closed for writing when trailers are sent while |
| 1299 | // there are still body bytes queued. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1300 | TEST_P(QuicSpdyStreamTest, WritingTrailersWithQueuedBytes) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1301 | // This test exercises sending trailers on the headers stream while data is |
| 1302 | // still queued on the response/request stream. In IETF QUIC, data and |
| 1303 | // trailers are sent on the same stream, so this test does not apply. |
| 1304 | if (VersionUsesQpack(GetParam().transport_version)) { |
| 1305 | return; |
| 1306 | } |
| 1307 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1308 | testing::InSequence seq; |
| 1309 | Initialize(kShouldProcessData); |
| 1310 | |
| 1311 | // Write the initial headers. |
| 1312 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1313 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1314 | |
| 1315 | // Write non-zero body data, but only consume partially, ensuring queueing. |
| 1316 | const int kBodySize = 1 * 1024; // 1 kB |
| 1317 | if (HasFrameHeader()) { |
| 1318 | EXPECT_CALL(*session_, WritevData(_, _, 3, _, NO_FIN)); |
| 1319 | } |
| 1320 | EXPECT_CALL(*session_, WritevData(_, _, kBodySize, _, NO_FIN)) |
| 1321 | .WillOnce(Return(QuicConsumedData(kBodySize - 1, false))); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1322 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1323 | EXPECT_EQ(1u, stream_->BufferedDataBytes()); |
| 1324 | |
| 1325 | // Writing trailers will send a FIN, but not close the write side of the |
| 1326 | // stream as there are queued bytes. |
| 1327 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1328 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1329 | EXPECT_TRUE(stream_->fin_sent()); |
| 1330 | EXPECT_FALSE(stream_->write_side_closed()); |
| 1331 | |
| 1332 | // Writing the queued bytes will close the write side of the stream. |
| 1333 | EXPECT_CALL(*session_, WritevData(_, _, 1, _, NO_FIN)); |
| 1334 | stream_->OnCanWrite(); |
| 1335 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1336 | } |
| 1337 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1338 | // Test that it is not possible to write Trailers after a FIN has been sent. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1339 | TEST_P(QuicSpdyStreamTest, WritingTrailersAfterFIN) { |
| 1340 | // EXPECT_QUIC_BUG tests are expensive so only run one instance of them. |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1341 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
| 1342 | // HEADERS frame. That is version 99, which is element 0 of the array, so |
| 1343 | // pick another element. |
| 1344 | if (GetParam() != AllSupportedVersions()[1]) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1345 | return; |
| 1346 | } |
| 1347 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1348 | Initialize(kShouldProcessData); |
| 1349 | |
| 1350 | // Write the initial headers, with a FIN. |
| 1351 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1352 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/true, nullptr); |
| 1353 | EXPECT_TRUE(stream_->fin_sent()); |
| 1354 | |
| 1355 | // Writing Trailers should fail, as the FIN has already been sent. |
| 1356 | // populated with the number of body bytes written. |
| 1357 | EXPECT_QUIC_BUG(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr), |
| 1358 | "Trailers cannot be sent after a FIN"); |
| 1359 | } |
| 1360 | |
| 1361 | TEST_P(QuicSpdyStreamTest, HeaderStreamNotiferCorrespondingSpdyStream) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1362 | // There is no headers stream if QPACK is used. |
| 1363 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1364 | return; |
| 1365 | } |
| 1366 | |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1367 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1368 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1369 | // enabled and fix it. |
| 1370 | return; |
| 1371 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1372 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1373 | const char kHeader1[] = "Header1"; |
| 1374 | const char kHeader2[] = "Header2"; |
| 1375 | const char kBody1[] = "Test1"; |
| 1376 | const char kBody2[] = "Test2"; |
| 1377 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1378 | Initialize(kShouldProcessData); |
| 1379 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1380 | testing::InSequence s; |
| 1381 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 1382 | new MockAckListener()); |
| 1383 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 1384 | new MockAckListener()); |
| 1385 | stream_->set_ack_listener(ack_listener1); |
| 1386 | stream2_->set_ack_listener(ack_listener2); |
| 1387 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1388 | session_->headers_stream()->WriteOrBufferData(kHeader1, false, ack_listener1); |
| 1389 | stream_->WriteOrBufferBody(kBody1, true); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1390 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1391 | session_->headers_stream()->WriteOrBufferData(kHeader2, false, ack_listener2); |
| 1392 | stream2_->WriteOrBufferBody(kBody2, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1393 | |
| 1394 | QuicStreamFrame frame1( |
| 1395 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 0, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1396 | kHeader1); |
| 1397 | |
| 1398 | std::string data1 = HasFrameHeader() ? DataFrame(kBody1) : kBody1; |
| 1399 | QuicStreamFrame frame2(stream_->id(), true, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1400 | QuicStreamFrame frame3( |
| 1401 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 7, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1402 | kHeader2); |
| 1403 | std::string data2 = HasFrameHeader() ? DataFrame(kBody2) : kBody2; |
| 1404 | QuicStreamFrame frame4(stream2_->id(), false, 0, data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1405 | |
| 1406 | EXPECT_CALL(*ack_listener1, OnPacketRetransmitted(7)); |
| 1407 | session_->OnStreamFrameRetransmitted(frame1); |
| 1408 | |
| 1409 | EXPECT_CALL(*ack_listener1, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1410 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame1), QuicTime::Delta::Zero(), |
| 1411 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1412 | EXPECT_CALL(*ack_listener1, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1413 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1414 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1415 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1416 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1417 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1418 | EXPECT_CALL(*ack_listener2, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1419 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame4), QuicTime::Delta::Zero(), |
| 1420 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1421 | } |
| 1422 | |
| 1423 | TEST_P(QuicSpdyStreamTest, StreamBecomesZombieWithWriteThatCloses) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1424 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1425 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1426 | // enabled and fix it. |
| 1427 | return; |
| 1428 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1429 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1430 | Initialize(kShouldProcessData); |
| 1431 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1432 | QuicStreamPeer::CloseReadSide(stream_); |
| 1433 | // This write causes stream to be closed. |
| 1434 | stream_->WriteOrBufferBody("Test1", true); |
| 1435 | // stream_ has unacked data and should become zombie. |
| 1436 | EXPECT_TRUE(QuicContainsKey(QuicSessionPeer::zombie_streams(session_.get()), |
| 1437 | stream_->id())); |
| 1438 | EXPECT_TRUE(QuicSessionPeer::closed_streams(session_.get()).empty()); |
| 1439 | } |
| 1440 | |
| 1441 | TEST_P(QuicSpdyStreamTest, OnPriorityFrame) { |
| 1442 | Initialize(kShouldProcessData); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 1443 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1444 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1445 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1446 | } |
| 1447 | |
| 1448 | TEST_P(QuicSpdyStreamTest, OnPriorityFrameAfterSendingData) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1449 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1450 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1451 | // enabled and fix it. |
| 1452 | return; |
| 1453 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1454 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1455 | testing::InSequence seq; |
| 1456 | Initialize(kShouldProcessData); |
| 1457 | |
| 1458 | if (HasFrameHeader()) { |
| 1459 | EXPECT_CALL(*session_, WritevData(_, _, 2, _, NO_FIN)); |
| 1460 | } |
| 1461 | EXPECT_CALL(*session_, WritevData(_, _, 4, _, FIN)); |
| 1462 | stream_->WriteOrBufferBody("data", true); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 1463 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1464 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1465 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1466 | } |
| 1467 | |
| 1468 | TEST_P(QuicSpdyStreamTest, SetPriorityBeforeUpdateStreamPriority) { |
| 1469 | MockQuicConnection* connection = new StrictMock<MockQuicConnection>( |
| 1470 | &helper_, &alarm_factory_, Perspective::IS_SERVER, |
| 1471 | SupportedVersions(GetParam())); |
| 1472 | std::unique_ptr<TestMockUpdateStreamSession> session( |
| 1473 | new StrictMock<TestMockUpdateStreamSession>(connection)); |
| 1474 | auto stream = new StrictMock<TestStream>( |
| 1475 | GetNthClientInitiatedBidirectionalStreamId( |
| 1476 | session->connection()->transport_version(), 0), |
| 1477 | session.get(), |
| 1478 | /*should_process_data=*/true); |
| 1479 | session->ActivateStream(QuicWrapUnique(stream)); |
| 1480 | |
| 1481 | // QuicSpdyStream::SetPriority() should eventually call UpdateStreamPriority() |
| 1482 | // on the session. Make sure stream->priority() returns the updated priority |
| 1483 | // if called within UpdateStreamPriority(). This expectation is enforced in |
| 1484 | // TestMockUpdateStreamSession::UpdateStreamPriority(). |
| 1485 | session->SetExpectedStream(stream); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 1486 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1487 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1488 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 1489 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
| 1490 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1491 | } |
| 1492 | |
| 1493 | TEST_P(QuicSpdyStreamTest, StreamWaitsForAcks) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1494 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1495 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1496 | // enabled and fix it. |
| 1497 | return; |
| 1498 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1499 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1500 | Initialize(kShouldProcessData); |
| 1501 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1502 | new StrictMock<MockAckListener>); |
| 1503 | stream_->set_ack_listener(mock_ack_listener); |
| 1504 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1505 | // Stream is not waiting for acks initially. |
| 1506 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1507 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1508 | |
| 1509 | // Send kData1. |
| 1510 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1511 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1512 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1513 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1514 | QuicByteCount newly_acked_length = 0; |
| 1515 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
| 1516 | &newly_acked_length)); |
| 1517 | // Stream is not waiting for acks as all sent data is acked. |
| 1518 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1519 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1520 | |
| 1521 | // Send kData2. |
| 1522 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1523 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1524 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1525 | // Send FIN. |
| 1526 | stream_->WriteOrBufferData("", true, nullptr); |
| 1527 | // Fin only frame is not stored in send buffer. |
| 1528 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1529 | |
| 1530 | // kData2 is retransmitted. |
| 1531 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(9)); |
| 1532 | stream_->OnStreamFrameRetransmitted(9, 9, false); |
| 1533 | |
| 1534 | // kData2 is acked. |
| 1535 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1536 | EXPECT_TRUE(stream_->OnStreamFrameAcked(9, 9, false, QuicTime::Delta::Zero(), |
| 1537 | &newly_acked_length)); |
| 1538 | // Stream is waiting for acks as FIN is not acked. |
| 1539 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1540 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1541 | |
| 1542 | // FIN is acked. |
| 1543 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1544 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 0, true, QuicTime::Delta::Zero(), |
| 1545 | &newly_acked_length)); |
| 1546 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1547 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1548 | } |
| 1549 | |
| 1550 | TEST_P(QuicSpdyStreamTest, StreamDataGetAckedMultipleTimes) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1551 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1552 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1553 | // enabled and fix it. |
| 1554 | return; |
| 1555 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1556 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1557 | Initialize(kShouldProcessData); |
| 1558 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1559 | new StrictMock<MockAckListener>); |
| 1560 | stream_->set_ack_listener(mock_ack_listener); |
| 1561 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1562 | // Send [0, 27) and fin. |
| 1563 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1564 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1565 | stream_->WriteOrBufferData("FooAndBar", true, nullptr); |
| 1566 | |
| 1567 | // Ack [0, 9), [5, 22) and [18, 26) |
| 1568 | // Verify [0, 9) 9 bytes are acked. |
| 1569 | QuicByteCount newly_acked_length = 0; |
| 1570 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1571 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
| 1572 | &newly_acked_length)); |
| 1573 | EXPECT_EQ(2u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1574 | // Verify [9, 22) 13 bytes are acked. |
| 1575 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(13, _)); |
| 1576 | EXPECT_TRUE(stream_->OnStreamFrameAcked(5, 17, false, QuicTime::Delta::Zero(), |
| 1577 | &newly_acked_length)); |
| 1578 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1579 | // Verify [22, 26) 4 bytes are acked. |
| 1580 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(4, _)); |
| 1581 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 8, false, QuicTime::Delta::Zero(), |
| 1582 | &newly_acked_length)); |
| 1583 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1584 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1585 | |
| 1586 | // Ack [0, 27). |
| 1587 | // Verify [26, 27) 1 byte is acked. |
| 1588 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(1, _)); |
| 1589 | EXPECT_TRUE(stream_->OnStreamFrameAcked(26, 1, false, QuicTime::Delta::Zero(), |
| 1590 | &newly_acked_length)); |
| 1591 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1592 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1593 | |
| 1594 | // Ack Fin. Verify OnPacketAcked is called. |
| 1595 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1596 | EXPECT_TRUE(stream_->OnStreamFrameAcked(27, 0, true, QuicTime::Delta::Zero(), |
| 1597 | &newly_acked_length)); |
| 1598 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1599 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1600 | |
| 1601 | // Ack [10, 27) and fin. |
| 1602 | // No new data is acked, verify OnPacketAcked is not called. |
| 1603 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(_, _)).Times(0); |
| 1604 | EXPECT_FALSE(stream_->OnStreamFrameAcked( |
| 1605 | 10, 17, true, QuicTime::Delta::Zero(), &newly_acked_length)); |
| 1606 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1607 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1608 | } |
| 1609 | |
| 1610 | // HTTP/3 only. |
| 1611 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteOrBufferBody) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1612 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1613 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1614 | // enabled and fix it. |
| 1615 | return; |
| 1616 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1617 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1618 | if (!HasFrameHeader()) { |
| 1619 | return; |
| 1620 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1621 | |
| 1622 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1623 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1624 | new StrictMock<MockAckListener>); |
| 1625 | stream_->set_ack_listener(mock_ack_listener); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1626 | std::string body = "Test1"; |
| 1627 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1628 | |
| 1629 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1630 | stream_->WriteOrBufferBody(body, false); |
| 1631 | stream_->WriteOrBufferBody(body2, true); |
| 1632 | |
| 1633 | std::unique_ptr<char[]> buffer; |
| 1634 | QuicByteCount header_length = |
| 1635 | encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1636 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1637 | |
| 1638 | header_length = encoder_.SerializeDataFrameHeader(body2.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1639 | std::string header2 = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1640 | |
| 1641 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body.length(), _)); |
| 1642 | QuicStreamFrame frame(stream_->id(), false, 0, header + body); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1643 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1644 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1645 | |
| 1646 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1647 | QuicStreamFrame frame2(stream_->id(), false, header.length() + body.length(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1648 | header2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1649 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1650 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1651 | |
| 1652 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body2.length(), _)); |
| 1653 | QuicStreamFrame frame3(stream_->id(), true, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1654 | header.length() + body.length() + header2.length(), |
| 1655 | body2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1656 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1657 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1658 | |
| 1659 | EXPECT_TRUE( |
| 1660 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1661 | } |
| 1662 | |
| 1663 | // HTTP/3 only. |
| 1664 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteBodySlices) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1665 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1666 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1667 | // enabled and fix it. |
| 1668 | return; |
| 1669 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1670 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1671 | if (!HasFrameHeader()) { |
| 1672 | return; |
| 1673 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1674 | |
| 1675 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1676 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1677 | new StrictMock<MockAckListener>); |
| 1678 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1679 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1680 | std::string body2(100, 'x'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1681 | struct iovec body1_iov = {const_cast<char*>(body1.data()), body1.length()}; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1682 | struct iovec body2_iov = {const_cast<char*>(body2.data()), body2.length()}; |
| 1683 | QuicMemSliceStorage storage(&body1_iov, 1, |
| 1684 | helper_.GetStreamSendBufferAllocator(), 1024); |
| 1685 | QuicMemSliceStorage storage2(&body2_iov, 1, |
| 1686 | helper_.GetStreamSendBufferAllocator(), 1024); |
| 1687 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1688 | stream_->WriteBodySlices(storage.ToSpan(), false); |
| 1689 | stream_->WriteBodySlices(storage2.ToSpan(), true); |
| 1690 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1691 | std::string data1 = DataFrame(body1); |
| 1692 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1693 | |
| 1694 | EXPECT_CALL(*mock_ack_listener, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1695 | OnPacketAcked(body1.length() + body2.length(), _)); |
| 1696 | QuicStreamFrame frame(stream_->id(), true, 0, data1 + data2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1697 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1698 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1699 | |
| 1700 | EXPECT_TRUE( |
| 1701 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1702 | } |
| 1703 | |
| 1704 | // HTTP/3 only. |
| 1705 | TEST_P(QuicSpdyStreamTest, HeaderBytesNotReportedOnRetransmission) { |
nharper | f5e6845 | 2019-05-29 17:24:18 -0700 | [diff] [blame] | 1706 | if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) { |
| 1707 | // TODO(nharper, b/112643533): Figure out why this test fails when TLS is |
| 1708 | // enabled and fix it. |
| 1709 | return; |
| 1710 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1711 | if (!HasFrameHeader()) { |
| 1712 | return; |
| 1713 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1714 | |
| 1715 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1716 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1717 | new StrictMock<MockAckListener>); |
| 1718 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1719 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1720 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1721 | |
| 1722 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1723 | stream_->WriteOrBufferBody(body1, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1724 | stream_->WriteOrBufferBody(body2, true); |
| 1725 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1726 | std::string data1 = DataFrame(body1); |
| 1727 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1728 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1729 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body1.length())); |
| 1730 | QuicStreamFrame frame(stream_->id(), false, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1731 | session_->OnStreamFrameRetransmitted(frame); |
| 1732 | |
| 1733 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body2.length())); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1734 | QuicStreamFrame frame2(stream_->id(), true, data1.length(), data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1735 | session_->OnStreamFrameRetransmitted(frame2); |
| 1736 | |
| 1737 | EXPECT_FALSE( |
| 1738 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1739 | } |
| 1740 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1741 | TEST_P(QuicSpdyStreamTest, HeadersFrameOnRequestStream) { |
| 1742 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1743 | return; |
| 1744 | } |
| 1745 | |
| 1746 | Initialize(kShouldProcessData); |
| 1747 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1748 | // HEADERS frame with QPACK encoded single header field "foo: bar". |
| 1749 | std::string headers = |
| 1750 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
| 1751 | std::string data = DataFrame(kDataFramePayload); |
| 1752 | // HEADERS frame with QPACK encoded single header |
| 1753 | // field "custom-key: custom-value". |
| 1754 | std::string trailers = HeadersFrame( |
| 1755 | QuicTextUtils::HexDecode("00002f0125a849e95ba97d7f8925a849e95bb8e8b4bf")); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1756 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1757 | std::string stream_frame_payload = QuicStrCat(headers, data, trailers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1758 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1759 | stream_->OnStreamFrame(frame); |
| 1760 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1761 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1762 | |
| 1763 | // QuicSpdyStream only calls OnBodyAvailable() |
| 1764 | // after the header list has been consumed. |
| 1765 | EXPECT_EQ("", stream_->data()); |
| 1766 | stream_->ConsumeHeaderList(); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1767 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1768 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1769 | EXPECT_THAT(stream_->received_trailers(), |
| 1770 | ElementsAre(Pair("custom-key", "custom-value"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1771 | } |
| 1772 | |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1773 | TEST_P(QuicSpdyStreamTest, ProcessBodyAfterTrailers) { |
| 1774 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1775 | return; |
| 1776 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1777 | |
| 1778 | Initialize(!kShouldProcessData); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1779 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1780 | // HEADERS frame with QPACK encoded single header field "foo: bar". |
| 1781 | std::string headers = |
| 1782 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1783 | |
| 1784 | // DATA frame. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1785 | std::string data = DataFrame(kDataFramePayload); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1786 | |
| 1787 | // A header block that will take more than one block of sequencer buffer. |
| 1788 | // This ensures that when the trailers are consumed, some buffer buckets will |
| 1789 | // be freed. |
| 1790 | SpdyHeaderBlock trailers_block; |
| 1791 | trailers_block["key1"] = std::string(10000, 'x'); |
| 1792 | std::string trailers_frame_payload = |
| 1793 | EncodeQpackHeaders(stream_->id(), &trailers_block); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1794 | std::string trailers = HeadersFrame(trailers_frame_payload); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1795 | |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1796 | // Feed all three HTTP/3 frames in a single stream frame. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1797 | std::string stream_frame_payload = QuicStrCat(headers, data, trailers); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1798 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1799 | stream_->OnStreamFrame(frame); |
| 1800 | |
| 1801 | stream_->ConsumeHeaderList(); |
| 1802 | stream_->MarkTrailersConsumed(); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1803 | |
| 1804 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1805 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1806 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 1807 | EXPECT_TRUE(stream_->HasBytesToRead()); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1808 | |
| 1809 | // Consume data. |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1810 | char buffer[2048]; |
| 1811 | struct iovec vec; |
| 1812 | vec.iov_base = buffer; |
| 1813 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 1814 | size_t bytes_read = stream_->Readv(&vec, 1); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1815 | EXPECT_EQ(kDataFramePayload, QuicStringPiece(buffer, bytes_read)); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1816 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 1817 | EXPECT_FALSE(stream_->HasBytesToRead()); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1818 | } |
| 1819 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1820 | // The test stream will receive a stream frame containing malformed headers and |
| 1821 | // normal body. Make sure the http decoder stops processing body after the |
| 1822 | // connection shuts down. |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1823 | TEST_P(QuicSpdyStreamTest, MalformedHeadersStopHttpDecoder) { |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1824 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1825 | return; |
| 1826 | } |
| 1827 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1828 | testing::InSequence s; |
| 1829 | |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1830 | Initialize(kShouldProcessData); |
| 1831 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 1832 | |
| 1833 | // Random bad headers. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1834 | std::string headers = |
| 1835 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e7036261")); |
| 1836 | std::string data = DataFrame(kDataFramePayload); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1837 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1838 | std::string stream_frame_payload = QuicStrCat(headers, data); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1839 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1840 | |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 1841 | EXPECT_CALL( |
| 1842 | *connection_, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1843 | CloseConnection( |
| 1844 | QUIC_DECOMPRESSION_FAILURE, |
| 1845 | MatchesRegex("Error decompressing header block on stream \\d+: " |
| 1846 | "Incomplete header block."), |
| 1847 | _)) |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1848 | .WillOnce( |
| 1849 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 1850 | ConnectionCloseBehavior connection_close_behavior) { |
| 1851 | connection_->ReallyCloseConnection(error, error_details, |
| 1852 | connection_close_behavior); |
| 1853 | }))); |
| 1854 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 1855 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 1856 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 1857 | ConnectionCloseSource source) { |
| 1858 | session_->ReallyOnConnectionClosed(frame, source); |
| 1859 | })); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1860 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 1861 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 1862 | stream_->OnStreamFrame(frame); |
| 1863 | } |
| 1864 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1865 | TEST_P(QuicSpdyStreamTest, ImmediateHeaderDecodingWithDynamicTableEntries) { |
| 1866 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1867 | return; |
| 1868 | } |
| 1869 | |
| 1870 | Initialize(kShouldProcessData); |
| 1871 | |
| 1872 | // Deliver dynamic table entry to decoder. |
| 1873 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 1874 | |
| 1875 | // HEADERS frame referencing first dynamic table entry. |
| 1876 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
| 1877 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1878 | |
| 1879 | // Headers can be decoded immediately. |
| 1880 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 1881 | |
| 1882 | // Verify headers. |
| 1883 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 1884 | stream_->ConsumeHeaderList(); |
| 1885 | |
| 1886 | // DATA frame. |
| 1887 | std::string data = DataFrame(kDataFramePayload); |
| 1888 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 1889 | headers.length(), data)); |
| 1890 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 1891 | |
| 1892 | // Deliver second dynamic table entry to decoder. |
| 1893 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
| 1894 | |
| 1895 | // Trailing HEADERS frame referencing second dynamic table entry. |
| 1896 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030080")); |
| 1897 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 1898 | headers.length() + data.length(), |
| 1899 | trailers)); |
| 1900 | |
| 1901 | // Trailers can be decoded immediately. |
| 1902 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1903 | |
| 1904 | // Verify trailers. |
| 1905 | EXPECT_THAT(stream_->received_trailers(), |
| 1906 | ElementsAre(Pair("trailing", "foobar"))); |
| 1907 | stream_->MarkTrailersConsumed(); |
| 1908 | } |
| 1909 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1910 | TEST_P(QuicSpdyStreamTest, BlockedHeaderDecoding) { |
| 1911 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1912 | return; |
| 1913 | } |
| 1914 | |
| 1915 | Initialize(kShouldProcessData); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1916 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1917 | // HEADERS frame referencing first dynamic table entry. |
| 1918 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1919 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1920 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1921 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1922 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 1923 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1924 | // Deliver dynamic table entry to decoder. |
| 1925 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1926 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 1927 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1928 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1929 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 1930 | stream_->ConsumeHeaderList(); |
| 1931 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1932 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1933 | std::string data = DataFrame(kDataFramePayload); |
| 1934 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 1935 | headers.length(), data)); |
| 1936 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 1937 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1938 | // Trailing HEADERS frame referencing second dynamic table entry. |
| 1939 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1940 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 1941 | headers.length() + data.length(), |
| 1942 | trailers)); |
| 1943 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1944 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1945 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 1946 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1947 | // Deliver second dynamic table entry to decoder. |
| 1948 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1949 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1950 | |
| 1951 | // Verify trailers. |
| 1952 | EXPECT_THAT(stream_->received_trailers(), |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1953 | ElementsAre(Pair("trailing", "foobar"))); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1954 | stream_->MarkTrailersConsumed(); |
| 1955 | } |
| 1956 | |
| 1957 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingHeaders) { |
| 1958 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1959 | return; |
| 1960 | } |
| 1961 | |
| 1962 | Initialize(kShouldProcessData); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1963 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1964 | // HEADERS frame only referencing entry with absolute index 0 but with |
| 1965 | // Required Insert Count = 2, which is incorrect. |
| 1966 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1967 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1968 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1969 | // Even though entire header block is received and every referenced entry is |
| 1970 | // available, decoding is blocked until insert count reaches the Required |
| 1971 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1972 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 1973 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1974 | EXPECT_CALL( |
| 1975 | *connection_, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1976 | CloseConnection( |
| 1977 | QUIC_DECOMPRESSION_FAILURE, |
| 1978 | MatchesRegex("Error during async decoding of headers on stream \\d+: " |
| 1979 | "Required Insert Count too large."), |
| 1980 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
| 1981 | |
| 1982 | // Deliver two dynamic table entries to decoder |
| 1983 | // to trigger decoding of header block. |
| 1984 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 1985 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1986 | } |
| 1987 | |
| 1988 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingTrailers) { |
| 1989 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 1990 | return; |
| 1991 | } |
| 1992 | |
| 1993 | Initialize(kShouldProcessData); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1994 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1995 | // HEADERS frame referencing first dynamic table entry. |
| 1996 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1997 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1998 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1999 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2000 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2001 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2002 | // Deliver dynamic table entry to decoder. |
| 2003 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2004 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 2005 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2006 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2007 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2008 | stream_->ConsumeHeaderList(); |
| 2009 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2010 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2011 | std::string data = DataFrame(kDataFramePayload); |
| 2012 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 2013 | headers.length(), data)); |
| 2014 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2015 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2016 | // Trailing HEADERS frame only referencing entry with absolute index 0 but |
| 2017 | // with Required Insert Count = 2, which is incorrect. |
| 2018 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2019 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 2020 | headers.length() + data.length(), |
| 2021 | trailers)); |
| 2022 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2023 | // Even though entire header block is received and every referenced entry is |
| 2024 | // available, decoding is blocked until insert count reaches the Required |
| 2025 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2026 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 2027 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2028 | EXPECT_CALL(*connection_, |
| 2029 | CloseConnection( |
| 2030 | QUIC_DECOMPRESSION_FAILURE, |
| 2031 | MatchesRegex( |
| 2032 | "Error during async decoding of trailers on stream \\d+: " |
| 2033 | "Required Insert Count too large."), |
| 2034 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
| 2035 | |
| 2036 | // Deliver second dynamic table entry to decoder |
| 2037 | // to trigger decoding of trailing header block. |
| 2038 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2039 | } |
| 2040 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2041 | class QuicSpdyStreamIncrementalConsumptionTest : public QuicSpdyStreamTest { |
| 2042 | protected: |
| 2043 | QuicSpdyStreamIncrementalConsumptionTest() : offset_(0), consumed_bytes_(0) {} |
| 2044 | ~QuicSpdyStreamIncrementalConsumptionTest() override = default; |
| 2045 | |
| 2046 | // Create QuicStreamFrame with |payload| |
| 2047 | // and pass it to stream_->OnStreamFrame(). |
| 2048 | void OnStreamFrame(QuicStringPiece payload) { |
| 2049 | QuicStreamFrame frame(stream_->id(), /* fin = */ false, offset_, payload); |
| 2050 | stream_->OnStreamFrame(frame); |
| 2051 | offset_ += payload.size(); |
| 2052 | } |
| 2053 | |
| 2054 | // Return number of bytes marked consumed with sequencer |
| 2055 | // since last NewlyConsumedBytes() call. |
| 2056 | QuicStreamOffset NewlyConsumedBytes() { |
| 2057 | QuicStreamOffset previously_consumed_bytes = consumed_bytes_; |
| 2058 | consumed_bytes_ = stream_->sequencer()->NumBytesConsumed(); |
| 2059 | return consumed_bytes_ - previously_consumed_bytes; |
| 2060 | } |
| 2061 | |
| 2062 | // Read |size| bytes from the stream. |
| 2063 | std::string ReadFromStream(QuicByteCount size) { |
| 2064 | std::string buffer; |
| 2065 | buffer.resize(size); |
| 2066 | |
| 2067 | struct iovec vec; |
| 2068 | vec.iov_base = const_cast<char*>(buffer.data()); |
| 2069 | vec.iov_len = size; |
| 2070 | |
| 2071 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 2072 | EXPECT_EQ(bytes_read, size); |
| 2073 | |
| 2074 | return buffer; |
| 2075 | } |
| 2076 | |
| 2077 | private: |
| 2078 | QuicStreamOffset offset_; |
| 2079 | QuicStreamOffset consumed_bytes_; |
| 2080 | }; |
| 2081 | |
| 2082 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 2083 | QuicSpdyStreamIncrementalConsumptionTest, |
| 2084 | ::testing::Values(ParsedQuicVersion{PROTOCOL_TLS1_3, |
| 2085 | QUIC_VERSION_99})); |
| 2086 | |
| 2087 | // Test that stream bytes are consumed (by calling |
| 2088 | // sequencer()->MarkConsumed()) incrementally, as soon as possible. |
| 2089 | TEST_P(QuicSpdyStreamIncrementalConsumptionTest, IncrementalConsumptionTest) { |
| 2090 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 2091 | return; |
| 2092 | } |
| 2093 | |
| 2094 | Initialize(!kShouldProcessData); |
| 2095 | |
| 2096 | // HEADERS frame with QPACK encoded single header field "foo: bar". |
| 2097 | std::string headers = |
| 2098 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
| 2099 | |
| 2100 | // All HEADERS frame bytes are consumed even if the frame is not received |
| 2101 | // completely (as long as at least some of the payload is received, which is |
| 2102 | // an implementation detail that should not be tested). |
| 2103 | OnStreamFrame(QuicStringPiece(headers).substr(0, headers.size() - 1)); |
| 2104 | EXPECT_EQ(headers.size() - 1, NewlyConsumedBytes()); |
| 2105 | |
| 2106 | // The rest of the HEADERS frame is also consumed immediately. |
| 2107 | OnStreamFrame(QuicStringPiece(headers).substr(headers.size() - 1)); |
| 2108 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2109 | |
| 2110 | // Verify headers. |
| 2111 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2112 | stream_->ConsumeHeaderList(); |
| 2113 | |
| 2114 | // DATA frame. |
| 2115 | QuicStringPiece data_payload(kDataFramePayload); |
| 2116 | std::string data_frame = DataFrame(data_payload); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2117 | QuicByteCount data_frame_header_length = |
| 2118 | data_frame.size() - data_payload.size(); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2119 | |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2120 | // DATA frame header is consumed. |
| 2121 | // DATA frame payload is not consumed because payload has to be buffered. |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2122 | OnStreamFrame(data_frame); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2123 | EXPECT_EQ(data_frame_header_length, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2124 | |
| 2125 | // Consume all but last byte of data. |
| 2126 | EXPECT_EQ(data_payload.substr(0, data_payload.size() - 1), |
| 2127 | ReadFromStream(data_payload.size() - 1)); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2128 | EXPECT_EQ(data_payload.size() - 1, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2129 | |
| 2130 | // Trailing HEADERS frame with QPACK encoded |
| 2131 | // single header field "custom-key: custom-value". |
| 2132 | std::string trailers = HeadersFrame( |
| 2133 | QuicTextUtils::HexDecode("00002f0125a849e95ba97d7f8925a849e95bb8e8b4bf")); |
| 2134 | |
| 2135 | // No bytes are consumed, because last byte of DATA payload is still buffered. |
| 2136 | OnStreamFrame(QuicStringPiece(trailers).substr(0, trailers.size() - 1)); |
| 2137 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2138 | |
| 2139 | // Reading last byte of DATA payload triggers consumption of all data received |
| 2140 | // so far, even though last HEADERS frame has not been received completely. |
| 2141 | EXPECT_EQ(data_payload.substr(data_payload.size() - 1), ReadFromStream(1)); |
| 2142 | EXPECT_EQ(1 + trailers.size() - 1, NewlyConsumedBytes()); |
| 2143 | |
| 2144 | // Last byte of trailers is immediately consumed. |
| 2145 | OnStreamFrame(QuicStringPiece(trailers).substr(trailers.size() - 1)); |
| 2146 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2147 | |
| 2148 | // Verify trailers. |
| 2149 | EXPECT_THAT(stream_->received_trailers(), |
| 2150 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2151 | } |
| 2152 | |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2153 | TEST_P(QuicSpdyStreamTest, PushPromiseOnDataStreamShouldClose) { |
| 2154 | Initialize(kShouldProcessData); |
| 2155 | if (!HasFrameHeader()) { |
| 2156 | return; |
| 2157 | } |
| 2158 | PushPromiseFrame push_promise; |
| 2159 | push_promise.push_id = 0x01; |
| 2160 | push_promise.headers = "Headers"; |
| 2161 | std::unique_ptr<char[]> buffer; |
| 2162 | HttpEncoder encoder; |
| 2163 | uint64_t length = |
| 2164 | encoder.SerializePushPromiseFrameWithOnlyPushId(push_promise, &buffer); |
| 2165 | QuicStreamFrame frame(stream_->id(), false, 0, buffer.get(), length); |
| 2166 | // TODO(lassey): Check for HTTP_WRONG_STREAM error code. |
| 2167 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_DECODER_ERROR, _, _)); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame^] | 2168 | stream_->OnStreamHeadersPriority( |
| 2169 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2170 | ProcessHeaders(false, headers_); |
| 2171 | stream_->ConsumeHeaderList(); |
| 2172 | stream_->OnStreamFrame(frame); |
| 2173 | } |
| 2174 | |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2175 | // Close connection if a DATA frame is received before a HEADERS frame. |
| 2176 | TEST_P(QuicSpdyStreamTest, DataBeforeHeaders) { |
| 2177 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 2178 | return; |
| 2179 | } |
| 2180 | |
| 2181 | Initialize(kShouldProcessData); |
| 2182 | |
| 2183 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2184 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2185 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2186 | EXPECT_CALL( |
| 2187 | *connection_, |
| 2188 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2189 | "Unexpected DATA frame received.", |
| 2190 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2191 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2192 | |
| 2193 | std::string data = DataFrame(kDataFramePayload); |
| 2194 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, data)); |
| 2195 | } |
| 2196 | |
| 2197 | // Close connection if a HEADERS frame is received after the trailing HEADERS. |
| 2198 | TEST_P(QuicSpdyStreamTest, TrailersAfterTrailers) { |
| 2199 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 2200 | return; |
| 2201 | } |
| 2202 | |
| 2203 | Initialize(kShouldProcessData); |
| 2204 | |
| 2205 | // Receive and consume headers, with single header field "foo: bar". |
| 2206 | std::string headers = |
| 2207 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
| 2208 | QuicStreamOffset offset = 0; |
| 2209 | stream_->OnStreamFrame( |
| 2210 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2211 | offset += headers.size(); |
| 2212 | |
| 2213 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2214 | stream_->ConsumeHeaderList(); |
| 2215 | |
| 2216 | // Receive data. It is consumed by TestStream. |
| 2217 | std::string data = DataFrame(kDataFramePayload); |
| 2218 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data)); |
| 2219 | offset += data.size(); |
| 2220 | |
| 2221 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2222 | |
| 2223 | // Receive and consume trailers, with single header field |
| 2224 | // "custom-key: custom-value". |
| 2225 | std::string trailers1 = HeadersFrame( |
| 2226 | QuicTextUtils::HexDecode("00002f0125a849e95ba97d7f8925a849e95bb8e8b4bf")); |
| 2227 | stream_->OnStreamFrame( |
| 2228 | QuicStreamFrame(stream_->id(), false, offset, trailers1)); |
| 2229 | offset += trailers1.size(); |
| 2230 | |
| 2231 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2232 | EXPECT_THAT(stream_->received_trailers(), |
| 2233 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2234 | |
| 2235 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2236 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2237 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2238 | EXPECT_CALL( |
| 2239 | *connection_, |
| 2240 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2241 | "HEADERS frame received after trailing HEADERS.", |
| 2242 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2243 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2244 | |
| 2245 | // Receive another HEADERS frame, with no header fields. |
| 2246 | std::string trailers2 = HeadersFrame(QuicTextUtils::HexDecode("0000")); |
| 2247 | stream_->OnStreamFrame( |
| 2248 | QuicStreamFrame(stream_->id(), false, offset, trailers2)); |
| 2249 | } |
| 2250 | |
| 2251 | // Regression test for https://crbug.com/978733. |
| 2252 | // Close connection if a DATA frame is received after the trailing HEADERS. |
| 2253 | TEST_P(QuicSpdyStreamTest, DataAfterTrailers) { |
| 2254 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 2255 | return; |
| 2256 | } |
| 2257 | |
| 2258 | Initialize(kShouldProcessData); |
| 2259 | |
| 2260 | // Receive and consume headers, with single header field "foo: bar". |
| 2261 | std::string headers = |
| 2262 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
| 2263 | QuicStreamOffset offset = 0; |
| 2264 | stream_->OnStreamFrame( |
| 2265 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2266 | offset += headers.size(); |
| 2267 | |
| 2268 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2269 | stream_->ConsumeHeaderList(); |
| 2270 | |
| 2271 | // Receive data. It is consumed by TestStream. |
| 2272 | std::string data1 = DataFrame(kDataFramePayload); |
| 2273 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data1)); |
| 2274 | offset += data1.size(); |
| 2275 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2276 | |
| 2277 | // Receive trailers, with single header field "custom-key: custom-value". |
| 2278 | std::string trailers = HeadersFrame( |
| 2279 | QuicTextUtils::HexDecode("00002f0125a849e95ba97d7f8925a849e95bb8e8b4bf")); |
| 2280 | stream_->OnStreamFrame( |
| 2281 | QuicStreamFrame(stream_->id(), false, offset, trailers)); |
| 2282 | offset += trailers.size(); |
| 2283 | |
| 2284 | EXPECT_THAT(stream_->received_trailers(), |
| 2285 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2286 | |
| 2287 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2288 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2289 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2290 | EXPECT_CALL( |
| 2291 | *connection_, |
| 2292 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2293 | "Unexpected DATA frame received.", |
| 2294 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2295 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2296 | |
| 2297 | // Receive more data. |
| 2298 | std::string data2 = DataFrame("This payload should not be proccessed."); |
| 2299 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data2)); |
| 2300 | } |
| 2301 | |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2302 | // SETTINGS frames are invalid on bidirectional streams. If one is received, |
| 2303 | // the connection is closed. No more data should be processed. |
| 2304 | TEST_P(QuicSpdyStreamTest, StopProcessingIfConnectionClosed) { |
| 2305 | if (!VersionUsesQpack(GetParam().transport_version)) { |
| 2306 | return; |
| 2307 | } |
| 2308 | |
| 2309 | Initialize(kShouldProcessData); |
| 2310 | |
| 2311 | // SETTINGS frame with empty payload. |
| 2312 | std::string settings = QuicTextUtils::HexDecode("0400"); |
| 2313 | // HEADERS frame with QPACK encoded single header field "foo: bar". |
| 2314 | // Since it arrives after a SETTINGS frame, it should never be read. |
| 2315 | std::string headers = |
| 2316 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e703626172")); |
| 2317 | |
| 2318 | // Combine the two frames to make sure they are processed in a single |
| 2319 | // QuicSpdyStream::OnDataAvailable() call. |
| 2320 | std::string frames = QuicStrCat(settings, headers); |
| 2321 | |
| 2322 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2323 | |
| 2324 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_DECODER_ERROR, _, _)) |
| 2325 | .WillOnce( |
| 2326 | Invoke(connection_, &MockQuicConnection::ReallyCloseConnection)); |
| 2327 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
| 2328 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)); |
| 2329 | |
| 2330 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), /* fin = */ false, |
| 2331 | /* offset = */ 0, frames)); |
| 2332 | |
| 2333 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2334 | } |
| 2335 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 2336 | } // namespace |
| 2337 | } // namespace test |
| 2338 | } // namespace quic |