QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright (c) 2017 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/third_party/quiche/src/quic/quartc/quartc_stream.h" |
| 6 | |
| 7 | #include <memory> |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 8 | #include <string> |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 9 | #include <type_traits> |
| 10 | #include <utility> |
| 11 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 12 | #include "net/third_party/quiche/src/quic/core/crypto/quic_random.h" |
| 13 | #include "net/third_party/quiche/src/quic/core/frames/quic_stream_frame.h" |
| 14 | #include "net/third_party/quiche/src/quic/core/quic_alarm_factory.h" |
| 15 | #include "net/third_party/quiche/src/quic/core/quic_buffer_allocator.h" |
vasilvv | 89713d0 | 2020-02-11 14:33:26 -0800 | [diff] [blame] | 16 | #include "net/third_party/quiche/src/quic/core/quic_clock.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 17 | #include "net/third_party/quiche/src/quic/core/quic_config.h" |
| 18 | #include "net/third_party/quiche/src/quic/core/quic_connection.h" |
| 19 | #include "net/third_party/quiche/src/quic/core/quic_crypto_stream.h" |
| 20 | #include "net/third_party/quiche/src/quic/core/quic_data_writer.h" |
| 21 | #include "net/third_party/quiche/src/quic/core/quic_error_codes.h" |
| 22 | #include "net/third_party/quiche/src/quic/core/quic_packet_writer.h" |
| 23 | #include "net/third_party/quiche/src/quic/core/quic_session.h" |
| 24 | #include "net/third_party/quiche/src/quic/core/quic_simple_buffer_allocator.h" |
| 25 | #include "net/third_party/quiche/src/quic/core/quic_time.h" |
| 26 | #include "net/third_party/quiche/src/quic/core/quic_types.h" |
| 27 | #include "net/third_party/quiche/src/quic/core/quic_utils.h" |
| 28 | #include "net/third_party/quiche/src/quic/core/quic_versions.h" |
| 29 | #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 30 | #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" |
| 31 | #include "net/third_party/quiche/src/quic/platform/api/quic_ip_address.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 32 | #include "net/third_party/quiche/src/quic/platform/api/quic_socket_address.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 33 | #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" |
| 34 | #include "net/third_party/quiche/src/quic/platform/api/quic_test_mem_slice_vector.h" |
| 35 | #include "net/third_party/quiche/src/quic/quartc/quartc_factory.h" |
| 36 | #include "net/third_party/quiche/src/quic/test_tools/mock_clock.h" |
| 37 | #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" |
QUICHE team | 173c48f | 2019-11-19 16:34:44 -0800 | [diff] [blame] | 38 | #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 39 | #include "net/third_party/quiche/src/spdy/core/spdy_protocol.h" |
| 40 | |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 41 | using ::quic::test::IsQuicStreamNoError; |
| 42 | using ::quic::test::IsStreamError; |
| 43 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 44 | namespace quic { |
| 45 | |
| 46 | namespace { |
| 47 | |
| 48 | static const QuicStreamId kStreamId = 5; |
| 49 | |
| 50 | // MockQuicSession that does not create streams and writes data from |
| 51 | // QuicStream to a string. |
| 52 | class MockQuicSession : public QuicSession { |
| 53 | public: |
| 54 | MockQuicSession(QuicConnection* connection, |
| 55 | const QuicConfig& config, |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 56 | std::string* write_buffer) |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 57 | : QuicSession(connection, |
| 58 | nullptr /*visitor*/, |
| 59 | config, |
renjietang | 216dc01 | 2019-08-27 11:28:27 -0700 | [diff] [blame] | 60 | CurrentSupportedVersions(), |
| 61 | /*num_expected_unidirectional_static_streams = */ 0), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 62 | write_buffer_(write_buffer) {} |
| 63 | |
| 64 | ~MockQuicSession() override {} |
| 65 | |
| 66 | // Writes outgoing data from QuicStream to a string. |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 67 | QuicConsumedData WritevData( |
| 68 | QuicStreamId id, |
| 69 | size_t write_length, |
| 70 | QuicStreamOffset offset, |
| 71 | StreamSendingState state, |
renjietang | 4d992bf | 2020-03-03 13:01:55 -0800 | [diff] [blame] | 72 | TransmissionType /*type*/, |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 73 | quiche::QuicheOptional<EncryptionLevel> /*level*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 74 | if (!writable_) { |
| 75 | return QuicConsumedData(0, false); |
| 76 | } |
| 77 | |
| 78 | // WritevData does not pass down a iovec, data is saved in stream before |
| 79 | // data is consumed. Retrieve data from stream. |
| 80 | char* buf = new char[write_length]; |
QUICHE team | 173c48f | 2019-11-19 16:34:44 -0800 | [diff] [blame] | 81 | QuicDataWriter writer(write_length, buf, quiche::NETWORK_BYTE_ORDER); |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 82 | QuicStream* stream = GetOrCreateStream(id); |
| 83 | DCHECK(stream); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 84 | if (write_length > 0) { |
| 85 | stream->WriteStreamData(offset, write_length, &writer); |
| 86 | } |
| 87 | write_buffer_->append(buf, write_length); |
| 88 | delete[] buf; |
| 89 | return QuicConsumedData(write_length, state != StreamSendingState::NO_FIN); |
| 90 | } |
| 91 | |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 92 | QuartcStream* CreateIncomingStream(QuicStreamId /*id*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 93 | return nullptr; |
| 94 | } |
| 95 | |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 96 | QuartcStream* CreateIncomingStream(PendingStream* /*pending*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 97 | return nullptr; |
| 98 | } |
| 99 | |
| 100 | const QuicCryptoStream* GetCryptoStream() const override { return nullptr; } |
| 101 | QuicCryptoStream* GetMutableCryptoStream() override { return nullptr; } |
| 102 | bool ShouldKeepConnectionAlive() const override { |
renjietang | 17e2993 | 2019-08-08 10:04:31 -0700 | [diff] [blame] | 103 | return GetNumActiveStreams() > 0; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 104 | } |
| 105 | |
| 106 | // Called by QuicStream when they want to close stream. |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 107 | void SendRstStream(QuicStreamId /*id*/, |
| 108 | QuicRstStreamErrorCode /*error*/, |
| 109 | QuicStreamOffset /*bytes_written*/) override {} |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 110 | |
| 111 | // Sets whether data is written to buffer, or else if this is write blocked. |
| 112 | void set_writable(bool writable) { writable_ = writable; } |
| 113 | |
| 114 | // Tracks whether the stream is write blocked and its priority. |
| 115 | void RegisterReliableStream(QuicStreamId stream_id, |
| 116 | spdy::SpdyPriority priority) { |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 117 | write_blocked_streams()->RegisterStream( |
| 118 | stream_id, |
| 119 | /*is_static_stream=*/false, spdy::SpdyStreamPrecedence(priority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 120 | } |
| 121 | |
| 122 | // The session take ownership of the stream. |
| 123 | void ActivateReliableStream(std::unique_ptr<QuicStream> stream) { |
| 124 | ActivateStream(std::move(stream)); |
| 125 | } |
| 126 | |
| 127 | private: |
| 128 | // Stores written data from ReliableQuicStreamAdapter. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 129 | std::string* write_buffer_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 130 | // Whether data is written to write_buffer_. |
| 131 | bool writable_ = true; |
| 132 | }; |
| 133 | |
| 134 | // Packet writer that does nothing. This is required for QuicConnection but |
| 135 | // isn't used for writing data. |
| 136 | class DummyPacketWriter : public QuicPacketWriter { |
| 137 | public: |
| 138 | DummyPacketWriter() {} |
| 139 | |
| 140 | // QuicPacketWriter overrides. |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 141 | WriteResult WritePacket(const char* /*buffer*/, |
| 142 | size_t /*buf_len*/, |
| 143 | const QuicIpAddress& /*self_address*/, |
| 144 | const QuicSocketAddress& /*peer_address*/, |
| 145 | PerPacketOptions* /*options*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 146 | return WriteResult(WRITE_STATUS_ERROR, 0); |
| 147 | } |
| 148 | |
| 149 | bool IsWriteBlocked() const override { return false; } |
| 150 | |
| 151 | void SetWritable() override {} |
| 152 | |
| 153 | QuicByteCount GetMaxPacketSize( |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 154 | const QuicSocketAddress& /*peer_address*/) const override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 155 | return 0; |
| 156 | } |
| 157 | |
| 158 | bool SupportsReleaseTime() const override { return false; } |
| 159 | |
| 160 | bool IsBatchMode() const override { return false; } |
| 161 | |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 162 | char* GetNextWriteLocation( |
| 163 | const QuicIpAddress& /*self_address*/, |
| 164 | const QuicSocketAddress& /*peer_address*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 165 | return nullptr; |
| 166 | } |
| 167 | |
| 168 | WriteResult Flush() override { return WriteResult(WRITE_STATUS_OK, 0); } |
| 169 | }; |
| 170 | |
| 171 | class MockQuartcStreamDelegate : public QuartcStream::Delegate { |
| 172 | public: |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 173 | MockQuartcStreamDelegate(QuicStreamId id, std::string* read_buffer) |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 174 | : id_(id), read_buffer_(read_buffer) {} |
| 175 | |
| 176 | void OnBufferChanged(QuartcStream* stream) override { |
| 177 | last_bytes_buffered_ = stream->BufferedDataBytes(); |
| 178 | last_bytes_pending_retransmission_ = stream->BytesPendingRetransmission(); |
| 179 | } |
| 180 | |
| 181 | size_t OnReceived(QuartcStream* stream, |
| 182 | iovec* iov, |
| 183 | size_t iov_length, |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 184 | bool /*fin*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 185 | EXPECT_EQ(id_, stream->id()); |
| 186 | EXPECT_EQ(stream->ReadOffset(), read_buffer_->size()); |
| 187 | size_t bytes_consumed = 0; |
| 188 | for (size_t i = 0; i < iov_length; ++i) { |
| 189 | read_buffer_->append(static_cast<const char*>(iov[i].iov_base), |
| 190 | iov[i].iov_len); |
| 191 | bytes_consumed += iov[i].iov_len; |
| 192 | } |
| 193 | return bytes_consumed; |
| 194 | } |
| 195 | |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 196 | void OnClose(QuartcStream* /*stream*/) override { closed_ = true; } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 197 | |
| 198 | bool closed() { return closed_; } |
| 199 | |
| 200 | QuicByteCount last_bytes_buffered() { return last_bytes_buffered_; } |
| 201 | QuicByteCount last_bytes_pending_retransmission() { |
| 202 | return last_bytes_pending_retransmission_; |
| 203 | } |
| 204 | |
| 205 | protected: |
| 206 | QuicStreamId id_; |
| 207 | // Data read by the QuicStream. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 208 | std::string* read_buffer_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 209 | // Whether the QuicStream is closed. |
| 210 | bool closed_ = false; |
| 211 | |
| 212 | // Last amount of data observed as buffered. |
| 213 | QuicByteCount last_bytes_buffered_ = 0; |
| 214 | QuicByteCount last_bytes_pending_retransmission_ = 0; |
| 215 | }; |
| 216 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 217 | class QuartcStreamTest : public QuicTestWithParam<ParsedQuicVersion>, |
| 218 | public QuicConnectionHelperInterface { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 219 | public: |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 220 | QuartcStreamTest() : version_(GetParam()) {} |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 221 | |
| 222 | ~QuartcStreamTest() override = default; |
| 223 | |
| 224 | void CreateReliableQuicStream() { |
| 225 | // Arbitrary values for QuicConnection. |
| 226 | Perspective perspective = Perspective::IS_SERVER; |
| 227 | QuicIpAddress ip; |
| 228 | ip.FromString("0.0.0.0"); |
| 229 | bool owns_writer = true; |
| 230 | |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 231 | alarm_factory_ = std::make_unique<test::MockAlarmFactory>(); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 232 | |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 233 | connection_ = std::make_unique<QuicConnection>( |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 234 | QuicUtils::CreateZeroConnectionId(version_.transport_version), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 235 | QuicSocketAddress(ip, 0), this /*QuicConnectionHelperInterface*/, |
| 236 | alarm_factory_.get(), new DummyPacketWriter(), owns_writer, perspective, |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 237 | ParsedQuicVersionVector{version_}); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 238 | clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 239 | session_ = std::make_unique<MockQuicSession>(connection_.get(), |
| 240 | QuicConfig(), &write_buffer_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 241 | mock_stream_delegate_ = |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 242 | std::make_unique<MockQuartcStreamDelegate>(kStreamId, &read_buffer_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 243 | stream_ = new QuartcStream(kStreamId, session_.get()); |
| 244 | stream_->SetDelegate(mock_stream_delegate_.get()); |
| 245 | session_->ActivateReliableStream(std::unique_ptr<QuartcStream>(stream_)); |
| 246 | } |
| 247 | |
| 248 | const QuicClock* GetClock() const override { return &clock_; } |
| 249 | |
| 250 | QuicRandom* GetRandomGenerator() override { |
| 251 | return QuicRandom::GetInstance(); |
| 252 | } |
| 253 | |
| 254 | QuicBufferAllocator* GetStreamSendBufferAllocator() override { |
| 255 | return &buffer_allocator_; |
| 256 | } |
| 257 | |
| 258 | protected: |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 259 | const ParsedQuicVersion version_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 260 | // The QuicSession will take the ownership. |
| 261 | QuartcStream* stream_; |
| 262 | std::unique_ptr<MockQuartcStreamDelegate> mock_stream_delegate_; |
| 263 | std::unique_ptr<MockQuicSession> session_; |
| 264 | // Data written by the ReliableQuicStreamAdapterTest. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 265 | std::string write_buffer_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 266 | // Data read by the ReliableQuicStreamAdapterTest. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 267 | std::string read_buffer_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 268 | std::unique_ptr<QuicAlarmFactory> alarm_factory_; |
| 269 | std::unique_ptr<QuicConnection> connection_; |
| 270 | // Used to implement the QuicConnectionHelperInterface. |
| 271 | SimpleBufferAllocator buffer_allocator_; |
| 272 | MockClock clock_; |
| 273 | }; |
| 274 | |
bnc | 36b7a03 | 2020-03-04 10:27:23 -0800 | [diff] [blame] | 275 | // TODO(b/150224094): Enable versions with TLS handshake. |
| 276 | INSTANTIATE_TEST_SUITE_P( |
| 277 | Tests, |
| 278 | QuartcStreamTest, |
| 279 | ::testing::ValuesIn(CurrentSupportedVersionsWithQuicCrypto()), |
| 280 | ::testing::PrintToStringParamName()); |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 281 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 282 | // Write an entire string. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 283 | TEST_P(QuartcStreamTest, WriteDataWhole) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 284 | CreateReliableQuicStream(); |
| 285 | char message[] = "Foo bar"; |
| 286 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 287 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 288 | EXPECT_EQ("Foo bar", write_buffer_); |
| 289 | } |
| 290 | |
| 291 | // Write part of a string. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 292 | TEST_P(QuartcStreamTest, WriteDataPartial) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 293 | CreateReliableQuicStream(); |
| 294 | char message[] = "Foo bar"; |
| 295 | test::QuicTestMemSliceVector data({std::make_pair(message, 5)}); |
| 296 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 297 | EXPECT_EQ("Foo b", write_buffer_); |
| 298 | } |
| 299 | |
| 300 | // Test that a QuartcStream buffers writes correctly. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 301 | TEST_P(QuartcStreamTest, StreamBuffersData) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 302 | CreateReliableQuicStream(); |
| 303 | |
| 304 | char message[] = "Foo bar"; |
| 305 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 306 | |
| 307 | // The stream is not yet writable, so data will be buffered. |
| 308 | session_->set_writable(false); |
| 309 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 310 | |
| 311 | // Check that data is buffered. |
| 312 | EXPECT_TRUE(stream_->HasBufferedData()); |
| 313 | EXPECT_EQ(7u, stream_->BufferedDataBytes()); |
| 314 | |
| 315 | // Check that the stream told its delegate about the buffer change. |
| 316 | EXPECT_EQ(7u, mock_stream_delegate_->last_bytes_buffered()); |
| 317 | |
| 318 | // Check that none of the data was written yet. |
| 319 | // Note that |write_buffer_| actually holds data written by the QuicSession |
| 320 | // (not data buffered by the stream). |
| 321 | EXPECT_EQ(0ul, write_buffer_.size()); |
| 322 | |
| 323 | char message1[] = "xyzzy"; |
| 324 | test::QuicTestMemSliceVector data1({std::make_pair(message1, 5)}); |
| 325 | |
| 326 | // More writes go into the buffer. |
| 327 | stream_->WriteMemSlices(data1.span(), /*fin=*/false); |
| 328 | |
| 329 | EXPECT_TRUE(stream_->HasBufferedData()); |
| 330 | EXPECT_EQ(12u, stream_->BufferedDataBytes()); |
| 331 | EXPECT_EQ(12u, mock_stream_delegate_->last_bytes_buffered()); |
| 332 | EXPECT_EQ(0ul, write_buffer_.size()); |
| 333 | |
| 334 | // The stream becomes writable, so it sends the buffered data. |
| 335 | session_->set_writable(true); |
| 336 | stream_->OnCanWrite(); |
| 337 | |
| 338 | EXPECT_FALSE(stream_->HasBufferedData()); |
| 339 | EXPECT_EQ(0u, stream_->BufferedDataBytes()); |
| 340 | EXPECT_EQ(0u, mock_stream_delegate_->last_bytes_buffered()); |
| 341 | EXPECT_EQ("Foo barxyzzy", write_buffer_); |
| 342 | } |
| 343 | |
| 344 | // Finish writing to a stream. |
| 345 | // It delivers the fin bit and closes the write-side as soon as possible. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 346 | TEST_P(QuartcStreamTest, FinishWriting) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 347 | CreateReliableQuicStream(); |
| 348 | |
| 349 | session_->set_writable(false); |
| 350 | stream_->FinishWriting(); |
| 351 | EXPECT_FALSE(stream_->fin_sent()); |
| 352 | |
| 353 | // Fin is sent as soon as the stream becomes writable. |
| 354 | session_->set_writable(true); |
| 355 | stream_->OnCanWrite(); |
| 356 | EXPECT_TRUE(stream_->fin_sent()); |
| 357 | EXPECT_TRUE(stream_->write_side_closed()); |
| 358 | } |
| 359 | |
| 360 | // Read an entire string. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 361 | TEST_P(QuartcStreamTest, ReadDataWhole) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 362 | CreateReliableQuicStream(); |
| 363 | QuicStreamFrame frame(kStreamId, false, 0, "Hello, World!"); |
| 364 | stream_->OnStreamFrame(frame); |
| 365 | |
| 366 | EXPECT_EQ("Hello, World!", read_buffer_); |
| 367 | } |
| 368 | |
| 369 | // Read part of a string. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 370 | TEST_P(QuartcStreamTest, ReadDataPartial) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 371 | CreateReliableQuicStream(); |
| 372 | QuicStreamFrame frame(kStreamId, false, 0, "Hello, World!"); |
| 373 | frame.data_length = 5; |
| 374 | stream_->OnStreamFrame(frame); |
| 375 | |
| 376 | EXPECT_EQ("Hello", read_buffer_); |
| 377 | } |
| 378 | |
| 379 | // Streams do not call OnReceived() after StopReading(). |
| 380 | // Note: this is tested here because Quartc relies on this behavior. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 381 | TEST_P(QuartcStreamTest, StopReading) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 382 | CreateReliableQuicStream(); |
| 383 | stream_->StopReading(); |
| 384 | |
| 385 | QuicStreamFrame frame(kStreamId, false, 0, "Hello, World!"); |
| 386 | stream_->OnStreamFrame(frame); |
| 387 | |
| 388 | EXPECT_EQ(0ul, read_buffer_.size()); |
| 389 | |
| 390 | QuicStreamFrame frame2(kStreamId, true, 0, "Hello, World!"); |
| 391 | stream_->OnStreamFrame(frame2); |
| 392 | |
| 393 | EXPECT_EQ(0ul, read_buffer_.size()); |
| 394 | EXPECT_TRUE(stream_->fin_received()); |
| 395 | } |
| 396 | |
| 397 | // Test that closing the stream results in a callback. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 398 | TEST_P(QuartcStreamTest, CloseStream) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 399 | CreateReliableQuicStream(); |
| 400 | EXPECT_FALSE(mock_stream_delegate_->closed()); |
| 401 | stream_->OnClose(); |
| 402 | EXPECT_TRUE(mock_stream_delegate_->closed()); |
| 403 | } |
| 404 | |
| 405 | // Both sending and receiving fin automatically closes a stream. |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 406 | TEST_P(QuartcStreamTest, CloseOnFins) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 407 | CreateReliableQuicStream(); |
| 408 | QuicStreamFrame frame(kStreamId, true, 0, 0); |
| 409 | stream_->OnStreamFrame(frame); |
| 410 | |
| 411 | test::QuicTestMemSliceVector data({}); |
| 412 | stream_->WriteMemSlices(data.span(), /*fin=*/true); |
| 413 | |
| 414 | // Check that the OnClose() callback occurred. |
| 415 | EXPECT_TRUE(mock_stream_delegate_->closed()); |
| 416 | } |
| 417 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 418 | TEST_P(QuartcStreamTest, TestCancelOnLossDisabled) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 419 | CreateReliableQuicStream(); |
| 420 | |
| 421 | // This should be the default state. |
| 422 | EXPECT_FALSE(stream_->cancel_on_loss()); |
| 423 | |
| 424 | char message[] = "Foo bar"; |
| 425 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 426 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 427 | |
| 428 | EXPECT_EQ("Foo bar", write_buffer_); |
| 429 | |
| 430 | stream_->OnStreamFrameLost(0, 7, false); |
| 431 | stream_->OnCanWrite(); |
| 432 | |
| 433 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 434 | EXPECT_THAT(stream_->stream_error(), IsQuicStreamNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 435 | } |
| 436 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 437 | TEST_P(QuartcStreamTest, TestCancelOnLossEnabled) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 438 | CreateReliableQuicStream(); |
| 439 | stream_->set_cancel_on_loss(true); |
| 440 | |
| 441 | char message[] = "Foo bar"; |
| 442 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 443 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 444 | |
| 445 | EXPECT_EQ("Foo bar", write_buffer_); |
| 446 | |
| 447 | stream_->OnStreamFrameLost(0, 7, false); |
| 448 | stream_->OnCanWrite(); |
| 449 | |
| 450 | EXPECT_EQ("Foo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 451 | EXPECT_THAT(stream_->stream_error(), IsStreamError(QUIC_STREAM_CANCELLED)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 452 | } |
| 453 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 454 | TEST_P(QuartcStreamTest, MaxRetransmissionsAbsent) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 455 | CreateReliableQuicStream(); |
| 456 | |
| 457 | // This should be the default state. |
| 458 | EXPECT_EQ(stream_->max_retransmission_count(), |
| 459 | std::numeric_limits<int>::max()); |
| 460 | |
| 461 | char message[] = "Foo bar"; |
| 462 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 463 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 464 | |
| 465 | EXPECT_EQ("Foo bar", write_buffer_); |
| 466 | |
| 467 | stream_->OnStreamFrameLost(0, 7, false); |
| 468 | stream_->OnCanWrite(); |
| 469 | |
| 470 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 471 | EXPECT_THAT(stream_->stream_error(), IsQuicStreamNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 472 | } |
| 473 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 474 | TEST_P(QuartcStreamTest, MaxRetransmissionsSet) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 475 | CreateReliableQuicStream(); |
| 476 | stream_->set_max_retransmission_count(2); |
| 477 | |
| 478 | char message[] = "Foo bar"; |
| 479 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 480 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 481 | |
| 482 | EXPECT_EQ("Foo bar", write_buffer_); |
| 483 | |
| 484 | stream_->OnStreamFrameLost(0, 7, false); |
| 485 | stream_->OnCanWrite(); |
| 486 | |
| 487 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
| 488 | |
| 489 | stream_->OnStreamFrameLost(0, 7, false); |
| 490 | stream_->OnCanWrite(); |
| 491 | |
| 492 | EXPECT_EQ("Foo barFoo barFoo bar", write_buffer_); |
| 493 | |
| 494 | stream_->OnStreamFrameLost(0, 7, false); |
| 495 | stream_->OnCanWrite(); |
| 496 | |
| 497 | EXPECT_EQ("Foo barFoo barFoo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 498 | EXPECT_THAT(stream_->stream_error(), IsStreamError(QUIC_STREAM_CANCELLED)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 499 | } |
| 500 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 501 | TEST_P(QuartcStreamTest, MaxRetransmissionsDisjointFrames) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 502 | CreateReliableQuicStream(); |
| 503 | stream_->set_max_retransmission_count(2); |
| 504 | |
| 505 | char message[] = "Foo bar"; |
| 506 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 507 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 508 | |
| 509 | EXPECT_EQ("Foo bar", write_buffer_); |
| 510 | |
| 511 | // Retransmit bytes [0, 3]. |
| 512 | stream_->OnStreamFrameLost(0, 4, false); |
| 513 | stream_->OnCanWrite(); |
| 514 | |
| 515 | EXPECT_EQ("Foo barFoo ", write_buffer_); |
| 516 | |
| 517 | // Retransmit bytes [4, 6]. Everything has been retransmitted once. |
| 518 | stream_->OnStreamFrameLost(4, 3, false); |
| 519 | stream_->OnCanWrite(); |
| 520 | |
| 521 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
| 522 | |
| 523 | // Retransmit bytes [0, 6]. Everything can be retransmitted a second time. |
| 524 | stream_->OnStreamFrameLost(0, 7, false); |
| 525 | stream_->OnCanWrite(); |
| 526 | |
| 527 | EXPECT_EQ("Foo barFoo barFoo bar", write_buffer_); |
| 528 | } |
| 529 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 530 | TEST_P(QuartcStreamTest, MaxRetransmissionsOverlappingFrames) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 531 | CreateReliableQuicStream(); |
| 532 | stream_->set_max_retransmission_count(2); |
| 533 | |
| 534 | char message[] = "Foo bar"; |
| 535 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 536 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 537 | |
| 538 | EXPECT_EQ("Foo bar", write_buffer_); |
| 539 | |
| 540 | // Retransmit bytes 0 to 3. |
| 541 | stream_->OnStreamFrameLost(0, 4, false); |
| 542 | stream_->OnCanWrite(); |
| 543 | |
| 544 | EXPECT_EQ("Foo barFoo ", write_buffer_); |
| 545 | |
| 546 | // Retransmit bytes 3 to 6. Byte 3 has been retransmitted twice. |
| 547 | stream_->OnStreamFrameLost(3, 4, false); |
| 548 | stream_->OnCanWrite(); |
| 549 | |
| 550 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
| 551 | |
| 552 | // Retransmit byte 3 a third time. This should cause cancellation. |
| 553 | stream_->OnStreamFrameLost(3, 1, false); |
| 554 | stream_->OnCanWrite(); |
| 555 | |
| 556 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 557 | EXPECT_THAT(stream_->stream_error(), IsStreamError(QUIC_STREAM_CANCELLED)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 558 | } |
| 559 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 560 | TEST_P(QuartcStreamTest, MaxRetransmissionsWithAckedFrame) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 561 | CreateReliableQuicStream(); |
| 562 | stream_->set_max_retransmission_count(1); |
| 563 | |
| 564 | char message[] = "Foo bar"; |
| 565 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 566 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 567 | |
| 568 | EXPECT_EQ("Foo bar", write_buffer_); |
| 569 | |
| 570 | // Retransmit bytes [0, 7). |
| 571 | stream_->OnStreamFrameLost(0, 7, false); |
| 572 | stream_->OnCanWrite(); |
| 573 | |
| 574 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
| 575 | |
| 576 | // Ack bytes [0, 7). These bytes should be pruned from the data tracked by |
| 577 | // the stream. |
| 578 | QuicByteCount newly_acked_length = 0; |
| 579 | stream_->OnStreamFrameAcked(0, 7, false, QuicTime::Delta::FromMilliseconds(1), |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 580 | QuicTime::Zero(), &newly_acked_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 581 | EXPECT_EQ(7u, newly_acked_length); |
| 582 | stream_->OnCanWrite(); |
| 583 | |
| 584 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
| 585 | |
| 586 | // Retransmit bytes [0, 7) again. |
| 587 | // QUIC will never mark frames as lost after they've been acked, but this lets |
| 588 | // us test that QuartcStream stopped tracking these bytes after the acked. |
| 589 | stream_->OnStreamFrameLost(0, 7, false); |
| 590 | stream_->OnCanWrite(); |
| 591 | |
| 592 | // QuartcStream should be cancelled, but it stopped tracking the lost bytes |
| 593 | // after they were acked, so it's not. |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 594 | EXPECT_THAT(stream_->stream_error(), IsQuicStreamNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 595 | } |
| 596 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 597 | TEST_P(QuartcStreamTest, TestBytesPendingRetransmission) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 598 | CreateReliableQuicStream(); |
| 599 | stream_->set_cancel_on_loss(false); |
| 600 | |
| 601 | char message[] = "Foo bar"; |
| 602 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 603 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 604 | |
| 605 | EXPECT_EQ("Foo bar", write_buffer_); |
| 606 | |
| 607 | stream_->OnStreamFrameLost(0, 4, false); |
| 608 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 4u); |
| 609 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 4u); |
| 610 | |
| 611 | stream_->OnStreamFrameLost(4, 3, false); |
| 612 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 7u); |
| 613 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 7u); |
| 614 | |
| 615 | stream_->OnCanWrite(); |
| 616 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 0u); |
| 617 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 0u); |
| 618 | |
| 619 | EXPECT_EQ("Foo barFoo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 620 | EXPECT_THAT(stream_->stream_error(), IsQuicStreamNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 621 | } |
| 622 | |
bnc | 43b9129 | 2020-02-26 10:22:30 -0800 | [diff] [blame] | 623 | TEST_P(QuartcStreamTest, TestBytesPendingRetransmissionWithCancelOnLoss) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 624 | CreateReliableQuicStream(); |
| 625 | stream_->set_cancel_on_loss(true); |
| 626 | |
| 627 | char message[] = "Foo bar"; |
| 628 | test::QuicTestMemSliceVector data({std::make_pair(message, 7)}); |
| 629 | stream_->WriteMemSlices(data.span(), /*fin=*/false); |
| 630 | |
| 631 | EXPECT_EQ("Foo bar", write_buffer_); |
| 632 | |
| 633 | stream_->OnStreamFrameLost(0, 4, false); |
| 634 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 0u); |
| 635 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 0u); |
| 636 | |
| 637 | stream_->OnStreamFrameLost(4, 3, false); |
| 638 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 0u); |
| 639 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 0u); |
| 640 | |
| 641 | stream_->OnCanWrite(); |
| 642 | EXPECT_EQ(stream_->BytesPendingRetransmission(), 0u); |
| 643 | EXPECT_EQ(mock_stream_delegate_->last_bytes_pending_retransmission(), 0u); |
| 644 | |
| 645 | EXPECT_EQ("Foo bar", write_buffer_); |
bnc | 1389583 | 2019-11-27 08:40:50 -0800 | [diff] [blame] | 646 | EXPECT_THAT(stream_->stream_error(), IsStreamError(QUIC_STREAM_CANCELLED)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 647 | } |
| 648 | |
| 649 | } // namespace |
| 650 | |
| 651 | } // namespace quic |