Remove stream pointer from QuicSession::WritevData.
The session only uses the pointer to access stream_bytes_written. It could simply be replaced by a |is_retransmission| boolean. This change makes the boundary of streams and sessions clearer.
gfe-relnote: no behavior change, not protected.
PiperOrigin-RevId: 296504335
Change-Id: I349bdadadd923e9dcb5b03231ce351e4f1a25c96
diff --git a/quic/quartc/quartc_stream_test.cc b/quic/quartc/quartc_stream_test.cc
index bb0d0e4..3a4e731 100644
--- a/quic/quartc/quartc_stream_test.cc
+++ b/quic/quartc/quartc_stream_test.cc
@@ -64,11 +64,11 @@
~MockQuicSession() override {}
// Writes outgoing data from QuicStream to a string.
- QuicConsumedData WritevData(QuicStream* stream,
- QuicStreamId /*id*/,
+ QuicConsumedData WritevData(QuicStreamId id,
size_t write_length,
QuicStreamOffset offset,
- StreamSendingState state) override {
+ StreamSendingState state,
+ bool /*is_retransmission*/) override {
if (!writable_) {
return QuicConsumedData(0, false);
}
@@ -77,6 +77,8 @@
// data is consumed. Retrieve data from stream.
char* buf = new char[write_length];
QuicDataWriter writer(write_length, buf, quiche::NETWORK_BYTE_ORDER);
+ QuicStream* stream = GetOrCreateStream(id);
+ DCHECK(stream);
if (write_length > 0) {
stream->WriteStreamData(offset, write_length, &writer);
}
