QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/third_party/quiche/src/quic/core/http/quic_spdy_stream.h" |
| 6 | |
| 7 | #include <memory> |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 8 | #include <string> |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 9 | #include <utility> |
| 10 | |
| 11 | #include "net/third_party/quiche/src/quic/core/http/http_encoder.h" |
| 12 | #include "net/third_party/quiche/src/quic/core/http/spdy_utils.h" |
| 13 | #include "net/third_party/quiche/src/quic/core/quic_connection.h" |
| 14 | #include "net/third_party/quiche/src/quic/core/quic_stream_sequencer_buffer.h" |
| 15 | #include "net/third_party/quiche/src/quic/core/quic_utils.h" |
| 16 | #include "net/third_party/quiche/src/quic/core/quic_versions.h" |
| 17 | #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" |
| 18 | #include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" |
| 19 | #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" |
| 20 | #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" |
| 21 | #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 22 | #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" |
| 23 | #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" |
| 24 | #include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h" |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 25 | #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 26 | #include "net/third_party/quiche/src/quic/test_tools/quic_flow_controller_peer.h" |
| 27 | #include "net/third_party/quiche/src/quic/test_tools/quic_session_peer.h" |
| 28 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_session_peer.h" |
| 29 | #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_stream_peer.h" |
| 30 | #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" |
| 31 | #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" |
| 32 | |
| 33 | using spdy::kV3HighestPriority; |
| 34 | using spdy::kV3LowestPriority; |
| 35 | using spdy::SpdyHeaderBlock; |
| 36 | using spdy::SpdyPriority; |
| 37 | using testing::_; |
| 38 | using testing::AtLeast; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 39 | using testing::ElementsAre; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 40 | using testing::Invoke; |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 41 | using testing::InvokeWithoutArgs; |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 42 | using testing::MatchesRegex; |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 43 | using testing::Pair; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 44 | using testing::Return; |
| 45 | using testing::StrictMock; |
| 46 | |
| 47 | namespace quic { |
| 48 | namespace test { |
| 49 | namespace { |
| 50 | |
| 51 | const bool kShouldProcessData = true; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 52 | const char kDataFramePayload[] = "some data"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 53 | |
| 54 | class TestStream : public QuicSpdyStream { |
| 55 | public: |
| 56 | TestStream(QuicStreamId id, |
| 57 | QuicSpdySession* session, |
| 58 | bool should_process_data) |
| 59 | : QuicSpdyStream(id, session, BIDIRECTIONAL), |
| 60 | should_process_data_(should_process_data) {} |
| 61 | ~TestStream() override = default; |
| 62 | |
| 63 | using QuicSpdyStream::set_ack_listener; |
| 64 | using QuicStream::CloseWriteSide; |
| 65 | using QuicStream::WriteOrBufferData; |
| 66 | |
| 67 | void OnBodyAvailable() override { |
| 68 | if (!should_process_data_) { |
| 69 | return; |
| 70 | } |
| 71 | char buffer[2048]; |
| 72 | struct iovec vec; |
| 73 | vec.iov_base = buffer; |
| 74 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 75 | size_t bytes_read = Readv(&vec, 1); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 76 | data_ += std::string(buffer, bytes_read); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 77 | } |
| 78 | |
| 79 | MOCK_METHOD1(WriteHeadersMock, void(bool fin)); |
| 80 | |
| 81 | size_t WriteHeadersImpl(spdy::SpdyHeaderBlock header_block, |
| 82 | bool fin, |
| 83 | QuicReferenceCountedPointer<QuicAckListenerInterface> |
dschinazi | 17d4242 | 2019-06-18 16:35:07 -0700 | [diff] [blame] | 84 | /*ack_listener*/) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 85 | saved_headers_ = std::move(header_block); |
| 86 | WriteHeadersMock(fin); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 87 | if (VersionUsesHttp3(transport_version())) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 88 | // In this case, call QuicSpdyStream::WriteHeadersImpl() that does the |
| 89 | // actual work of closing the stream. |
| 90 | QuicSpdyStream::WriteHeadersImpl(saved_headers_.Clone(), fin, nullptr); |
| 91 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 92 | return 0; |
| 93 | } |
| 94 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 95 | const std::string& data() const { return data_; } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 96 | const spdy::SpdyHeaderBlock& saved_headers() const { return saved_headers_; } |
| 97 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 98 | // Expose protected accessor. |
| 99 | const QuicStreamSequencer* sequencer() const { |
| 100 | return QuicStream::sequencer(); |
| 101 | } |
| 102 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 103 | private: |
| 104 | bool should_process_data_; |
| 105 | spdy::SpdyHeaderBlock saved_headers_; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 106 | std::string data_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 107 | }; |
| 108 | |
| 109 | class TestMockUpdateStreamSession : public MockQuicSpdySession { |
| 110 | public: |
| 111 | explicit TestMockUpdateStreamSession(QuicConnection* connection) |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 112 | : MockQuicSpdySession(connection), |
| 113 | expected_precedence_( |
| 114 | spdy::SpdyStreamPrecedence(QuicStream::kDefaultPriority)) {} |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 115 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 116 | void UpdateStreamPriority( |
| 117 | QuicStreamId id, |
| 118 | const spdy::SpdyStreamPrecedence& precedence) override { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 119 | EXPECT_EQ(id, expected_stream_->id()); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 120 | EXPECT_EQ(expected_precedence_, precedence); |
| 121 | EXPECT_EQ(expected_precedence_, expected_stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 122 | } |
| 123 | |
| 124 | void SetExpectedStream(QuicSpdyStream* stream) { expected_stream_ = stream; } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 125 | void SetExpectedPriority(const spdy::SpdyStreamPrecedence& precedence) { |
| 126 | expected_precedence_ = precedence; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 127 | } |
| 128 | |
| 129 | private: |
| 130 | QuicSpdyStream* expected_stream_; |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 131 | spdy::SpdyStreamPrecedence expected_precedence_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 132 | }; |
| 133 | |
| 134 | class QuicSpdyStreamTest : public QuicTestWithParam<ParsedQuicVersion> { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 135 | protected: |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 136 | QuicSpdyStreamTest() { |
| 137 | headers_[":host"] = "www.google.com"; |
| 138 | headers_[":path"] = "/index.hml"; |
| 139 | headers_[":scheme"] = "https"; |
| 140 | headers_["cookie"] = |
| 141 | "__utma=208381060.1228362404.1372200928.1372200928.1372200928.1; " |
| 142 | "__utmc=160408618; " |
| 143 | "GX=DQAAAOEAAACWJYdewdE9rIrW6qw3PtVi2-d729qaa-74KqOsM1NVQblK4VhX" |
| 144 | "hoALMsy6HOdDad2Sz0flUByv7etmo3mLMidGrBoljqO9hSVA40SLqpG_iuKKSHX" |
| 145 | "RW3Np4bq0F0SDGDNsW0DSmTS9ufMRrlpARJDS7qAI6M3bghqJp4eABKZiRqebHT" |
| 146 | "pMU-RXvTI5D5oCF1vYxYofH_l1Kviuiy3oQ1kS1enqWgbhJ2t61_SNdv-1XJIS0" |
| 147 | "O3YeHLmVCs62O6zp89QwakfAWK9d3IDQvVSJzCQsvxvNIvaZFa567MawWlXg0Rh" |
| 148 | "1zFMi5vzcns38-8_Sns; " |
| 149 | "GA=v*2%2Fmem*57968640*47239936%2Fmem*57968640*47114716%2Fno-nm-" |
| 150 | "yj*15%2Fno-cc-yj*5%2Fpc-ch*133685%2Fpc-s-cr*133947%2Fpc-s-t*1339" |
| 151 | "47%2Fno-nm-yj*4%2Fno-cc-yj*1%2Fceft-as*1%2Fceft-nqas*0%2Fad-ra-c" |
| 152 | "v_p%2Fad-nr-cv_p-f*1%2Fad-v-cv_p*859%2Fad-ns-cv_p-f*1%2Ffn-v-ad%" |
| 153 | "2Fpc-t*250%2Fpc-cm*461%2Fpc-s-cr*722%2Fpc-s-t*722%2Fau_p*4" |
| 154 | "SICAID=AJKiYcHdKgxum7KMXG0ei2t1-W4OD1uW-ecNsCqC0wDuAXiDGIcT_HA2o1" |
| 155 | "3Rs1UKCuBAF9g8rWNOFbxt8PSNSHFuIhOo2t6bJAVpCsMU5Laa6lewuTMYI8MzdQP" |
| 156 | "ARHKyW-koxuhMZHUnGBJAM1gJODe0cATO_KGoX4pbbFxxJ5IicRxOrWK_5rU3cdy6" |
| 157 | "edlR9FsEdH6iujMcHkbE5l18ehJDwTWmBKBzVD87naobhMMrF6VvnDGxQVGp9Ir_b" |
| 158 | "Rgj3RWUoPumQVCxtSOBdX0GlJOEcDTNCzQIm9BSfetog_eP_TfYubKudt5eMsXmN6" |
| 159 | "QnyXHeGeK2UINUzJ-D30AFcpqYgH9_1BvYSpi7fc7_ydBU8TaD8ZRxvtnzXqj0RfG" |
| 160 | "tuHghmv3aD-uzSYJ75XDdzKdizZ86IG6Fbn1XFhYZM-fbHhm3mVEXnyRW4ZuNOLFk" |
| 161 | "Fas6LMcVC6Q8QLlHYbXBpdNFuGbuZGUnav5C-2I_-46lL0NGg3GewxGKGHvHEfoyn" |
| 162 | "EFFlEYHsBQ98rXImL8ySDycdLEFvBPdtctPmWCfTxwmoSMLHU2SCVDhbqMWU5b0yr" |
| 163 | "JBCScs_ejbKaqBDoB7ZGxTvqlrB__2ZmnHHjCr8RgMRtKNtIeuZAo "; |
| 164 | } |
| 165 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 166 | ~QuicSpdyStreamTest() override = default; |
| 167 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 168 | // Return QPACK-encoded header block without using the dynamic table. |
| 169 | std::string EncodeQpackHeaders( |
| 170 | std::vector<std::pair<QuicStringPiece, QuicStringPiece>> headers) { |
| 171 | SpdyHeaderBlock header_block; |
| 172 | for (const auto& header_field : headers) { |
| 173 | header_block.AppendValueOrAddHeader(header_field.first, |
| 174 | header_field.second); |
| 175 | } |
| 176 | |
| 177 | return EncodeQpackHeaders(header_block); |
| 178 | } |
| 179 | |
| 180 | // Return QPACK-encoded header block without using the dynamic table. |
| 181 | std::string EncodeQpackHeaders(const SpdyHeaderBlock& header) { |
renjietang | c2aa5cb | 2019-06-20 12:22:53 -0700 | [diff] [blame] | 182 | NoopQpackStreamSenderDelegate encoder_stream_sender_delegate; |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 183 | auto qpack_encoder = std::make_unique<QpackEncoder>(session_.get()); |
renjietang | 8a2df8f | 2019-08-07 10:43:52 -0700 | [diff] [blame] | 184 | qpack_encoder->set_qpack_stream_sender_delegate( |
| 185 | &encoder_stream_sender_delegate); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 186 | // QpackEncoder does not use the dynamic table by default, |
| 187 | // therefore the value of |stream_id| does not matter. |
bnc | 609c24e | 2019-09-10 05:24:32 -0700 | [diff] [blame] | 188 | return qpack_encoder->EncodeHeaderList(/* stream_id = */ 0, header, |
| 189 | nullptr); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 190 | } |
| 191 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 192 | void Initialize(bool stream_should_process_data) { |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 193 | InitializeWithPerspective(stream_should_process_data, |
| 194 | Perspective::IS_SERVER); |
| 195 | } |
| 196 | |
| 197 | void InitializeWithPerspective(bool stream_should_process_data, |
| 198 | Perspective perspective) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 199 | connection_ = new StrictMock<MockQuicConnection>( |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 200 | &helper_, &alarm_factory_, perspective, SupportedVersions(GetParam())); |
vasilvv | 0fc587f | 2019-09-06 13:33:08 -0700 | [diff] [blame] | 201 | session_ = std::make_unique<StrictMock<MockQuicSpdySession>>(connection_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 202 | session_->Initialize(); |
| 203 | ON_CALL(*session_, WritevData(_, _, _, _, _)) |
| 204 | .WillByDefault(Invoke(MockQuicSession::ConsumeData)); |
| 205 | |
| 206 | stream_ = |
| 207 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(0), |
| 208 | session_.get(), stream_should_process_data); |
| 209 | session_->ActivateStream(QuicWrapUnique(stream_)); |
| 210 | stream2_ = |
| 211 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalId(1), |
| 212 | session_.get(), stream_should_process_data); |
| 213 | session_->ActivateStream(QuicWrapUnique(stream2_)); |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 214 | QuicConfigPeer::SetReceivedInitialSessionFlowControlWindow( |
| 215 | session_->config(), kMinimumFlowControlSendWindow); |
dschinazi | 18cdf13 | 2019-10-09 16:08:18 -0700 | [diff] [blame] | 216 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesUnidirectional( |
| 217 | session_->config(), kMinimumFlowControlSendWindow); |
| 218 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesIncomingBidirectional( |
| 219 | session_->config(), kMinimumFlowControlSendWindow); |
| 220 | QuicConfigPeer::SetReceivedInitialMaxStreamDataBytesOutgoingBidirectional( |
| 221 | session_->config(), kMinimumFlowControlSendWindow); |
renjietang | bb2e22a | 2019-09-12 15:46:39 -0700 | [diff] [blame] | 222 | QuicConfigPeer::SetReceivedMaxIncomingUnidirectionalStreams( |
| 223 | session_->config(), 10); |
| 224 | session_->OnConfigNegotiated(); |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 225 | EXPECT_CALL(*connection_, OnCanWrite()); |
| 226 | if (UsesHttp3()) { |
| 227 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 228 | // Six writes include priority for headers, headers frame header, headers |
| 229 | // frame, priority of trailers, trailing headers frame header, and |
| 230 | // trailers. |
| 231 | auto send_control_stream = |
| 232 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
| 233 | // The control stream will write 3 times, including stream type, settings |
| 234 | // frame, priority for headers. |
| 235 | EXPECT_CALL(*session_, WritevData(send_control_stream, |
| 236 | send_control_stream->id(), _, _, _)) |
| 237 | .Times(2); |
| 238 | auto qpack_encoder_stream = |
| 239 | QuicSpdySessionPeer::GetQpackEncoderSendStream(session_.get()); |
| 240 | EXPECT_CALL(*session_, WritevData(qpack_encoder_stream, |
| 241 | qpack_encoder_stream->id(), 1, 0, _)); |
| 242 | auto qpack_decoder_stream = |
| 243 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 244 | EXPECT_CALL(*session_, WritevData(qpack_decoder_stream, |
| 245 | qpack_decoder_stream->id(), 1, 0, _)); |
| 246 | } |
| 247 | static_cast<QuicSession*>(session_.get()) |
| 248 | ->OnCryptoHandshakeEvent(QuicSession::ENCRYPTION_ESTABLISHED); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 249 | } |
| 250 | |
| 251 | QuicHeaderList ProcessHeaders(bool fin, const SpdyHeaderBlock& headers) { |
| 252 | QuicHeaderList h = AsHeaderList(headers); |
| 253 | stream_->OnStreamHeaderList(fin, h.uncompressed_header_bytes(), h); |
| 254 | return h; |
| 255 | } |
| 256 | |
| 257 | QuicStreamId GetNthClientInitiatedBidirectionalId(int n) { |
| 258 | return GetNthClientInitiatedBidirectionalStreamId( |
| 259 | connection_->transport_version(), n); |
| 260 | } |
| 261 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 262 | bool UsesHttp3() const { |
| 263 | return VersionUsesHttp3(GetParam().transport_version); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 264 | } |
| 265 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 266 | // Construct HEADERS frame with QPACK-encoded |headers| without using the |
| 267 | // dynamic table. |
| 268 | std::string HeadersFrame( |
| 269 | std::vector<std::pair<QuicStringPiece, QuicStringPiece>> headers) { |
| 270 | return HeadersFrame(EncodeQpackHeaders(headers)); |
| 271 | } |
| 272 | |
| 273 | // Construct HEADERS frame with QPACK-encoded |headers| without using the |
| 274 | // dynamic table. |
| 275 | std::string HeadersFrame(const SpdyHeaderBlock& headers) { |
| 276 | return HeadersFrame(EncodeQpackHeaders(headers)); |
| 277 | } |
| 278 | |
| 279 | // Construct HEADERS frame with given payload. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 280 | std::string HeadersFrame(QuicStringPiece payload) { |
| 281 | std::unique_ptr<char[]> headers_buffer; |
| 282 | QuicByteCount headers_frame_header_length = |
| 283 | encoder_.SerializeHeadersFrameHeader(payload.length(), &headers_buffer); |
| 284 | QuicStringPiece headers_frame_header(headers_buffer.get(), |
| 285 | headers_frame_header_length); |
| 286 | return QuicStrCat(headers_frame_header, payload); |
| 287 | } |
| 288 | |
| 289 | std::string DataFrame(QuicStringPiece payload) { |
| 290 | std::unique_ptr<char[]> data_buffer; |
| 291 | QuicByteCount data_frame_header_length = |
| 292 | encoder_.SerializeDataFrameHeader(payload.length(), &data_buffer); |
| 293 | QuicStringPiece data_frame_header(data_buffer.get(), |
| 294 | data_frame_header_length); |
| 295 | return QuicStrCat(data_frame_header, payload); |
| 296 | } |
| 297 | |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 298 | std::string UnknownFrame(uint64_t frame_type, QuicStringPiece payload) { |
| 299 | std::string frame; |
| 300 | const size_t length = QuicDataWriter::GetVarInt62Len(frame_type) + |
| 301 | QuicDataWriter::GetVarInt62Len(payload.size()) + |
| 302 | payload.size(); |
| 303 | frame.resize(length); |
| 304 | |
fayang | f0041ed | 2019-07-31 02:39:45 -0700 | [diff] [blame] | 305 | QuicDataWriter writer(length, const_cast<char*>(frame.data())); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 306 | writer.WriteVarInt62(frame_type); |
| 307 | writer.WriteStringPieceVarInt62(payload); |
| 308 | // Even though integers can be encoded with different lengths, |
| 309 | // QuicDataWriter is expected to produce an encoding in Write*() of length |
| 310 | // promised in GetVarInt62Len(). |
| 311 | DCHECK_EQ(length, writer.length()); |
| 312 | |
| 313 | return frame; |
| 314 | } |
| 315 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 316 | MockQuicConnectionHelper helper_; |
| 317 | MockAlarmFactory alarm_factory_; |
| 318 | MockQuicConnection* connection_; |
| 319 | std::unique_ptr<MockQuicSpdySession> session_; |
| 320 | |
| 321 | // Owned by the |session_|. |
| 322 | TestStream* stream_; |
| 323 | TestStream* stream2_; |
| 324 | |
| 325 | SpdyHeaderBlock headers_; |
| 326 | |
| 327 | HttpEncoder encoder_; |
| 328 | }; |
| 329 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 330 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 331 | QuicSpdyStreamTest, |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 332 | ::testing::ValuesIn(AllSupportedVersions()), |
| 333 | ::testing::PrintToStringParamName()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 334 | |
| 335 | TEST_P(QuicSpdyStreamTest, ProcessHeaderList) { |
| 336 | Initialize(kShouldProcessData); |
| 337 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 338 | stream_->OnStreamHeadersPriority( |
| 339 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 340 | ProcessHeaders(false, headers_); |
| 341 | EXPECT_EQ("", stream_->data()); |
| 342 | EXPECT_FALSE(stream_->header_list().empty()); |
| 343 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 344 | } |
| 345 | |
| 346 | TEST_P(QuicSpdyStreamTest, ProcessTooLargeHeaderList) { |
| 347 | Initialize(kShouldProcessData); |
| 348 | |
| 349 | QuicHeaderList headers; |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 350 | stream_->OnStreamHeadersPriority( |
| 351 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 352 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 353 | const bool version_uses_qpack = |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 354 | VersionUsesHttp3(GetParam().transport_version); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 355 | |
| 356 | if (version_uses_qpack) { |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 357 | EXPECT_CALL( |
| 358 | *connection_, |
dschinazi | 7ae3d60 | 2019-06-19 11:04:29 -0700 | [diff] [blame] | 359 | CloseConnection( |
| 360 | QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 361 | MatchesRegex("Too large headers received on stream \\d+"), _)); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 362 | } else { |
| 363 | EXPECT_CALL(*session_, |
| 364 | SendRstStream(stream_->id(), QUIC_HEADERS_TOO_LARGE, 0)); |
| 365 | } |
| 366 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 367 | stream_->OnStreamHeaderList(false, 1 << 20, headers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 368 | |
| 369 | if (!version_uses_qpack) { |
| 370 | EXPECT_EQ(QUIC_HEADERS_TOO_LARGE, stream_->stream_error()); |
| 371 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 372 | } |
| 373 | |
| 374 | TEST_P(QuicSpdyStreamTest, ProcessHeaderListWithFin) { |
| 375 | Initialize(kShouldProcessData); |
| 376 | |
| 377 | size_t total_bytes = 0; |
| 378 | QuicHeaderList headers; |
| 379 | for (auto p : headers_) { |
| 380 | headers.OnHeader(p.first, p.second); |
| 381 | total_bytes += p.first.size() + p.second.size(); |
| 382 | } |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 383 | stream_->OnStreamHeadersPriority( |
| 384 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 385 | stream_->OnStreamHeaderList(true, total_bytes, headers); |
| 386 | EXPECT_EQ("", stream_->data()); |
| 387 | EXPECT_FALSE(stream_->header_list().empty()); |
| 388 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 389 | EXPECT_TRUE(stream_->HasFinalReceivedByteOffset()); |
| 390 | } |
| 391 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 392 | // A valid status code should be 3-digit integer. The first digit should be in |
| 393 | // the range of [1, 5]. All the others are invalid. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 394 | TEST_P(QuicSpdyStreamTest, ParseHeaderStatusCode) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 395 | Initialize(kShouldProcessData); |
| 396 | int status_code = 0; |
| 397 | |
| 398 | // Valid status codes. |
| 399 | headers_[":status"] = "404"; |
| 400 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 401 | EXPECT_EQ(404, status_code); |
| 402 | |
| 403 | headers_[":status"] = "100"; |
| 404 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 405 | EXPECT_EQ(100, status_code); |
| 406 | |
| 407 | headers_[":status"] = "599"; |
| 408 | EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 409 | EXPECT_EQ(599, status_code); |
| 410 | |
| 411 | // Invalid status codes. |
| 412 | headers_[":status"] = "010"; |
| 413 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 414 | |
| 415 | headers_[":status"] = "600"; |
| 416 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 417 | |
| 418 | headers_[":status"] = "200 ok"; |
| 419 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 420 | |
| 421 | headers_[":status"] = "2000"; |
| 422 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 423 | |
| 424 | headers_[":status"] = "+200"; |
| 425 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 426 | |
| 427 | headers_[":status"] = "+20"; |
| 428 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 429 | |
| 430 | headers_[":status"] = "-10"; |
| 431 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 432 | |
| 433 | headers_[":status"] = "-100"; |
| 434 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 435 | |
| 436 | // Leading or trailing spaces are also invalid. |
| 437 | headers_[":status"] = " 200"; |
| 438 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 439 | |
| 440 | headers_[":status"] = "200 "; |
| 441 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 442 | |
| 443 | headers_[":status"] = " 200 "; |
| 444 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 445 | |
| 446 | headers_[":status"] = " "; |
| 447 | EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code)); |
| 448 | } |
| 449 | |
| 450 | TEST_P(QuicSpdyStreamTest, MarkHeadersConsumed) { |
| 451 | Initialize(kShouldProcessData); |
| 452 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 453 | std::string body = "this is the body"; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 454 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 455 | EXPECT_EQ(headers, stream_->header_list()); |
| 456 | |
| 457 | stream_->ConsumeHeaderList(); |
| 458 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 459 | } |
| 460 | |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 461 | TEST_P(QuicSpdyStreamTest, ProcessWrongFramesOnSpdyStream) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 462 | if (!UsesHttp3()) { |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 463 | return; |
| 464 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 465 | |
| 466 | testing::InSequence s; |
| 467 | Initialize(kShouldProcessData); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 468 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 469 | GoAwayFrame goaway; |
| 470 | goaway.stream_id = 0x1; |
| 471 | std::unique_ptr<char[]> buffer; |
| 472 | QuicByteCount header_length = encoder_.SerializeGoAwayFrame(goaway, &buffer); |
| 473 | std::string data = std::string(buffer.get(), header_length); |
| 474 | |
| 475 | EXPECT_EQ("", stream_->data()); |
| 476 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 477 | EXPECT_EQ(headers, stream_->header_list()); |
| 478 | stream_->ConsumeHeaderList(); |
| 479 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 480 | QuicStringPiece(data)); |
| 481 | |
| 482 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_DECODER_ERROR, _, _)) |
| 483 | .WillOnce( |
| 484 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 485 | ConnectionCloseBehavior connection_close_behavior) { |
| 486 | connection_->ReallyCloseConnection(error, error_details, |
| 487 | connection_close_behavior); |
| 488 | }))); |
ianswett | dc1e7ab | 2019-05-03 16:10:44 -0700 | [diff] [blame] | 489 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 490 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 491 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 492 | ConnectionCloseSource source) { |
| 493 | session_->ReallyOnConnectionClosed(frame, source); |
| 494 | })); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 495 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 496 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 497 | |
| 498 | stream_->OnStreamFrame(frame); |
| 499 | } |
| 500 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 501 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBody) { |
| 502 | Initialize(kShouldProcessData); |
| 503 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 504 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 505 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 506 | |
| 507 | EXPECT_EQ("", stream_->data()); |
| 508 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 509 | EXPECT_EQ(headers, stream_->header_list()); |
| 510 | stream_->ConsumeHeaderList(); |
| 511 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 512 | QuicStringPiece(data)); |
| 513 | stream_->OnStreamFrame(frame); |
| 514 | EXPECT_EQ(QuicHeaderList(), stream_->header_list()); |
| 515 | EXPECT_EQ(body, stream_->data()); |
| 516 | } |
| 517 | |
| 518 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragments) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 519 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 520 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 521 | |
| 522 | for (size_t fragment_size = 1; fragment_size < data.size(); ++fragment_size) { |
| 523 | Initialize(kShouldProcessData); |
| 524 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 525 | ASSERT_EQ(headers, stream_->header_list()); |
| 526 | stream_->ConsumeHeaderList(); |
| 527 | for (size_t offset = 0; offset < data.size(); offset += fragment_size) { |
| 528 | size_t remaining_data = data.size() - offset; |
| 529 | QuicStringPiece fragment(data.data() + offset, |
| 530 | std::min(fragment_size, remaining_data)); |
| 531 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, |
| 532 | offset, QuicStringPiece(fragment)); |
| 533 | stream_->OnStreamFrame(frame); |
| 534 | } |
| 535 | ASSERT_EQ(body, stream_->data()) << "fragment_size: " << fragment_size; |
| 536 | } |
| 537 | } |
| 538 | |
| 539 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyFragmentsSplit) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 540 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 541 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 542 | |
| 543 | for (size_t split_point = 1; split_point < data.size() - 1; ++split_point) { |
| 544 | Initialize(kShouldProcessData); |
| 545 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 546 | ASSERT_EQ(headers, stream_->header_list()); |
| 547 | stream_->ConsumeHeaderList(); |
| 548 | |
| 549 | QuicStringPiece fragment1(data.data(), split_point); |
| 550 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 551 | QuicStringPiece(fragment1)); |
| 552 | stream_->OnStreamFrame(frame1); |
| 553 | |
| 554 | QuicStringPiece fragment2(data.data() + split_point, |
| 555 | data.size() - split_point); |
| 556 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 557 | split_point, QuicStringPiece(fragment2)); |
| 558 | stream_->OnStreamFrame(frame2); |
| 559 | |
| 560 | ASSERT_EQ(body, stream_->data()) << "split_point: " << split_point; |
| 561 | } |
| 562 | } |
| 563 | |
| 564 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyReadv) { |
| 565 | Initialize(!kShouldProcessData); |
| 566 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 567 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 568 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 569 | |
| 570 | ProcessHeaders(false, headers_); |
| 571 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 572 | QuicStringPiece(data)); |
| 573 | stream_->OnStreamFrame(frame); |
| 574 | stream_->ConsumeHeaderList(); |
| 575 | |
| 576 | char buffer[2048]; |
| 577 | ASSERT_LT(data.length(), QUIC_ARRAYSIZE(buffer)); |
| 578 | struct iovec vec; |
| 579 | vec.iov_base = buffer; |
| 580 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 581 | |
| 582 | size_t bytes_read = stream_->Readv(&vec, 1); |
QUICHE team | 396d109 | 2019-03-20 10:21:07 -0700 | [diff] [blame] | 583 | QuicStreamPeer::CloseReadSide(stream_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 584 | EXPECT_EQ(body.length(), bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 585 | EXPECT_EQ(body, std::string(buffer, bytes_read)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 586 | } |
| 587 | |
| 588 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndLargeBodySmallReadv) { |
| 589 | Initialize(kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 590 | std::string body(12 * 1024, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 591 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 592 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 593 | ProcessHeaders(false, headers_); |
| 594 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 595 | QuicStringPiece(data)); |
| 596 | stream_->OnStreamFrame(frame); |
| 597 | stream_->ConsumeHeaderList(); |
| 598 | char buffer[2048]; |
| 599 | char buffer2[2048]; |
| 600 | struct iovec vec[2]; |
| 601 | vec[0].iov_base = buffer; |
| 602 | vec[0].iov_len = QUIC_ARRAYSIZE(buffer); |
| 603 | vec[1].iov_base = buffer2; |
| 604 | vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); |
| 605 | size_t bytes_read = stream_->Readv(vec, 2); |
| 606 | EXPECT_EQ(2048u * 2, bytes_read); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 607 | EXPECT_EQ(body.substr(0, 2048), std::string(buffer, 2048)); |
| 608 | EXPECT_EQ(body.substr(2048, 2048), std::string(buffer2, 2048)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 609 | } |
| 610 | |
| 611 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyMarkConsumed) { |
| 612 | Initialize(!kShouldProcessData); |
| 613 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 614 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 615 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 616 | |
| 617 | ProcessHeaders(false, headers_); |
| 618 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 619 | QuicStringPiece(data)); |
| 620 | stream_->OnStreamFrame(frame); |
| 621 | stream_->ConsumeHeaderList(); |
| 622 | |
| 623 | struct iovec vec; |
| 624 | |
| 625 | EXPECT_EQ(1, stream_->GetReadableRegions(&vec, 1)); |
| 626 | EXPECT_EQ(body.length(), vec.iov_len); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 627 | EXPECT_EQ(body, std::string(static_cast<char*>(vec.iov_base), vec.iov_len)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 628 | |
| 629 | stream_->MarkConsumed(body.length()); |
| 630 | EXPECT_EQ(data.length(), stream_->flow_controller()->bytes_consumed()); |
| 631 | } |
| 632 | |
| 633 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndConsumeMultipleBody) { |
| 634 | Initialize(!kShouldProcessData); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 635 | std::string body1 = "this is body 1"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 636 | std::string data1 = UsesHttp3() ? DataFrame(body1) : body1; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 637 | std::string body2 = "body 2"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 638 | std::string data2 = UsesHttp3() ? DataFrame(body2) : body2; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 639 | |
| 640 | ProcessHeaders(false, headers_); |
| 641 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 642 | QuicStringPiece(data1)); |
| 643 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 644 | data1.length(), QuicStringPiece(data2)); |
| 645 | stream_->OnStreamFrame(frame1); |
| 646 | stream_->OnStreamFrame(frame2); |
| 647 | stream_->ConsumeHeaderList(); |
| 648 | |
| 649 | stream_->MarkConsumed(body1.length() + body2.length()); |
| 650 | EXPECT_EQ(data1.length() + data2.length(), |
| 651 | stream_->flow_controller()->bytes_consumed()); |
| 652 | } |
| 653 | |
| 654 | TEST_P(QuicSpdyStreamTest, ProcessHeadersAndBodyIncrementalReadv) { |
| 655 | Initialize(!kShouldProcessData); |
| 656 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 657 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 658 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 659 | |
| 660 | ProcessHeaders(false, headers_); |
| 661 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 662 | QuicStringPiece(data)); |
| 663 | stream_->OnStreamFrame(frame); |
| 664 | stream_->ConsumeHeaderList(); |
| 665 | |
| 666 | char buffer[1]; |
| 667 | struct iovec vec; |
| 668 | vec.iov_base = buffer; |
| 669 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 670 | |
| 671 | for (size_t i = 0; i < body.length(); ++i) { |
| 672 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 673 | ASSERT_EQ(1u, bytes_read); |
| 674 | EXPECT_EQ(body.data()[i], buffer[0]); |
| 675 | } |
| 676 | } |
| 677 | |
| 678 | TEST_P(QuicSpdyStreamTest, ProcessHeadersUsingReadvWithMultipleIovecs) { |
| 679 | Initialize(!kShouldProcessData); |
| 680 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 681 | std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 682 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 683 | |
| 684 | ProcessHeaders(false, headers_); |
| 685 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 686 | QuicStringPiece(data)); |
| 687 | stream_->OnStreamFrame(frame); |
| 688 | stream_->ConsumeHeaderList(); |
| 689 | |
| 690 | char buffer1[1]; |
| 691 | char buffer2[1]; |
| 692 | struct iovec vec[2]; |
| 693 | vec[0].iov_base = buffer1; |
| 694 | vec[0].iov_len = QUIC_ARRAYSIZE(buffer1); |
| 695 | vec[1].iov_base = buffer2; |
| 696 | vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); |
| 697 | |
| 698 | for (size_t i = 0; i < body.length(); i += 2) { |
| 699 | size_t bytes_read = stream_->Readv(vec, 2); |
| 700 | ASSERT_EQ(2u, bytes_read) << i; |
| 701 | ASSERT_EQ(body.data()[i], buffer1[0]) << i; |
| 702 | ASSERT_EQ(body.data()[i + 1], buffer2[0]) << i; |
| 703 | } |
| 704 | } |
| 705 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 706 | // Tests that we send a BLOCKED frame to the peer when we attempt to write, but |
| 707 | // are flow control blocked. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 708 | TEST_P(QuicSpdyStreamTest, StreamFlowControlBlocked) { |
| 709 | testing::InSequence seq; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 710 | Initialize(kShouldProcessData); |
| 711 | |
| 712 | // Set a small flow control limit. |
| 713 | const uint64_t kWindow = 36; |
| 714 | QuicFlowControllerPeer::SetSendWindowOffset(stream_->flow_controller(), |
| 715 | kWindow); |
| 716 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::SendWindowOffset( |
| 717 | stream_->flow_controller())); |
| 718 | |
| 719 | // Try to send more data than the flow control limit allows. |
| 720 | const uint64_t kOverflow = 15; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 721 | std::string body(kWindow + kOverflow, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 722 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 723 | const uint64_t kHeaderLength = UsesHttp3() ? 2 : 0; |
| 724 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 725 | EXPECT_CALL(*session_, WritevData(_, _, kHeaderLength, _, NO_FIN)); |
| 726 | } |
| 727 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)) |
| 728 | .WillOnce(Return(QuicConsumedData(kWindow - kHeaderLength, true))); |
| 729 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 730 | stream_->WriteOrBufferBody(body, false); |
| 731 | |
| 732 | // Should have sent as much as possible, resulting in no send window left. |
| 733 | EXPECT_EQ(0u, |
| 734 | QuicFlowControllerPeer::SendWindowSize(stream_->flow_controller())); |
| 735 | |
| 736 | // And we should have queued the overflowed data. |
bnc | c7d9e0c | 2019-04-16 10:22:15 -0700 | [diff] [blame] | 737 | EXPECT_EQ(kOverflow + kHeaderLength, stream_->BufferedDataBytes()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 738 | } |
| 739 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 740 | // The flow control receive window decreases whenever we add new bytes to the |
| 741 | // sequencer, whether they are consumed immediately or buffered. However we only |
| 742 | // send WINDOW_UPDATE frames based on increasing number of bytes consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 743 | TEST_P(QuicSpdyStreamTest, StreamFlowControlNoWindowUpdateIfNotConsumed) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 744 | // Don't process data - it will be buffered instead. |
| 745 | Initialize(!kShouldProcessData); |
| 746 | |
| 747 | // Expect no WINDOW_UPDATE frames to be sent. |
| 748 | EXPECT_CALL(*connection_, SendWindowUpdate(_, _)).Times(0); |
| 749 | |
| 750 | // Set a small flow control receive window. |
| 751 | const uint64_t kWindow = 36; |
| 752 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 753 | kWindow); |
| 754 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 755 | kWindow); |
| 756 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 757 | stream_->flow_controller())); |
| 758 | |
| 759 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 760 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 761 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 762 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 763 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 764 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 765 | std::unique_ptr<char[]> buffer; |
| 766 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 767 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 768 | data = header + body; |
| 769 | } else { |
| 770 | data = body; |
| 771 | } |
| 772 | |
| 773 | ProcessHeaders(false, headers_); |
| 774 | |
| 775 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 776 | QuicStringPiece(data)); |
| 777 | stream_->OnStreamFrame(frame1); |
| 778 | EXPECT_EQ( |
| 779 | kWindow - (kWindow / 3) - header_length, |
| 780 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 781 | |
| 782 | // Now receive another frame which results in the receive window being over |
| 783 | // half full. This should all be buffered, decreasing the receive window but |
| 784 | // not sending WINDOW_UPDATE. |
| 785 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 786 | kWindow / 3 + header_length, QuicStringPiece(data)); |
| 787 | stream_->OnStreamFrame(frame2); |
| 788 | EXPECT_EQ( |
| 789 | kWindow - (2 * kWindow / 3) - 2 * header_length, |
| 790 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 791 | } |
| 792 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 793 | // Tests that on receipt of data, the stream updates its receive window offset |
| 794 | // appropriately, and sends WINDOW_UPDATE frames when its receive window drops |
| 795 | // too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 796 | TEST_P(QuicSpdyStreamTest, StreamFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 797 | Initialize(kShouldProcessData); |
| 798 | |
| 799 | // Set a small flow control limit. |
| 800 | const uint64_t kWindow = 36; |
| 801 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 802 | kWindow); |
| 803 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 804 | kWindow); |
| 805 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 806 | stream_->flow_controller())); |
| 807 | |
| 808 | // Stream receives enough data to fill a fraction of the receive window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 809 | std::string body(kWindow / 3, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 810 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 811 | std::string data; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 812 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 813 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 814 | std::unique_ptr<char[]> buffer; |
| 815 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 816 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 817 | data = header + body; |
| 818 | } else { |
| 819 | data = body; |
| 820 | } |
| 821 | |
| 822 | ProcessHeaders(false, headers_); |
| 823 | stream_->ConsumeHeaderList(); |
| 824 | |
| 825 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 826 | QuicStringPiece(data)); |
| 827 | stream_->OnStreamFrame(frame1); |
| 828 | EXPECT_EQ( |
| 829 | kWindow - (kWindow / 3) - header_length, |
| 830 | QuicFlowControllerPeer::ReceiveWindowSize(stream_->flow_controller())); |
| 831 | |
| 832 | // Now receive another frame which results in the receive window being over |
| 833 | // half full. This will trigger the stream to increase its receive window |
| 834 | // offset and send a WINDOW_UPDATE. The result will be again an available |
| 835 | // window of kWindow bytes. |
| 836 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(0), false, |
| 837 | kWindow / 3 + header_length, QuicStringPiece(data)); |
| 838 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 839 | stream_->OnStreamFrame(frame2); |
| 840 | EXPECT_EQ(kWindow, QuicFlowControllerPeer::ReceiveWindowSize( |
| 841 | stream_->flow_controller())); |
| 842 | } |
| 843 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 844 | // Tests that on receipt of data, the connection updates its receive window |
| 845 | // offset appropriately, and sends WINDOW_UPDATE frames when its receive window |
| 846 | // drops too low. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 847 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlWindowUpdate) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 848 | Initialize(kShouldProcessData); |
| 849 | |
| 850 | // Set a small flow control limit for streams and connection. |
| 851 | const uint64_t kWindow = 36; |
| 852 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 853 | kWindow); |
| 854 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream_->flow_controller(), |
| 855 | kWindow); |
| 856 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream2_->flow_controller(), |
| 857 | kWindow); |
| 858 | QuicFlowControllerPeer::SetMaxReceiveWindow(stream2_->flow_controller(), |
| 859 | kWindow); |
| 860 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 861 | kWindow); |
| 862 | QuicFlowControllerPeer::SetMaxReceiveWindow(session_->flow_controller(), |
| 863 | kWindow); |
| 864 | |
| 865 | // Supply headers to both streams so that they are happy to receive data. |
| 866 | auto headers = AsHeaderList(headers_); |
| 867 | stream_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 868 | headers); |
| 869 | stream_->ConsumeHeaderList(); |
| 870 | stream2_->OnStreamHeaderList(false, headers.uncompressed_header_bytes(), |
| 871 | headers); |
| 872 | stream2_->ConsumeHeaderList(); |
| 873 | |
| 874 | // Each stream gets a quarter window of data. This should not trigger a |
| 875 | // WINDOW_UPDATE for either stream, nor for the connection. |
| 876 | QuicByteCount header_length = 0; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 877 | std::string body; |
| 878 | std::string data; |
| 879 | std::string data2; |
| 880 | std::string body2(1, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 881 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 882 | if (UsesHttp3()) { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 883 | body = std::string(kWindow / 4 - 2, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 884 | std::unique_ptr<char[]> buffer; |
| 885 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 886 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 887 | data = header + body; |
| 888 | std::unique_ptr<char[]> buffer2; |
| 889 | QuicByteCount header_length2 = |
| 890 | encoder_.SerializeDataFrameHeader(body2.length(), &buffer2); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 891 | std::string header2 = std::string(buffer2.get(), header_length2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 892 | data2 = header2 + body2; |
| 893 | } else { |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 894 | body = std::string(kWindow / 4, 'a'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 895 | data = body; |
| 896 | data2 = body2; |
| 897 | } |
| 898 | |
| 899 | QuicStreamFrame frame1(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 900 | QuicStringPiece(data)); |
| 901 | stream_->OnStreamFrame(frame1); |
| 902 | QuicStreamFrame frame2(GetNthClientInitiatedBidirectionalId(1), false, 0, |
| 903 | QuicStringPiece(data)); |
| 904 | stream2_->OnStreamFrame(frame2); |
| 905 | |
| 906 | // Now receive a further single byte on one stream - again this does not |
| 907 | // trigger a stream WINDOW_UPDATE, but now the connection flow control window |
| 908 | // is over half full and thus a connection WINDOW_UPDATE is sent. |
| 909 | EXPECT_CALL(*connection_, SendControlFrame(_)); |
| 910 | QuicStreamFrame frame3(GetNthClientInitiatedBidirectionalId(0), false, |
| 911 | body.length() + header_length, QuicStringPiece(data2)); |
| 912 | stream_->OnStreamFrame(frame3); |
| 913 | } |
| 914 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 915 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 916 | // protocol), then we terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 917 | TEST_P(QuicSpdyStreamTest, StreamFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 918 | // Stream should not process data, so that data gets buffered in the |
| 919 | // sequencer, triggering flow control limits. |
| 920 | Initialize(!kShouldProcessData); |
| 921 | |
| 922 | // Set a small flow control limit. |
| 923 | const uint64_t kWindow = 50; |
| 924 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 925 | kWindow); |
| 926 | |
| 927 | ProcessHeaders(false, headers_); |
| 928 | |
| 929 | // Receive data to overflow the window, violating flow control. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 930 | std::string body(kWindow + 1, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 931 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 932 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 933 | QuicStringPiece(data)); |
| 934 | EXPECT_CALL(*connection_, |
| 935 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 936 | stream_->OnStreamFrame(frame); |
| 937 | } |
| 938 | |
| 939 | TEST_P(QuicSpdyStreamTest, TestHandlingQuicRstStreamNoError) { |
| 940 | Initialize(kShouldProcessData); |
| 941 | ProcessHeaders(false, headers_); |
| 942 | |
| 943 | stream_->OnStreamReset(QuicRstStreamFrame( |
| 944 | kInvalidControlFrameId, stream_->id(), QUIC_STREAM_NO_ERROR, 0)); |
| 945 | EXPECT_TRUE(stream_->write_side_closed()); |
| 946 | EXPECT_FALSE(stream_->reading_stopped()); |
| 947 | } |
| 948 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 949 | // Tests that on if the peer sends too much data (i.e. violates the flow control |
| 950 | // protocol), at the connection level (rather than the stream level) then we |
| 951 | // terminate the connection. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 952 | TEST_P(QuicSpdyStreamTest, ConnectionFlowControlViolation) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 953 | // Stream should not process data, so that data gets buffered in the |
| 954 | // sequencer, triggering flow control limits. |
| 955 | Initialize(!kShouldProcessData); |
| 956 | |
| 957 | // Set a small flow control window on streams, and connection. |
| 958 | const uint64_t kStreamWindow = 50; |
| 959 | const uint64_t kConnectionWindow = 10; |
| 960 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), |
| 961 | kStreamWindow); |
| 962 | QuicFlowControllerPeer::SetReceiveWindowOffset(session_->flow_controller(), |
| 963 | kConnectionWindow); |
| 964 | |
| 965 | ProcessHeaders(false, headers_); |
| 966 | |
| 967 | // Send enough data to overflow the connection level flow control window. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 968 | std::string body(kConnectionWindow + 1, 'a'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 969 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 970 | |
| 971 | EXPECT_LT(data.size(), kStreamWindow); |
| 972 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), false, 0, |
| 973 | QuicStringPiece(data)); |
| 974 | |
| 975 | EXPECT_CALL(*connection_, |
| 976 | CloseConnection(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA, _, _)); |
| 977 | stream_->OnStreamFrame(frame); |
| 978 | } |
| 979 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 980 | // An attempt to write a FIN with no data should not be flow control blocked, |
| 981 | // even if the send window is 0. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 982 | TEST_P(QuicSpdyStreamTest, StreamFlowControlFinNotBlocked) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 983 | Initialize(kShouldProcessData); |
| 984 | |
| 985 | // Set a flow control limit of zero. |
| 986 | QuicFlowControllerPeer::SetReceiveWindowOffset(stream_->flow_controller(), 0); |
| 987 | EXPECT_EQ(0u, QuicFlowControllerPeer::ReceiveWindowOffset( |
| 988 | stream_->flow_controller())); |
| 989 | |
| 990 | // Send a frame with a FIN but no data. This should not be blocked. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 991 | std::string body = ""; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 992 | bool fin = true; |
| 993 | |
| 994 | EXPECT_CALL(*connection_, |
| 995 | SendBlocked(GetNthClientInitiatedBidirectionalId(0))) |
| 996 | .Times(0); |
| 997 | EXPECT_CALL(*session_, WritevData(_, _, 0, _, FIN)); |
| 998 | |
| 999 | stream_->WriteOrBufferBody(body, fin); |
| 1000 | } |
| 1001 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1002 | // Test that receiving trailing headers from the peer via OnStreamHeaderList() |
| 1003 | // works, and can be read from the stream and consumed. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1004 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersViaHeaderList) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1005 | Initialize(kShouldProcessData); |
| 1006 | |
| 1007 | // Receive initial headers. |
| 1008 | size_t total_bytes = 0; |
| 1009 | QuicHeaderList headers; |
| 1010 | for (const auto& p : headers_) { |
| 1011 | headers.OnHeader(p.first, p.second); |
| 1012 | total_bytes += p.first.size() + p.second.size(); |
| 1013 | } |
| 1014 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1015 | stream_->OnStreamHeadersPriority( |
| 1016 | spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1017 | stream_->OnStreamHeaderList(/*fin=*/false, total_bytes, headers); |
| 1018 | stream_->ConsumeHeaderList(); |
| 1019 | |
| 1020 | // Receive trailing headers. |
| 1021 | SpdyHeaderBlock trailers_block; |
| 1022 | trailers_block["key1"] = "value1"; |
| 1023 | trailers_block["key2"] = "value2"; |
| 1024 | trailers_block["key3"] = "value3"; |
| 1025 | SpdyHeaderBlock trailers_block_with_final_offset = trailers_block.Clone(); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1026 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1027 | // :final-offset pseudo-header is only added if trailers are sent |
| 1028 | // on the headers stream. |
| 1029 | trailers_block_with_final_offset[kFinalOffsetHeaderKey] = "0"; |
| 1030 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1031 | total_bytes = 0; |
| 1032 | QuicHeaderList trailers; |
| 1033 | for (const auto& p : trailers_block_with_final_offset) { |
| 1034 | trailers.OnHeader(p.first, p.second); |
| 1035 | total_bytes += p.first.size() + p.second.size(); |
| 1036 | } |
| 1037 | stream_->OnStreamHeaderList(/*fin=*/true, total_bytes, trailers); |
| 1038 | |
| 1039 | // The trailers should be decompressed, and readable from the stream. |
| 1040 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1041 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1042 | |
| 1043 | // IsDoneReading() returns false until trailers marked consumed. |
| 1044 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 1045 | stream_->MarkTrailersConsumed(); |
| 1046 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1047 | } |
| 1048 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1049 | // Test that when receiving trailing headers with an offset before response |
| 1050 | // body, stream is closed at the right offset. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1051 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1052 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 1053 | // request/response stream. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1054 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1055 | return; |
| 1056 | } |
| 1057 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1058 | Initialize(kShouldProcessData); |
| 1059 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1060 | // Receive initial headers. |
| 1061 | QuicHeaderList headers = ProcessHeaders(false, headers_); |
| 1062 | stream_->ConsumeHeaderList(); |
| 1063 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1064 | const std::string body = "this is the body"; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1065 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1066 | |
| 1067 | // Receive trailing headers. |
| 1068 | SpdyHeaderBlock trailers_block; |
| 1069 | trailers_block["key1"] = "value1"; |
| 1070 | trailers_block["key2"] = "value2"; |
| 1071 | trailers_block["key3"] = "value3"; |
| 1072 | trailers_block[kFinalOffsetHeaderKey] = |
| 1073 | QuicTextUtils::Uint64ToString(data.size()); |
| 1074 | |
| 1075 | QuicHeaderList trailers = ProcessHeaders(true, trailers_block); |
| 1076 | |
| 1077 | // The trailers should be decompressed, and readable from the stream. |
| 1078 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1079 | |
| 1080 | // The final offset trailer will be consumed by QUIC. |
| 1081 | trailers_block.erase(kFinalOffsetHeaderKey); |
| 1082 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1083 | |
| 1084 | // Consuming the trailers erases them from the stream. |
| 1085 | stream_->MarkTrailersConsumed(); |
| 1086 | EXPECT_TRUE(stream_->FinishedReadingTrailers()); |
| 1087 | |
| 1088 | EXPECT_FALSE(stream_->IsDoneReading()); |
| 1089 | // Receive and consume body. |
| 1090 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/false, |
| 1091 | 0, data); |
| 1092 | stream_->OnStreamFrame(frame); |
| 1093 | EXPECT_EQ(body, stream_->data()); |
| 1094 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1095 | } |
| 1096 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1097 | // Test that receiving trailers without a final offset field is an error. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1098 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutOffset) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1099 | // kFinalOffsetHeaderKey is not used when HEADERS are sent on the |
| 1100 | // request/response stream. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1101 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1102 | return; |
| 1103 | } |
| 1104 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1105 | Initialize(kShouldProcessData); |
| 1106 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1107 | // Receive initial headers. |
| 1108 | ProcessHeaders(false, headers_); |
| 1109 | stream_->ConsumeHeaderList(); |
| 1110 | |
| 1111 | // Receive trailing headers, without kFinalOffsetHeaderKey. |
| 1112 | SpdyHeaderBlock trailers_block; |
| 1113 | trailers_block["key1"] = "value1"; |
| 1114 | trailers_block["key2"] = "value2"; |
| 1115 | trailers_block["key3"] = "value3"; |
| 1116 | auto trailers = AsHeaderList(trailers_block); |
| 1117 | |
| 1118 | // Verify that the trailers block didn't contain a final offset. |
| 1119 | EXPECT_EQ("", trailers_block[kFinalOffsetHeaderKey].as_string()); |
| 1120 | |
| 1121 | // Receipt of the malformed trailers will close the connection. |
| 1122 | EXPECT_CALL(*connection_, |
| 1123 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1124 | .Times(1); |
| 1125 | stream_->OnStreamHeaderList(/*fin=*/true, |
| 1126 | trailers.uncompressed_header_bytes(), trailers); |
| 1127 | } |
| 1128 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1129 | // Test that received Trailers must always have the FIN set. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1130 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersWithoutFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1131 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
| 1132 | // HEADERS frame. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1133 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1134 | return; |
| 1135 | } |
| 1136 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1137 | Initialize(kShouldProcessData); |
| 1138 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1139 | // Receive initial headers. |
| 1140 | auto headers = AsHeaderList(headers_); |
| 1141 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1142 | headers.uncompressed_header_bytes(), headers); |
| 1143 | stream_->ConsumeHeaderList(); |
| 1144 | |
| 1145 | // Receive trailing headers with FIN deliberately set to false. |
| 1146 | SpdyHeaderBlock trailers_block; |
| 1147 | trailers_block["foo"] = "bar"; |
| 1148 | auto trailers = AsHeaderList(trailers_block); |
| 1149 | |
| 1150 | EXPECT_CALL(*connection_, |
| 1151 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1152 | .Times(1); |
| 1153 | stream_->OnStreamHeaderList(/*fin=*/false, |
| 1154 | trailers.uncompressed_header_bytes(), trailers); |
| 1155 | } |
| 1156 | |
| 1157 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterHeadersWithFin) { |
| 1158 | // If headers are received with a FIN, no trailers should then arrive. |
| 1159 | Initialize(kShouldProcessData); |
| 1160 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1161 | // If HEADERS frames are sent on the request/response stream, then the |
| 1162 | // sequencer will signal an error if any stream data arrives after a FIN, |
| 1163 | // so QuicSpdyStream does not need to. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1164 | if (VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1165 | return; |
| 1166 | } |
| 1167 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1168 | // Receive initial headers with FIN set. |
| 1169 | ProcessHeaders(true, headers_); |
| 1170 | stream_->ConsumeHeaderList(); |
| 1171 | |
| 1172 | // Receive trailing headers after FIN already received. |
| 1173 | SpdyHeaderBlock trailers_block; |
| 1174 | trailers_block["foo"] = "bar"; |
| 1175 | EXPECT_CALL(*connection_, |
| 1176 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1177 | .Times(1); |
| 1178 | ProcessHeaders(true, trailers_block); |
| 1179 | } |
| 1180 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1181 | // If body data are received with a FIN, no trailers should then arrive. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1182 | TEST_P(QuicSpdyStreamTest, ReceivingTrailersAfterBodyWithFin) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1183 | // If HEADERS frames are sent on the request/response stream, |
| 1184 | // then the sequencer will block them from reaching QuicSpdyStream |
| 1185 | // after the stream is closed. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1186 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1187 | return; |
| 1188 | } |
| 1189 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1190 | Initialize(kShouldProcessData); |
| 1191 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1192 | // Receive initial headers without FIN set. |
| 1193 | ProcessHeaders(false, headers_); |
| 1194 | stream_->ConsumeHeaderList(); |
| 1195 | |
| 1196 | // Receive body data, with FIN. |
| 1197 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1198 | 0, "body"); |
| 1199 | stream_->OnStreamFrame(frame); |
| 1200 | |
| 1201 | // Receive trailing headers after FIN already received. |
| 1202 | SpdyHeaderBlock trailers_block; |
| 1203 | trailers_block["foo"] = "bar"; |
| 1204 | EXPECT_CALL(*connection_, |
| 1205 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 1206 | .Times(1); |
| 1207 | ProcessHeaders(true, trailers_block); |
| 1208 | } |
| 1209 | |
| 1210 | TEST_P(QuicSpdyStreamTest, ClosingStreamWithNoTrailers) { |
| 1211 | // Verify that a stream receiving headers, body, and no trailers is correctly |
| 1212 | // marked as done reading on consumption of headers and body. |
| 1213 | Initialize(kShouldProcessData); |
| 1214 | |
| 1215 | // Receive and consume initial headers with FIN not set. |
| 1216 | auto h = AsHeaderList(headers_); |
| 1217 | stream_->OnStreamHeaderList(/*fin=*/false, h.uncompressed_header_bytes(), h); |
| 1218 | stream_->ConsumeHeaderList(); |
| 1219 | |
| 1220 | // Receive and consume body with FIN set, and no trailers. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1221 | std::string body(1024, 'x'); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1222 | std::string data = UsesHttp3() ? DataFrame(body) : body; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1223 | |
| 1224 | QuicStreamFrame frame(GetNthClientInitiatedBidirectionalId(0), /*fin=*/true, |
| 1225 | 0, data); |
| 1226 | stream_->OnStreamFrame(frame); |
| 1227 | |
| 1228 | EXPECT_TRUE(stream_->IsDoneReading()); |
| 1229 | } |
| 1230 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1231 | // Test that writing trailers will send a FIN, as Trailers are the last thing to |
| 1232 | // be sent on a stream. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1233 | TEST_P(QuicSpdyStreamTest, WritingTrailersSendsAFin) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1234 | Initialize(kShouldProcessData); |
| 1235 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1236 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1237 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1238 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1239 | .Times(AtLeast(1)); |
| 1240 | } |
| 1241 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1242 | // Write the initial headers, without a FIN. |
| 1243 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1244 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1245 | |
| 1246 | // Writing trailers implicitly sends a FIN. |
| 1247 | SpdyHeaderBlock trailers; |
| 1248 | trailers["trailer key"] = "trailer value"; |
| 1249 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1250 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1251 | EXPECT_TRUE(stream_->fin_sent()); |
| 1252 | } |
| 1253 | |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1254 | TEST_P(QuicSpdyStreamTest, ClientWritesPriority) { |
renjietang | 6647f9e | 2019-09-17 11:11:17 -0700 | [diff] [blame] | 1255 | SetQuicFlag(FLAGS_quic_allow_http3_priority, true); |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1256 | InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT); |
| 1257 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1258 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1259 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1260 | // Six writes include priority for headers, headers frame header, headers |
| 1261 | // frame, priority of trailers, trailing headers frame header, and trailers. |
| 1262 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1263 | .Times(4); |
| 1264 | auto send_control_stream = |
| 1265 | QuicSpdySessionPeer::GetSendControlStream(session_.get()); |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 1266 | // The control stream will write priority for headers. |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1267 | EXPECT_CALL(*session_, WritevData(send_control_stream, |
| 1268 | send_control_stream->id(), _, _, _)) |
rch | ee32232 | 2019-10-11 14:56:03 -0700 | [diff] [blame] | 1269 | .Times(1); |
renjietang | 7498c8c | 2019-07-02 19:28:42 -0700 | [diff] [blame] | 1270 | } |
| 1271 | |
| 1272 | // Write the initial headers, without a FIN. |
| 1273 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1274 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1275 | |
| 1276 | // Writing trailers implicitly sends a FIN. |
| 1277 | SpdyHeaderBlock trailers; |
| 1278 | trailers["trailer key"] = "trailer value"; |
| 1279 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1280 | stream_->WriteTrailers(std::move(trailers), nullptr); |
| 1281 | EXPECT_TRUE(stream_->fin_sent()); |
| 1282 | } |
| 1283 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1284 | // Test that when writing trailers, the trailers that are actually sent to the |
| 1285 | // peer contain the final offset field indicating last byte of data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1286 | TEST_P(QuicSpdyStreamTest, WritingTrailersFinalOffset) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1287 | Initialize(kShouldProcessData); |
| 1288 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1289 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1290 | // In this case, TestStream::WriteHeadersImpl() does not prevent writes. |
| 1291 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1292 | .Times(AtLeast(1)); |
| 1293 | } |
| 1294 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1295 | // Write the initial headers. |
| 1296 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1297 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1298 | |
| 1299 | // Write non-zero body data to force a non-zero final offset. |
| 1300 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1301 | std::string body(1024, 'x'); // 1 kB |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1302 | QuicByteCount header_length = 0; |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1303 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1304 | std::unique_ptr<char[]> buf; |
| 1305 | header_length = encoder_.SerializeDataFrameHeader(body.length(), &buf); |
| 1306 | } |
| 1307 | |
| 1308 | stream_->WriteOrBufferBody(body, false); |
| 1309 | |
| 1310 | // The final offset field in the trailing headers is populated with the |
| 1311 | // number of body bytes written (including queued bytes). |
| 1312 | SpdyHeaderBlock trailers; |
| 1313 | trailers["trailer key"] = "trailer value"; |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1314 | |
| 1315 | SpdyHeaderBlock expected_trailers(trailers.Clone()); |
| 1316 | // :final-offset pseudo-header is only added if trailers are sent |
| 1317 | // on the headers stream. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1318 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1319 | expected_trailers[kFinalOffsetHeaderKey] = |
| 1320 | QuicTextUtils::Uint64ToString(body.length() + header_length); |
| 1321 | } |
| 1322 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1323 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1324 | stream_->WriteTrailers(std::move(trailers), nullptr); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1325 | EXPECT_EQ(expected_trailers, stream_->saved_headers()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1326 | } |
| 1327 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1328 | // Test that if trailers are written after all other data has been written |
| 1329 | // (headers and body), that this closes the stream for writing. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1330 | TEST_P(QuicSpdyStreamTest, WritingTrailersClosesWriteSide) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1331 | Initialize(kShouldProcessData); |
| 1332 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1333 | // Expect data being written on the stream. In addition to that, headers are |
| 1334 | // also written on the stream in case of IETF QUIC. |
| 1335 | EXPECT_CALL(*session_, WritevData(stream_, stream_->id(), _, _, _)) |
| 1336 | .Times(AtLeast(1)); |
| 1337 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1338 | // Write the initial headers. |
| 1339 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1340 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1341 | |
| 1342 | // Write non-zero body data. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1343 | const int kBodySize = 1 * 1024; // 1 kB |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1344 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1345 | EXPECT_EQ(0u, stream_->BufferedDataBytes()); |
| 1346 | |
| 1347 | // Headers and body have been fully written, there is no queued data. Writing |
| 1348 | // trailers marks the end of this stream, and thus the write side is closed. |
| 1349 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1350 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1351 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1352 | } |
| 1353 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1354 | // Test that the stream is not closed for writing when trailers are sent while |
| 1355 | // there are still body bytes queued. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1356 | TEST_P(QuicSpdyStreamTest, WritingTrailersWithQueuedBytes) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1357 | // This test exercises sending trailers on the headers stream while data is |
| 1358 | // still queued on the response/request stream. In IETF QUIC, data and |
| 1359 | // trailers are sent on the same stream, so this test does not apply. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1360 | if (VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1361 | return; |
| 1362 | } |
| 1363 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1364 | testing::InSequence seq; |
| 1365 | Initialize(kShouldProcessData); |
| 1366 | |
| 1367 | // Write the initial headers. |
| 1368 | EXPECT_CALL(*stream_, WriteHeadersMock(false)); |
| 1369 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/false, nullptr); |
| 1370 | |
| 1371 | // Write non-zero body data, but only consume partially, ensuring queueing. |
| 1372 | const int kBodySize = 1 * 1024; // 1 kB |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1373 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1374 | EXPECT_CALL(*session_, WritevData(_, _, 3, _, NO_FIN)); |
| 1375 | } |
| 1376 | EXPECT_CALL(*session_, WritevData(_, _, kBodySize, _, NO_FIN)) |
| 1377 | .WillOnce(Return(QuicConsumedData(kBodySize - 1, false))); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1378 | stream_->WriteOrBufferBody(std::string(kBodySize, 'x'), false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1379 | EXPECT_EQ(1u, stream_->BufferedDataBytes()); |
| 1380 | |
| 1381 | // Writing trailers will send a FIN, but not close the write side of the |
| 1382 | // stream as there are queued bytes. |
| 1383 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1384 | stream_->WriteTrailers(SpdyHeaderBlock(), nullptr); |
| 1385 | EXPECT_TRUE(stream_->fin_sent()); |
| 1386 | EXPECT_FALSE(stream_->write_side_closed()); |
| 1387 | |
| 1388 | // Writing the queued bytes will close the write side of the stream. |
| 1389 | EXPECT_CALL(*session_, WritevData(_, _, 1, _, NO_FIN)); |
| 1390 | stream_->OnCanWrite(); |
| 1391 | EXPECT_TRUE(stream_->write_side_closed()); |
| 1392 | } |
| 1393 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1394 | // Test that it is not possible to write Trailers after a FIN has been sent. |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1395 | TEST_P(QuicSpdyStreamTest, WritingTrailersAfterFIN) { |
| 1396 | // EXPECT_QUIC_BUG tests are expensive so only run one instance of them. |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1397 | // In IETF QUIC, there is no such thing as FIN flag on HTTP/3 frames like the |
| 1398 | // HEADERS frame. That is version 99, which is element 0 of the array, so |
| 1399 | // pick another element. |
| 1400 | if (GetParam() != AllSupportedVersions()[1]) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1401 | return; |
| 1402 | } |
| 1403 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1404 | Initialize(kShouldProcessData); |
| 1405 | |
| 1406 | // Write the initial headers, with a FIN. |
| 1407 | EXPECT_CALL(*stream_, WriteHeadersMock(true)); |
| 1408 | stream_->WriteHeaders(SpdyHeaderBlock(), /*fin=*/true, nullptr); |
| 1409 | EXPECT_TRUE(stream_->fin_sent()); |
| 1410 | |
| 1411 | // Writing Trailers should fail, as the FIN has already been sent. |
| 1412 | // populated with the number of body bytes written. |
| 1413 | EXPECT_QUIC_BUG(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr), |
| 1414 | "Trailers cannot be sent after a FIN"); |
| 1415 | } |
| 1416 | |
| 1417 | TEST_P(QuicSpdyStreamTest, HeaderStreamNotiferCorrespondingSpdyStream) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1418 | // There is no headers stream if QPACK is used. |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1419 | if (VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1420 | return; |
| 1421 | } |
| 1422 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1423 | const char kHeader1[] = "Header1"; |
| 1424 | const char kHeader2[] = "Header2"; |
| 1425 | const char kBody1[] = "Test1"; |
| 1426 | const char kBody2[] = "Test2"; |
| 1427 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1428 | Initialize(kShouldProcessData); |
| 1429 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1430 | testing::InSequence s; |
| 1431 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 1432 | new MockAckListener()); |
| 1433 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 1434 | new MockAckListener()); |
| 1435 | stream_->set_ack_listener(ack_listener1); |
| 1436 | stream2_->set_ack_listener(ack_listener2); |
| 1437 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1438 | session_->headers_stream()->WriteOrBufferData(kHeader1, false, ack_listener1); |
| 1439 | stream_->WriteOrBufferBody(kBody1, true); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1440 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1441 | session_->headers_stream()->WriteOrBufferData(kHeader2, false, ack_listener2); |
| 1442 | stream2_->WriteOrBufferBody(kBody2, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1443 | |
| 1444 | QuicStreamFrame frame1( |
| 1445 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 0, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1446 | kHeader1); |
| 1447 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1448 | std::string data1 = UsesHttp3() ? DataFrame(kBody1) : kBody1; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1449 | QuicStreamFrame frame2(stream_->id(), true, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1450 | QuicStreamFrame frame3( |
| 1451 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), false, 7, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1452 | kHeader2); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1453 | std::string data2 = UsesHttp3() ? DataFrame(kBody2) : kBody2; |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1454 | QuicStreamFrame frame4(stream2_->id(), false, 0, data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1455 | |
| 1456 | EXPECT_CALL(*ack_listener1, OnPacketRetransmitted(7)); |
| 1457 | session_->OnStreamFrameRetransmitted(frame1); |
| 1458 | |
| 1459 | EXPECT_CALL(*ack_listener1, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1460 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame1), QuicTime::Delta::Zero(), |
| 1461 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1462 | EXPECT_CALL(*ack_listener1, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1463 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1464 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1465 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1466 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1467 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1468 | EXPECT_CALL(*ack_listener2, OnPacketAcked(5, _)); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1469 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame4), QuicTime::Delta::Zero(), |
| 1470 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1471 | } |
| 1472 | |
| 1473 | TEST_P(QuicSpdyStreamTest, StreamBecomesZombieWithWriteThatCloses) { |
| 1474 | Initialize(kShouldProcessData); |
| 1475 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1476 | QuicStreamPeer::CloseReadSide(stream_); |
| 1477 | // This write causes stream to be closed. |
| 1478 | stream_->WriteOrBufferBody("Test1", true); |
| 1479 | // stream_ has unacked data and should become zombie. |
| 1480 | EXPECT_TRUE(QuicContainsKey(QuicSessionPeer::zombie_streams(session_.get()), |
| 1481 | stream_->id())); |
| 1482 | EXPECT_TRUE(QuicSessionPeer::closed_streams(session_.get()).empty()); |
| 1483 | } |
| 1484 | |
| 1485 | TEST_P(QuicSpdyStreamTest, OnPriorityFrame) { |
| 1486 | Initialize(kShouldProcessData); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1487 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1488 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1489 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1490 | } |
| 1491 | |
| 1492 | TEST_P(QuicSpdyStreamTest, OnPriorityFrameAfterSendingData) { |
| 1493 | testing::InSequence seq; |
| 1494 | Initialize(kShouldProcessData); |
| 1495 | |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1496 | if (UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1497 | EXPECT_CALL(*session_, WritevData(_, _, 2, _, NO_FIN)); |
| 1498 | } |
| 1499 | EXPECT_CALL(*session_, WritevData(_, _, 4, _, FIN)); |
| 1500 | stream_->WriteOrBufferBody("data", true); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1501 | stream_->OnPriorityFrame(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1502 | EXPECT_EQ(spdy::SpdyStreamPrecedence(kV3HighestPriority), |
| 1503 | stream_->precedence()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1504 | } |
| 1505 | |
| 1506 | TEST_P(QuicSpdyStreamTest, SetPriorityBeforeUpdateStreamPriority) { |
| 1507 | MockQuicConnection* connection = new StrictMock<MockQuicConnection>( |
| 1508 | &helper_, &alarm_factory_, Perspective::IS_SERVER, |
| 1509 | SupportedVersions(GetParam())); |
| 1510 | std::unique_ptr<TestMockUpdateStreamSession> session( |
| 1511 | new StrictMock<TestMockUpdateStreamSession>(connection)); |
renjietang | d1d0085 | 2019-09-06 10:43:12 -0700 | [diff] [blame] | 1512 | auto stream = |
| 1513 | new StrictMock<TestStream>(GetNthClientInitiatedBidirectionalStreamId( |
| 1514 | session->transport_version(), 0), |
| 1515 | session.get(), |
| 1516 | /*should_process_data=*/true); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1517 | session->ActivateStream(QuicWrapUnique(stream)); |
| 1518 | |
| 1519 | // QuicSpdyStream::SetPriority() should eventually call UpdateStreamPriority() |
| 1520 | // on the session. Make sure stream->priority() returns the updated priority |
| 1521 | // if called within UpdateStreamPriority(). This expectation is enforced in |
| 1522 | // TestMockUpdateStreamSession::UpdateStreamPriority(). |
| 1523 | session->SetExpectedStream(stream); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1524 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
| 1525 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3HighestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1526 | |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 1527 | session->SetExpectedPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
| 1528 | stream->SetPriority(spdy::SpdyStreamPrecedence(kV3LowestPriority)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1529 | } |
| 1530 | |
| 1531 | TEST_P(QuicSpdyStreamTest, StreamWaitsForAcks) { |
| 1532 | Initialize(kShouldProcessData); |
| 1533 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1534 | new StrictMock<MockAckListener>); |
| 1535 | stream_->set_ack_listener(mock_ack_listener); |
| 1536 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1537 | // Stream is not waiting for acks initially. |
| 1538 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1539 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1540 | |
| 1541 | // Send kData1. |
| 1542 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1543 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1544 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1545 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1546 | QuicByteCount newly_acked_length = 0; |
| 1547 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
| 1548 | &newly_acked_length)); |
| 1549 | // Stream is not waiting for acks as all sent data is acked. |
| 1550 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1551 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1552 | |
| 1553 | // Send kData2. |
| 1554 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1555 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1556 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1557 | // Send FIN. |
| 1558 | stream_->WriteOrBufferData("", true, nullptr); |
| 1559 | // Fin only frame is not stored in send buffer. |
| 1560 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1561 | |
| 1562 | // kData2 is retransmitted. |
| 1563 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(9)); |
| 1564 | stream_->OnStreamFrameRetransmitted(9, 9, false); |
| 1565 | |
| 1566 | // kData2 is acked. |
| 1567 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1568 | EXPECT_TRUE(stream_->OnStreamFrameAcked(9, 9, false, QuicTime::Delta::Zero(), |
| 1569 | &newly_acked_length)); |
| 1570 | // Stream is waiting for acks as FIN is not acked. |
| 1571 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1572 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1573 | |
| 1574 | // FIN is acked. |
| 1575 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1576 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 0, true, QuicTime::Delta::Zero(), |
| 1577 | &newly_acked_length)); |
| 1578 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1579 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1580 | } |
| 1581 | |
| 1582 | TEST_P(QuicSpdyStreamTest, StreamDataGetAckedMultipleTimes) { |
| 1583 | Initialize(kShouldProcessData); |
| 1584 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1585 | new StrictMock<MockAckListener>); |
| 1586 | stream_->set_ack_listener(mock_ack_listener); |
| 1587 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1588 | // Send [0, 27) and fin. |
| 1589 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1590 | stream_->WriteOrBufferData("FooAndBar", false, nullptr); |
| 1591 | stream_->WriteOrBufferData("FooAndBar", true, nullptr); |
| 1592 | |
| 1593 | // Ack [0, 9), [5, 22) and [18, 26) |
| 1594 | // Verify [0, 9) 9 bytes are acked. |
| 1595 | QuicByteCount newly_acked_length = 0; |
| 1596 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(9, _)); |
| 1597 | EXPECT_TRUE(stream_->OnStreamFrameAcked(0, 9, false, QuicTime::Delta::Zero(), |
| 1598 | &newly_acked_length)); |
| 1599 | EXPECT_EQ(2u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1600 | // Verify [9, 22) 13 bytes are acked. |
| 1601 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(13, _)); |
| 1602 | EXPECT_TRUE(stream_->OnStreamFrameAcked(5, 17, false, QuicTime::Delta::Zero(), |
| 1603 | &newly_acked_length)); |
| 1604 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1605 | // Verify [22, 26) 4 bytes are acked. |
| 1606 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(4, _)); |
| 1607 | EXPECT_TRUE(stream_->OnStreamFrameAcked(18, 8, false, QuicTime::Delta::Zero(), |
| 1608 | &newly_acked_length)); |
| 1609 | EXPECT_EQ(1u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1610 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1611 | |
| 1612 | // Ack [0, 27). |
| 1613 | // Verify [26, 27) 1 byte is acked. |
| 1614 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(1, _)); |
| 1615 | EXPECT_TRUE(stream_->OnStreamFrameAcked(26, 1, false, QuicTime::Delta::Zero(), |
| 1616 | &newly_acked_length)); |
| 1617 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1618 | EXPECT_TRUE(stream_->IsWaitingForAcks()); |
| 1619 | |
| 1620 | // Ack Fin. Verify OnPacketAcked is called. |
| 1621 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
| 1622 | EXPECT_TRUE(stream_->OnStreamFrameAcked(27, 0, true, QuicTime::Delta::Zero(), |
| 1623 | &newly_acked_length)); |
| 1624 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1625 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1626 | |
| 1627 | // Ack [10, 27) and fin. |
| 1628 | // No new data is acked, verify OnPacketAcked is not called. |
| 1629 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(_, _)).Times(0); |
| 1630 | EXPECT_FALSE(stream_->OnStreamFrameAcked( |
| 1631 | 10, 17, true, QuicTime::Delta::Zero(), &newly_acked_length)); |
| 1632 | EXPECT_EQ(0u, QuicStreamPeer::SendBuffer(stream_).size()); |
| 1633 | EXPECT_FALSE(stream_->IsWaitingForAcks()); |
| 1634 | } |
| 1635 | |
| 1636 | // HTTP/3 only. |
| 1637 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteOrBufferBody) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1638 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1639 | return; |
| 1640 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1641 | |
| 1642 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1643 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1644 | new StrictMock<MockAckListener>); |
| 1645 | stream_->set_ack_listener(mock_ack_listener); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1646 | std::string body = "Test1"; |
| 1647 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1648 | |
| 1649 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1650 | stream_->WriteOrBufferBody(body, false); |
| 1651 | stream_->WriteOrBufferBody(body2, true); |
| 1652 | |
| 1653 | std::unique_ptr<char[]> buffer; |
| 1654 | QuicByteCount header_length = |
| 1655 | encoder_.SerializeDataFrameHeader(body.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1656 | std::string header = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1657 | |
| 1658 | header_length = encoder_.SerializeDataFrameHeader(body2.length(), &buffer); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1659 | std::string header2 = std::string(buffer.get(), header_length); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1660 | |
| 1661 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body.length(), _)); |
| 1662 | QuicStreamFrame frame(stream_->id(), false, 0, header + body); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1663 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1664 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1665 | |
| 1666 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(0, _)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1667 | QuicStreamFrame frame2(stream_->id(), false, header.length() + body.length(), |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1668 | header2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1669 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame2), QuicTime::Delta::Zero(), |
| 1670 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1671 | |
| 1672 | EXPECT_CALL(*mock_ack_listener, OnPacketAcked(body2.length(), _)); |
| 1673 | QuicStreamFrame frame3(stream_->id(), true, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1674 | header.length() + body.length() + header2.length(), |
| 1675 | body2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1676 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame3), QuicTime::Delta::Zero(), |
| 1677 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1678 | |
| 1679 | EXPECT_TRUE( |
| 1680 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1681 | } |
| 1682 | |
| 1683 | // HTTP/3 only. |
| 1684 | TEST_P(QuicSpdyStreamTest, HeadersAckNotReportedWriteBodySlices) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1685 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1686 | return; |
| 1687 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1688 | |
| 1689 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1690 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1691 | new StrictMock<MockAckListener>); |
| 1692 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1693 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1694 | std::string body2(100, 'x'); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1695 | struct iovec body1_iov = {const_cast<char*>(body1.data()), body1.length()}; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1696 | struct iovec body2_iov = {const_cast<char*>(body2.data()), body2.length()}; |
| 1697 | QuicMemSliceStorage storage(&body1_iov, 1, |
| 1698 | helper_.GetStreamSendBufferAllocator(), 1024); |
| 1699 | QuicMemSliceStorage storage2(&body2_iov, 1, |
| 1700 | helper_.GetStreamSendBufferAllocator(), 1024); |
| 1701 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
| 1702 | stream_->WriteBodySlices(storage.ToSpan(), false); |
| 1703 | stream_->WriteBodySlices(storage2.ToSpan(), true); |
| 1704 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1705 | std::string data1 = DataFrame(body1); |
| 1706 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1707 | |
| 1708 | EXPECT_CALL(*mock_ack_listener, |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1709 | OnPacketAcked(body1.length() + body2.length(), _)); |
| 1710 | QuicStreamFrame frame(stream_->id(), true, 0, data1 + data2); |
QUICHE team | 9467db0 | 2019-05-30 09:38:45 -0700 | [diff] [blame] | 1711 | EXPECT_TRUE(session_->OnFrameAcked(QuicFrame(frame), QuicTime::Delta::Zero(), |
| 1712 | QuicTime::Zero())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1713 | |
| 1714 | EXPECT_TRUE( |
| 1715 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1716 | } |
| 1717 | |
| 1718 | // HTTP/3 only. |
| 1719 | TEST_P(QuicSpdyStreamTest, HeaderBytesNotReportedOnRetransmission) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1720 | if (!UsesHttp3()) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1721 | return; |
| 1722 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1723 | |
| 1724 | Initialize(kShouldProcessData); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1725 | QuicReferenceCountedPointer<MockAckListener> mock_ack_listener( |
| 1726 | new StrictMock<MockAckListener>); |
| 1727 | stream_->set_ack_listener(mock_ack_listener); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1728 | std::string body1 = "Test1"; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 1729 | std::string body2(100, 'x'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1730 | |
| 1731 | EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(AtLeast(1)); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1732 | stream_->WriteOrBufferBody(body1, false); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1733 | stream_->WriteOrBufferBody(body2, true); |
| 1734 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1735 | std::string data1 = DataFrame(body1); |
| 1736 | std::string data2 = DataFrame(body2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1737 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1738 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body1.length())); |
| 1739 | QuicStreamFrame frame(stream_->id(), false, 0, data1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1740 | session_->OnStreamFrameRetransmitted(frame); |
| 1741 | |
| 1742 | EXPECT_CALL(*mock_ack_listener, OnPacketRetransmitted(body2.length())); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1743 | QuicStreamFrame frame2(stream_->id(), true, data1.length(), data2); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1744 | session_->OnStreamFrameRetransmitted(frame2); |
| 1745 | |
| 1746 | EXPECT_FALSE( |
| 1747 | QuicSpdyStreamPeer::unacked_frame_headers_offsets(stream_).Empty()); |
| 1748 | } |
| 1749 | |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1750 | TEST_P(QuicSpdyStreamTest, HeadersFrameOnRequestStream) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1751 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1752 | return; |
| 1753 | } |
| 1754 | |
| 1755 | Initialize(kShouldProcessData); |
| 1756 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1757 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1758 | std::string data = DataFrame(kDataFramePayload); |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1759 | std::string trailers = |
| 1760 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1761 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1762 | std::string stream_frame_payload = QuicStrCat(headers, data, trailers); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1763 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1764 | stream_->OnStreamFrame(frame); |
| 1765 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1766 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1767 | |
| 1768 | // QuicSpdyStream only calls OnBodyAvailable() |
| 1769 | // after the header list has been consumed. |
| 1770 | EXPECT_EQ("", stream_->data()); |
| 1771 | stream_->ConsumeHeaderList(); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1772 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1773 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 1774 | EXPECT_THAT(stream_->received_trailers(), |
| 1775 | ElementsAre(Pair("custom-key", "custom-value"))); |
renjietang | 2abedac | 2019-05-20 14:04:50 -0700 | [diff] [blame] | 1776 | } |
| 1777 | |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1778 | TEST_P(QuicSpdyStreamTest, ProcessBodyAfterTrailers) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1779 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1780 | return; |
| 1781 | } |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1782 | |
| 1783 | Initialize(!kShouldProcessData); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1784 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 1785 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1786 | std::string data = DataFrame(kDataFramePayload); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1787 | |
| 1788 | // A header block that will take more than one block of sequencer buffer. |
| 1789 | // This ensures that when the trailers are consumed, some buffer buckets will |
| 1790 | // be freed. |
| 1791 | SpdyHeaderBlock trailers_block; |
| 1792 | trailers_block["key1"] = std::string(10000, 'x'); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 1793 | std::string trailers = HeadersFrame(trailers_block); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1794 | |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1795 | // Feed all three HTTP/3 frames in a single stream frame. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1796 | std::string stream_frame_payload = QuicStrCat(headers, data, trailers); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1797 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1798 | stream_->OnStreamFrame(frame); |
| 1799 | |
| 1800 | stream_->ConsumeHeaderList(); |
| 1801 | stream_->MarkTrailersConsumed(); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1802 | |
| 1803 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1804 | EXPECT_EQ(trailers_block, stream_->received_trailers()); |
| 1805 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 1806 | EXPECT_TRUE(stream_->HasBytesToRead()); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1807 | |
| 1808 | // Consume data. |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1809 | char buffer[2048]; |
| 1810 | struct iovec vec; |
| 1811 | vec.iov_base = buffer; |
| 1812 | vec.iov_len = QUIC_ARRAYSIZE(buffer); |
| 1813 | size_t bytes_read = stream_->Readv(&vec, 1); |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1814 | EXPECT_EQ(kDataFramePayload, QuicStringPiece(buffer, bytes_read)); |
bnc | d48a92e | 2019-06-18 19:24:58 -0700 | [diff] [blame] | 1815 | |
bnc | ab33c71 | 2019-06-28 15:42:15 -0700 | [diff] [blame] | 1816 | EXPECT_FALSE(stream_->HasBytesToRead()); |
renjietang | bd1a039 | 2019-05-31 11:36:24 -0700 | [diff] [blame] | 1817 | } |
| 1818 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1819 | // The test stream will receive a stream frame containing malformed headers and |
| 1820 | // normal body. Make sure the http decoder stops processing body after the |
| 1821 | // connection shuts down. |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1822 | TEST_P(QuicSpdyStreamTest, MalformedHeadersStopHttpDecoder) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1823 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1824 | return; |
| 1825 | } |
| 1826 | |
bnc | 677451a | 2019-06-07 10:13:30 -0700 | [diff] [blame] | 1827 | testing::InSequence s; |
| 1828 | |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1829 | Initialize(kShouldProcessData); |
| 1830 | connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1)); |
| 1831 | |
| 1832 | // Random bad headers. |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1833 | std::string headers = |
| 1834 | HeadersFrame(QuicTextUtils::HexDecode("00002a94e7036261")); |
| 1835 | std::string data = DataFrame(kDataFramePayload); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1836 | |
bnc | 9f977e4 | 2019-06-07 11:36:34 -0700 | [diff] [blame] | 1837 | std::string stream_frame_payload = QuicStrCat(headers, data); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1838 | QuicStreamFrame frame(stream_->id(), false, 0, stream_frame_payload); |
| 1839 | |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 1840 | EXPECT_CALL( |
| 1841 | *connection_, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1842 | CloseConnection( |
bnc | 13753e6 | 2019-10-17 04:40:09 -0700 | [diff] [blame] | 1843 | QUIC_QPACK_DECOMPRESSION_FAILED, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1844 | MatchesRegex("Error decompressing header block on stream \\d+: " |
| 1845 | "Incomplete header block."), |
| 1846 | _)) |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1847 | .WillOnce( |
| 1848 | (Invoke([this](QuicErrorCode error, const std::string& error_details, |
| 1849 | ConnectionCloseBehavior connection_close_behavior) { |
| 1850 | connection_->ReallyCloseConnection(error, error_details, |
| 1851 | connection_close_behavior); |
| 1852 | }))); |
| 1853 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
fkastenholz | 5d880a9 | 2019-06-21 09:01:56 -0700 | [diff] [blame] | 1854 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)) |
| 1855 | .WillOnce(Invoke([this](const QuicConnectionCloseFrame& frame, |
| 1856 | ConnectionCloseSource source) { |
| 1857 | session_->ReallyOnConnectionClosed(frame, source); |
| 1858 | })); |
renjietang | 546a628 | 2019-06-03 10:21:21 -0700 | [diff] [blame] | 1859 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 1860 | EXPECT_CALL(*session_, SendRstStream(_, _, _)); |
| 1861 | stream_->OnStreamFrame(frame); |
| 1862 | } |
| 1863 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1864 | TEST_P(QuicSpdyStreamTest, ImmediateHeaderDecodingWithDynamicTableEntries) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1865 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1866 | return; |
| 1867 | } |
| 1868 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1869 | testing::InSequence s; |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1870 | Initialize(kShouldProcessData); |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 1871 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1872 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1873 | auto decoder_send_stream = |
| 1874 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 1875 | |
| 1876 | // The stream byte will be written in the first byte. |
| 1877 | EXPECT_CALL(*session_, WritevData(decoder_send_stream, |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1878 | decoder_send_stream->id(), _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1879 | // Deliver dynamic table entry to decoder. |
| 1880 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 1881 | |
| 1882 | // HEADERS frame referencing first dynamic table entry. |
| 1883 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
| 1884 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1885 | |
| 1886 | // Headers can be decoded immediately. |
| 1887 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 1888 | |
| 1889 | // Verify headers. |
| 1890 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 1891 | stream_->ConsumeHeaderList(); |
| 1892 | |
| 1893 | // DATA frame. |
| 1894 | std::string data = DataFrame(kDataFramePayload); |
| 1895 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 1896 | headers.length(), data)); |
| 1897 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 1898 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1899 | EXPECT_CALL(*session_, WritevData(decoder_send_stream, |
| 1900 | decoder_send_stream->id(), _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1901 | // Deliver second dynamic table entry to decoder. |
| 1902 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
| 1903 | |
| 1904 | // Trailing HEADERS frame referencing second dynamic table entry. |
| 1905 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030080")); |
| 1906 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 1907 | headers.length() + data.length(), |
| 1908 | trailers)); |
| 1909 | |
| 1910 | // Trailers can be decoded immediately. |
| 1911 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1912 | |
| 1913 | // Verify trailers. |
| 1914 | EXPECT_THAT(stream_->received_trailers(), |
| 1915 | ElementsAre(Pair("trailing", "foobar"))); |
| 1916 | stream_->MarkTrailersConsumed(); |
| 1917 | } |
| 1918 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1919 | TEST_P(QuicSpdyStreamTest, BlockedHeaderDecoding) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1920 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1921 | return; |
| 1922 | } |
| 1923 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1924 | testing::InSequence s; |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1925 | Initialize(kShouldProcessData); |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 1926 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1927 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1928 | // HEADERS frame referencing first dynamic table entry. |
| 1929 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1930 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1931 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1932 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1933 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 1934 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1935 | auto decoder_send_stream = |
| 1936 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 1937 | |
| 1938 | // The stream byte will be written in the first byte. |
| 1939 | EXPECT_CALL(*session_, WritevData(decoder_send_stream, |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1940 | decoder_send_stream->id(), _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1941 | // Deliver dynamic table entry to decoder. |
| 1942 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1943 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 1944 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1945 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1946 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 1947 | stream_->ConsumeHeaderList(); |
| 1948 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1949 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1950 | std::string data = DataFrame(kDataFramePayload); |
| 1951 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 1952 | headers.length(), data)); |
| 1953 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 1954 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1955 | // Trailing HEADERS frame referencing second dynamic table entry. |
| 1956 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1957 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 1958 | headers.length() + data.length(), |
| 1959 | trailers)); |
| 1960 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1961 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1962 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 1963 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 1964 | EXPECT_CALL(*session_, WritevData(decoder_send_stream, |
| 1965 | decoder_send_stream->id(), _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1966 | // Deliver second dynamic table entry to decoder. |
| 1967 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1968 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 1969 | |
| 1970 | // Verify trailers. |
| 1971 | EXPECT_THAT(stream_->received_trailers(), |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1972 | ElementsAre(Pair("trailing", "foobar"))); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1973 | stream_->MarkTrailersConsumed(); |
| 1974 | } |
| 1975 | |
| 1976 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingHeaders) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 1977 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1978 | return; |
| 1979 | } |
| 1980 | |
| 1981 | Initialize(kShouldProcessData); |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 1982 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1983 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1984 | // HEADERS frame only referencing entry with absolute index 0 but with |
| 1985 | // Required Insert Count = 2, which is incorrect. |
| 1986 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1987 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 1988 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1989 | // Even though entire header block is received and every referenced entry is |
| 1990 | // available, decoding is blocked until insert count reaches the Required |
| 1991 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1992 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 1993 | |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 1994 | EXPECT_CALL( |
| 1995 | *connection_, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1996 | CloseConnection( |
bnc | 13753e6 | 2019-10-17 04:40:09 -0700 | [diff] [blame] | 1997 | QUIC_QPACK_DECOMPRESSION_FAILED, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 1998 | MatchesRegex("Error during async decoding of headers on stream \\d+: " |
| 1999 | "Required Insert Count too large."), |
| 2000 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
| 2001 | |
| 2002 | // Deliver two dynamic table entries to decoder |
| 2003 | // to trigger decoding of header block. |
| 2004 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
| 2005 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2006 | } |
| 2007 | |
| 2008 | TEST_P(QuicSpdyStreamTest, AsyncErrorDecodingTrailers) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2009 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2010 | return; |
| 2011 | } |
| 2012 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2013 | testing::InSequence s; |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2014 | Initialize(kShouldProcessData); |
bnc | 40e9a7b | 2019-08-30 05:27:08 -0700 | [diff] [blame] | 2015 | session_->qpack_decoder()->OnSetDynamicTableCapacity(1024); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2016 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2017 | // HEADERS frame referencing first dynamic table entry. |
| 2018 | std::string headers = HeadersFrame(QuicTextUtils::HexDecode("020080")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2019 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, headers)); |
| 2020 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2021 | // Decoding is blocked because dynamic table entry has not been received yet. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2022 | EXPECT_FALSE(stream_->headers_decompressed()); |
| 2023 | |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2024 | auto decoder_send_stream = |
| 2025 | QuicSpdySessionPeer::GetQpackDecoderSendStream(session_.get()); |
| 2026 | |
| 2027 | // The stream byte will be written in the first byte. |
| 2028 | EXPECT_CALL(*session_, WritevData(decoder_send_stream, |
renjietang | 87cd7de | 2019-08-16 08:35:10 -0700 | [diff] [blame] | 2029 | decoder_send_stream->id(), _, _, _)); |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2030 | // Deliver dynamic table entry to decoder. |
| 2031 | session_->qpack_decoder()->OnInsertWithoutNameReference("foo", "bar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2032 | EXPECT_TRUE(stream_->headers_decompressed()); |
| 2033 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2034 | // Verify headers. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2035 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2036 | stream_->ConsumeHeaderList(); |
| 2037 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2038 | // DATA frame. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2039 | std::string data = DataFrame(kDataFramePayload); |
| 2040 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, /* offset = */ |
| 2041 | headers.length(), data)); |
| 2042 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2043 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2044 | // Trailing HEADERS frame only referencing entry with absolute index 0 but |
| 2045 | // with Required Insert Count = 2, which is incorrect. |
| 2046 | std::string trailers = HeadersFrame(QuicTextUtils::HexDecode("030081")); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2047 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), true, /* offset = */ |
| 2048 | headers.length() + data.length(), |
| 2049 | trailers)); |
| 2050 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2051 | // Even though entire header block is received and every referenced entry is |
| 2052 | // available, decoding is blocked until insert count reaches the Required |
| 2053 | // Insert Count value advertised in the header block prefix. |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2054 | EXPECT_FALSE(stream_->trailers_decompressed()); |
| 2055 | |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2056 | EXPECT_CALL(*connection_, |
| 2057 | CloseConnection( |
bnc | 13753e6 | 2019-10-17 04:40:09 -0700 | [diff] [blame] | 2058 | QUIC_QPACK_DECOMPRESSION_FAILED, |
bnc | bdd303e | 2019-07-09 05:33:17 -0700 | [diff] [blame] | 2059 | MatchesRegex( |
| 2060 | "Error during async decoding of trailers on stream \\d+: " |
| 2061 | "Required Insert Count too large."), |
| 2062 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)); |
| 2063 | |
| 2064 | // Deliver second dynamic table entry to decoder |
| 2065 | // to trigger decoding of trailing header block. |
| 2066 | session_->qpack_decoder()->OnInsertWithoutNameReference("trailing", "foobar"); |
bnc | c057c01 | 2019-07-02 11:13:22 -0700 | [diff] [blame] | 2067 | } |
| 2068 | |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2069 | class QuicSpdyStreamIncrementalConsumptionTest : public QuicSpdyStreamTest { |
| 2070 | protected: |
| 2071 | QuicSpdyStreamIncrementalConsumptionTest() : offset_(0), consumed_bytes_(0) {} |
| 2072 | ~QuicSpdyStreamIncrementalConsumptionTest() override = default; |
| 2073 | |
| 2074 | // Create QuicStreamFrame with |payload| |
| 2075 | // and pass it to stream_->OnStreamFrame(). |
| 2076 | void OnStreamFrame(QuicStringPiece payload) { |
| 2077 | QuicStreamFrame frame(stream_->id(), /* fin = */ false, offset_, payload); |
| 2078 | stream_->OnStreamFrame(frame); |
| 2079 | offset_ += payload.size(); |
| 2080 | } |
| 2081 | |
| 2082 | // Return number of bytes marked consumed with sequencer |
| 2083 | // since last NewlyConsumedBytes() call. |
| 2084 | QuicStreamOffset NewlyConsumedBytes() { |
| 2085 | QuicStreamOffset previously_consumed_bytes = consumed_bytes_; |
| 2086 | consumed_bytes_ = stream_->sequencer()->NumBytesConsumed(); |
| 2087 | return consumed_bytes_ - previously_consumed_bytes; |
| 2088 | } |
| 2089 | |
| 2090 | // Read |size| bytes from the stream. |
| 2091 | std::string ReadFromStream(QuicByteCount size) { |
| 2092 | std::string buffer; |
| 2093 | buffer.resize(size); |
| 2094 | |
| 2095 | struct iovec vec; |
| 2096 | vec.iov_base = const_cast<char*>(buffer.data()); |
| 2097 | vec.iov_len = size; |
| 2098 | |
| 2099 | size_t bytes_read = stream_->Readv(&vec, 1); |
| 2100 | EXPECT_EQ(bytes_read, size); |
| 2101 | |
| 2102 | return buffer; |
| 2103 | } |
| 2104 | |
| 2105 | private: |
| 2106 | QuicStreamOffset offset_; |
| 2107 | QuicStreamOffset consumed_bytes_; |
| 2108 | }; |
| 2109 | |
| 2110 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 2111 | QuicSpdyStreamIncrementalConsumptionTest, |
| 2112 | ::testing::Values(ParsedQuicVersion{PROTOCOL_TLS1_3, |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 2113 | QUIC_VERSION_99}), |
| 2114 | ::testing::PrintToStringParamName()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2115 | |
| 2116 | // Test that stream bytes are consumed (by calling |
| 2117 | // sequencer()->MarkConsumed()) incrementally, as soon as possible. |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2118 | TEST_P(QuicSpdyStreamIncrementalConsumptionTest, OnlyKnownFrames) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2119 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2120 | return; |
| 2121 | } |
| 2122 | |
| 2123 | Initialize(!kShouldProcessData); |
| 2124 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2125 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2126 | |
| 2127 | // All HEADERS frame bytes are consumed even if the frame is not received |
bnc | 7deaf37 | 2019-07-25 18:00:40 -0700 | [diff] [blame] | 2128 | // completely. |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2129 | OnStreamFrame(QuicStringPiece(headers).substr(0, headers.size() - 1)); |
| 2130 | EXPECT_EQ(headers.size() - 1, NewlyConsumedBytes()); |
| 2131 | |
| 2132 | // The rest of the HEADERS frame is also consumed immediately. |
| 2133 | OnStreamFrame(QuicStringPiece(headers).substr(headers.size() - 1)); |
| 2134 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2135 | |
| 2136 | // Verify headers. |
| 2137 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2138 | stream_->ConsumeHeaderList(); |
| 2139 | |
| 2140 | // DATA frame. |
| 2141 | QuicStringPiece data_payload(kDataFramePayload); |
| 2142 | std::string data_frame = DataFrame(data_payload); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2143 | QuicByteCount data_frame_header_length = |
| 2144 | data_frame.size() - data_payload.size(); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2145 | |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2146 | // DATA frame header is consumed. |
| 2147 | // DATA frame payload is not consumed because payload has to be buffered. |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2148 | OnStreamFrame(data_frame); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2149 | EXPECT_EQ(data_frame_header_length, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2150 | |
| 2151 | // Consume all but last byte of data. |
| 2152 | EXPECT_EQ(data_payload.substr(0, data_payload.size() - 1), |
| 2153 | ReadFromStream(data_payload.size() - 1)); |
bnc | e5f9c03 | 2019-07-25 11:30:40 -0700 | [diff] [blame] | 2154 | EXPECT_EQ(data_payload.size() - 1, NewlyConsumedBytes()); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2155 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2156 | std::string trailers = |
| 2157 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 8d04130 | 2019-06-10 10:19:04 -0700 | [diff] [blame] | 2158 | |
| 2159 | // No bytes are consumed, because last byte of DATA payload is still buffered. |
| 2160 | OnStreamFrame(QuicStringPiece(trailers).substr(0, trailers.size() - 1)); |
| 2161 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2162 | |
| 2163 | // Reading last byte of DATA payload triggers consumption of all data received |
| 2164 | // so far, even though last HEADERS frame has not been received completely. |
| 2165 | EXPECT_EQ(data_payload.substr(data_payload.size() - 1), ReadFromStream(1)); |
| 2166 | EXPECT_EQ(1 + trailers.size() - 1, NewlyConsumedBytes()); |
| 2167 | |
| 2168 | // Last byte of trailers is immediately consumed. |
| 2169 | OnStreamFrame(QuicStringPiece(trailers).substr(trailers.size() - 1)); |
| 2170 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2171 | |
| 2172 | // Verify trailers. |
| 2173 | EXPECT_THAT(stream_->received_trailers(), |
| 2174 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2175 | } |
| 2176 | |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2177 | TEST_P(QuicSpdyStreamIncrementalConsumptionTest, UnknownFramesInterleaved) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2178 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2179 | return; |
| 2180 | } |
| 2181 | |
| 2182 | Initialize(!kShouldProcessData); |
| 2183 | |
| 2184 | // Unknown frame of reserved type before HEADERS is consumed immediately. |
| 2185 | std::string unknown_frame1 = UnknownFrame(0x21, "foo"); |
| 2186 | OnStreamFrame(unknown_frame1); |
| 2187 | EXPECT_EQ(unknown_frame1.size(), NewlyConsumedBytes()); |
| 2188 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2189 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2190 | |
| 2191 | // All HEADERS frame bytes are consumed even if the frame is not received |
| 2192 | // completely. |
| 2193 | OnStreamFrame(QuicStringPiece(headers).substr(0, headers.size() - 1)); |
| 2194 | EXPECT_EQ(headers.size() - 1, NewlyConsumedBytes()); |
| 2195 | |
| 2196 | // The rest of the HEADERS frame is also consumed immediately. |
| 2197 | OnStreamFrame(QuicStringPiece(headers).substr(headers.size() - 1)); |
| 2198 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2199 | |
| 2200 | // Verify headers. |
| 2201 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2202 | stream_->ConsumeHeaderList(); |
| 2203 | |
| 2204 | // Frame of unknown, not reserved type between HEADERS and DATA is consumed |
| 2205 | // immediately. |
| 2206 | std::string unknown_frame2 = UnknownFrame(0x3a, ""); |
| 2207 | OnStreamFrame(unknown_frame2); |
| 2208 | EXPECT_EQ(unknown_frame2.size(), NewlyConsumedBytes()); |
| 2209 | |
| 2210 | // DATA frame. |
| 2211 | QuicStringPiece data_payload(kDataFramePayload); |
| 2212 | std::string data_frame = DataFrame(data_payload); |
| 2213 | QuicByteCount data_frame_header_length = |
| 2214 | data_frame.size() - data_payload.size(); |
| 2215 | |
| 2216 | // DATA frame header is consumed. |
| 2217 | // DATA frame payload is not consumed because payload has to be buffered. |
| 2218 | OnStreamFrame(data_frame); |
| 2219 | EXPECT_EQ(data_frame_header_length, NewlyConsumedBytes()); |
| 2220 | |
| 2221 | // Frame of unknown, not reserved type is not consumed because DATA payload is |
| 2222 | // still buffered. |
| 2223 | std::string unknown_frame3 = UnknownFrame(0x39, "bar"); |
| 2224 | OnStreamFrame(unknown_frame3); |
| 2225 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2226 | |
| 2227 | // Consume all but last byte of data. |
| 2228 | EXPECT_EQ(data_payload.substr(0, data_payload.size() - 1), |
| 2229 | ReadFromStream(data_payload.size() - 1)); |
| 2230 | EXPECT_EQ(data_payload.size() - 1, NewlyConsumedBytes()); |
| 2231 | |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2232 | std::string trailers = |
| 2233 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 25827c4 | 2019-07-29 08:57:24 -0700 | [diff] [blame] | 2234 | |
| 2235 | // No bytes are consumed, because last byte of DATA payload is still buffered. |
| 2236 | OnStreamFrame(QuicStringPiece(trailers).substr(0, trailers.size() - 1)); |
| 2237 | EXPECT_EQ(0u, NewlyConsumedBytes()); |
| 2238 | |
| 2239 | // Reading last byte of DATA payload triggers consumption of all data received |
| 2240 | // so far, even though last HEADERS frame has not been received completely. |
| 2241 | EXPECT_EQ(data_payload.substr(data_payload.size() - 1), ReadFromStream(1)); |
| 2242 | EXPECT_EQ(1 + unknown_frame3.size() + trailers.size() - 1, |
| 2243 | NewlyConsumedBytes()); |
| 2244 | |
| 2245 | // Last byte of trailers is immediately consumed. |
| 2246 | OnStreamFrame(QuicStringPiece(trailers).substr(trailers.size() - 1)); |
| 2247 | EXPECT_EQ(1u, NewlyConsumedBytes()); |
| 2248 | |
| 2249 | // Verify trailers. |
| 2250 | EXPECT_THAT(stream_->received_trailers(), |
| 2251 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2252 | |
| 2253 | // Unknown frame of reserved type after trailers is consumed immediately. |
| 2254 | std::string unknown_frame4 = UnknownFrame(0x40, ""); |
| 2255 | OnStreamFrame(unknown_frame4); |
| 2256 | EXPECT_EQ(unknown_frame4.size(), NewlyConsumedBytes()); |
| 2257 | } |
| 2258 | |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2259 | TEST_P(QuicSpdyStreamTest, PushPromiseOnDataStream) { |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2260 | Initialize(kShouldProcessData); |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2261 | if (!UsesHttp3()) { |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2262 | return; |
| 2263 | } |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2264 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2265 | std::string headers = EncodeQpackHeaders({{"foo", "bar"}}); |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2266 | |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2267 | PushPromiseFrame push_promise; |
| 2268 | push_promise.push_id = 0x01; |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2269 | push_promise.headers = headers; |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2270 | std::unique_ptr<char[]> buffer; |
| 2271 | HttpEncoder encoder; |
| 2272 | uint64_t length = |
| 2273 | encoder.SerializePushPromiseFrameWithOnlyPushId(push_promise, &buffer); |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 2274 | std::string data = std::string(buffer.get(), length) + headers; |
| 2275 | QuicStreamFrame frame(stream_->id(), false, 0, data); |
| 2276 | |
| 2277 | EXPECT_CALL(*session_, |
| 2278 | OnPromiseHeaderList(stream_->id(), push_promise.push_id, |
| 2279 | headers.length(), _)); |
QUICHE team | 6c57946 | 2019-06-21 14:06:09 -0700 | [diff] [blame] | 2280 | stream_->OnStreamFrame(frame); |
| 2281 | } |
| 2282 | |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2283 | // Close connection if a DATA frame is received before a HEADERS frame. |
| 2284 | TEST_P(QuicSpdyStreamTest, DataBeforeHeaders) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2285 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2286 | return; |
| 2287 | } |
| 2288 | |
| 2289 | Initialize(kShouldProcessData); |
| 2290 | |
| 2291 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2292 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2293 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2294 | EXPECT_CALL( |
| 2295 | *connection_, |
| 2296 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2297 | "Unexpected DATA frame received.", |
| 2298 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2299 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2300 | |
| 2301 | std::string data = DataFrame(kDataFramePayload); |
| 2302 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, 0, data)); |
| 2303 | } |
| 2304 | |
| 2305 | // Close connection if a HEADERS frame is received after the trailing HEADERS. |
| 2306 | TEST_P(QuicSpdyStreamTest, TrailersAfterTrailers) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2307 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2308 | return; |
| 2309 | } |
| 2310 | |
| 2311 | Initialize(kShouldProcessData); |
| 2312 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2313 | // Receive and consume headers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2314 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2315 | QuicStreamOffset offset = 0; |
| 2316 | stream_->OnStreamFrame( |
| 2317 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2318 | offset += headers.size(); |
| 2319 | |
| 2320 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2321 | stream_->ConsumeHeaderList(); |
| 2322 | |
| 2323 | // Receive data. It is consumed by TestStream. |
| 2324 | std::string data = DataFrame(kDataFramePayload); |
| 2325 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data)); |
| 2326 | offset += data.size(); |
| 2327 | |
| 2328 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2329 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2330 | // Receive and consume trailers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2331 | std::string trailers1 = |
| 2332 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2333 | stream_->OnStreamFrame( |
| 2334 | QuicStreamFrame(stream_->id(), false, offset, trailers1)); |
| 2335 | offset += trailers1.size(); |
| 2336 | |
| 2337 | EXPECT_TRUE(stream_->trailers_decompressed()); |
| 2338 | EXPECT_THAT(stream_->received_trailers(), |
| 2339 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2340 | |
| 2341 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2342 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2343 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2344 | EXPECT_CALL( |
| 2345 | *connection_, |
| 2346 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2347 | "HEADERS frame received after trailing HEADERS.", |
| 2348 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2349 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2350 | |
| 2351 | // Receive another HEADERS frame, with no header fields. |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2352 | std::string trailers2 = HeadersFrame(SpdyHeaderBlock()); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2353 | stream_->OnStreamFrame( |
| 2354 | QuicStreamFrame(stream_->id(), false, offset, trailers2)); |
| 2355 | } |
| 2356 | |
| 2357 | // Regression test for https://crbug.com/978733. |
| 2358 | // Close connection if a DATA frame is received after the trailing HEADERS. |
| 2359 | TEST_P(QuicSpdyStreamTest, DataAfterTrailers) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2360 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2361 | return; |
| 2362 | } |
| 2363 | |
| 2364 | Initialize(kShouldProcessData); |
| 2365 | |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2366 | // Receive and consume headers. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2367 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2368 | QuicStreamOffset offset = 0; |
| 2369 | stream_->OnStreamFrame( |
| 2370 | QuicStreamFrame(stream_->id(), false, offset, headers)); |
| 2371 | offset += headers.size(); |
| 2372 | |
| 2373 | EXPECT_THAT(stream_->header_list(), ElementsAre(Pair("foo", "bar"))); |
| 2374 | stream_->ConsumeHeaderList(); |
| 2375 | |
| 2376 | // Receive data. It is consumed by TestStream. |
| 2377 | std::string data1 = DataFrame(kDataFramePayload); |
| 2378 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data1)); |
| 2379 | offset += data1.size(); |
| 2380 | EXPECT_EQ(kDataFramePayload, stream_->data()); |
| 2381 | |
| 2382 | // Receive trailers, with single header field "custom-key: custom-value". |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2383 | std::string trailers = |
| 2384 | HeadersFrame({std::make_pair("custom-key", "custom-value")}); |
bnc | 519216c | 2019-07-09 05:03:48 -0700 | [diff] [blame] | 2385 | stream_->OnStreamFrame( |
| 2386 | QuicStreamFrame(stream_->id(), false, offset, trailers)); |
| 2387 | offset += trailers.size(); |
| 2388 | |
| 2389 | EXPECT_THAT(stream_->received_trailers(), |
| 2390 | ElementsAre(Pair("custom-key", "custom-value"))); |
| 2391 | |
| 2392 | // Closing the connection is mocked out in tests. Instead, simply stop |
| 2393 | // reading data at the stream level to prevent QuicSpdyStream from blowing up. |
| 2394 | // TODO(b/124216424): Change error code to HTTP_UNEXPECTED_FRAME. |
| 2395 | EXPECT_CALL( |
| 2396 | *connection_, |
| 2397 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 2398 | "Unexpected DATA frame received.", |
| 2399 | ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET)) |
| 2400 | .WillOnce(InvokeWithoutArgs([this]() { stream_->StopReading(); })); |
| 2401 | |
| 2402 | // Receive more data. |
| 2403 | std::string data2 = DataFrame("This payload should not be proccessed."); |
| 2404 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), false, offset, data2)); |
| 2405 | } |
| 2406 | |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2407 | // SETTINGS frames are invalid on bidirectional streams. If one is received, |
| 2408 | // the connection is closed. No more data should be processed. |
| 2409 | TEST_P(QuicSpdyStreamTest, StopProcessingIfConnectionClosed) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 2410 | if (!VersionUsesHttp3(GetParam().transport_version)) { |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2411 | return; |
| 2412 | } |
| 2413 | |
| 2414 | Initialize(kShouldProcessData); |
| 2415 | |
| 2416 | // SETTINGS frame with empty payload. |
| 2417 | std::string settings = QuicTextUtils::HexDecode("0400"); |
bnc | 2e963aa | 2019-07-31 18:03:17 -0700 | [diff] [blame] | 2418 | |
| 2419 | // HEADERS frame. |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2420 | // Since it arrives after a SETTINGS frame, it should never be read. |
fayang | 7e3c1a1 | 2019-08-02 08:07:13 -0700 | [diff] [blame] | 2421 | std::string headers = HeadersFrame({std::make_pair("foo", "bar")}); |
bnc | ef51815 | 2019-07-18 05:36:44 -0700 | [diff] [blame] | 2422 | |
| 2423 | // Combine the two frames to make sure they are processed in a single |
| 2424 | // QuicSpdyStream::OnDataAvailable() call. |
| 2425 | std::string frames = QuicStrCat(settings, headers); |
| 2426 | |
| 2427 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2428 | |
| 2429 | EXPECT_CALL(*connection_, CloseConnection(QUIC_HTTP_DECODER_ERROR, _, _)) |
| 2430 | .WillOnce( |
| 2431 | Invoke(connection_, &MockQuicConnection::ReallyCloseConnection)); |
| 2432 | EXPECT_CALL(*connection_, SendConnectionClosePacket(_, _)); |
| 2433 | EXPECT_CALL(*session_, OnConnectionClosed(_, _)); |
| 2434 | |
| 2435 | stream_->OnStreamFrame(QuicStreamFrame(stream_->id(), /* fin = */ false, |
| 2436 | /* offset = */ 0, frames)); |
| 2437 | |
| 2438 | EXPECT_EQ(0u, stream_->sequencer()->NumBytesConsumed()); |
| 2439 | } |
| 2440 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 2441 | } // namespace |
| 2442 | } // namespace test |
| 2443 | } // namespace quic |