QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
QUICHE team | 5be974e | 2020-12-29 18:35:24 -0500 | [diff] [blame] | 5 | #include "quic/core/http/quic_headers_stream.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 6 | |
| 7 | #include <cstdint> |
| 8 | #include <ostream> |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 9 | #include <string> |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 10 | #include <tuple> |
| 11 | #include <utility> |
| 12 | #include <vector> |
| 13 | |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 14 | #include "absl/strings/str_cat.h" |
vasilvv | e2707e3 | 2020-10-08 12:27:46 -0700 | [diff] [blame] | 15 | #include "absl/strings/string_view.h" |
QUICHE team | 5be974e | 2020-12-29 18:35:24 -0500 | [diff] [blame] | 16 | #include "quic/core/crypto/null_encrypter.h" |
| 17 | #include "quic/core/http/spdy_utils.h" |
| 18 | #include "quic/core/quic_data_writer.h" |
| 19 | #include "quic/core/quic_utils.h" |
| 20 | #include "quic/platform/api/quic_bug_tracker.h" |
| 21 | #include "quic/platform/api/quic_expect_bug.h" |
| 22 | #include "quic/platform/api/quic_flags.h" |
| 23 | #include "quic/platform/api/quic_logging.h" |
| 24 | #include "quic/platform/api/quic_test.h" |
| 25 | #include "quic/test_tools/quic_connection_peer.h" |
| 26 | #include "quic/test_tools/quic_spdy_session_peer.h" |
| 27 | #include "quic/test_tools/quic_stream_peer.h" |
| 28 | #include "quic/test_tools/quic_test_utils.h" |
| 29 | #include "common/quiche_endian.h" |
| 30 | #include "spdy/core/http2_frame_decoder_adapter.h" |
| 31 | #include "spdy/core/recording_headers_handler.h" |
| 32 | #include "spdy/core/spdy_alt_svc_wire_format.h" |
| 33 | #include "spdy/core/spdy_protocol.h" |
| 34 | #include "spdy/core/spdy_test_utils.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 35 | |
| 36 | using spdy::ERROR_CODE_PROTOCOL_ERROR; |
QUICHE team | 6169e49 | 2020-11-10 14:05:30 -0800 | [diff] [blame] | 37 | using spdy::RecordingHeadersHandler; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 38 | using spdy::SETTINGS_ENABLE_PUSH; |
| 39 | using spdy::SETTINGS_HEADER_TABLE_SIZE; |
| 40 | using spdy::SETTINGS_INITIAL_WINDOW_SIZE; |
| 41 | using spdy::SETTINGS_MAX_CONCURRENT_STREAMS; |
| 42 | using spdy::SETTINGS_MAX_FRAME_SIZE; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 43 | using spdy::Spdy3PriorityToHttp2Weight; |
| 44 | using spdy::SpdyAltSvcWireFormat; |
| 45 | using spdy::SpdyDataIR; |
| 46 | using spdy::SpdyErrorCode; |
| 47 | using spdy::SpdyFramer; |
| 48 | using spdy::SpdyFramerVisitorInterface; |
| 49 | using spdy::SpdyGoAwayIR; |
| 50 | using spdy::SpdyHeaderBlock; |
| 51 | using spdy::SpdyHeadersHandlerInterface; |
| 52 | using spdy::SpdyHeadersIR; |
| 53 | using spdy::SpdyKnownSettingsId; |
| 54 | using spdy::SpdyPingId; |
| 55 | using spdy::SpdyPingIR; |
| 56 | using spdy::SpdyPriority; |
| 57 | using spdy::SpdyPriorityIR; |
| 58 | using spdy::SpdyPushPromiseIR; |
| 59 | using spdy::SpdyRstStreamIR; |
| 60 | using spdy::SpdySerializedFrame; |
| 61 | using spdy::SpdySettingsId; |
| 62 | using spdy::SpdySettingsIR; |
| 63 | using spdy::SpdyStreamId; |
| 64 | using spdy::SpdyWindowUpdateIR; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 65 | using testing::_; |
wub | 8eea919 | 2020-08-13 12:05:40 -0700 | [diff] [blame] | 66 | using testing::AnyNumber; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 67 | using testing::AtLeast; |
| 68 | using testing::InSequence; |
| 69 | using testing::Invoke; |
| 70 | using testing::Return; |
| 71 | using testing::StrictMock; |
| 72 | using testing::WithArgs; |
| 73 | |
| 74 | namespace quic { |
| 75 | namespace test { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 76 | namespace { |
| 77 | |
| 78 | class MockVisitor : public SpdyFramerVisitorInterface { |
| 79 | public: |
wub | 713afae | 2020-04-27 07:48:31 -0700 | [diff] [blame] | 80 | MOCK_METHOD(void, |
| 81 | OnError, |
fayang | 8036668 | 2020-07-24 09:19:11 -0700 | [diff] [blame] | 82 | (http2::Http2DecoderAdapter::SpdyFramerError error, |
| 83 | std::string detailed_error), |
wub | 713afae | 2020-04-27 07:48:31 -0700 | [diff] [blame] | 84 | (override)); |
| 85 | MOCK_METHOD(void, |
| 86 | OnDataFrameHeader, |
| 87 | (SpdyStreamId stream_id, size_t length, bool fin), |
| 88 | (override)); |
| 89 | MOCK_METHOD(void, |
| 90 | OnStreamFrameData, |
| 91 | (SpdyStreamId stream_id, const char*, size_t len), |
| 92 | (override)); |
| 93 | MOCK_METHOD(void, OnStreamEnd, (SpdyStreamId stream_id), (override)); |
| 94 | MOCK_METHOD(void, |
| 95 | OnStreamPadding, |
| 96 | (SpdyStreamId stream_id, size_t len), |
| 97 | (override)); |
| 98 | MOCK_METHOD(SpdyHeadersHandlerInterface*, |
| 99 | OnHeaderFrameStart, |
| 100 | (SpdyStreamId stream_id), |
| 101 | (override)); |
| 102 | MOCK_METHOD(void, OnHeaderFrameEnd, (SpdyStreamId stream_id), (override)); |
| 103 | MOCK_METHOD(void, |
| 104 | OnRstStream, |
| 105 | (SpdyStreamId stream_id, SpdyErrorCode error_code), |
| 106 | (override)); |
| 107 | MOCK_METHOD(void, OnSettings, (), (override)); |
| 108 | MOCK_METHOD(void, OnSetting, (SpdySettingsId id, uint32_t value), (override)); |
| 109 | MOCK_METHOD(void, OnSettingsAck, (), (override)); |
| 110 | MOCK_METHOD(void, OnSettingsEnd, (), (override)); |
| 111 | MOCK_METHOD(void, OnPing, (SpdyPingId unique_id, bool is_ack), (override)); |
| 112 | MOCK_METHOD(void, |
| 113 | OnGoAway, |
| 114 | (SpdyStreamId last_accepted_stream_id, SpdyErrorCode error_code), |
| 115 | (override)); |
| 116 | MOCK_METHOD(void, |
| 117 | OnHeaders, |
| 118 | (SpdyStreamId stream_id, |
| 119 | bool has_priority, |
| 120 | int weight, |
| 121 | SpdyStreamId parent_stream_id, |
| 122 | bool exclusive, |
| 123 | bool fin, |
| 124 | bool end), |
| 125 | (override)); |
| 126 | MOCK_METHOD(void, |
| 127 | OnWindowUpdate, |
| 128 | (SpdyStreamId stream_id, int delta_window_size), |
| 129 | (override)); |
| 130 | MOCK_METHOD(void, |
| 131 | OnPushPromise, |
| 132 | (SpdyStreamId stream_id, |
| 133 | SpdyStreamId promised_stream_id, |
| 134 | bool end), |
| 135 | (override)); |
| 136 | MOCK_METHOD(void, |
| 137 | OnContinuation, |
| 138 | (SpdyStreamId stream_id, bool end), |
| 139 | (override)); |
| 140 | MOCK_METHOD( |
| 141 | void, |
| 142 | OnAltSvc, |
| 143 | (SpdyStreamId stream_id, |
vasilvv | e2707e3 | 2020-10-08 12:27:46 -0700 | [diff] [blame] | 144 | absl::string_view origin, |
wub | 713afae | 2020-04-27 07:48:31 -0700 | [diff] [blame] | 145 | const SpdyAltSvcWireFormat::AlternativeServiceVector& altsvc_vector), |
| 146 | (override)); |
| 147 | MOCK_METHOD(void, |
| 148 | OnPriority, |
| 149 | (SpdyStreamId stream_id, |
| 150 | SpdyStreamId parent_stream_id, |
| 151 | int weight, |
| 152 | bool exclusive), |
| 153 | (override)); |
bnc | a5a3013 | 2020-12-17 13:50:27 -0800 | [diff] [blame] | 154 | MOCK_METHOD(void, |
| 155 | OnPriorityUpdate, |
| 156 | (SpdyStreamId prioritized_stream_id, |
| 157 | absl::string_view priority_field_value), |
| 158 | (override)); |
wub | 713afae | 2020-04-27 07:48:31 -0700 | [diff] [blame] | 159 | MOCK_METHOD(bool, |
| 160 | OnUnknownFrame, |
| 161 | (SpdyStreamId stream_id, uint8_t frame_type), |
| 162 | (override)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 163 | }; |
| 164 | |
| 165 | struct TestParams { |
| 166 | TestParams(const ParsedQuicVersion& version, Perspective perspective) |
| 167 | : version(version), perspective(perspective) { |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 168 | QUIC_LOG(INFO) << "TestParams: " << *this; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 169 | } |
| 170 | |
| 171 | TestParams(const TestParams& other) |
| 172 | : version(other.version), perspective(other.perspective) {} |
| 173 | |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 174 | friend std::ostream& operator<<(std::ostream& os, const TestParams& tp) { |
| 175 | os << "{ version: " << ParsedQuicVersionToString(tp.version) |
| 176 | << ", perspective: " |
| 177 | << (tp.perspective == Perspective::IS_CLIENT ? "client" : "server") |
| 178 | << "}"; |
| 179 | return os; |
| 180 | } |
| 181 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 182 | ParsedQuicVersion version; |
| 183 | Perspective perspective; |
| 184 | }; |
| 185 | |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 186 | // Used by ::testing::PrintToStringParamName(). |
| 187 | std::string PrintToString(const TestParams& tp) { |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 188 | return absl::StrCat( |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 189 | ParsedQuicVersionToString(tp.version), "_", |
| 190 | (tp.perspective == Perspective::IS_CLIENT ? "client" : "server")); |
| 191 | } |
| 192 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 193 | std::vector<TestParams> GetTestParams() { |
| 194 | std::vector<TestParams> params; |
| 195 | ParsedQuicVersionVector all_supported_versions = AllSupportedVersions(); |
| 196 | for (size_t i = 0; i < all_supported_versions.size(); ++i) { |
renjietang | a29a96a | 2019-10-10 12:47:50 -0700 | [diff] [blame] | 197 | if (VersionUsesHttp3(all_supported_versions[i].transport_version)) { |
renjietang | 3c3dfb7 | 2019-07-26 11:55:52 -0700 | [diff] [blame] | 198 | continue; |
| 199 | } |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 200 | for (Perspective p : {Perspective::IS_SERVER, Perspective::IS_CLIENT}) { |
| 201 | params.emplace_back(all_supported_versions[i], p); |
| 202 | } |
| 203 | } |
| 204 | return params; |
| 205 | } |
| 206 | |
| 207 | class QuicHeadersStreamTest : public QuicTestWithParam<TestParams> { |
| 208 | public: |
| 209 | QuicHeadersStreamTest() |
| 210 | : connection_(new StrictMock<MockQuicConnection>(&helper_, |
| 211 | &alarm_factory_, |
| 212 | perspective(), |
| 213 | GetVersion())), |
| 214 | session_(connection_), |
| 215 | body_("hello world"), |
| 216 | stream_frame_( |
| 217 | QuicUtils::GetHeadersStreamId(connection_->transport_version()), |
| 218 | /*fin=*/false, |
| 219 | /*offset=*/0, |
| 220 | ""), |
| 221 | next_promised_stream_id_(2) { |
bnc | 30d610c | 2019-07-08 18:39:59 -0700 | [diff] [blame] | 222 | QuicSpdySessionPeer::SetMaxInboundHeaderListSize(&session_, 256 * 1024); |
wub | 8eea919 | 2020-08-13 12:05:40 -0700 | [diff] [blame] | 223 | EXPECT_CALL(session_, OnCongestionWindowChange(_)).Times(AnyNumber()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 224 | session_.Initialize(); |
fayang | 9c41f8b | 2020-10-30 13:13:06 -0700 | [diff] [blame] | 225 | connection_->SetEncrypter( |
| 226 | quic::ENCRYPTION_FORWARD_SECURE, |
| 227 | std::make_unique<quic::NullEncrypter>(connection_->perspective())); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 228 | headers_stream_ = QuicSpdySessionPeer::GetHeadersStream(&session_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 229 | headers_[":status"] = "200 Ok"; |
| 230 | headers_["content-length"] = "11"; |
| 231 | framer_ = std::unique_ptr<SpdyFramer>( |
| 232 | new SpdyFramer(SpdyFramer::ENABLE_COMPRESSION)); |
| 233 | deframer_ = std::unique_ptr<http2::Http2DecoderAdapter>( |
| 234 | new http2::Http2DecoderAdapter()); |
| 235 | deframer_->set_visitor(&visitor_); |
renjietang | d1d0085 | 2019-09-06 10:43:12 -0700 | [diff] [blame] | 236 | EXPECT_EQ(transport_version(), session_.transport_version()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 237 | EXPECT_TRUE(headers_stream_ != nullptr); |
| 238 | connection_->AdvanceTime(QuicTime::Delta::FromMilliseconds(1)); |
| 239 | client_id_1_ = GetNthClientInitiatedBidirectionalStreamId( |
| 240 | connection_->transport_version(), 0); |
| 241 | client_id_2_ = GetNthClientInitiatedBidirectionalStreamId( |
| 242 | connection_->transport_version(), 1); |
| 243 | client_id_3_ = GetNthClientInitiatedBidirectionalStreamId( |
| 244 | connection_->transport_version(), 2); |
| 245 | next_stream_id_ = |
| 246 | QuicUtils::StreamIdDelta(connection_->transport_version()); |
| 247 | } |
| 248 | |
| 249 | QuicStreamId GetNthClientInitiatedId(int n) { |
| 250 | return GetNthClientInitiatedBidirectionalStreamId( |
| 251 | connection_->transport_version(), n); |
| 252 | } |
| 253 | |
| 254 | QuicConsumedData SaveIov(size_t write_length) { |
| 255 | char* buf = new char[write_length]; |
QUICHE team | 173c48f | 2019-11-19 16:34:44 -0800 | [diff] [blame] | 256 | QuicDataWriter writer(write_length, buf, quiche::NETWORK_BYTE_ORDER); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 257 | headers_stream_->WriteStreamData(headers_stream_->stream_bytes_written(), |
| 258 | write_length, &writer); |
| 259 | saved_data_.append(buf, write_length); |
| 260 | delete[] buf; |
| 261 | return QuicConsumedData(write_length, false); |
| 262 | } |
| 263 | |
| 264 | void SavePayload(const char* data, size_t len) { |
| 265 | saved_payloads_.append(data, len); |
| 266 | } |
| 267 | |
| 268 | bool SaveHeaderData(const char* data, int len) { |
| 269 | saved_header_data_.append(data, len); |
| 270 | return true; |
| 271 | } |
| 272 | |
vasilvv | e2707e3 | 2020-10-08 12:27:46 -0700 | [diff] [blame] | 273 | void SaveHeaderDataStringPiece(absl::string_view data) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 274 | saved_header_data_.append(data.data(), data.length()); |
| 275 | } |
| 276 | |
| 277 | void SavePromiseHeaderList(QuicStreamId /* stream_id */, |
| 278 | QuicStreamId /* promised_stream_id */, |
| 279 | size_t size, |
| 280 | const QuicHeaderList& header_list) { |
| 281 | SaveToHandler(size, header_list); |
| 282 | } |
| 283 | |
| 284 | void SaveHeaderList(QuicStreamId /* stream_id */, |
| 285 | bool /* fin */, |
| 286 | size_t size, |
| 287 | const QuicHeaderList& header_list) { |
| 288 | SaveToHandler(size, header_list); |
| 289 | } |
| 290 | |
| 291 | void SaveToHandler(size_t size, const QuicHeaderList& header_list) { |
QUICHE team | 6169e49 | 2020-11-10 14:05:30 -0800 | [diff] [blame] | 292 | headers_handler_ = std::make_unique<RecordingHeadersHandler>(); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 293 | headers_handler_->OnHeaderBlockStart(); |
| 294 | for (const auto& p : header_list) { |
| 295 | headers_handler_->OnHeader(p.first, p.second); |
| 296 | } |
| 297 | headers_handler_->OnHeaderBlockEnd(size, size); |
| 298 | } |
| 299 | |
| 300 | void WriteAndExpectRequestHeaders(QuicStreamId stream_id, |
| 301 | bool fin, |
| 302 | SpdyPriority priority) { |
| 303 | WriteHeadersAndCheckData(stream_id, fin, priority, true /*is_request*/); |
| 304 | } |
| 305 | |
| 306 | void WriteAndExpectResponseHeaders(QuicStreamId stream_id, bool fin) { |
| 307 | WriteHeadersAndCheckData(stream_id, fin, 0, false /*is_request*/); |
| 308 | } |
| 309 | |
| 310 | void WriteHeadersAndCheckData(QuicStreamId stream_id, |
| 311 | bool fin, |
| 312 | SpdyPriority priority, |
| 313 | bool is_request) { |
| 314 | // Write the headers and capture the outgoing data |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 315 | EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 316 | connection_->transport_version()), |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 317 | _, _, NO_FIN, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 318 | .WillOnce(WithArgs<1>(Invoke(this, &QuicHeadersStreamTest::SaveIov))); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 319 | QuicSpdySessionPeer::WriteHeadersOnHeadersStream( |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 320 | &session_, stream_id, headers_.Clone(), fin, |
| 321 | spdy::SpdyStreamPrecedence(priority), nullptr); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 322 | |
| 323 | // Parse the outgoing data and check that it matches was was written. |
| 324 | if (is_request) { |
| 325 | EXPECT_CALL(visitor_, |
| 326 | OnHeaders(stream_id, kHasPriority, |
| 327 | Spdy3PriorityToHttp2Weight(priority), |
| 328 | /*parent_stream_id=*/0, |
| 329 | /*exclusive=*/false, fin, kFrameComplete)); |
| 330 | } else { |
| 331 | EXPECT_CALL(visitor_, |
| 332 | OnHeaders(stream_id, !kHasPriority, |
wub | 0b2ae54 | 2019-10-24 08:32:06 -0700 | [diff] [blame] | 333 | /*weight=*/0, |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 334 | /*parent_stream_id=*/0, |
| 335 | /*exclusive=*/false, fin, kFrameComplete)); |
| 336 | } |
QUICHE team | 6169e49 | 2020-11-10 14:05:30 -0800 | [diff] [blame] | 337 | headers_handler_ = std::make_unique<RecordingHeadersHandler>(); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 338 | EXPECT_CALL(visitor_, OnHeaderFrameStart(stream_id)) |
| 339 | .WillOnce(Return(headers_handler_.get())); |
| 340 | EXPECT_CALL(visitor_, OnHeaderFrameEnd(stream_id)).Times(1); |
| 341 | if (fin) { |
| 342 | EXPECT_CALL(visitor_, OnStreamEnd(stream_id)); |
| 343 | } |
| 344 | deframer_->ProcessInput(saved_data_.data(), saved_data_.length()); |
| 345 | EXPECT_FALSE(deframer_->HasError()) |
| 346 | << http2::Http2DecoderAdapter::SpdyFramerErrorToString( |
| 347 | deframer_->spdy_framer_error()); |
| 348 | |
| 349 | CheckHeaders(); |
| 350 | saved_data_.clear(); |
| 351 | } |
| 352 | |
| 353 | void CheckHeaders() { |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 354 | ASSERT_TRUE(headers_handler_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 355 | EXPECT_EQ(headers_, headers_handler_->decoded_block()); |
| 356 | headers_handler_.reset(); |
| 357 | } |
| 358 | |
| 359 | Perspective perspective() const { return GetParam().perspective; } |
| 360 | |
| 361 | QuicTransportVersion transport_version() const { |
| 362 | return GetParam().version.transport_version; |
| 363 | } |
| 364 | |
| 365 | ParsedQuicVersionVector GetVersion() { |
| 366 | ParsedQuicVersionVector versions; |
| 367 | versions.push_back(GetParam().version); |
| 368 | return versions; |
| 369 | } |
| 370 | |
| 371 | void TearDownLocalConnectionState() { |
| 372 | QuicConnectionPeer::TearDownLocalConnectionState(connection_); |
| 373 | } |
| 374 | |
| 375 | QuicStreamId NextPromisedStreamId() { |
| 376 | return next_promised_stream_id_ += next_stream_id_; |
| 377 | } |
| 378 | |
QUICHE team | 897763c | 2020-04-14 08:15:58 -0700 | [diff] [blame] | 379 | static constexpr bool kFrameComplete = true; |
| 380 | static constexpr bool kHasPriority = true; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 381 | |
| 382 | MockQuicConnectionHelper helper_; |
| 383 | MockAlarmFactory alarm_factory_; |
| 384 | StrictMock<MockQuicConnection>* connection_; |
| 385 | StrictMock<MockQuicSpdySession> session_; |
| 386 | QuicHeadersStream* headers_stream_; |
| 387 | SpdyHeaderBlock headers_; |
QUICHE team | 6169e49 | 2020-11-10 14:05:30 -0800 | [diff] [blame] | 388 | std::unique_ptr<RecordingHeadersHandler> headers_handler_; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 389 | std::string body_; |
| 390 | std::string saved_data_; |
| 391 | std::string saved_header_data_; |
| 392 | std::string saved_payloads_; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 393 | std::unique_ptr<SpdyFramer> framer_; |
| 394 | std::unique_ptr<http2::Http2DecoderAdapter> deframer_; |
| 395 | StrictMock<MockVisitor> visitor_; |
| 396 | QuicStreamFrame stream_frame_; |
| 397 | QuicStreamId next_promised_stream_id_; |
| 398 | QuicStreamId client_id_1_; |
| 399 | QuicStreamId client_id_2_; |
| 400 | QuicStreamId client_id_3_; |
| 401 | QuicStreamId next_stream_id_; |
| 402 | }; |
| 403 | |
| 404 | // Run all tests with each version and perspective (client or server). |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 405 | INSTANTIATE_TEST_SUITE_P(Tests, |
| 406 | QuicHeadersStreamTest, |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 407 | ::testing::ValuesIn(GetTestParams()), |
| 408 | ::testing::PrintToStringParamName()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 409 | |
| 410 | TEST_P(QuicHeadersStreamTest, StreamId) { |
| 411 | EXPECT_EQ(QuicUtils::GetHeadersStreamId(connection_->transport_version()), |
| 412 | headers_stream_->id()); |
| 413 | } |
| 414 | |
| 415 | TEST_P(QuicHeadersStreamTest, WriteHeaders) { |
| 416 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 417 | stream_id += next_stream_id_) { |
| 418 | for (bool fin : {false, true}) { |
| 419 | if (perspective() == Perspective::IS_SERVER) { |
| 420 | WriteAndExpectResponseHeaders(stream_id, fin); |
| 421 | } else { |
| 422 | for (SpdyPriority priority = 0; priority < 7; ++priority) { |
| 423 | // TODO(rch): implement priorities correctly. |
| 424 | WriteAndExpectRequestHeaders(stream_id, fin, 0); |
| 425 | } |
| 426 | } |
| 427 | } |
| 428 | } |
| 429 | } |
| 430 | |
| 431 | TEST_P(QuicHeadersStreamTest, WritePushPromises) { |
| 432 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 433 | stream_id += next_stream_id_) { |
| 434 | QuicStreamId promised_stream_id = NextPromisedStreamId(); |
| 435 | if (perspective() == Perspective::IS_SERVER) { |
| 436 | // Write the headers and capture the outgoing data |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 437 | EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 438 | connection_->transport_version()), |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 439 | _, _, NO_FIN, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 440 | .WillOnce(WithArgs<1>(Invoke(this, &QuicHeadersStreamTest::SaveIov))); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 441 | session_.WritePushPromise(stream_id, promised_stream_id, |
| 442 | headers_.Clone()); |
| 443 | |
| 444 | // Parse the outgoing data and check that it matches was was written. |
| 445 | EXPECT_CALL(visitor_, |
| 446 | OnPushPromise(stream_id, promised_stream_id, kFrameComplete)); |
QUICHE team | 6169e49 | 2020-11-10 14:05:30 -0800 | [diff] [blame] | 447 | headers_handler_ = std::make_unique<RecordingHeadersHandler>(); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 448 | EXPECT_CALL(visitor_, OnHeaderFrameStart(stream_id)) |
| 449 | .WillOnce(Return(headers_handler_.get())); |
| 450 | EXPECT_CALL(visitor_, OnHeaderFrameEnd(stream_id)).Times(1); |
| 451 | deframer_->ProcessInput(saved_data_.data(), saved_data_.length()); |
| 452 | EXPECT_FALSE(deframer_->HasError()) |
| 453 | << http2::Http2DecoderAdapter::SpdyFramerErrorToString( |
| 454 | deframer_->spdy_framer_error()); |
| 455 | CheckHeaders(); |
| 456 | saved_data_.clear(); |
| 457 | } else { |
| 458 | EXPECT_QUIC_BUG(session_.WritePushPromise(stream_id, promised_stream_id, |
| 459 | headers_.Clone()), |
| 460 | "Client shouldn't send PUSH_PROMISE"); |
| 461 | } |
| 462 | } |
| 463 | } |
| 464 | |
| 465 | TEST_P(QuicHeadersStreamTest, ProcessRawData) { |
| 466 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 467 | stream_id += next_stream_id_) { |
| 468 | for (bool fin : {false, true}) { |
| 469 | for (SpdyPriority priority = 0; priority < 7; ++priority) { |
| 470 | // Replace with "WriteHeadersAndSaveData" |
| 471 | SpdySerializedFrame frame; |
| 472 | if (perspective() == Perspective::IS_SERVER) { |
| 473 | SpdyHeadersIR headers_frame(stream_id, headers_.Clone()); |
| 474 | headers_frame.set_fin(fin); |
| 475 | headers_frame.set_has_priority(true); |
| 476 | headers_frame.set_weight(Spdy3PriorityToHttp2Weight(0)); |
| 477 | frame = framer_->SerializeFrame(headers_frame); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 478 | EXPECT_CALL(session_, OnStreamHeadersPriority( |
| 479 | stream_id, spdy::SpdyStreamPrecedence(0))); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 480 | } else { |
| 481 | SpdyHeadersIR headers_frame(stream_id, headers_.Clone()); |
| 482 | headers_frame.set_fin(fin); |
| 483 | frame = framer_->SerializeFrame(headers_frame); |
| 484 | } |
| 485 | EXPECT_CALL(session_, |
| 486 | OnStreamHeaderList(stream_id, fin, frame.size(), _)) |
| 487 | .WillOnce(Invoke(this, &QuicHeadersStreamTest::SaveHeaderList)); |
| 488 | stream_frame_.data_buffer = frame.data(); |
| 489 | stream_frame_.data_length = frame.size(); |
| 490 | headers_stream_->OnStreamFrame(stream_frame_); |
| 491 | stream_frame_.offset += frame.size(); |
| 492 | CheckHeaders(); |
| 493 | } |
| 494 | } |
| 495 | } |
| 496 | } |
| 497 | |
| 498 | TEST_P(QuicHeadersStreamTest, ProcessPushPromise) { |
| 499 | if (perspective() == Perspective::IS_SERVER) { |
| 500 | return; |
| 501 | } |
| 502 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 503 | stream_id += next_stream_id_) { |
| 504 | QuicStreamId promised_stream_id = NextPromisedStreamId(); |
| 505 | SpdyPushPromiseIR push_promise(stream_id, promised_stream_id, |
| 506 | headers_.Clone()); |
| 507 | SpdySerializedFrame frame(framer_->SerializeFrame(push_promise)); |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 508 | bool connection_closed = false; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 509 | if (perspective() == Perspective::IS_SERVER) { |
| 510 | EXPECT_CALL(*connection_, |
| 511 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 512 | "PUSH_PROMISE not supported.", _)) |
| 513 | .WillRepeatedly(InvokeWithoutArgs( |
| 514 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 515 | } else { |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 516 | ON_CALL(*connection_, CloseConnection(_, _, _)) |
| 517 | .WillByDefault(testing::Assign(&connection_closed, true)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 518 | EXPECT_CALL(session_, OnPromiseHeaderList(stream_id, promised_stream_id, |
| 519 | frame.size(), _)) |
| 520 | .WillOnce( |
| 521 | Invoke(this, &QuicHeadersStreamTest::SavePromiseHeaderList)); |
| 522 | } |
| 523 | stream_frame_.data_buffer = frame.data(); |
| 524 | stream_frame_.data_length = frame.size(); |
| 525 | headers_stream_->OnStreamFrame(stream_frame_); |
| 526 | if (perspective() == Perspective::IS_CLIENT) { |
| 527 | stream_frame_.offset += frame.size(); |
dschinazi | 552accc | 2019-06-17 17:07:34 -0700 | [diff] [blame] | 528 | // CheckHeaders crashes if the connection is closed so this ensures we |
| 529 | // fail the test instead of crashing. |
| 530 | ASSERT_FALSE(connection_closed); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 531 | CheckHeaders(); |
| 532 | } |
| 533 | } |
| 534 | } |
| 535 | |
| 536 | TEST_P(QuicHeadersStreamTest, ProcessPriorityFrame) { |
| 537 | QuicStreamId parent_stream_id = 0; |
| 538 | for (SpdyPriority priority = 0; priority < 7; ++priority) { |
| 539 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 540 | stream_id += next_stream_id_) { |
| 541 | int weight = Spdy3PriorityToHttp2Weight(priority); |
| 542 | SpdyPriorityIR priority_frame(stream_id, parent_stream_id, weight, true); |
| 543 | SpdySerializedFrame frame(framer_->SerializeFrame(priority_frame)); |
| 544 | parent_stream_id = stream_id; |
fayang | 8265a2a | 2019-10-16 11:23:51 -0700 | [diff] [blame] | 545 | if (perspective() == Perspective::IS_CLIENT) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 546 | EXPECT_CALL(*connection_, |
| 547 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 548 | "Server must not send PRIORITY frames.", _)) |
| 549 | .WillRepeatedly(InvokeWithoutArgs( |
| 550 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 551 | } else { |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 552 | EXPECT_CALL( |
| 553 | session_, |
| 554 | OnPriorityFrame(stream_id, spdy::SpdyStreamPrecedence(priority))) |
| 555 | .Times(1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 556 | } |
| 557 | stream_frame_.data_buffer = frame.data(); |
| 558 | stream_frame_.data_length = frame.size(); |
| 559 | headers_stream_->OnStreamFrame(stream_frame_); |
| 560 | stream_frame_.offset += frame.size(); |
| 561 | } |
| 562 | } |
| 563 | } |
| 564 | |
| 565 | TEST_P(QuicHeadersStreamTest, ProcessPushPromiseDisabledSetting) { |
bnc | 0142a09 | 2021-04-27 12:13:52 -0700 | [diff] [blame] | 566 | if (perspective() != Perspective::IS_CLIENT) { |
| 567 | return; |
| 568 | } |
| 569 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 570 | session_.OnConfigNegotiated(); |
| 571 | SpdySettingsIR data; |
| 572 | // Respect supported settings frames SETTINGS_ENABLE_PUSH. |
| 573 | data.AddSetting(SETTINGS_ENABLE_PUSH, 0); |
| 574 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 575 | stream_frame_.data_buffer = frame.data(); |
| 576 | stream_frame_.data_length = frame.size(); |
bnc | 0142a09 | 2021-04-27 12:13:52 -0700 | [diff] [blame] | 577 | EXPECT_CALL( |
| 578 | *connection_, |
| 579 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 580 | "Unsupported field of HTTP/2 SETTINGS frame: 2", _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 581 | headers_stream_->OnStreamFrame(stream_frame_); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 582 | } |
| 583 | |
| 584 | TEST_P(QuicHeadersStreamTest, ProcessLargeRawData) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 585 | // We want to create a frame that is more than the SPDY Framer's max control |
| 586 | // frame size, which is 16K, but less than the HPACK decoders max decode |
| 587 | // buffer size, which is 32K. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 588 | headers_["key0"] = std::string(1 << 13, '.'); |
| 589 | headers_["key1"] = std::string(1 << 13, '.'); |
| 590 | headers_["key2"] = std::string(1 << 13, '.'); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 591 | for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; |
| 592 | stream_id += next_stream_id_) { |
| 593 | for (bool fin : {false, true}) { |
| 594 | for (SpdyPriority priority = 0; priority < 7; ++priority) { |
| 595 | // Replace with "WriteHeadersAndSaveData" |
| 596 | SpdySerializedFrame frame; |
| 597 | if (perspective() == Perspective::IS_SERVER) { |
| 598 | SpdyHeadersIR headers_frame(stream_id, headers_.Clone()); |
| 599 | headers_frame.set_fin(fin); |
| 600 | headers_frame.set_has_priority(true); |
| 601 | headers_frame.set_weight(Spdy3PriorityToHttp2Weight(0)); |
| 602 | frame = framer_->SerializeFrame(headers_frame); |
fayang | 476683a | 2019-07-25 12:42:16 -0700 | [diff] [blame] | 603 | EXPECT_CALL(session_, OnStreamHeadersPriority( |
| 604 | stream_id, spdy::SpdyStreamPrecedence(0))); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 605 | } else { |
| 606 | SpdyHeadersIR headers_frame(stream_id, headers_.Clone()); |
| 607 | headers_frame.set_fin(fin); |
| 608 | frame = framer_->SerializeFrame(headers_frame); |
| 609 | } |
| 610 | EXPECT_CALL(session_, |
| 611 | OnStreamHeaderList(stream_id, fin, frame.size(), _)) |
| 612 | .WillOnce(Invoke(this, &QuicHeadersStreamTest::SaveHeaderList)); |
| 613 | stream_frame_.data_buffer = frame.data(); |
| 614 | stream_frame_.data_length = frame.size(); |
| 615 | headers_stream_->OnStreamFrame(stream_frame_); |
| 616 | stream_frame_.offset += frame.size(); |
| 617 | CheckHeaders(); |
| 618 | } |
| 619 | } |
| 620 | } |
| 621 | } |
| 622 | |
| 623 | TEST_P(QuicHeadersStreamTest, ProcessBadData) { |
| 624 | const char kBadData[] = "blah blah blah"; |
| 625 | EXPECT_CALL(*connection_, |
| 626 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, _, _)) |
| 627 | .Times(::testing::AnyNumber()); |
| 628 | stream_frame_.data_buffer = kBadData; |
| 629 | stream_frame_.data_length = strlen(kBadData); |
| 630 | headers_stream_->OnStreamFrame(stream_frame_); |
| 631 | } |
| 632 | |
| 633 | TEST_P(QuicHeadersStreamTest, ProcessSpdyDataFrame) { |
| 634 | SpdyDataIR data(/* stream_id = */ 2, "ping"); |
| 635 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 636 | |
| 637 | EXPECT_CALL(*connection_, CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 638 | "SPDY DATA frame received.", _)) |
| 639 | .WillOnce(InvokeWithoutArgs( |
| 640 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 641 | stream_frame_.data_buffer = frame.data(); |
| 642 | stream_frame_.data_length = frame.size(); |
| 643 | headers_stream_->OnStreamFrame(stream_frame_); |
| 644 | } |
| 645 | |
| 646 | TEST_P(QuicHeadersStreamTest, ProcessSpdyRstStreamFrame) { |
| 647 | SpdyRstStreamIR data(/* stream_id = */ 2, ERROR_CODE_PROTOCOL_ERROR); |
| 648 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 649 | EXPECT_CALL(*connection_, |
| 650 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 651 | "SPDY RST_STREAM frame received.", _)) |
| 652 | .WillOnce(InvokeWithoutArgs( |
| 653 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 654 | stream_frame_.data_buffer = frame.data(); |
| 655 | stream_frame_.data_length = frame.size(); |
| 656 | headers_stream_->OnStreamFrame(stream_frame_); |
| 657 | } |
| 658 | |
| 659 | TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameSupportedFields) { |
| 660 | const uint32_t kTestHeaderTableSize = 1000; |
| 661 | SpdySettingsIR data; |
| 662 | // Respect supported settings frames SETTINGS_HEADER_TABLE_SIZE, |
| 663 | // SETTINGS_MAX_HEADER_LIST_SIZE. |
| 664 | data.AddSetting(SETTINGS_HEADER_TABLE_SIZE, kTestHeaderTableSize); |
renjietang | 4e9714d | 2020-09-21 15:25:23 -0700 | [diff] [blame] | 665 | data.AddSetting(spdy::SETTINGS_MAX_HEADER_LIST_SIZE, 2000); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 666 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 667 | stream_frame_.data_buffer = frame.data(); |
| 668 | stream_frame_.data_length = frame.size(); |
| 669 | headers_stream_->OnStreamFrame(stream_frame_); |
| 670 | EXPECT_EQ(kTestHeaderTableSize, QuicSpdySessionPeer::GetSpdyFramer(&session_) |
bnc | 92fa63a | 2020-02-04 05:13:43 -0800 | [diff] [blame] | 671 | ->header_encoder_table_size()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 672 | } |
| 673 | |
| 674 | TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameUnsupportedFields) { |
| 675 | SpdySettingsIR data; |
| 676 | // Does not support SETTINGS_MAX_CONCURRENT_STREAMS, |
| 677 | // SETTINGS_INITIAL_WINDOW_SIZE, SETTINGS_ENABLE_PUSH and |
| 678 | // SETTINGS_MAX_FRAME_SIZE. |
| 679 | data.AddSetting(SETTINGS_MAX_CONCURRENT_STREAMS, 100); |
| 680 | data.AddSetting(SETTINGS_INITIAL_WINDOW_SIZE, 100); |
| 681 | data.AddSetting(SETTINGS_ENABLE_PUSH, 1); |
| 682 | data.AddSetting(SETTINGS_MAX_FRAME_SIZE, 1250); |
| 683 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 684 | EXPECT_CALL(*connection_, |
| 685 | CloseConnection( |
| 686 | QUIC_INVALID_HEADERS_STREAM_DATA, |
| 687 | absl::StrCat("Unsupported field of HTTP/2 SETTINGS frame: ", |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 688 | SETTINGS_MAX_CONCURRENT_STREAMS), |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 689 | _)); |
| 690 | EXPECT_CALL(*connection_, |
| 691 | CloseConnection( |
| 692 | QUIC_INVALID_HEADERS_STREAM_DATA, |
| 693 | absl::StrCat("Unsupported field of HTTP/2 SETTINGS frame: ", |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 694 | SETTINGS_INITIAL_WINDOW_SIZE), |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 695 | _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 696 | if (session_.perspective() == Perspective::IS_CLIENT) { |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 697 | EXPECT_CALL(*connection_, |
| 698 | CloseConnection( |
| 699 | QUIC_INVALID_HEADERS_STREAM_DATA, |
| 700 | absl::StrCat("Unsupported field of HTTP/2 SETTINGS frame: ", |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 701 | SETTINGS_ENABLE_PUSH), |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 702 | _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 703 | } |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 704 | EXPECT_CALL(*connection_, |
| 705 | CloseConnection( |
| 706 | QUIC_INVALID_HEADERS_STREAM_DATA, |
| 707 | absl::StrCat("Unsupported field of HTTP/2 SETTINGS frame: ", |
dmcardle | ba2fb7e | 2019-12-13 07:44:34 -0800 | [diff] [blame] | 708 | SETTINGS_MAX_FRAME_SIZE), |
vasilvv | a163b38 | 2020-12-04 11:47:46 -0800 | [diff] [blame] | 709 | _)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 710 | stream_frame_.data_buffer = frame.data(); |
| 711 | stream_frame_.data_length = frame.size(); |
| 712 | headers_stream_->OnStreamFrame(stream_frame_); |
| 713 | } |
| 714 | |
| 715 | TEST_P(QuicHeadersStreamTest, ProcessSpdyPingFrame) { |
| 716 | SpdyPingIR data(1); |
| 717 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 718 | EXPECT_CALL(*connection_, CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 719 | "SPDY PING frame received.", _)) |
| 720 | .WillOnce(InvokeWithoutArgs( |
| 721 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 722 | stream_frame_.data_buffer = frame.data(); |
| 723 | stream_frame_.data_length = frame.size(); |
| 724 | headers_stream_->OnStreamFrame(stream_frame_); |
| 725 | } |
| 726 | |
| 727 | TEST_P(QuicHeadersStreamTest, ProcessSpdyGoAwayFrame) { |
| 728 | SpdyGoAwayIR data(/* last_good_stream_id = */ 1, ERROR_CODE_PROTOCOL_ERROR, |
| 729 | "go away"); |
| 730 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 731 | EXPECT_CALL(*connection_, CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 732 | "SPDY GOAWAY frame received.", _)) |
| 733 | .WillOnce(InvokeWithoutArgs( |
| 734 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 735 | stream_frame_.data_buffer = frame.data(); |
| 736 | stream_frame_.data_length = frame.size(); |
| 737 | headers_stream_->OnStreamFrame(stream_frame_); |
| 738 | } |
| 739 | |
| 740 | TEST_P(QuicHeadersStreamTest, ProcessSpdyWindowUpdateFrame) { |
| 741 | SpdyWindowUpdateIR data(/* stream_id = */ 1, /* delta = */ 1); |
| 742 | SpdySerializedFrame frame(framer_->SerializeFrame(data)); |
| 743 | EXPECT_CALL(*connection_, |
| 744 | CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 745 | "SPDY WINDOW_UPDATE frame received.", _)) |
| 746 | .WillOnce(InvokeWithoutArgs( |
| 747 | this, &QuicHeadersStreamTest::TearDownLocalConnectionState)); |
| 748 | stream_frame_.data_buffer = frame.data(); |
| 749 | stream_frame_.data_length = frame.size(); |
| 750 | headers_stream_->OnStreamFrame(stream_frame_); |
| 751 | } |
| 752 | |
| 753 | TEST_P(QuicHeadersStreamTest, NoConnectionLevelFlowControl) { |
| 754 | EXPECT_FALSE(QuicStreamPeer::StreamContributesToConnectionFlowControl( |
| 755 | headers_stream_)); |
| 756 | } |
| 757 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 758 | TEST_P(QuicHeadersStreamTest, AckSentData) { |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 759 | EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 760 | connection_->transport_version()), |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 761 | _, _, NO_FIN, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 762 | .WillRepeatedly(Invoke(&session_, &MockQuicSpdySession::ConsumeData)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 763 | InSequence s; |
| 764 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 765 | new MockAckListener()); |
| 766 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 767 | new MockAckListener()); |
| 768 | QuicReferenceCountedPointer<MockAckListener> ack_listener3( |
| 769 | new MockAckListener()); |
| 770 | |
| 771 | // Packet 1. |
| 772 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 773 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 774 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 775 | |
| 776 | // Packet 2. |
| 777 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 778 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 779 | |
| 780 | // Packet 3. |
| 781 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 782 | |
| 783 | // Packet 2 gets retransmitted. |
| 784 | EXPECT_CALL(*ack_listener3, OnPacketRetransmitted(7)).Times(1); |
| 785 | EXPECT_CALL(*ack_listener2, OnPacketRetransmitted(7)).Times(1); |
| 786 | headers_stream_->OnStreamFrameRetransmitted(21, 7, false); |
| 787 | headers_stream_->OnStreamFrameRetransmitted(28, 7, false); |
| 788 | |
| 789 | // Packets are acked in order: 2, 3, 1. |
| 790 | QuicByteCount newly_acked_length = 0; |
| 791 | EXPECT_CALL(*ack_listener3, OnPacketAcked(7, _)); |
| 792 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
| 793 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 794 | 21, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 795 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 796 | EXPECT_EQ(7u, newly_acked_length); |
| 797 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 798 | 28, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 799 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 800 | EXPECT_EQ(7u, newly_acked_length); |
| 801 | |
| 802 | EXPECT_CALL(*ack_listener3, OnPacketAcked(7, _)); |
| 803 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 804 | 35, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 805 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 806 | EXPECT_EQ(7u, newly_acked_length); |
| 807 | |
| 808 | EXPECT_CALL(*ack_listener1, OnPacketAcked(7, _)); |
| 809 | EXPECT_CALL(*ack_listener1, OnPacketAcked(7, _)); |
| 810 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 811 | 0, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 812 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 813 | EXPECT_EQ(7u, newly_acked_length); |
| 814 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 815 | 7, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 816 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 817 | EXPECT_EQ(7u, newly_acked_length); |
| 818 | // Unsent data is acked. |
| 819 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
| 820 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 821 | 14, 10, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 822 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 823 | EXPECT_EQ(7u, newly_acked_length); |
| 824 | } |
| 825 | |
| 826 | TEST_P(QuicHeadersStreamTest, FrameContainsMultipleHeaders) { |
| 827 | // In this test, a stream frame can contain multiple headers. |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 828 | EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 829 | connection_->transport_version()), |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 830 | _, _, NO_FIN, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 831 | .WillRepeatedly(Invoke(&session_, &MockQuicSpdySession::ConsumeData)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 832 | InSequence s; |
| 833 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 834 | new MockAckListener()); |
| 835 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 836 | new MockAckListener()); |
| 837 | QuicReferenceCountedPointer<MockAckListener> ack_listener3( |
| 838 | new MockAckListener()); |
| 839 | |
| 840 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 841 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 842 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 843 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 844 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 845 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 846 | |
| 847 | // Frame 1 is retransmitted. |
| 848 | EXPECT_CALL(*ack_listener1, OnPacketRetransmitted(14)); |
| 849 | EXPECT_CALL(*ack_listener2, OnPacketRetransmitted(3)); |
| 850 | headers_stream_->OnStreamFrameRetransmitted(0, 17, false); |
| 851 | |
| 852 | // Frames are acked in order: 2, 3, 1. |
| 853 | QuicByteCount newly_acked_length = 0; |
| 854 | EXPECT_CALL(*ack_listener2, OnPacketAcked(4, _)); |
| 855 | EXPECT_CALL(*ack_listener3, OnPacketAcked(7, _)); |
| 856 | EXPECT_CALL(*ack_listener2, OnPacketAcked(2, _)); |
| 857 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 858 | 17, 13, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 859 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 860 | EXPECT_EQ(13u, newly_acked_length); |
| 861 | |
| 862 | EXPECT_CALL(*ack_listener2, OnPacketAcked(5, _)); |
| 863 | EXPECT_CALL(*ack_listener3, OnPacketAcked(7, _)); |
| 864 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 865 | 30, 12, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 866 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 867 | EXPECT_EQ(12u, newly_acked_length); |
| 868 | |
| 869 | EXPECT_CALL(*ack_listener1, OnPacketAcked(14, _)); |
| 870 | EXPECT_CALL(*ack_listener2, OnPacketAcked(3, _)); |
| 871 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 872 | 0, 17, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 873 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 874 | EXPECT_EQ(17u, newly_acked_length); |
| 875 | } |
| 876 | |
| 877 | TEST_P(QuicHeadersStreamTest, HeadersGetAckedMultipleTimes) { |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 878 | EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 879 | connection_->transport_version()), |
renjietang | 41a1b41 | 2020-02-27 15:05:14 -0800 | [diff] [blame] | 880 | _, _, NO_FIN, _, _)) |
renjietang | 7c23917 | 2020-02-21 13:50:39 -0800 | [diff] [blame] | 881 | .WillRepeatedly(Invoke(&session_, &MockQuicSpdySession::ConsumeData)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 882 | InSequence s; |
| 883 | QuicReferenceCountedPointer<MockAckListener> ack_listener1( |
| 884 | new MockAckListener()); |
| 885 | QuicReferenceCountedPointer<MockAckListener> ack_listener2( |
| 886 | new MockAckListener()); |
| 887 | QuicReferenceCountedPointer<MockAckListener> ack_listener3( |
| 888 | new MockAckListener()); |
| 889 | |
| 890 | // Send [0, 42). |
| 891 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 892 | headers_stream_->WriteOrBufferData("Header5", false, ack_listener1); |
| 893 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 894 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 895 | headers_stream_->WriteOrBufferData("Header7", false, ack_listener2); |
| 896 | headers_stream_->WriteOrBufferData("Header9", false, ack_listener3); |
| 897 | |
| 898 | // Ack [15, 20), [5, 25), [10, 17), [0, 12) and [22, 42). |
| 899 | QuicByteCount newly_acked_length = 0; |
| 900 | EXPECT_CALL(*ack_listener2, OnPacketAcked(5, _)); |
| 901 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 902 | 15, 5, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 903 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 904 | EXPECT_EQ(5u, newly_acked_length); |
| 905 | |
| 906 | EXPECT_CALL(*ack_listener1, OnPacketAcked(9, _)); |
| 907 | EXPECT_CALL(*ack_listener2, OnPacketAcked(1, _)); |
| 908 | EXPECT_CALL(*ack_listener2, OnPacketAcked(1, _)); |
| 909 | EXPECT_CALL(*ack_listener3, OnPacketAcked(4, _)); |
| 910 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 911 | 5, 20, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 912 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 913 | EXPECT_EQ(15u, newly_acked_length); |
| 914 | |
| 915 | // Duplicate ack. |
| 916 | EXPECT_FALSE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 917 | 10, 7, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 918 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 919 | EXPECT_EQ(0u, newly_acked_length); |
| 920 | |
| 921 | EXPECT_CALL(*ack_listener1, OnPacketAcked(5, _)); |
| 922 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 923 | 0, 12, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 924 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 925 | EXPECT_EQ(5u, newly_acked_length); |
| 926 | |
| 927 | EXPECT_CALL(*ack_listener3, OnPacketAcked(3, _)); |
| 928 | EXPECT_CALL(*ack_listener2, OnPacketAcked(7, _)); |
| 929 | EXPECT_CALL(*ack_listener3, OnPacketAcked(7, _)); |
| 930 | EXPECT_TRUE(headers_stream_->OnStreamFrameAcked( |
QUICHE team | 2f5f30b | 2020-02-18 08:52:28 -0800 | [diff] [blame] | 931 | 22, 20, false, QuicTime::Delta::Zero(), QuicTime::Zero(), |
| 932 | &newly_acked_length)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 933 | EXPECT_EQ(17u, newly_acked_length); |
| 934 | } |
| 935 | |
QUICHE team | 690a187 | 2019-06-25 16:49:56 -0700 | [diff] [blame] | 936 | TEST_P(QuicHeadersStreamTest, CloseOnPushPromiseToServer) { |
| 937 | if (perspective() == Perspective::IS_CLIENT) { |
| 938 | return; |
| 939 | } |
| 940 | QuicStreamId promised_id = 1; |
| 941 | SpdyPushPromiseIR push_promise(client_id_1_, promised_id, headers_.Clone()); |
| 942 | SpdySerializedFrame frame = framer_->SerializeFrame(push_promise); |
| 943 | stream_frame_.data_buffer = frame.data(); |
| 944 | stream_frame_.data_length = frame.size(); |
| 945 | EXPECT_CALL(session_, OnStreamHeaderList(_, _, _, _)); |
| 946 | // TODO(lassey): Check for HTTP_WRONG_STREAM error code. |
| 947 | EXPECT_CALL(*connection_, CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA, |
| 948 | "PUSH_PROMISE not supported.", _)); |
| 949 | headers_stream_->OnStreamFrame(stream_frame_); |
| 950 | } |
| 951 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 952 | } // namespace |
| 953 | } // namespace test |
| 954 | } // namespace quic |