QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 1 | // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "net/third_party/quiche/src/quic/core/quic_config.h" |
| 6 | |
vasilvv | 872e7a3 | 2019-03-12 16:42:44 -0700 | [diff] [blame] | 7 | #include <string> |
| 8 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 9 | #include "net/third_party/quiche/src/quic/core/crypto/crypto_handshake_message.h" |
| 10 | #include "net/third_party/quiche/src/quic/core/crypto/crypto_protocol.h" |
| 11 | #include "net/third_party/quiche/src/quic/core/quic_packets.h" |
| 12 | #include "net/third_party/quiche/src/quic/core/quic_time.h" |
| 13 | #include "net/third_party/quiche/src/quic/core/quic_utils.h" |
| 14 | #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 15 | #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" |
| 16 | #include "net/third_party/quiche/src/quic/platform/api/quic_uint128.h" |
| 17 | #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" |
| 18 | #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" |
| 19 | |
| 20 | namespace quic { |
| 21 | namespace test { |
| 22 | namespace { |
| 23 | |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 24 | const uint32_t kMaxPacketSizeForTest = 1234; |
dschinazi | cd86dd1 | 2019-11-14 10:11:13 -0800 | [diff] [blame] | 25 | const uint32_t kMaxDatagramFrameSizeForTest = 1333; |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 26 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 27 | class QuicConfigTest : public QuicTestWithParam<QuicTransportVersion> { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 28 | protected: |
| 29 | QuicConfig config_; |
| 30 | }; |
| 31 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 32 | // Run all tests with all versions of QUIC. |
| 33 | INSTANTIATE_TEST_SUITE_P(QuicConfigTests, |
| 34 | QuicConfigTest, |
dschinazi | 142051a | 2019-09-18 18:17:29 -0700 | [diff] [blame] | 35 | ::testing::ValuesIn(AllSupportedTransportVersions()), |
| 36 | ::testing::PrintToStringParamName()); |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 37 | |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 38 | TEST_P(QuicConfigTest, SetDefaults) { |
| 39 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 40 | config_.GetInitialStreamFlowControlWindowToSend()); |
| 41 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 42 | config_.GetInitialMaxStreamDataBytesIncomingBidirectionalToSend()); |
| 43 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 44 | config_.GetInitialMaxStreamDataBytesOutgoingBidirectionalToSend()); |
| 45 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 46 | config_.GetInitialMaxStreamDataBytesUnidirectionalToSend()); |
| 47 | EXPECT_FALSE(config_.HasReceivedInitialStreamFlowControlWindowBytes()); |
| 48 | EXPECT_FALSE( |
| 49 | config_.HasReceivedInitialMaxStreamDataBytesIncomingBidirectional()); |
| 50 | EXPECT_FALSE( |
| 51 | config_.HasReceivedInitialMaxStreamDataBytesOutgoingBidirectional()); |
| 52 | EXPECT_FALSE(config_.HasReceivedInitialMaxStreamDataBytesUnidirectional()); |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 53 | EXPECT_EQ(kMaxIncomingPacketSize, config_.GetMaxPacketSizeToSend()); |
| 54 | EXPECT_FALSE(config_.HasReceivedMaxPacketSize()); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 55 | } |
| 56 | |
dschinazi | 90165ee | 2019-10-15 15:11:41 -0700 | [diff] [blame] | 57 | TEST_P(QuicConfigTest, AutoSetIetfFlowControl) { |
| 58 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 59 | config_.GetInitialStreamFlowControlWindowToSend()); |
| 60 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 61 | config_.GetInitialMaxStreamDataBytesIncomingBidirectionalToSend()); |
| 62 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 63 | config_.GetInitialMaxStreamDataBytesOutgoingBidirectionalToSend()); |
| 64 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 65 | config_.GetInitialMaxStreamDataBytesUnidirectionalToSend()); |
| 66 | static const uint32_t kTestWindowSize = 1234567; |
| 67 | config_.SetInitialStreamFlowControlWindowToSend(kTestWindowSize); |
| 68 | EXPECT_EQ(kTestWindowSize, config_.GetInitialStreamFlowControlWindowToSend()); |
| 69 | EXPECT_EQ(kTestWindowSize, |
| 70 | config_.GetInitialMaxStreamDataBytesIncomingBidirectionalToSend()); |
| 71 | EXPECT_EQ(kTestWindowSize, |
| 72 | config_.GetInitialMaxStreamDataBytesOutgoingBidirectionalToSend()); |
| 73 | EXPECT_EQ(kTestWindowSize, |
| 74 | config_.GetInitialMaxStreamDataBytesUnidirectionalToSend()); |
| 75 | static const uint32_t kTestWindowSizeTwo = 2345678; |
| 76 | config_.SetInitialMaxStreamDataBytesIncomingBidirectionalToSend( |
| 77 | kTestWindowSizeTwo); |
| 78 | EXPECT_EQ(kTestWindowSize, config_.GetInitialStreamFlowControlWindowToSend()); |
| 79 | EXPECT_EQ(kTestWindowSizeTwo, |
| 80 | config_.GetInitialMaxStreamDataBytesIncomingBidirectionalToSend()); |
| 81 | EXPECT_EQ(kTestWindowSize, |
| 82 | config_.GetInitialMaxStreamDataBytesOutgoingBidirectionalToSend()); |
| 83 | EXPECT_EQ(kTestWindowSize, |
| 84 | config_.GetInitialMaxStreamDataBytesUnidirectionalToSend()); |
| 85 | } |
| 86 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 87 | TEST_P(QuicConfigTest, ToHandshakeMessage) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 88 | config_.SetInitialStreamFlowControlWindowToSend( |
| 89 | kInitialStreamFlowControlWindowForTest); |
| 90 | config_.SetInitialSessionFlowControlWindowToSend( |
| 91 | kInitialSessionFlowControlWindowForTest); |
| 92 | config_.SetIdleNetworkTimeout(QuicTime::Delta::FromSeconds(5), |
| 93 | QuicTime::Delta::FromSeconds(2)); |
| 94 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 95 | config_.ToHandshakeMessage(&msg, GetParam()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 96 | |
| 97 | uint32_t value; |
| 98 | QuicErrorCode error = msg.GetUint32(kICSL, &value); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 99 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 100 | EXPECT_EQ(5u, value); |
| 101 | |
| 102 | error = msg.GetUint32(kSFCW, &value); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 103 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 104 | EXPECT_EQ(kInitialStreamFlowControlWindowForTest, value); |
| 105 | |
| 106 | error = msg.GetUint32(kCFCW, &value); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 107 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 108 | EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value); |
| 109 | } |
| 110 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 111 | TEST_P(QuicConfigTest, ProcessClientHello) { |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 112 | const uint32_t kTestMaxAckDelayMs = |
| 113 | static_cast<uint32_t>(kDefaultDelayedAckTimeMs + 1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 114 | QuicConfig client_config; |
| 115 | QuicTagVector cgst; |
| 116 | cgst.push_back(kQBIC); |
| 117 | client_config.SetIdleNetworkTimeout( |
| 118 | QuicTime::Delta::FromSeconds(2 * kMaximumIdleTimeoutSecs), |
| 119 | QuicTime::Delta::FromSeconds(kMaximumIdleTimeoutSecs)); |
| 120 | client_config.SetInitialRoundTripTimeUsToSend(10 * kNumMicrosPerMilli); |
| 121 | client_config.SetInitialStreamFlowControlWindowToSend( |
| 122 | 2 * kInitialStreamFlowControlWindowForTest); |
| 123 | client_config.SetInitialSessionFlowControlWindowToSend( |
| 124 | 2 * kInitialSessionFlowControlWindowForTest); |
| 125 | QuicTagVector copt; |
| 126 | copt.push_back(kTBBR); |
| 127 | client_config.SetConnectionOptionsToSend(copt); |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 128 | client_config.SetMaxAckDelayToSendMs(kTestMaxAckDelayMs); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 129 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 130 | client_config.ToHandshakeMessage(&msg, GetParam()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 131 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 132 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 133 | QuicTagVector initial_received_options; |
| 134 | initial_received_options.push_back(kIW50); |
| 135 | EXPECT_TRUE( |
| 136 | config_.SetInitialReceivedConnectionOptions(initial_received_options)); |
| 137 | EXPECT_FALSE( |
| 138 | config_.SetInitialReceivedConnectionOptions(initial_received_options)) |
| 139 | << "You can only set initial options once."; |
| 140 | const QuicErrorCode error = |
| 141 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
| 142 | EXPECT_FALSE( |
| 143 | config_.SetInitialReceivedConnectionOptions(initial_received_options)) |
| 144 | << "You cannot set initial options after the hello."; |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 145 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 146 | EXPECT_TRUE(config_.negotiated()); |
| 147 | EXPECT_EQ(QuicTime::Delta::FromSeconds(kMaximumIdleTimeoutSecs), |
| 148 | config_.IdleNetworkTimeout()); |
| 149 | EXPECT_EQ(10 * kNumMicrosPerMilli, config_.ReceivedInitialRoundTripTimeUs()); |
| 150 | EXPECT_TRUE(config_.HasReceivedConnectionOptions()); |
| 151 | EXPECT_EQ(2u, config_.ReceivedConnectionOptions().size()); |
| 152 | EXPECT_EQ(config_.ReceivedConnectionOptions()[0], kIW50); |
| 153 | EXPECT_EQ(config_.ReceivedConnectionOptions()[1], kTBBR); |
| 154 | EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(), |
| 155 | 2 * kInitialStreamFlowControlWindowForTest); |
| 156 | EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(), |
| 157 | 2 * kInitialSessionFlowControlWindowForTest); |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 158 | if (GetQuicReloadableFlag(quic_negotiate_ack_delay_time)) { |
| 159 | EXPECT_TRUE(config_.HasReceivedMaxAckDelayMs()); |
| 160 | EXPECT_EQ(kTestMaxAckDelayMs, config_.ReceivedMaxAckDelayMs()); |
| 161 | } else { |
| 162 | EXPECT_FALSE(config_.HasReceivedMaxAckDelayMs()); |
| 163 | } |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 164 | |
| 165 | // IETF QUIC stream limits should not be received in QUIC crypto messages. |
| 166 | EXPECT_FALSE( |
| 167 | config_.HasReceivedInitialMaxStreamDataBytesIncomingBidirectional()); |
| 168 | EXPECT_FALSE( |
| 169 | config_.HasReceivedInitialMaxStreamDataBytesOutgoingBidirectional()); |
| 170 | EXPECT_FALSE(config_.HasReceivedInitialMaxStreamDataBytesUnidirectional()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 171 | } |
| 172 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 173 | TEST_P(QuicConfigTest, ProcessServerHello) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 174 | QuicIpAddress host; |
| 175 | host.FromString("127.0.3.1"); |
| 176 | const QuicSocketAddress kTestServerAddress = QuicSocketAddress(host, 1234); |
| 177 | const QuicUint128 kTestResetToken = MakeQuicUint128(0, 10111100001); |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 178 | const uint32_t kTestMaxAckDelayMs = |
| 179 | static_cast<uint32_t>(kDefaultDelayedAckTimeMs + 1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 180 | QuicConfig server_config; |
| 181 | QuicTagVector cgst; |
| 182 | cgst.push_back(kQBIC); |
| 183 | server_config.SetIdleNetworkTimeout( |
| 184 | QuicTime::Delta::FromSeconds(kMaximumIdleTimeoutSecs / 2), |
| 185 | QuicTime::Delta::FromSeconds(kMaximumIdleTimeoutSecs / 2)); |
| 186 | server_config.SetInitialRoundTripTimeUsToSend(10 * kNumMicrosPerMilli); |
| 187 | server_config.SetInitialStreamFlowControlWindowToSend( |
| 188 | 2 * kInitialStreamFlowControlWindowForTest); |
| 189 | server_config.SetInitialSessionFlowControlWindowToSend( |
| 190 | 2 * kInitialSessionFlowControlWindowForTest); |
| 191 | server_config.SetAlternateServerAddressToSend(kTestServerAddress); |
| 192 | server_config.SetStatelessResetTokenToSend(kTestResetToken); |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 193 | server_config.SetMaxAckDelayToSendMs(kTestMaxAckDelayMs); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 194 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 195 | server_config.ToHandshakeMessage(&msg, GetParam()); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 196 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 197 | const QuicErrorCode error = |
| 198 | config_.ProcessPeerHello(msg, SERVER, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 199 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 200 | EXPECT_TRUE(config_.negotiated()); |
| 201 | EXPECT_EQ(QuicTime::Delta::FromSeconds(kMaximumIdleTimeoutSecs / 2), |
| 202 | config_.IdleNetworkTimeout()); |
| 203 | EXPECT_EQ(10 * kNumMicrosPerMilli, config_.ReceivedInitialRoundTripTimeUs()); |
| 204 | EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(), |
| 205 | 2 * kInitialStreamFlowControlWindowForTest); |
| 206 | EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(), |
| 207 | 2 * kInitialSessionFlowControlWindowForTest); |
| 208 | EXPECT_TRUE(config_.HasReceivedAlternateServerAddress()); |
| 209 | EXPECT_EQ(kTestServerAddress, config_.ReceivedAlternateServerAddress()); |
| 210 | EXPECT_TRUE(config_.HasReceivedStatelessResetToken()); |
| 211 | EXPECT_EQ(kTestResetToken, config_.ReceivedStatelessResetToken()); |
fkastenholz | 4c7303c | 2019-07-29 08:17:07 -0700 | [diff] [blame] | 212 | if (GetQuicReloadableFlag(quic_negotiate_ack_delay_time)) { |
| 213 | EXPECT_TRUE(config_.HasReceivedMaxAckDelayMs()); |
| 214 | EXPECT_EQ(kTestMaxAckDelayMs, config_.ReceivedMaxAckDelayMs()); |
| 215 | } else { |
| 216 | EXPECT_FALSE(config_.HasReceivedMaxAckDelayMs()); |
| 217 | } |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 218 | |
| 219 | // IETF QUIC stream limits should not be received in QUIC crypto messages. |
| 220 | EXPECT_FALSE( |
| 221 | config_.HasReceivedInitialMaxStreamDataBytesIncomingBidirectional()); |
| 222 | EXPECT_FALSE( |
| 223 | config_.HasReceivedInitialMaxStreamDataBytesOutgoingBidirectional()); |
| 224 | EXPECT_FALSE(config_.HasReceivedInitialMaxStreamDataBytesUnidirectional()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 225 | } |
| 226 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 227 | TEST_P(QuicConfigTest, MissingOptionalValuesInCHLO) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 228 | CryptoHandshakeMessage msg; |
| 229 | msg.SetValue(kICSL, 1); |
| 230 | |
| 231 | // Set all REQUIRED tags. |
| 232 | msg.SetValue(kICSL, 1); |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 233 | msg.SetValue(kMIBS, 1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 234 | |
| 235 | // No error, as rest are optional. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 236 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 237 | const QuicErrorCode error = |
| 238 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 239 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 240 | EXPECT_TRUE(config_.negotiated()); |
| 241 | } |
| 242 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 243 | TEST_P(QuicConfigTest, MissingOptionalValuesInSHLO) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 244 | CryptoHandshakeMessage msg; |
| 245 | |
| 246 | // Set all REQUIRED tags. |
| 247 | msg.SetValue(kICSL, 1); |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 248 | msg.SetValue(kMIBS, 1); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 249 | |
| 250 | // No error, as rest are optional. |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 251 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 252 | const QuicErrorCode error = |
| 253 | config_.ProcessPeerHello(msg, SERVER, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 254 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 255 | EXPECT_TRUE(config_.negotiated()); |
| 256 | } |
| 257 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 258 | TEST_P(QuicConfigTest, MissingValueInCHLO) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 259 | // Server receives CHLO with missing kICSL. |
| 260 | CryptoHandshakeMessage msg; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 261 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 262 | const QuicErrorCode error = |
| 263 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 264 | EXPECT_THAT(error, IsError(QUIC_CRYPTO_MESSAGE_PARAMETER_NOT_FOUND)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 265 | } |
| 266 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 267 | TEST_P(QuicConfigTest, MissingValueInSHLO) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 268 | // Client receives SHLO with missing kICSL. |
| 269 | CryptoHandshakeMessage msg; |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 270 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 271 | const QuicErrorCode error = |
| 272 | config_.ProcessPeerHello(msg, SERVER, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 273 | EXPECT_THAT(error, IsError(QUIC_CRYPTO_MESSAGE_PARAMETER_NOT_FOUND)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 274 | } |
| 275 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 276 | TEST_P(QuicConfigTest, OutOfBoundSHLO) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 277 | QuicConfig server_config; |
| 278 | server_config.SetIdleNetworkTimeout( |
| 279 | QuicTime::Delta::FromSeconds(2 * kMaximumIdleTimeoutSecs), |
| 280 | QuicTime::Delta::FromSeconds(2 * kMaximumIdleTimeoutSecs)); |
| 281 | |
| 282 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 283 | server_config.ToHandshakeMessage(&msg, GetParam()); |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 284 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 285 | const QuicErrorCode error = |
| 286 | config_.ProcessPeerHello(msg, SERVER, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 287 | EXPECT_THAT(error, IsError(QUIC_INVALID_NEGOTIATED_VALUE)); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 288 | } |
| 289 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 290 | TEST_P(QuicConfigTest, InvalidFlowControlWindow) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 291 | // QuicConfig should not accept an invalid flow control window to send to the |
| 292 | // peer: the receive window must be at least the default of 16 Kb. |
| 293 | QuicConfig config; |
| 294 | const uint64_t kInvalidWindow = kMinimumFlowControlSendWindow - 1; |
| 295 | EXPECT_QUIC_BUG( |
| 296 | config.SetInitialStreamFlowControlWindowToSend(kInvalidWindow), |
| 297 | "Initial stream flow control receive window"); |
| 298 | |
| 299 | EXPECT_EQ(kMinimumFlowControlSendWindow, |
| 300 | config.GetInitialStreamFlowControlWindowToSend()); |
| 301 | } |
| 302 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 303 | TEST_P(QuicConfigTest, HasClientSentConnectionOption) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 304 | QuicConfig client_config; |
| 305 | QuicTagVector copt; |
| 306 | copt.push_back(kTBBR); |
| 307 | client_config.SetConnectionOptionsToSend(copt); |
| 308 | EXPECT_TRUE(client_config.HasClientSentConnectionOption( |
| 309 | kTBBR, Perspective::IS_CLIENT)); |
| 310 | |
| 311 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 312 | client_config.ToHandshakeMessage(&msg, GetParam()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 313 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 314 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 315 | const QuicErrorCode error = |
| 316 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 317 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 318 | EXPECT_TRUE(config_.negotiated()); |
| 319 | |
| 320 | EXPECT_TRUE(config_.HasReceivedConnectionOptions()); |
| 321 | EXPECT_EQ(1u, config_.ReceivedConnectionOptions().size()); |
| 322 | EXPECT_TRUE( |
| 323 | config_.HasClientSentConnectionOption(kTBBR, Perspective::IS_SERVER)); |
| 324 | } |
| 325 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 326 | TEST_P(QuicConfigTest, DontSendClientConnectionOptions) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 327 | QuicConfig client_config; |
| 328 | QuicTagVector copt; |
| 329 | copt.push_back(kTBBR); |
| 330 | client_config.SetClientConnectionOptions(copt); |
| 331 | |
| 332 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 333 | client_config.ToHandshakeMessage(&msg, GetParam()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 334 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 335 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 336 | const QuicErrorCode error = |
| 337 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 338 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 339 | EXPECT_TRUE(config_.negotiated()); |
| 340 | |
| 341 | EXPECT_FALSE(config_.HasReceivedConnectionOptions()); |
| 342 | } |
| 343 | |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 344 | TEST_P(QuicConfigTest, HasClientRequestedIndependentOption) { |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 345 | QuicConfig client_config; |
| 346 | QuicTagVector client_opt; |
| 347 | client_opt.push_back(kRENO); |
| 348 | QuicTagVector copt; |
| 349 | copt.push_back(kTBBR); |
| 350 | client_config.SetClientConnectionOptions(client_opt); |
| 351 | client_config.SetConnectionOptionsToSend(copt); |
| 352 | EXPECT_TRUE(client_config.HasClientSentConnectionOption( |
| 353 | kTBBR, Perspective::IS_CLIENT)); |
| 354 | EXPECT_TRUE(client_config.HasClientRequestedIndependentOption( |
| 355 | kRENO, Perspective::IS_CLIENT)); |
| 356 | EXPECT_FALSE(client_config.HasClientRequestedIndependentOption( |
| 357 | kTBBR, Perspective::IS_CLIENT)); |
| 358 | |
| 359 | CryptoHandshakeMessage msg; |
fkastenholz | d3a1de9 | 2019-05-15 07:00:07 -0700 | [diff] [blame] | 360 | client_config.ToHandshakeMessage(&msg, GetParam()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 361 | |
vasilvv | c48c871 | 2019-03-11 13:38:16 -0700 | [diff] [blame] | 362 | std::string error_details; |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 363 | const QuicErrorCode error = |
| 364 | config_.ProcessPeerHello(msg, CLIENT, &error_details); |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 365 | EXPECT_THAT(error, IsQuicNoError()); |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 366 | EXPECT_TRUE(config_.negotiated()); |
| 367 | |
| 368 | EXPECT_TRUE(config_.HasReceivedConnectionOptions()); |
| 369 | EXPECT_EQ(1u, config_.ReceivedConnectionOptions().size()); |
| 370 | EXPECT_FALSE(config_.HasClientRequestedIndependentOption( |
| 371 | kRENO, Perspective::IS_SERVER)); |
| 372 | EXPECT_TRUE(config_.HasClientRequestedIndependentOption( |
| 373 | kTBBR, Perspective::IS_SERVER)); |
| 374 | } |
| 375 | |
dschinazi | 6464c4a | 2019-09-11 16:25:01 -0700 | [diff] [blame] | 376 | TEST_P(QuicConfigTest, IncomingLargeIdleTimeoutTransportParameter) { |
| 377 | // Configure our default to 30s and max to 60s, then receive 120s from peer. |
| 378 | // Since the received value is above the max, we should then use the max. |
| 379 | config_.SetIdleNetworkTimeout(quic::QuicTime::Delta::FromSeconds(60), |
| 380 | quic::QuicTime::Delta::FromSeconds(30)); |
| 381 | TransportParameters params; |
| 382 | params.idle_timeout_milliseconds.set_value(120000); |
| 383 | |
| 384 | std::string error_details = "foobar"; |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 385 | EXPECT_THAT( |
| 386 | config_.ProcessTransportParameters(params, SERVER, &error_details), |
| 387 | IsQuicNoError()); |
dschinazi | 6464c4a | 2019-09-11 16:25:01 -0700 | [diff] [blame] | 388 | EXPECT_EQ("", error_details); |
| 389 | EXPECT_EQ(quic::QuicTime::Delta::FromSeconds(60), |
| 390 | config_.IdleNetworkTimeout()); |
| 391 | } |
| 392 | |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 393 | TEST_P(QuicConfigTest, FillTransportParams) { |
| 394 | config_.SetInitialMaxStreamDataBytesIncomingBidirectionalToSend( |
| 395 | 2 * kMinimumFlowControlSendWindow); |
| 396 | config_.SetInitialMaxStreamDataBytesOutgoingBidirectionalToSend( |
| 397 | 3 * kMinimumFlowControlSendWindow); |
| 398 | config_.SetInitialMaxStreamDataBytesUnidirectionalToSend( |
| 399 | 4 * kMinimumFlowControlSendWindow); |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 400 | config_.SetMaxPacketSizeToSend(kMaxPacketSizeForTest); |
dschinazi | cd86dd1 | 2019-11-14 10:11:13 -0800 | [diff] [blame] | 401 | config_.SetMaxDatagramFrameSizeToSend(kMaxDatagramFrameSizeForTest); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 402 | |
| 403 | TransportParameters params; |
| 404 | config_.FillTransportParameters(¶ms); |
| 405 | |
| 406 | EXPECT_EQ(2 * kMinimumFlowControlSendWindow, |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 407 | params.initial_max_stream_data_bidi_remote.value()); |
dschinazi | 18cdf13 | 2019-10-09 16:08:18 -0700 | [diff] [blame] | 408 | EXPECT_EQ(3 * kMinimumFlowControlSendWindow, |
| 409 | params.initial_max_stream_data_bidi_local.value()); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 410 | EXPECT_EQ(4 * kMinimumFlowControlSendWindow, |
| 411 | params.initial_max_stream_data_uni.value()); |
dschinazi | aab6818 | 2019-10-09 15:39:51 -0700 | [diff] [blame] | 412 | |
| 413 | EXPECT_EQ(static_cast<uint64_t>(kMaximumIdleTimeoutSecs * 1000), |
| 414 | params.idle_timeout_milliseconds.value()); |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 415 | |
| 416 | EXPECT_EQ(kMaxPacketSizeForTest, params.max_packet_size.value()); |
dschinazi | cd86dd1 | 2019-11-14 10:11:13 -0800 | [diff] [blame] | 417 | EXPECT_EQ(kMaxDatagramFrameSizeForTest, |
| 418 | params.max_datagram_frame_size.value()); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 419 | } |
| 420 | |
| 421 | TEST_P(QuicConfigTest, ProcessTransportParametersServer) { |
| 422 | TransportParameters params; |
| 423 | |
| 424 | params.initial_max_stream_data_bidi_local.set_value( |
| 425 | 2 * kMinimumFlowControlSendWindow); |
| 426 | params.initial_max_stream_data_bidi_remote.set_value( |
| 427 | 3 * kMinimumFlowControlSendWindow); |
| 428 | params.initial_max_stream_data_uni.set_value(4 * |
| 429 | kMinimumFlowControlSendWindow); |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 430 | params.max_packet_size.set_value(kMaxPacketSizeForTest); |
dschinazi | cd86dd1 | 2019-11-14 10:11:13 -0800 | [diff] [blame] | 431 | params.max_datagram_frame_size.set_value(kMaxDatagramFrameSizeForTest); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 432 | |
| 433 | std::string error_details; |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 434 | EXPECT_THAT( |
| 435 | config_.ProcessTransportParameters(params, SERVER, &error_details), |
| 436 | IsQuicNoError()); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 437 | |
| 438 | ASSERT_TRUE( |
| 439 | config_.HasReceivedInitialMaxStreamDataBytesIncomingBidirectional()); |
| 440 | EXPECT_EQ(2 * kMinimumFlowControlSendWindow, |
| 441 | config_.ReceivedInitialMaxStreamDataBytesIncomingBidirectional()); |
| 442 | |
| 443 | ASSERT_TRUE( |
| 444 | config_.HasReceivedInitialMaxStreamDataBytesOutgoingBidirectional()); |
| 445 | EXPECT_EQ(3 * kMinimumFlowControlSendWindow, |
| 446 | config_.ReceivedInitialMaxStreamDataBytesOutgoingBidirectional()); |
| 447 | |
| 448 | ASSERT_TRUE(config_.HasReceivedInitialMaxStreamDataBytesUnidirectional()); |
| 449 | EXPECT_EQ(4 * kMinimumFlowControlSendWindow, |
| 450 | config_.ReceivedInitialMaxStreamDataBytesUnidirectional()); |
dschinazi | 5888113 | 2019-11-11 11:34:02 -0800 | [diff] [blame] | 451 | |
| 452 | ASSERT_TRUE(config_.HasReceivedMaxPacketSize()); |
| 453 | EXPECT_EQ(kMaxPacketSizeForTest, config_.ReceivedMaxPacketSize()); |
dschinazi | cd86dd1 | 2019-11-14 10:11:13 -0800 | [diff] [blame] | 454 | |
| 455 | ASSERT_TRUE(config_.HasReceivedMaxDatagramFrameSize()); |
| 456 | EXPECT_EQ(kMaxDatagramFrameSizeForTest, |
| 457 | config_.ReceivedMaxDatagramFrameSize()); |
| 458 | |
dschinazi | 8067d55 | 2019-11-13 19:44:00 -0800 | [diff] [blame] | 459 | EXPECT_FALSE(config_.DisableConnectionMigration()); |
| 460 | } |
| 461 | |
| 462 | TEST_P(QuicConfigTest, DisableMigrationTransportParameter) { |
| 463 | TransportParameters params; |
| 464 | params.disable_migration = true; |
| 465 | std::string error_details; |
bnc | f54082a | 2019-11-27 10:19:47 -0800 | [diff] [blame] | 466 | EXPECT_THAT( |
| 467 | config_.ProcessTransportParameters(params, SERVER, &error_details), |
| 468 | IsQuicNoError()); |
dschinazi | 8067d55 | 2019-11-13 19:44:00 -0800 | [diff] [blame] | 469 | EXPECT_TRUE(config_.DisableConnectionMigration()); |
rch | b045185 | 2019-09-11 21:17:01 -0700 | [diff] [blame] | 470 | } |
| 471 | |
QUICHE team | a6ef0a6 | 2019-03-07 20:34:33 -0500 | [diff] [blame] | 472 | } // namespace |
| 473 | } // namespace test |
| 474 | } // namespace quic |