Fix 7 ClangTidyReadability findings:
* function 'bytes' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'bytes_transmitted' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'get_value' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'packets' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'packets_transmitted' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'times_cancelled' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
* function 'times_set' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
This CL looks good? Just grant approval!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/clang-tidy-bug for category ClangTidyReadability if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* For all other issues such as the formatting of the CL, please file a bug under
go/clrobot-bug.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/third_party/quiche/METADATA.common which is reachable following include_presubmits from //depot/google3/third_party/quic/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#clrobot #readability-redundant-inline-specifier
Tested:
Local presubmit tests passed.
PiperOrigin-RevId: 925120951
diff --git a/quiche/quic/test_tools/simulator/simulator_test.cc b/quiche/quic/test_tools/simulator/simulator_test.cc
index 93197cf..cae5fab 100644
--- a/quiche/quic/test_tools/simulator/simulator_test.cc
+++ b/quiche/quic/test_tools/simulator/simulator_test.cc
@@ -36,7 +36,7 @@
}
~Counter() override {}
- inline int get_value() const { return value_; }
+ int get_value() const { return value_; }
void Act() override {
++value_;
@@ -77,8 +77,8 @@
CounterPort() { Reset(); }
~CounterPort() override {}
- inline QuicByteCount bytes() const { return bytes_; }
- inline QuicPacketCount packets() const { return packets_; }
+ QuicByteCount bytes() const { return bytes_; }
+ QuicPacketCount packets() const { return packets_; }
void AcceptPacket(std::unique_ptr<Packet> packet) override {
bytes_ += packet->size;
@@ -148,10 +148,8 @@
CounterPort* counter() { return &rx_port_; }
- inline QuicByteCount bytes_transmitted() const { return bytes_transmitted_; }
- inline QuicPacketCount packets_transmitted() const {
- return packets_transmitted_;
- }
+ QuicByteCount bytes_transmitted() const { return bytes_transmitted_; }
+ QuicPacketCount packets_transmitted() const { return packets_transmitted_; }
void Pause() { Unschedule(); }
void Resume() { Schedule(clock_->Now()); }
@@ -458,8 +456,8 @@
Schedule(clock_->Now() + interval_);
}
- inline int times_set() { return times_set_; }
- inline int times_cancelled() { return times_cancelled_; }
+ int times_set() { return times_set_; }
+ int times_cancelled() { return times_cancelled_; }
private:
QuicAlarm* alarm_;