Fix 4 ClangInliner findings:
Details for what is fixed can be found at the top of each file.
See go/inliner-lsc for more information on why you've received this change and why it is important.
This CL looks good? Just grant approval!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/inliner-bug for category ClangInliner if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* For all other issues such as the formatting of the CL, please file a bug under
go/clrobot-bug.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#clrobot #third_party-googletest-googlemock-include-gmock-gmock-actions.h
Tested:
Local presubmit tests passed.
PiperOrigin-RevId: 952051014
diff --git a/quiche/quic/core/qpack/qpack_instruction_decoder_test.cc b/quiche/quic/core/qpack/qpack_instruction_decoder_test.cc
index a7b8262..f4b6087 100644
--- a/quiche/quic/core/qpack/qpack_instruction_decoder_test.cc
+++ b/quiche/quic/core/qpack/qpack_instruction_decoder_test.cc
@@ -83,7 +83,7 @@
// Destroy QpackInstructionDecoder on error to test that it does not crash.
// See https://crbug.com/1025209.
ON_CALL(delegate_, OnInstructionDecodingError(_, _))
- .WillByDefault(InvokeWithoutArgs([this]() { decoder_.reset(); }));
+ .WillByDefault([this]() { decoder_.reset(); });
}
// Decode one full instruction with fragment sizes dictated by
@@ -203,18 +203,18 @@
// First instruction is valid.
Expectation first_call =
EXPECT_CALL(delegate_, OnInstructionDecoded(TestInstruction1()))
- .WillOnce(InvokeWithoutArgs([this]() -> bool {
+ .WillOnce([this]() -> bool {
EXPECT_EQ(1u, decoder_->varint());
return true;
- }));
+ });
// Second instruction is invalid. Decoding must halt.
EXPECT_CALL(delegate_, OnInstructionDecoded(TestInstruction1()))
.After(first_call)
- .WillOnce(InvokeWithoutArgs([this]() -> bool {
+ .WillOnce([this]() -> bool {
EXPECT_EQ(2u, decoder_->varint());
return false;
- }));
+ });
std::string encoded_data;
ASSERT_TRUE(absl::HexStringToBytes("01000200030004000500", &encoded_data));
@@ -225,11 +225,11 @@
// Delegate::OnInstructionDecoded() call as long as it returns false.
TEST_P(QpackInstructionDecoderTest, DelegateSignalsErrorAndDestroysDecoder) {
EXPECT_CALL(delegate_, OnInstructionDecoded(TestInstruction1()))
- .WillOnce(InvokeWithoutArgs([this]() -> bool {
+ .WillOnce([this]() -> bool {
EXPECT_EQ(1u, decoder_->varint());
decoder_.reset();
return false;
- }));
+ });
std::string encoded_data;
ASSERT_TRUE(absl::HexStringToBytes("0100", &encoded_data));
DecodeInstruction(encoded_data);