Delete quic_flags_impl.{h,cc}.
Merge contents into quiche_flags_impl.{h,cc}.
PiperOrigin-RevId: 465550584
diff --git a/build/source_list.bzl b/build/source_list.bzl
index 0d8046e..30d068a 100644
--- a/build/source_list.bzl
+++ b/build/source_list.bzl
@@ -1388,7 +1388,6 @@
"http2/adapter/nghttp2_util_test.cc",
]
default_platform_impl_hdrs = [
- "common/platform/default/quiche_platform_impl/quic_flags_impl.h",
"common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
@@ -1411,7 +1410,6 @@
"common/platform/default/quiche_platform_impl/quiche_url_utils_impl.h",
]
default_platform_impl_srcs = [
- "common/platform/default/quiche_platform_impl/quic_flags_impl.cc",
"common/platform/default/quiche_platform_impl/quiche_flags_impl.cc",
"common/platform/default/quiche_platform_impl/quiche_mutex_impl.cc",
"common/platform/default/quiche_platform_impl/quiche_stack_trace_impl.cc",
diff --git a/build/source_list.gni b/build/source_list.gni
index b53797a..daadaf6 100644
--- a/build/source_list.gni
+++ b/build/source_list.gni
@@ -1388,7 +1388,6 @@
"src/quiche/http2/adapter/nghttp2_util_test.cc",
]
default_platform_impl_hdrs = [
- "src/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
@@ -1411,7 +1410,6 @@
"src/quiche/common/platform/default/quiche_platform_impl/quiche_url_utils_impl.h",
]
default_platform_impl_srcs = [
- "src/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.cc",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_mutex_impl.cc",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_stack_trace_impl.cc",
diff --git a/build/source_list.json b/build/source_list.json
index d65d487..ca31469 100644
--- a/build/source_list.json
+++ b/build/source_list.json
@@ -1387,7 +1387,6 @@
"quiche/http2/adapter/nghttp2_util_test.cc"
],
"default_platform_impl_hdrs": [
- "quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
@@ -1410,7 +1409,6 @@
"quiche/common/platform/default/quiche_platform_impl/quiche_url_utils_impl.h"
],
"default_platform_impl_srcs": [
- "quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.cc",
"quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc",
"quiche/common/platform/default/quiche_platform_impl/quiche_mutex_impl.cc",
"quiche/common/platform/default/quiche_platform_impl/quiche_stack_trace_impl.cc",
diff --git a/quiche/common/platform/api/quiche_flags.h b/quiche/common/platform/api/quiche_flags.h
index 26a933c..5fb23bf 100644
--- a/quiche/common/platform/api/quiche_flags.h
+++ b/quiche/common/platform/api/quiche_flags.h
@@ -5,7 +5,6 @@
#ifndef QUICHE_COMMON_PLATFORM_API_QUICHE_FLAGS_H_
#define QUICHE_COMMON_PLATFORM_API_QUICHE_FLAGS_H_
-#include "quiche_platform_impl/quic_flags_impl.h"
#include "quiche_platform_impl/quiche_flags_impl.h"
// Flags accessed via GetQuicheReloadableFlag/GetQuicheRestartFlag are temporary
diff --git a/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.cc b/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.cc
deleted file mode 100644
index df2c88e..0000000
--- a/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.cc
+++ /dev/null
@@ -1,29 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "quiche_platform_impl/quic_flags_impl.h"
-
-#define DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE(type, flag, value, doc) \
- type FLAGS_##flag = value;
-
-#define DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES(type, flag, internal_value, \
- external_value, doc) \
- type FLAGS_##flag = external_value;
-
-// Preprocessor macros can only have one definition.
-// Select the right macro based on the number of arguments.
-#define GET_6TH_ARG(arg1, arg2, arg3, arg4, arg5, arg6, ...) arg6
-#define QUIC_PROTOCOL_FLAG_MACRO_CHOOSER(...) \
- GET_6TH_ARG(__VA_ARGS__, DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES, \
- DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE)
-#define QUIC_PROTOCOL_FLAG(...) \
- QUIC_PROTOCOL_FLAG_MACRO_CHOOSER(__VA_ARGS__)(__VA_ARGS__)
-
-#include "quiche/quic/core/quic_protocol_flags_list.h"
-
-#undef QUIC_PROTOCOL_FLAG
-#undef QUIC_PROTOCOL_FLAG_MACRO_CHOOSER
-#undef GET_6TH_ARG
-#undef DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES
-#undef DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE
diff --git a/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.h b/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.h
deleted file mode 100644
index 23758ca..0000000
--- a/quiche/common/platform/default/quiche_platform_impl/quic_flags_impl.h
+++ /dev/null
@@ -1,17 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef QUICHE_COMMON_PLATFORM_DEFAULT_QUICHE_PLATFORM_IMPL_QUIC_FLAGS_IMPL_H_
-#define QUICHE_COMMON_PLATFORM_DEFAULT_QUICHE_PLATFORM_IMPL_QUIC_FLAGS_IMPL_H_
-
-#include <cstdint>
-
-#include "quiche/common/platform/api/quiche_export.h"
-
-#define QUIC_PROTOCOL_FLAG(type, flag, ...) \
- QUICHE_EXPORT_PRIVATE extern type FLAGS_##flag;
-#include "quiche/quic/core/quic_protocol_flags_list.h"
-#undef QUIC_PROTOCOL_FLAG
-
-#endif // QUICHE_COMMON_PLATFORM_DEFAULT_QUICHE_PLATFORM_IMPL_QUIC_FLAGS_IMPL_H_
diff --git a/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc b/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc
index d753bd7..eb60983 100644
--- a/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc
+++ b/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.cc
@@ -8,6 +8,30 @@
#include "quiche/quic/core/quic_flags_list.h"
#undef QUIC_FLAG
+#define DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE(type, flag, value, doc) \
+ type FLAGS_##flag = value;
+
+#define DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES(type, flag, internal_value, \
+ external_value, doc) \
+ type FLAGS_##flag = external_value;
+
+// Preprocessor macros can only have one definition.
+// Select the right macro based on the number of arguments.
+#define GET_6TH_ARG(arg1, arg2, arg3, arg4, arg5, arg6, ...) arg6
+#define QUIC_PROTOCOL_FLAG_MACRO_CHOOSER(...) \
+ GET_6TH_ARG(__VA_ARGS__, DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES, \
+ DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE)
+#define QUIC_PROTOCOL_FLAG(...) \
+ QUIC_PROTOCOL_FLAG_MACRO_CHOOSER(__VA_ARGS__)(__VA_ARGS__)
+
+#include "quiche/quic/core/quic_protocol_flags_list.h"
+
+#undef QUIC_PROTOCOL_FLAG
+#undef QUIC_PROTOCOL_FLAG_MACRO_CHOOSER
+#undef GET_6TH_ARG
+#undef DEFINE_QUIC_PROTOCOL_FLAG_TWO_VALUES
+#undef DEFINE_QUIC_PROTOCOL_FLAG_SINGLE_VALUE
+
#define QUICHE_PROTOCOL_FLAG(type, flag, value, doc) type FLAGS_##flag = value;
#include "quiche/common/quiche_protocol_flags_list.h"
#undef QUICHE_PROTOCOL_FLAG
diff --git a/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.h b/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.h
index 2ef8b61..df14e0f 100644
--- a/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.h
+++ b/quiche/common/platform/default/quiche_platform_impl/quiche_flags_impl.h
@@ -17,6 +17,12 @@
#include "quiche/quic/core/quic_flags_list.h"
#undef QUIC_FLAG
+// Protocol flags. TODO(bnc): Move to quiche_protocol_flags_list.h.
+#define QUIC_PROTOCOL_FLAG(type, flag, ...) \
+ QUICHE_EXPORT_PRIVATE extern type FLAGS_##flag;
+#include "quiche/quic/core/quic_protocol_flags_list.h"
+#undef QUIC_PROTOCOL_FLAG
+
// Protocol flags.
#define QUICHE_PROTOCOL_FLAG(type, flag, ...) \
QUICHE_EXPORT_PRIVATE extern type FLAGS_##flag;
diff --git a/quiche/quic/core/qpack/qpack_decoded_headers_accumulator.cc b/quiche/quic/core/qpack/qpack_decoded_headers_accumulator.cc
index 0f4766b..b932b3d 100644
--- a/quiche/quic/core/qpack/qpack_decoded_headers_accumulator.cc
+++ b/quiche/quic/core/qpack/qpack_decoded_headers_accumulator.cc
@@ -8,6 +8,7 @@
#include "quiche/quic/core/qpack/qpack_decoder.h"
#include "quiche/quic/core/qpack/qpack_header_table.h"
#include "quiche/quic/platform/api/quic_bug_tracker.h"
+#include "quiche/quic/platform/api/quic_flags.h"
namespace quic {
diff --git a/quiche/quic/core/quic_ping_manager.cc b/quiche/quic/core/quic_ping_manager.cc
index da7c423..961eb8d 100644
--- a/quiche/quic/core/quic_ping_manager.cc
+++ b/quiche/quic/core/quic_ping_manager.cc
@@ -4,6 +4,8 @@
#include "quiche/quic/core/quic_ping_manager.h"
+#include "quiche/quic/platform/api/quic_flags.h"
+
namespace quic {
namespace {
