Deprecate gfe2_reloadable_flag_quic_blocked_ports PiperOrigin-RevId: 412119269
diff --git a/quic/core/quic_dispatcher.cc b/quic/core/quic_dispatcher.cc index a1e89b2..4221d4f 100644 --- a/quic/core/quic_dispatcher.cc +++ b/quic/core/quic_dispatcher.cc
@@ -495,13 +495,7 @@ } namespace { -inline bool IsSourceUdpPortBlocked(uint16_t port) { - // TODO(dschinazi) make this function constexpr when we remove flag - // protection. - if (!GetQuicReloadableFlag(quic_blocked_ports)) { - return port == 0; - } - QUIC_RELOADABLE_FLAG_COUNT(quic_blocked_ports); +constexpr bool IsSourceUdpPortBlocked(uint16_t port) { // These UDP source ports have been observed in large scale denial of service // attacks and are not expected to ever carry user traffic, they are therefore // blocked as a safety measure. See draft-ietf-quic-applicability for details.
diff --git a/quic/core/quic_dispatcher_test.cc b/quic/core/quic_dispatcher_test.cc index 199270e..ca4ae48 100644 --- a/quic/core/quic_dispatcher_test.cc +++ b/quic/core/quic_dispatcher_test.cc
@@ -1216,7 +1216,6 @@ } TEST_P(QuicDispatcherTestAllVersions, ProcessPacketWithBlockedPort) { - SetQuicReloadableFlag(quic_blocked_ports, true); CreateTimeWaitListManager(); QuicSocketAddress client_address(QuicIpAddress::Loopback4(), 17);
diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h index 9942173..1726182 100644 --- a/quic/core/quic_flags_list.h +++ b/quic/core/quic_flags_list.h
@@ -127,8 +127,6 @@ QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_ignore_user_agent_transport_parameter, true) // When true, QUIC will both send and validate the version_information transport parameter. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_version_information, false) -// When true, QuicDispatcher will silently drop incoming packets whose UDP source port is on the blocklist. -QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_blocked_ports, true) // When true, defaults to BBR congestion control instead of Cubic. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_default_to_bbr, false) // When true, prevents QUIC\'s PacingSender from generating bursts when the congestion controller is CWND limited and not pacing limited.