Deprecate gfe2_reloadable_flag_quic_add_upperbound_for_queued_packets. PiperOrigin-RevId: 404817360
diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h index be5ef35..1c70b08 100644 --- a/quic/core/quic_flags_list.h +++ b/quic/core/quic_flags_list.h
@@ -99,8 +99,6 @@ QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_require_handshake_confirmation, false) // If true, reset per packet state before processing undecryptable packets. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_reset_per_packet_state_for_undecryptable_packets, true) -// If true, respect FLAGS_quic_time_wait_list_max_pending_packets as the upper bound of queued packets in time wait list. -QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_add_upperbound_for_queued_packets, true) // If true, restore connection context in various callbacks in TlsServerHandshaker. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_tls_restore_connection_context_in_callbacks, true) // If true, send PATH_RESPONSE upon receiving PATH_CHALLENGE regardless of perspective. --gfe2_reloadable_flag_quic_start_peer_migration_earlier has to be true before turn on this flag.
diff --git a/quic/core/quic_time_wait_list_manager.cc b/quic/core/quic_time_wait_list_manager.cc index c92b636..da01d2a 100644 --- a/quic/core/quic_time_wait_list_manager.cc +++ b/quic/core/quic_time_wait_list_manager.cc
@@ -370,9 +370,8 @@ QUIC_LOG(ERROR) << "Tried to send or queue a null packet"; return true; } - if (GetQuicReloadableFlag(quic_add_upperbound_for_queued_packets) && - pending_packets_queue_.size() >= - GetQuicFlag(FLAGS_quic_time_wait_list_max_pending_packets)) { + if (pending_packets_queue_.size() >= + GetQuicFlag(FLAGS_quic_time_wait_list_max_pending_packets)) { // There are too many pending packets. QUIC_CODE_COUNT(quic_too_many_pending_packets_in_time_wait); return true;
diff --git a/quic/core/quic_time_wait_list_manager_test.cc b/quic/core/quic_time_wait_list_manager_test.cc index 3610535..fcfdbbb 100644 --- a/quic/core/quic_time_wait_list_manager_test.cc +++ b/quic/core/quic_time_wait_list_manager_test.cc
@@ -778,16 +778,9 @@ QuicFramer::GetMinStatelessResetPacketLength() + 1, /*packet_context=*/nullptr); } - if (GetQuicReloadableFlag(quic_add_upperbound_for_queued_packets)) { - // Verify pending packet queue size is limited. - EXPECT_EQ(5u, QuicTimeWaitListManagerPeer::PendingPacketsQueueSize( - &time_wait_list_manager_)); - } else { - // The pending packet queue grows unbounded. - EXPECT_EQ(kNumOfUnProcessablePackets, - QuicTimeWaitListManagerPeer::PendingPacketsQueueSize( - &time_wait_list_manager_)); - } + // Verify pending packet queue size is limited. + EXPECT_EQ(5u, QuicTimeWaitListManagerPeer::PendingPacketsQueueSize( + &time_wait_list_manager_)); } } // namespace