commit f59e72c032c7a827eee1915975bdfd867e96b384
author fayang <fayang@google.com> Tue Oct 27 08:46:45 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Oct 27 08:47:19 2020 -0700
tree 592405cfcbd5e5f06708a51a72d8cc714d375599
parent cb150c5cbe6728f54fc3697c35d6ed9b354cd70d

Deprecate gfe2_reloadable_flag_quic_add_missing_connected_checks.

PiperOrigin-RevId: 339256926
Change-Id: Ide5f4f57f155d1f552d48f285524d34f0b49c3f3

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index cf6f0e3..0bbceaa 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -355,9 +355,6 @@
            self_address_.IsInitialized());
     QUIC_RELOADABLE_FLAG_COUNT(quic_connection_set_initial_self_address);
   }
-  if (fix_missing_connected_checks_) {
-    QUIC_RELOADABLE_FLAG_COUNT(quic_add_missing_connected_checks);
-  }
   if (enable_aead_limits_) {
     QUIC_RELOADABLE_FLAG_COUNT(quic_enable_aead_limits);
   }
@@ -3526,7 +3523,7 @@
     DCHECK(!IsHandshakeComplete());
   }
 #endif
-  if (fix_missing_connected_checks_ && !connected_) {
+  if (!connected_) {
     return;
   }
 
@@ -4121,7 +4118,7 @@
 }
 
 void QuicConnection::SetRetransmissionAlarm() {
-  if (fix_missing_connected_checks_ && !connected_) {
+  if (!connected_) {
     if (retransmission_alarm_->IsSet()) {
       QUIC_BUG << ENDPOINT << "Retransmission alarm is set while disconnected";
       retransmission_alarm_->Cancel();
@@ -4624,8 +4621,7 @@
 }
 
 void QuicConnection::CheckIfApplicationLimited() {
-  if ((fix_missing_connected_checks_ && !connected_) ||
-      probing_retransmission_pending_) {
+  if (!connected_ || probing_retransmission_pending_) {
     return;
   }
 
@@ -5022,7 +5018,7 @@
 
 bool QuicConnection::FlushCoalescedPacket() {
   ScopedCoalescedPacketClearer clearer(&coalesced_packet_);
-  if (fix_missing_connected_checks_ && !connected_) {
+  if (!connected_) {
     return false;
   }
   if (!version().CanSendCoalescedPackets()) {

quic/core/quic_connection.h

diff --git a/quic/core/quic_connection.h b/quic/core/quic_connection.h
index 5778724..45eb1cb 100644
--- a/quic/core/quic_connection.h
+++ b/quic/core/quic_connection.h
@@ -1897,9 +1897,6 @@
   bool start_peer_migration_earlier_ =
       GetQuicReloadableFlag(quic_start_peer_migration_earlier);
 
-  bool fix_missing_connected_checks_ =
-      GetQuicReloadableFlag(quic_add_missing_connected_checks);
-
   // latch --gfe2_reloadable_flag_quic_send_path_response and
   // --gfe2_reloadable_flag_quic_start_peer_migration_earlier.
   bool send_path_response_ = start_peer_migration_earlier_ &&