commit ebc71c10d631a3de51d259dbb443a2ad548376b7
author QUICHE team <quiche-dev@google.com> Thu Sep 10 08:00:10 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Sep 10 08:00:45 2020 -0700
tree 03ce325c3b5f44b77574793a350f559ed0602be8
parent 434c4c0b1d32a5462499c0a1006c785b4a766bb6

Fix use-after-move in SimpleLinkedHashMap

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check (see
https://crbug.com/1122844).

PiperOrigin-RevId: 330937081
Change-Id: I4a9e742d128c444b3c3fec63a35c86bbf2772c7d

common/simple_linked_hash_map.h

diff --git a/common/simple_linked_hash_map.h b/common/simple_linked_hash_map.h
index 6eb6ed9..36933bc 100644
--- a/common/simple_linked_hash_map.h
+++ b/common/simple_linked_hash_map.h
@@ -212,7 +212,7 @@
     typename ListType::iterator last = list_.end();
     --last;
 
-    CHECK(map_.insert(std::make_pair(pair.first, last)).second)
+    CHECK(map_.insert(std::make_pair(last->first, last)).second)
         << "Map and list are inconsistent";
     return std::make_pair(last, true);
   }