Deprecate --gfe2_reloadable_flag_quic_clear_body_manager_along_with_sequencer. This flag is deprecated and the behavior is now always enabled. PiperOrigin-RevId: 936646052
diff --git a/quiche/common/quiche_feature_flags_list.h b/quiche/common/quiche_feature_flags_list.h index 49825df..ca1c819 100755 --- a/quiche/common/quiche_feature_flags_list.h +++ b/quiche/common/quiche_feature_flags_list.h
@@ -17,7 +17,6 @@ QUICHE_FLAG(bool, quiche_reloadable_flag_quic_bbr_exit_startup_on_loss_network_param, false, true, "Enables adjustment of BBRv1's exit-startup-on-loss behavior on established connections via NetworkParams::enable_bbr_exit_startup_on_loss.") QUICHE_FLAG(bool, quiche_reloadable_flag_quic_block_until_settings_received_copt, true, true, "If enabled and a BSUS connection is received, blocks server connections until SETTINGS frame is received.") QUICHE_FLAG(bool, quiche_reloadable_flag_quic_check_alternate_reset_token, false, false, "When true, checks the stateless reset token on a path probe using the alternate path's token") -QUICHE_FLAG(bool, quiche_reloadable_flag_quic_clear_body_manager_along_with_sequencer, true, true, "If true, QuicSpdyStream::StopReading always clears BodyManager along with the SequenceBuffer.") QUICHE_FLAG(bool, quiche_reloadable_flag_quic_clear_packet_on_serialization_failure, false, false, "If true, clear QuicPacketCreator state when serialization failure.") QUICHE_FLAG(bool, quiche_reloadable_flag_quic_client_check_blockage_before_on_can_write, false, false, "If true, quic clients will only call OnCanWrite() upon write events if the writer is unblocked.") QUICHE_FLAG(bool, quiche_reloadable_flag_quic_close_on_idle_timeout, false, false, "If true, closes the connection if it has exceeded the idle timeout when deciding whether to open a stream.")
diff --git a/quiche/quic/core/http/quic_spdy_stream.cc b/quiche/quic/core/http/quic_spdy_stream.cc index e0d7f96..ed57d71 100644 --- a/quiche/quic/core/http/quic_spdy_stream.cc +++ b/quiche/quic/core/http/quic_spdy_stream.cc
@@ -1961,10 +1961,7 @@ void QuicSpdyStream::StopReading() { QuicStream::StopReading(); - if (GetQuicReloadableFlag(quic_clear_body_manager_along_with_sequencer)) { - QUICHE_RELOADABLE_FLAG_COUNT(quic_clear_body_manager_along_with_sequencer); - body_manager_.Clear(); - } + body_manager_.Clear(); if (VersionIsIetfQuic(transport_version()) && !fin_received() && spdy_session_->qpack_decoder()) { // Clean up Qpack decoding states.
diff --git a/quiche/quic/core/http/quic_spdy_stream_test.cc b/quiche/quic/core/http/quic_spdy_stream_test.cc index 6bd56f1..58406c0 100644 --- a/quiche/quic/core/http/quic_spdy_stream_test.cc +++ b/quiche/quic/core/http/quic_spdy_stream_test.cc
@@ -3853,12 +3853,10 @@ stream_->StopReading(); EXPECT_TRUE(stream_->sequencer()->IsClosed()); stream_->set_should_process_data(true); - if (GetQuicReloadableFlag(quic_clear_body_manager_along_with_sequencer)) { - std::string old_data = stream_->data(); - stream_->sequencer()->SetUnblocked(); - // No new data should have been consumed. - EXPECT_EQ(old_data, stream_->data()); - } + std::string old_data = stream_->data(); + stream_->sequencer()->SetUnblocked(); + // No new data should have been consumed. + EXPECT_EQ(old_data, stream_->data()); } // Regression test for b/488057588. @@ -3866,7 +3864,6 @@ if (!IsIetfQuic()) { return; } - SetQuicReloadableFlag(quic_clear_body_manager_along_with_sequencer, true); Initialize(kShouldProcessData);