commit dad8fadd04563dbeb1cae44b4f2a164032e6dd3c
author wub <wub@google.com> Tue Jun 14 15:29:26 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jun 14 15:30:32 2022 -0700
tree 95f1b80beb47f8ad8ed44a5f634522f39e689552
parent e48e609f9d3bb2d659191bce18813c17e9ff9e81

Add inplace constructors for QuicheMemSlice and QuicheMemSliceImpl and use them in quic::WriteGfeMemSliceSpanToStream and video_streaming::QuicExternalRequest::WriteBody.

This avoids the creation of 3 temporary gfe2::MemSlice objects for every QuicheMemSlice created.

PiperOrigin-RevId: 454970726

quiche/common/platform/api/quiche_mem_slice.h

diff --git a/quiche/common/platform/api/quiche_mem_slice.h b/quiche/common/platform/api/quiche_mem_slice.h
index bb703a4..42c3e58 100644
--- a/quiche/common/platform/api/quiche_mem_slice.h
+++ b/quiche/common/platform/api/quiche_mem_slice.h
@@ -31,9 +31,13 @@
   QuicheMemSlice(std::unique_ptr<char[]> buffer, size_t length)
       : impl_(std::move(buffer), length) {}
 
-  // Constructs QuicheMemSlice from |impl|. It takes the reference away from
-  // |impl|.
-  explicit QuicheMemSlice(QuicheMemSliceImpl impl) : impl_(std::move(impl)) {}
+  // Ensures the use of the in-place constructor (below) is intentional.
+  struct InPlace {};
+
+  // Constructs a QuicheMemSlice by constructing |impl_| in-place.
+  template <typename... Args>
+  explicit QuicheMemSlice(InPlace, Args&&... args)
+      : impl_{std::forward<Args>(args)...} {}
 
   QuicheMemSlice(const QuicheMemSlice& other) = delete;
   QuicheMemSlice& operator=(const QuicheMemSlice& other) = delete;