commit d85af47aae7ed301c23b9dc7225e175381fe52ee
author bschneider <bschneider@google.com> Fri Sep 23 08:29:39 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Sep 23 08:30:41 2022 -0700
tree af6f980356d2976dc3f964b03c2cba62160a0ec6
parent 25487132255dd03ed030d9d3c519b46613705f9f

Switch EXPECT_OK an ASSERT_OK to EXPECT_TRUE and ASSERT_TRUE.

Closes #22

PiperOrigin-RevId: 476376863

quiche/binary_http/binary_http_message_test.cc

diff --git a/quiche/binary_http/binary_http_message_test.cc b/quiche/binary_http/binary_http_message_test.cc
index f98a375..67a1326 100644
--- a/quiche/binary_http/binary_http_message_test.cc
+++ b/quiche/binary_http/binary_http_message_test.cc
@@ -619,59 +619,68 @@
 TEST(BinaryHttpResponse, Equality) {
   BinaryHttpResponse response(200);
   response.AddHeaderField({"Server", "Apache"})->set_body("Hello, world!\r\n");
-  ASSERT_OK(
-      response.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}));
+  ASSERT_TRUE(
+      response.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+          .ok());
 
   BinaryHttpResponse same(200);
   same.AddHeaderField({"Server", "Apache"})->set_body("Hello, world!\r\n");
-  ASSERT_OK(same.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}));
+  ASSERT_TRUE(
+      same.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}).ok());
   ASSERT_EQ(response, same);
 }
 
 TEST(BinaryHttpResponse, Inequality) {
   BinaryHttpResponse response(200);
   response.AddHeaderField({"Server", "Apache"})->set_body("Hello, world!\r\n");
-  ASSERT_OK(
-      response.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}));
+  ASSERT_TRUE(
+      response.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+          .ok());
 
   BinaryHttpResponse different_status(201);
   different_status.AddHeaderField({"Server", "Apache"})
       ->set_body("Hello, world!\r\n");
-  EXPECT_OK(different_status.AddInformationalResponse(
-      102, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(different_status
+                  .AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+                  .ok());
   EXPECT_NE(response, different_status);
 
   BinaryHttpResponse different_header(200);
   different_header.AddHeaderField({"Server", "python3"})
       ->set_body("Hello, world!\r\n");
-  EXPECT_OK(different_header.AddInformationalResponse(
-      102, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(different_header
+                  .AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+                  .ok());
   EXPECT_NE(response, different_header);
 
   BinaryHttpResponse no_header(200);
   no_header.set_body("Hello, world!\r\n");
-  EXPECT_OK(
-      no_header.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(
+      no_header.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+          .ok());
   EXPECT_NE(response, no_header);
 
   BinaryHttpResponse different_body(200);
   different_body.AddHeaderField({"Server", "Apache"})
       ->set_body("Goodbye, world!\r\n");
-  EXPECT_OK(different_body.AddInformationalResponse(
-      102, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(different_body
+                  .AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+                  .ok());
   EXPECT_NE(response, different_body);
 
   BinaryHttpResponse no_body(200);
   no_body.AddHeaderField({"Server", "Apache"});
-  EXPECT_OK(
-      no_body.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(
+      no_body.AddInformationalResponse(102, {{"Running", "\"sleep 15\""}})
+          .ok());
   EXPECT_NE(response, no_body);
 
   BinaryHttpResponse different_informational(200);
   different_informational.AddHeaderField({"Server", "Apache"})
       ->set_body("Hello, world!\r\n");
-  EXPECT_OK(different_informational.AddInformationalResponse(
-      198, {{"Running", "\"sleep 15\""}}));
+  EXPECT_TRUE(different_informational
+                  .AddInformationalResponse(198, {{"Running", "\"sleep 15\""}})
+                  .ok());
   EXPECT_NE(response, different_informational);
 
   BinaryHttpResponse no_informational(200);