commit ce06ef5d2c149369269981ad5a48849873da14ee
author QUICHE team <quiche-dev@google.com> Mon Jul 26 09:48:06 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jul 26 09:49:44 2021 -0700
tree b5061f718706bdbc410418ea8abf2a74cb92254b
parent 3df755e294e6654a727d1aeb7e61ee3b8c6eed54

Fix some instances of -Wunused-but-set-variable.

Bug: chromium:1203071
PiperOrigin-RevId: 386896023

quic/core/quic_connection_test.cc

diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc
index c16121c..a303afb 100644
--- a/quic/core/quic_connection_test.cc
+++ b/quic/core/quic_connection_test.cc
@@ -3762,11 +3762,9 @@
 
 TEST_P(QuicConnectionTest, RetransmitOnNack) {
   QuicPacketNumber last_packet;
-  QuicByteCount second_packet_size;
-  SendStreamDataToPeer(3, "foo", 0, NO_FIN, &last_packet);  // Packet 1
-  second_packet_size =
-      SendStreamDataToPeer(3, "foos", 3, NO_FIN, &last_packet);  // Packet 2
-  SendStreamDataToPeer(3, "fooos", 7, NO_FIN, &last_packet);     // Packet 3
+  SendStreamDataToPeer(3, "foo", 0, NO_FIN, &last_packet);
+  SendStreamDataToPeer(3, "foos", 3, NO_FIN, &last_packet);
+  SendStreamDataToPeer(3, "fooos", 7, NO_FIN, &last_packet);
 
   EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
 

quic/test_tools/qpack/qpack_offline_decoder.cc

diff --git a/quic/test_tools/qpack/qpack_offline_decoder.cc b/quic/test_tools/qpack/qpack_offline_decoder.cc
index ad7155a..a7ea1be 100644
--- a/quic/test_tools/qpack/qpack_offline_decoder.cc
+++ b/quic/test_tools/qpack/qpack_offline_decoder.cc
@@ -86,12 +86,7 @@
   auto piece_it = pieces.rbegin();
 
   // Acknowledgement mode: 1 for immediate, 0 for none.
-  bool immediate_acknowledgement = false;
-  if (*piece_it == "0") {
-    immediate_acknowledgement = false;
-  } else if (*piece_it == "1") {
-    immediate_acknowledgement = true;
-  } else {
+  if (*piece_it != "0" && *piece_it != "1") {
     QUIC_LOG(ERROR)
         << "Header acknowledgement field must be 0 or 1 in input filename "
         << input_filename;