commit c91e76e6d44bf89b8591a1d21f4d1f31fd856157
author wub <wub@google.com> Tue Aug 10 08:04:32 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Aug 10 08:05:06 2021 -0700
tree 382046786b164eeed21ff289d067b6a13be2dc2b
parent baa2cfb8cac2cc2fe97f6a5d16aab01e386fdaae

Deflake QuicIdleNetworkDetectorTest by always enabling --quic_idle_network_detector_no_alarm_after_stopped, which is being rolled out this week.

Verified  test passed with randomized flags: http://sponge2/4947c724-ffc3-4160-ae67-b14b470cc359

PiperOrigin-RevId: 389885666

quic/core/quic_idle_network_detector_test.cc

diff --git a/quic/core/quic_idle_network_detector_test.cc b/quic/core/quic_idle_network_detector_test.cc
index 11d0cf7..278b72b 100644
--- a/quic/core/quic_idle_network_detector_test.cc
+++ b/quic/core/quic_idle_network_detector_test.cc
@@ -30,6 +30,8 @@
 class QuicIdleNetworkDetectorTest : public QuicTest {
  public:
   QuicIdleNetworkDetectorTest() {
+    SetQuicReloadableFlag(quic_idle_network_detector_no_alarm_after_stopped,
+                          true);
     clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
     detector_ = std::make_unique<QuicIdleNetworkDetector>(
         &delegate_, clock_.Now(), &arena_, &alarm_factory_);
@@ -185,20 +187,12 @@
 TEST_F(QuicIdleNetworkDetectorTest, NoAlarmAfterStopped) {
   detector_->StopDetection();
 
-  if (GetQuicReloadableFlag(
-          quic_idle_network_detector_no_alarm_after_stopped)) {
-    EXPECT_QUIC_BUG(
-        detector_->SetTimeouts(
-            /*handshake_timeout=*/QuicTime::Delta::FromSeconds(30),
-            /*idle_network_timeout=*/QuicTime::Delta::FromSeconds(20)),
-        "SetAlarm called after stopped");
-    EXPECT_FALSE(alarm_->IsSet());
-  } else {
-    detector_->SetTimeouts(
-        /*handshake_timeout=*/QuicTime::Delta::FromSeconds(30),
-        /*idle_network_timeout=*/QuicTime::Delta::FromSeconds(20));
-    EXPECT_TRUE(alarm_->IsSet());
-  }
+  EXPECT_QUIC_BUG(
+      detector_->SetTimeouts(
+          /*handshake_timeout=*/QuicTime::Delta::FromSeconds(30),
+          /*idle_network_timeout=*/QuicTime::Delta::FromSeconds(20)),
+      "SetAlarm called after stopped");
+  EXPECT_FALSE(alarm_->IsSet());
 }
 
 }  // namespace