commit c8a1ee0391c7ddbf00ebd8044c86c2758ee0c19d
author QUICHE team <quiche-dev@google.com> Fri Jun 25 14:59:37 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 25 15:00:13 2021 -0700
tree d2d8ff8a4a143c50a3d7f3dfb3a45cdca0934c5a
parent 6b3d3900789c728a8d09a7b165f5b9f200266649

Actually set SPDY_CONTROL_PAYLOAD_TOO_LARGE Http2DecoderAdapter::OnFrameSizeError

Looks like SPDY_CONTROL_PAYLOAD_TOO_LARGE was never set.

Bug: chromium:1222490
PiperOrigin-RevId: 381554797

spdy/core/http2_frame_decoder_adapter.cc

diff --git a/spdy/core/http2_frame_decoder_adapter.cc b/spdy/core/http2_frame_decoder_adapter.cc
index 90fc6b7..be896ef 100644
--- a/spdy/core/http2_frame_decoder_adapter.cc
+++ b/spdy/core/http2_frame_decoder_adapter.cc
@@ -774,12 +774,12 @@
   QUICHE_DVLOG(1) << "OnFrameSizeError: " << header;
   size_t recv_limit = recv_frame_size_limit_;
   if (header.payload_length > recv_limit) {
-    SetSpdyErrorAndNotify(SpdyFramerError::SPDY_OVERSIZED_PAYLOAD, "");
-    return;
-  }
-  if (header.type != Http2FrameType::DATA &&
-      header.payload_length > recv_limit) {
-    SetSpdyErrorAndNotify(SpdyFramerError::SPDY_CONTROL_PAYLOAD_TOO_LARGE, "");
+    if (header.type == Http2FrameType::DATA) {
+      SetSpdyErrorAndNotify(SpdyFramerError::SPDY_OVERSIZED_PAYLOAD, "");
+    } else {
+      SetSpdyErrorAndNotify(SpdyFramerError::SPDY_CONTROL_PAYLOAD_TOO_LARGE,
+                            "");
+    }
     return;
   }
   switch (header.type) {