commit bb6620fa0678bd8f2d9b648d2c30df54ca58b06b
author birenroy <birenroy@google.com> Mon Jun 06 15:19:12 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jun 06 15:27:49 2022 -0700
tree cb9f62b26e27667276ccc2413d1db0f288eff2ad
parent ae7299c8bc414ca58bd1b17b15de13aa0612c71b

Reorders cases in OgHttp2Session::OnSetting() to match the order of the settings defined in RFC 7540.

PiperOrigin-RevId: 453294307

quiche/http2/adapter/oghttp2_session.cc

diff --git a/quiche/http2/adapter/oghttp2_session.cc b/quiche/http2/adapter/oghttp2_session.cc
index 8be0fe8..9f48090 100644
--- a/quiche/http2/adapter/oghttp2_session.cc
+++ b/quiche/http2/adapter/oghttp2_session.cc
@@ -1218,26 +1218,6 @@
 
 void OgHttp2Session::OnSetting(spdy::SpdySettingsId id, uint32_t value) {
   switch (id) {
-    case MAX_FRAME_SIZE:
-      if (value < kDefaultFramePayloadSizeLimit ||
-          value > kMaximumFramePayloadSizeLimit) {
-        visitor_.OnInvalidFrame(
-            0, Http2VisitorInterface::InvalidFrameError::kProtocol);
-        // The specification says this is a connection-level protocol error.
-        LatchErrorAndNotify(
-            Http2ErrorCode::PROTOCOL_ERROR,
-            Http2VisitorInterface::ConnectionError::kInvalidSetting);
-        return;
-      }
-      max_frame_payload_ = value;
-      break;
-    case MAX_CONCURRENT_STREAMS:
-      max_outbound_concurrent_streams_ = value;
-      if (!IsServerSession()) {
-        // We may now be able to start pending streams.
-        StartPendingStreams();
-      }
-      break;
     case HEADER_TABLE_SIZE:
       value = std::min(value, HpackCapacityBound(options_));
       if (value < framer_.GetHpackEncoder()->CurrentHeaderTableSizeSetting()) {
@@ -1253,6 +1233,13 @@
         encoder_header_table_capacity_when_acking_ = value;
       }
       break;
+    case MAX_CONCURRENT_STREAMS:
+      max_outbound_concurrent_streams_ = value;
+      if (!IsServerSession()) {
+        // We may now be able to start pending streams.
+        StartPendingStreams();
+      }
+      break;
     case INITIAL_WINDOW_SIZE:
       if (value > spdy::kSpdyMaximumWindowSize) {
         visitor_.OnInvalidFrame(
@@ -1266,6 +1253,19 @@
         UpdateStreamSendWindowSizes(value);
       }
       break;
+    case MAX_FRAME_SIZE:
+      if (value < kDefaultFramePayloadSizeLimit ||
+          value > kMaximumFramePayloadSizeLimit) {
+        visitor_.OnInvalidFrame(
+            0, Http2VisitorInterface::InvalidFrameError::kProtocol);
+        // The specification says this is a connection-level protocol error.
+        LatchErrorAndNotify(
+            Http2ErrorCode::PROTOCOL_ERROR,
+            Http2VisitorInterface::ConnectionError::kInvalidSetting);
+        return;
+      }
+      max_frame_payload_ = value;
+      break;
     default:
       // TODO(bnc): See if C++17 inline constants are allowed in QUICHE.
       if (id == kMetadataExtensionId) {