commit afd8daad85b215c3f1c5e838d95b382da8ed0e7f
author fayang <fayang@google.com> Wed Jun 10 10:40:57 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Jun 10 10:41:30 2020 -0700
tree d5d13a31b10bdfab6ee9b0ea25ed9f9f2c0799b3
parent 749e69b2b39e826777e6c06b2105dabbc1eb03a9

Update a QUIC_BUG to make it clear that when timer fires in TLP/RTO/PTO mode, at least one packet will be sent eventually.

PiperOrigin-RevId: 315720299
Change-Id: I664541c00d6bbe77ac7f0959b4b153327fc6b9af

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index e7990d9..7b1b9af 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -3018,8 +3018,9 @@
   if (retransmission_mode == QuicSentPacketManager::PTO_MODE) {
     sent_packet_manager_.AdjustPendingTimerTransmissions();
   }
-  if (retransmission_mode != QuicSentPacketManager::LOSS_MODE) {
-    // When timer fires in TLP or RTO mode, ensure 1) at least one packet is
+  if (retransmission_mode != QuicSentPacketManager::LOSS_MODE &&
+      retransmission_mode != QuicSentPacketManager::HANDSHAKE_MODE) {
+    // When timer fires in TLP/RTO/PTO mode, ensure 1) at least one packet is
     // created, or there is data to send and available credit (such that
     // packets will be sent eventually).
     QUIC_BUG_IF(packet_creator_.packet_number() ==