commit a9622b2f6563dc25aed91ab3581566ef3e9a4d05
author fayang <fayang@google.com> Tue Oct 19 13:45:05 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Oct 19 13:45:50 2021 -0700
tree 221664b0d04ce74004ee45b78a2a404a7988c7e2
parent fdab2ecec7cea2183a9bda9c9e60670fd496dfab

Deprecate gfe2_reloadable_flag_quic_add_missing_update_ack_timeout.

PiperOrigin-RevId: 404356575

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index 7588a96..a93715d 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -318,10 +318,6 @@
   QUICHE_DCHECK(perspective_ == Perspective::IS_CLIENT ||
                 default_path_.self_address.IsInitialized());
 
-  if (add_missing_update_ack_timeout_) {
-    QUIC_RELOADABLE_FLAG_COUNT(quic_add_missing_update_ack_timeout);
-  }
-
   support_multiple_connection_ids_ =
       version().HasIetfQuicFrames() &&
       GetQuicRestartFlag(
@@ -1652,9 +1648,7 @@
   QUIC_DLOG(INFO) << ENDPOINT << "STOP_SENDING frame received for stream: "
                   << frame.stream_id
                   << " with error: " << frame.ietf_error_code;
-  if (add_missing_update_ack_timeout_) {
-    MaybeUpdateAckTimeout();
-  }
+  MaybeUpdateAckTimeout();
   visitor_->OnStopSendingFrame(frame);
   return connected_;
 }
@@ -1864,9 +1858,7 @@
   if (debug_visitor_ != nullptr) {
     debug_visitor_->OnMaxStreamsFrame(frame);
   }
-  if (add_missing_update_ack_timeout_) {
-    MaybeUpdateAckTimeout();
-  }
+  MaybeUpdateAckTimeout();
   return visitor_->OnMaxStreamsFrame(frame) && connected_;
 }
 
@@ -1883,9 +1875,7 @@
   if (debug_visitor_ != nullptr) {
     debug_visitor_->OnStreamsBlockedFrame(frame);
   }
-  if (add_missing_update_ack_timeout_) {
-    MaybeUpdateAckTimeout();
-  }
+  MaybeUpdateAckTimeout();
   return visitor_->OnStreamsBlockedFrame(frame) && connected_;
 }
 

quic/core/quic_connection.h

diff --git a/quic/core/quic_connection.h b/quic/core/quic_connection.h
index 5d8ff27..4f7f2b6 100644
--- a/quic/core/quic_connection.h
+++ b/quic/core/quic_connection.h
@@ -2278,9 +2278,6 @@
   const bool reset_per_packet_state_for_undecryptable_packets_ =
       GetQuicReloadableFlag(
           quic_reset_per_packet_state_for_undecryptable_packets);
-
-  const bool add_missing_update_ack_timeout_ =
-      GetQuicReloadableFlag(quic_add_missing_update_ack_timeout);
 };
 
 }  // namespace quic

quic/core/quic_connection_test.cc

diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc
index ad04ccf..09b4ebe 100644
--- a/quic/core/quic_connection_test.cc
+++ b/quic/core/quic_connection_test.cc
@@ -15358,8 +15358,7 @@
     connection_.SetFromConfig(config);
   }
   if (!version().HasIetfQuicFrames() ||
-      !connection_.connection_migration_use_new_cid() ||
-      !GetQuicReloadableFlag(quic_add_missing_update_ack_timeout)) {
+      !connection_.connection_migration_use_new_cid()) {
     return;
   }
   EXPECT_CALL(visitor_, SendNewConnectionId(_)).Times(2);

quic/core/quic_flags_list.h

diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h
index 1322716..be5ef35 100644
--- a/quic/core/quic_flags_list.h
+++ b/quic/core/quic_flags_list.h
@@ -35,8 +35,6 @@
 QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_accept_empty_crypto_frame, false)
 // If true, ack frequency frame can be sent from server to client.
 QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_can_send_ack_frequency, true)
-// If true, add missing MaybeUpdateAckTimeout for ack-eliciting frames.
-QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_add_missing_update_ack_timeout, true)
 // If true, allow client to enable BBRv2 on server via connection option \'B2ON\'.
 QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_allow_client_enabled_bbr_v2, false)
 // If true, always starts a new ack aggregation epoch if a full round has passed since the start of the current epoch.