Fix a QuicConnection connection close log
During IETF interop testing I realized that one of our logs was printing the decimal error code instead of the readable string. This CL fixes that to make debugging easier. It also removes the "private" special-casing which has been obsolete since we dropped support for T050. This change only modifies logging and therefore does not require flag protection.
PiperOrigin-RevId: 408662167
diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index ee706e5..d6d07c1 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -1826,7 +1826,10 @@
<< connection_id() << ", with error: "
<< QuicErrorCodeToString(frame.quic_error_code) << " ("
<< frame.error_details << ")"
- << ", transport error code: " << frame.wire_error_code
+ << ", transport error code: "
+ << QuicIetfTransportErrorCodeString(
+ static_cast<QuicIetfTransportErrorCodes>(
+ frame.wire_error_code))
<< ", error frame type: "
<< frame.transport_close_frame_type;
break;
diff --git a/quic/core/quic_error_codes.cc b/quic/core/quic_error_codes.cc
index af5525d..74922c3 100644
--- a/quic/core/quic_error_codes.cc
+++ b/quic/core/quic_error_codes.cc
@@ -291,9 +291,6 @@
}
std::string QuicIetfTransportErrorCodeString(QuicIetfTransportErrorCodes c) {
- if (static_cast<uint64_t>(c) >= 0xff00u) {
- return absl::StrCat("Private(", static_cast<uint64_t>(c), ")");
- }
if (c >= CRYPTO_ERROR_FIRST && c <= CRYPTO_ERROR_LAST) {
const int tls_error = static_cast<int>(c - CRYPTO_ERROR_FIRST);
const char* tls_error_description = SSL_alert_desc_string_long(tls_error);
diff --git a/quic/core/quic_error_codes_test.cc b/quic/core/quic_error_codes_test.cc
index f72c150..4c5517f 100644
--- a/quic/core/quic_error_codes_test.cc
+++ b/quic/core/quic_error_codes_test.cc
@@ -20,10 +20,6 @@
}
TEST_F(QuicErrorCodesTest, QuicIetfTransportErrorCodeString) {
- EXPECT_EQ("Private(65280)",
- QuicIetfTransportErrorCodeString(
- static_cast<quic::QuicIetfTransportErrorCodes>(0xff00u)));
-
EXPECT_EQ("CRYPTO_ERROR(missing extension)",
QuicIetfTransportErrorCodeString(
static_cast<quic::QuicIetfTransportErrorCodes>(
