commit a4a457d4acae7c43bf3c3e35c2f2a731ee397f00
author haoyuewang <haoyuewang@google.com> Thu May 06 06:48:17 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Thu May 06 06:48:52 2021 -0700
tree e64e869fcaaa903574e7d95be53c1f3e0b62911b
parent 30c9c73edfdf37adb6e7b91258ee653150c9a151

Explicitly instantiate all possible non-inline member functions of templated class QpackHeaderTableBase.

This might fix some missing reference in linking::
https://ci.chromium.org/ui/p/chromium/builders/try/mac_chromium_compile_dbg_ng/898791/overview

PiperOrigin-RevId: 372332777
Change-Id: Ifc5578f7bda34c276650f1e098fd10fb0ad72c46

quic/core/qpack/qpack_header_table.cc

diff --git a/quic/core/qpack/qpack_header_table.cc b/quic/core/qpack/qpack_header_table.cc
index 3284062..e39babf 100644
--- a/quic/core/qpack/qpack_header_table.cc
+++ b/quic/core/qpack/qpack_header_table.cc
@@ -10,27 +10,43 @@
 
 namespace quic {
 
-// Explicitly instantiate templated public non-virtual base class methods.
+// Explicitly instantiate all possible templated non-inline base class methods.
 
+template QpackHeaderTableBase<QpackEncoderDynamicTable>::QpackHeaderTableBase();
 template bool
 QpackHeaderTableBase<QpackEncoderDynamicTable>::EntryFitsDynamicTableCapacity(
     absl::string_view name,
     absl::string_view value) const;
+template uint64_t QpackHeaderTableBase<QpackEncoderDynamicTable>::InsertEntry(
+    absl::string_view name,
+    absl::string_view value);
 template bool QpackHeaderTableBase<
     QpackEncoderDynamicTable>::SetDynamicTableCapacity(uint64_t capacity);
 template bool
 QpackHeaderTableBase<QpackEncoderDynamicTable>::SetMaximumDynamicTableCapacity(
     uint64_t maximum_dynamic_table_capacity);
+template void
+QpackHeaderTableBase<QpackEncoderDynamicTable>::RemoveEntryFromEnd();
+template void QpackHeaderTableBase<
+    QpackEncoderDynamicTable>::EvictDownToCapacity(uint64_t capacity);
 
+template QpackHeaderTableBase<QpackDecoderDynamicTable>::QpackHeaderTableBase();
 template bool
 QpackHeaderTableBase<QpackDecoderDynamicTable>::EntryFitsDynamicTableCapacity(
     absl::string_view name,
     absl::string_view value) const;
+template uint64_t QpackHeaderTableBase<QpackDecoderDynamicTable>::InsertEntry(
+    absl::string_view name,
+    absl::string_view value);
 template bool QpackHeaderTableBase<
     QpackDecoderDynamicTable>::SetDynamicTableCapacity(uint64_t capacity);
 template bool
 QpackHeaderTableBase<QpackDecoderDynamicTable>::SetMaximumDynamicTableCapacity(
     uint64_t maximum_dynamic_table_capacity);
+template void
+QpackHeaderTableBase<QpackDecoderDynamicTable>::RemoveEntryFromEnd();
+template void QpackHeaderTableBase<
+    QpackDecoderDynamicTable>::EvictDownToCapacity(uint64_t capacity);
 
 template <typename DynamicEntryTable>
 QpackHeaderTableBase<DynamicEntryTable>::QpackHeaderTableBase()