commit a42442adf7b63f266451896de0c1093752ade8fd
author fayang <fayang@google.com> Fri Jun 19 10:44:55 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 19 10:45:31 2020 -0700
tree e585c5e371c660350ee18f9fa315b7f25d199093
parent 1c6e592bd976bd9e18075cf81c377d0b05236153

Do not flush all pending ACKs in QuicTestClient::WaitForResponseForMs since this seems to slow the loadtest.

PiperOrigin-RevId: 317336216
Change-Id: I15a16d46e0f05aa4f2d18cac065c1808bd1ed11d

quic/test_tools/quic_test_client.h

diff --git a/quic/test_tools/quic_test_client.h b/quic/test_tools/quic_test_client.h
index 4dc5a72..41e30b1 100644
--- a/quic/test_tools/quic_test_client.h
+++ b/quic/test_tools/quic_test_client.h
@@ -202,16 +202,12 @@
   void WaitForInitialResponse() { WaitForInitialResponseForMs(-1); }
 
   // Returns once at least one complete response or a connection close has been
-  // received from the server, or once the timeout expires. Also waits for
-  // pending ACKs to be flushed.
+  // received from the server, or once the timeout expires.
   // Passing in a timeout value of -1 disables the timeout. If multiple
   // responses are received while the client is waiting, subsequent calls to
   // this function will return immediately.
   void WaitForResponseForMs(int timeout_ms) {
-    WaitUntil(timeout_ms, [this]() {
-      return !closed_stream_states_.empty() &&
-             !client()->client_session()->connection()->HasPendingAcks();
-    });
+    WaitUntil(timeout_ms, [this]() { return !closed_stream_states_.empty(); });
     if (response_complete()) {
       QUIC_VLOG(1) << "Client received response:"
                    << response_headers()->DebugString() << response_body();