commit a2736fc2f94e88b38ffd24491c625854fa9aa7c3
author renjietang <renjietang@google.com> Thu Jul 18 11:07:23 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jul 18 12:43:50 2019 -0700
tree 0b00299777b53c1bc8ea53a63a2885a89439e844
parent 0fdff8e5d6734d8c69cd5fb7fed73de94f890212

Clarify member variable of QpackSendStream.

Adding "http3" to stream type so that it differentiates with QUIC stream type (Bidirectional/unidirectional).

gfe-relnote: v99 only, not protected.
PiperOrigin-RevId: 258806370
Change-Id: I02746a82a869367ff75da8e4f74f4b890395d9c4

quic/core/qpack/qpack_send_stream.cc

diff --git a/quic/core/qpack/qpack_send_stream.cc b/quic/core/qpack/qpack_send_stream.cc
index 75b9c57..250f9e4 100644
--- a/quic/core/qpack/qpack_send_stream.cc
+++ b/quic/core/qpack/qpack_send_stream.cc
@@ -10,9 +10,9 @@
 namespace quic {
 QpackSendStream::QpackSendStream(QuicStreamId id,
                                  QuicSpdySession* session,
-                                 uint64_t stream_type)
+                                 uint64_t http3_stream_type)
     : QuicStream(id, session, /*is_static = */ true, WRITE_UNIDIRECTIONAL),
-      stream_type_(stream_type),
+      http3_stream_type_(http3_stream_type),
       stream_type_sent_(false) {}
 
 void QpackSendStream::OnStreamReset(const QuicRstStreamFrame& /*frame*/) {
@@ -26,9 +26,9 @@
 void QpackSendStream::WriteStreamData(QuicStringPiece data) {
   QuicConnection::ScopedPacketFlusher flusher(session()->connection());
   if (!stream_type_sent_) {
-    char type[sizeof(stream_type_)];
+    char type[sizeof(http3_stream_type_)];
     QuicDataWriter writer(QUIC_ARRAYSIZE(type), type);
-    writer.WriteVarInt62(stream_type_);
+    writer.WriteVarInt62(http3_stream_type_);
     WriteOrBufferData(QuicStringPiece(writer.data(), writer.length()), false,
                       nullptr);
     stream_type_sent_ = true;

quic/core/qpack/qpack_send_stream.h

diff --git a/quic/core/qpack/qpack_send_stream.h b/quic/core/qpack/qpack_send_stream.h
index 4a10e7f..526cf6d 100644
--- a/quic/core/qpack/qpack_send_stream.h
+++ b/quic/core/qpack/qpack_send_stream.h
@@ -25,7 +25,7 @@
   // this stream.
   QpackSendStream(QuicStreamId id,
                   QuicSpdySession* session,
-                  uint64_t stream_type);
+                  uint64_t http3_stream_type);
   QpackSendStream(const QpackSendStream&) = delete;
   QpackSendStream& operator=(const QpackSendStream&) = delete;
   ~QpackSendStream() override = default;
@@ -43,7 +43,7 @@
   void WriteStreamData(QuicStringPiece data) override;
 
  private:
-  const uint64_t stream_type_;
+  const uint64_t http3_stream_type_;
   bool stream_type_sent_;
 };