commit a0cbbdc8f813ad4731c672c5eebc308cd8154bd8
author wub <wub@google.com> Mon Sep 09 06:40:59 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Sep 09 08:58:28 2019 -0700
tree 8a258147c0a28ca76e330a805762cf1001b79e9f
parent b2486b8ca513974c0df2479d07078e80cd8481d1

gfe-relnote: (n/a) Fix a use-of-uninitialized-value in QuicFramerTest.GetRetransmittableControlFrameSize. Test only.

This fixes https://crbug.com/1001905

PiperOrigin-RevId: 267985541
Change-Id: I621a04da9b9806dd956689843b1a7308f098f49f

quic/core/quic_framer_test.cc

diff --git a/quic/core/quic_framer_test.cc b/quic/core/quic_framer_test.cc
index f288441..a1bf902 100644
--- a/quic/core/quic_framer_test.cc
+++ b/quic/core/quic_framer_test.cc
@@ -11050,11 +11050,9 @@
                 framer_.transport_version(), QuicFrame(&rst_stream)));
 
   std::string error_detail(2048, 'e');
-  QuicConnectionCloseFrame connection_close(QUIC_NETWORK_IDLE_TIMEOUT,
-                                            error_detail);
-  if (VersionHasIetfQuicFrames(framer_.transport_version())) {
-    connection_close.close_type = IETF_QUIC_TRANSPORT_CONNECTION_CLOSE;
-  }
+  QuicConnectionCloseFrame connection_close(
+      framer_.transport_version(), QUIC_NETWORK_IDLE_TIMEOUT, error_detail,
+      /*transport_close_frame_type=*/0);
 
   EXPECT_EQ(QuicFramer::GetConnectionCloseFrameSize(framer_.transport_version(),
                                                     connection_close),