gfe-relnote: deprecate gfe2_reloadable_flag_quic_do_not_send_settings.
PiperOrigin-RevId: 275925308
Change-Id: I9e38a2bd66891ab158894952d14a86420e295680
diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index 474dc0b..513d270 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -601,20 +601,7 @@
// created HTTP/3 unidirectional streams.
qpack_encoder_send_stream_->MaybeSendStreamType();
qpack_decoder_send_stream_->MaybeSendStreamType();
- return;
}
- if (GetQuicReloadableFlag(quic_do_not_send_settings)) {
- QUIC_RELOADABLE_FLAG_COUNT(quic_do_not_send_settings);
- return;
- }
-
- SpdySettingsIR settings_frame;
- settings_frame.AddSetting(SETTINGS_MAX_HEADER_LIST_SIZE,
- max_inbound_header_list_size_);
-
- SpdySerializedFrame frame(spdy_framer_.SerializeFrame(settings_frame));
- headers_stream()->WriteOrBufferData(
- QuicStringPiece(frame.data(), frame.size()), false, nullptr);
}
QpackEncoder* QuicSpdySession::qpack_encoder() {
diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc
index c4eb3c7..1dd05d1 100644
--- a/quic/core/http/quic_spdy_session_test.cc
+++ b/quic/core/http/quic_spdy_session_test.cc
@@ -456,8 +456,7 @@
}
TEST_P(QuicSpdySessionTestServer, IsCryptoHandshakeConfirmed) {
- if (!GetQuicReloadableFlag(quic_do_not_send_settings) ||
- VersionUsesHttp3(transport_version())) {
+ if (VersionUsesHttp3(transport_version())) {
MockPacketWriter* writer = static_cast<MockPacketWriter*>(
QuicConnectionPeer::GetWriter(session_.connection()));
EXPECT_CALL(*writer, WritePacket(_, _, _, _, _))
@@ -1062,8 +1061,7 @@
}
TEST_P(QuicSpdySessionTestServer, IncreasedTimeoutAfterCryptoHandshake) {
- if (!GetQuicReloadableFlag(quic_do_not_send_settings) ||
- VersionUsesHttp3(transport_version())) {
+ if (VersionUsesHttp3(transport_version())) {
MockPacketWriter* writer = static_cast<MockPacketWriter*>(
QuicConnectionPeer::GetWriter(session_.connection()));
EXPECT_CALL(*writer, WritePacket(_, _, _, _, _))