commit 98fc8d0ff571b8412e972047a8503b1f63a46fc6
author dschinazi <dschinazi@google.com> Tue Sep 17 23:34:49 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 18 14:33:12 2019 -0700
tree 6aafbd0ef6b5bb2a55c591dfc0b5e26888fe136b
parent 56055be76348f2b8d7021b0863746def81af625c

Display version in quic_framer_test

For example, now in test results you see
QuicFramerTests/QuicFramerTest.UndecryptableCoalescedPacket/Q099
instead of
QuicFramerTests/QuicFramerTest.UndecryptableCoalescedPacket/42

gfe-relnote: test-only
PiperOrigin-RevId: 269736155
Change-Id: I22a9deb0288b328210bcdc46d35fdf807c3dffd0

quic/core/quic_framer_test.cc

diff --git a/quic/core/quic_framer_test.cc b/quic/core/quic_framer_test.cc
index beb6571..728214a 100644
--- a/quic/core/quic_framer_test.cc
+++ b/quic/core/quic_framer_test.cc
@@ -569,6 +569,11 @@
 
 using PacketFragments = std::vector<struct PacketFragment>;
 
+// Used by ::testing::PrintToStringParamName().
+std::string PrintToString(const ParsedQuicVersion& version) {
+  return ParsedQuicVersionToString(version);
+}
+
 class QuicFramerTest : public QuicTestWithParam<ParsedQuicVersion> {
  public:
   QuicFramerTest()
@@ -595,6 +600,7 @@
     framer_.set_visitor(&visitor_);
     framer_.InferPacketHeaderTypeFromVersion();
     visitor_.set_framer(&framer_);
+    QUIC_DVLOG(2) << "QuicFramerTest(" << PrintToString(version_) << ")";
   }
 
   void SetDecrypterLevel(EncryptionLevel level) {
@@ -814,7 +820,8 @@
 // Run all framer tests with all supported versions of QUIC.
 INSTANTIATE_TEST_SUITE_P(QuicFramerTests,
                          QuicFramerTest,
-                         ::testing::ValuesIn(AllSupportedVersions()));
+                         ::testing::ValuesIn(AllSupportedVersions()),
+                         ::testing::PrintToStringParamName());
 
 TEST_P(QuicFramerTest, CalculatePacketNumberFromWireNearEpochStart) {
   // A few quick manual sanity checks.