commit 94adffdb28ad485cf5023b6ac4345feffba534b0
author vasilvv <vasilvv@google.com> Thu Oct 08 08:17:17 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 08 08:18:04 2020 -0700
tree d79298802d728af3040edcbe8f3e46458b0772f8
parent 6c9e9c3a4bd72c4c779a9b213f15dbcd436fb55a

Replace QuicheStringPiece with absl::string_view

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:335945927:BASE:335945937:1602112350918:858d0121
PiperOrigin-RevId: 336088152
Change-Id: I6f35eab21c89977cfe5714184b017d63d227414a

quic/qbone/bonnet/icmp_reachable.cc

diff --git a/quic/qbone/bonnet/icmp_reachable.cc b/quic/qbone/bonnet/icmp_reachable.cc
index c6dd96d..6865e1d 100644
--- a/quic/qbone/bonnet/icmp_reachable.cc
+++ b/quic/qbone/bonnet/icmp_reachable.cc
@@ -6,12 +6,12 @@
 
 #include <netinet/ip6.h>
 
+#include "absl/strings/string_view.h"
 #include "net/third_party/quiche/src/quic/core/crypto/quic_random.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_mutex.h"
 #include "net/third_party/quiche/src/quic/qbone/platform/icmp_packet.h"
 #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h"
-#include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h"
 #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h"
 
 namespace quic {
@@ -128,7 +128,7 @@
   }
 
   QUIC_VLOG(2) << quiche::QuicheTextUtils::HexDump(
-      quiche::QuicheStringPiece(buffer, size));
+      absl::string_view(buffer, size));
 
   auto* header = reinterpret_cast<const icmp6_hdr*>(&buffer);
   QuicWriterMutexLock mu(&header_lock_);
@@ -168,7 +168,7 @@
 
   icmp_header_.icmp6_seq++;
   CreateIcmpPacket(src_.sin6_addr, dst_.sin6_addr, icmp_header_, "",
-                   [this](quiche::QuicheStringPiece packet) {
+                   [this](absl::string_view packet) {
                      QUIC_VLOG(2) << quiche::QuicheTextUtils::HexDump(packet);
 
                      ssize_t size = kernel_->sendto(
@@ -185,8 +185,7 @@
   return absl::ToUnixMicros(absl::Now() + timeout_);
 }
 
-quiche::QuicheStringPiece IcmpReachable::StatusName(
-    IcmpReachable::Status status) {
+absl::string_view IcmpReachable::StatusName(IcmpReachable::Status status) {
   switch (status) {
     case REACHABLE:
       return "REACHABLE";

quic/qbone/bonnet/icmp_reachable.h

diff --git a/quic/qbone/bonnet/icmp_reachable.h b/quic/qbone/bonnet/icmp_reachable.h
index f58efd0..a3bc090 100644
--- a/quic/qbone/bonnet/icmp_reachable.h
+++ b/quic/qbone/bonnet/icmp_reachable.h
@@ -7,11 +7,11 @@
 
 #include <netinet/icmp6.h>
 
+#include "absl/strings/string_view.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_ip_address.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_mutex.h"
 #include "net/third_party/quiche/src/quic/qbone/bonnet/icmp_reachable_interface.h"
 #include "net/third_party/quiche/src/quic/qbone/platform/kernel_interface.h"
-#include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h"
 
 namespace quic {
 
@@ -80,7 +80,7 @@
   int64 /* allow-non-std-int */ OnAlarm()
       QUIC_LOCKS_EXCLUDED(header_lock_) override;
 
-  static quiche::QuicheStringPiece StatusName(Status status);
+  static absl::string_view StatusName(Status status);
 
  private:
   class EpollCallback : public QuicEpollCallbackInterface {