commit 9193b6323eb69f38b76c4b96e58074d6fbd61cbd
author QUICHE team <quiche-dev@google.com> Fri Feb 11 13:01:54 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Feb 11 13:02:50 2022 -0800
tree 711aac9497ccaf6615f09aa07f548faa312745a9
parent e6ae631d8e23f49d9f727861f33c57fe00202a08

Replaces if-else sequences with switch statements when handling SETTINGS identifiers.

Minor refactoring to ease upcoming changes to how OgHttp2Session handles outbound SETTINGS.

PiperOrigin-RevId: 428071076

http2/adapter/oghttp2_session.cc

diff --git a/http2/adapter/oghttp2_session.cc b/http2/adapter/oghttp2_session.cc
index eef7a5f..773199c 100644
--- a/http2/adapter/oghttp2_session.cc
+++ b/http2/adapter/oghttp2_session.cc
@@ -1521,13 +1521,26 @@
 void OgHttp2Session::HandleOutboundSettings(
     const spdy::SpdySettingsIR& settings_frame) {
   for (const auto& [id, value] : settings_frame.values()) {
-    if (id == Http2KnownSettingsId::MAX_CONCURRENT_STREAMS) {
-      pending_max_inbound_concurrent_streams_ = value;
-    }
-    if (id == ENABLE_CONNECT_PROTOCOL && value == 1u && IsServerSession()) {
-      // Allow extended CONNECT semantics even before SETTINGS are acked, to
-      // make things easier for clients.
-      headers_handler_.AllowConnect();
+    switch (static_cast<Http2KnownSettingsId>(id)) {
+      case MAX_CONCURRENT_STREAMS:
+        pending_max_inbound_concurrent_streams_ = value;
+        break;
+      case ENABLE_CONNECT_PROTOCOL:
+        if (value == 1u && IsServerSession()) {
+          // Allow extended CONNECT semantics even before SETTINGS are acked, to
+          // make things easier for clients.
+          headers_handler_.AllowConnect();
+        }
+        break;
+      case HEADER_TABLE_SIZE:
+      case ENABLE_PUSH:
+      case INITIAL_WINDOW_SIZE:
+      case MAX_FRAME_SIZE:
+      case MAX_HEADER_LIST_SIZE:
+        QUICHE_VLOG(2)
+            << "Not adjusting internal state for outbound setting with id "
+            << id;
+        break;
     }
   }
 
@@ -1536,10 +1549,22 @@
   settings_ack_callbacks_.push_back(
       [this, settings_map = settings_frame.values()]() {
         for (const auto& [id, value] : settings_map) {
-          if (id == spdy::SETTINGS_MAX_CONCURRENT_STREAMS) {
-            max_inbound_concurrent_streams_ = value;
-          } else if (id == spdy::SETTINGS_HEADER_TABLE_SIZE) {
-            decoder_.GetHpackDecoder()->ApplyHeaderTableSizeSetting(value);
+          switch (static_cast<Http2KnownSettingsId>(id)) {
+            case MAX_CONCURRENT_STREAMS:
+              max_inbound_concurrent_streams_ = value;
+              break;
+            case HEADER_TABLE_SIZE:
+              decoder_.GetHpackDecoder()->ApplyHeaderTableSizeSetting(value);
+              break;
+            case ENABLE_PUSH:
+            case INITIAL_WINDOW_SIZE:
+            case MAX_FRAME_SIZE:
+            case MAX_HEADER_LIST_SIZE:
+            case ENABLE_CONNECT_PROTOCOL:
+              QUICHE_VLOG(2)
+                  << "No action required in ack for outbound setting with id "
+                  << id;
+              break;
           }
         }
       });