commit 8f2ee4efc422becbcd5ac4112a3a35d72ed264be
author QUICHE team <quiche-dev@google.com> Sat Oct 16 08:42:36 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Sat Oct 16 08:43:24 2021 -0700
tree b66b2f0f4a7135b8a7e9efcaaf5aa9ba26664f73
parent b5a03ba6178f3b755d2f91ddaf95c8c739c5f9d3

Resolves 3 instances of the following issue: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character (performance-faster-string-find)

CL generated via Upkeep (go/upkeep).

#upkeep #autofix #codehealth #cleanup

PiperOrigin-RevId: 403612856

quic/core/http/spdy_utils.cc

diff --git a/quic/core/http/spdy_utils.cc b/quic/core/http/spdy_utils.cc
index 27f5314..74c9c53 100644
--- a/quic/core/http/spdy_utils.cc
+++ b/quic/core/http/spdy_utils.cc
@@ -142,7 +142,7 @@
   }
   (*headers)[":scheme"] = url.substr(0, pos);
   size_t start = pos + 3;
-  pos = url.find("/", start);
+  pos = url.find('/', start);
   if (pos == std::string::npos) {
     (*headers)[":authority"] = url.substr(start);
     (*headers)[":path"] = "/";

quic/tools/quic_memory_cache_backend.cc

diff --git a/quic/tools/quic_memory_cache_backend.cc b/quic/tools/quic_memory_cache_backend.cc
index 58aa7a9..19ac29a 100644
--- a/quic/tools/quic_memory_cache_backend.cc
+++ b/quic/tools/quic_memory_cache_backend.cc
@@ -40,7 +40,7 @@
   // First read the headers.
   size_t start = 0;
   while (start < file_contents_.length()) {
-    size_t pos = file_contents_.find("\n", start);
+    size_t pos = file_contents_.find('\n', start);
     if (pos == std::string::npos) {
       QUIC_LOG(DFATAL) << "Headers invalid or empty, ignoring: " << file_name_;
       return;
@@ -58,7 +58,7 @@
     }
     // Extract the status from the HTTP first line.
     if (line.substr(0, 4) == "HTTP") {
-      pos = line.find(" ");
+      pos = line.find(' ');
       if (pos == std::string::npos) {
         QUIC_LOG(DFATAL) << "Headers invalid or empty, ignoring: "
                          << file_name_;

spdy/core/hpack/hpack_encoder.cc

diff --git a/spdy/core/hpack/hpack_encoder.cc b/spdy/core/hpack/hpack_encoder.cc
index 1821d7c..cc7746f 100644
--- a/spdy/core/hpack/hpack_encoder.cc
+++ b/spdy/core/hpack/hpack_encoder.cc
@@ -233,7 +233,7 @@
     cookie_value = cookie_value.substr(first, (last - first) + 1);
   }
   for (size_t pos = 0;;) {
-    size_t end = cookie_value.find(";", pos);
+    size_t end = cookie_value.find(';', pos);
 
     if (end == absl::string_view::npos) {
       out->push_back(std::make_pair(cookie.first, cookie_value.substr(pos)));