commit 8ea3fa84bafa0127093ff7d45a4245145fae5315
author vasilvv <vasilvv@google.com> Mon Sep 27 07:24:06 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Sep 27 07:25:11 2021 -0700
tree 51c6f66380fdfc0a4ce23d88af2afede02c0a089
parent 36d9a1fbff6e0f8665a1c60c09e19aa38380ae85

In QuicSession, check if the visitor_ is not nullptr before calling it.

According to the QuicSession API contract, the session visitor may be nullptr; while we typically only use this for the clients, in some unit tests, this also applies to the server.

PiperOrigin-RevId: 399184256

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index e35e1a3..309f92f 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -2073,13 +2073,17 @@
 
 void QuicSession::OnServerConnectionIdIssued(
     const QuicConnectionId& server_connection_id) {
-  visitor_->OnNewConnectionIdSent(connection_->GetOneActiveServerConnectionId(),
-                                  server_connection_id);
+  if (visitor_) {
+    visitor_->OnNewConnectionIdSent(
+        connection_->GetOneActiveServerConnectionId(), server_connection_id);
+  }
 }
 
 void QuicSession::OnServerConnectionIdRetired(
     const QuicConnectionId& server_connection_id) {
-  visitor_->OnConnectionIdRetired(server_connection_id);
+  if (visitor_) {
+    visitor_->OnConnectionIdRetired(server_connection_id);
+  }
 }
 
 bool QuicSession::IsConnectionFlowControlBlocked() const {