Remove 255-packet delta limit in QuicReceivedPacketManager::GetUpdatedAckFrame. This is a leftover from gQUIC encoding. PiperOrigin-RevId: 984020128
diff --git a/quiche/quic/core/quic_received_packet_manager.cc b/quiche/quic/core/quic_received_packet_manager.cc index 408d878..e56ece2 100644 --- a/quiche/quic/core/quic_received_packet_manager.cc +++ b/quiche/quic/core/quic_received_packet_manager.cc
@@ -196,17 +196,6 @@ << " num_iterations:" << num_iterations; ack_frame_.packets.RemoveSmallestInterval(); } - // Clear all packet times if any are too far from largest observed. - // It's expected this is extremely rare. - for (auto it = ack_frame_.received_packet_times.begin(); - it != ack_frame_.received_packet_times.end();) { - if (LargestAcked(ack_frame_) - it->first >= - std::numeric_limits<uint8_t>::max()) { - it = ack_frame_.received_packet_times.erase(it); - } else { - ++it; - } - } #if QUIC_FRAME_DEBUG QuicFrame frame = QuicFrame(&ack_frame_);
diff --git a/quiche/quic/core/quic_received_packet_manager_test.cc b/quiche/quic/core/quic_received_packet_manager_test.cc index 7616590..6014f3e 100644 --- a/quiche/quic/core/quic_received_packet_manager_test.cc +++ b/quiche/quic/core/quic_received_packet_manager_test.cc
@@ -144,9 +144,9 @@ ack = received_manager_.GetUpdatedAckFrame(two_ms); received_manager_.ResetAckStates(); EXPECT_FALSE(received_manager_.ack_frame_updated()); - // UpdateReceivedPacketInfo should discard any times which can't be - // expressed on the wire. - EXPECT_EQ(2u, ack.ack_frame->received_packet_times.size()); + // IETF ACK_RECEIVE_TIMESTAMPS encodes deltas as 62-bit varints, so all 3 + // timestamps are retained. + EXPECT_EQ(3u, ack.ack_frame->received_packet_times.size()); } TEST_F(QuicReceivedPacketManagerTest, UpdateReceivedConnectionStats) {
diff --git a/quiche/quic/core/uber_received_packet_manager_test.cc b/quiche/quic/core/uber_received_packet_manager_test.cc index 4cab508..7e21c1d 100644 --- a/quiche/quic/core/uber_received_packet_manager_test.cc +++ b/quiche/quic/core/uber_received_packet_manager_test.cc
@@ -184,9 +184,9 @@ ack = manager_->GetUpdatedAckFrame(APPLICATION_DATA, two_ms); manager_->ResetAckStates(ENCRYPTION_FORWARD_SECURE); EXPECT_FALSE(manager_->IsAckFrameUpdated()); - // UpdateReceivedPacketInfo should discard any times which can't be - // expressed on the wire. - EXPECT_EQ(2u, ack.ack_frame->received_packet_times.size()); + // IETF ACK_RECEIVE_TIMESTAMPS encodes deltas as 62-bit varints, so all 3 + // timestamps are retained. + EXPECT_EQ(3u, ack.ack_frame->received_packet_times.size()); } TEST_F(UberReceivedPacketManagerTest, UpdateReceivedConnectionStats) {