commit 8b715462abd3b9b604da3a535cd4adfd48921778
author QUICHE team <quiche-dev@google.com> Fri Apr 01 17:17:36 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Apr 01 17:18:17 2022 -0700
tree fc62afd4251249e3e06e319757c27fb4aa69657f
parent 458a7c310230a5ac940e1e8661102752443c6940

Address an out of bounds read/write in promised_streams_. This was identified by UBSAN while fuzzing

PiperOrigin-RevId: 438944445

quic/tools/quic_simple_server_session.cc

diff --git a/quic/tools/quic_simple_server_session.cc b/quic/tools/quic_simple_server_session.cc
index d1e9a73..6288182 100644
--- a/quic/tools/quic_simple_server_session.cc
+++ b/quic/tools/quic_simple_server_session.cc
@@ -132,7 +132,7 @@
         frame.stream_id >= next_stream_id) {
       size_t index = (frame.stream_id - next_stream_id) /
                      QuicUtils::StreamIdDelta(transport_version());
-      if (index <= promised_streams_.size()) {
+      if (index < promised_streams_.size()) {
         promised_streams_[index].is_cancelled = true;
       }
     }