commit 7e41d5c0cbbebe2d1a0e9e317f0e307a108c95fc
author fayang <fayang@google.com> Mon Mar 07 17:10:41 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Mar 07 17:11:25 2022 -0800
tree 7578e5ba21f5f3b46ea8f1c4e7bd9b202fdde9b5
parent 3cfa582312cabd4c00ce8618d5dde734f147e4bd

Automated g4 rollback of changelist 433064452.

*** Reason for rollback ***

This could be a functional change given connection can be disconnected when ScopedPeerAddressContext goes out of scope.

*** Original change description ***

Delete redundant brackets.

***

PiperOrigin-RevId: 433078419

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index c6b2887..4715925 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -6385,26 +6385,28 @@
     return connected_;
   }
   if (connection_migration_use_new_cid_) {
-    QuicConnectionId client_cid, server_cid;
-    FindOnPathConnectionIds(self_address, effective_peer_address, &client_cid,
-                            &server_cid);
-    QuicPacketCreator::ScopedPeerAddressContext context(
-        &packet_creator_, peer_address, client_cid, server_cid,
-        connection_migration_use_new_cid_);
-    if (writer == writer_) {
-      ScopedPacketFlusher flusher(this);
-      // It's on current path, add the PATH_CHALLENGE the same way as other
-      // frames. This may cause connection to be closed.
-      packet_creator_.AddPathChallengeFrame(data_buffer);
-    } else {
-      std::unique_ptr<SerializedPacket> probing_packet =
-          packet_creator_.SerializePathChallengeConnectivityProbingPacket(
-              data_buffer);
-      QUICHE_DCHECK_EQ(IsRetransmittable(*probing_packet),
-                       NO_RETRANSMITTABLE_DATA);
-      QUICHE_DCHECK_EQ(self_address, alternative_path_.self_address);
-      WritePacketUsingWriter(std::move(probing_packet), writer, self_address,
-                             peer_address, /*measure_rtt=*/false);
+    {
+      QuicConnectionId client_cid, server_cid;
+      FindOnPathConnectionIds(self_address, effective_peer_address, &client_cid,
+                              &server_cid);
+      QuicPacketCreator::ScopedPeerAddressContext context(
+          &packet_creator_, peer_address, client_cid, server_cid,
+          connection_migration_use_new_cid_);
+      if (writer == writer_) {
+        ScopedPacketFlusher flusher(this);
+        // It's on current path, add the PATH_CHALLENGE the same way as other
+        // frames. This may cause connection to be closed.
+        packet_creator_.AddPathChallengeFrame(data_buffer);
+      } else {
+        std::unique_ptr<SerializedPacket> probing_packet =
+            packet_creator_.SerializePathChallengeConnectivityProbingPacket(
+                data_buffer);
+        QUICHE_DCHECK_EQ(IsRetransmittable(*probing_packet),
+                         NO_RETRANSMITTABLE_DATA);
+        QUICHE_DCHECK_EQ(self_address, alternative_path_.self_address);
+        WritePacketUsingWriter(std::move(probing_packet), writer, self_address,
+                               peer_address, /*measure_rtt=*/false);
+      }
     }
     return connected_;
   }