Latch in SpdyHeadersIR the feature flag that updates SpdyHeadersIR::size().

We observed a b/331280235 coredump with the following Http2WriteQueue member:
  ...
  pending_frames_bytes_ = 18446744073709551614,
  ...

From this value, we found that different values of
--gfe2_reloadable_flag_http2_add_hpack_overhead_bytes at various size() call
sites could lead to inconsistent size estimate values, which would lead to
issues when attempting to write.

The new regression test would have failed using the initial version of this
flag: http://sponge2/ae76de9d-6a60-4031-bc9b-12a95ec6ae47 (failed).

This CL deprecates --gfe2_reloadable_flag_http2_add_hpack_overhead_bytes and
renames the flag with the new behavivor to latch in SpdyHeadersIR.

This CL also changes some Http2WriteQueue member types from size_t to ssize_t.

Protected by FLAGS_gfe2_reloadable_flag_http2_add_hpack_overhead_bytes2.

PiperOrigin-RevId: 619920782
4 files changed
tree: 11c32d8c29cf2da7415aca0843cc647c6cd1dbe9
  1. build/
  2. depstool/
  3. quiche/
  4. .bazelrc
  5. .bazelversion
  6. BUILD.bazel
  7. CONTRIBUTING.md
  8. LICENSE
  9. README.md
  10. WHITESPACE
  11. WORKSPACE.bazel
README.md

QUICHE

QUICHE stands for QUIC, Http, Etc. It is Google‘s production-ready implementation of QUIC, HTTP/2, HTTP/3, and related protocols and tools. It powers Google’s servers, Chromium, Envoy, and other projects. It is actively developed and maintained.

There are two public QUICHE repositories. Either one may be used by embedders, as they are automatically kept in sync:

To embed QUICHE in your project, platform APIs need to be implemented and build files need to be created. Note that it is on the QUICHE team's roadmap to include default implementation for all platform APIs and to open-source build files. In the meanwhile, take a look at open source embedders like Chromium and Envoy to get started:

To contribute to QUICHE, follow instructions at CONTRIBUTING.md.

QUICHE is only supported on little-endian platforms.