)]}'
{
  "commit": "75c002fa7dcf52dc50c801888f777879e24fb1d2",
  "tree": "11c32d8c29cf2da7415aca0843cc647c6cd1dbe9",
  "parents": [
    "7640b5cd7defafe56c69068daabe4e173b53bbbf"
  ],
  "author": {
    "name": "diannahu",
    "email": "diannahu@google.com",
    "time": "Thu Mar 28 07:19:05 2024 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Thu Mar 28 07:20:12 2024 -0700"
  },
  "message": "Latch in SpdyHeadersIR the feature flag that updates SpdyHeadersIR::size().\n\nWe observed a b/331280235 coredump with the following Http2WriteQueue member:\n  ...\n  pending_frames_bytes_ \u003d 18446744073709551614,\n  ...\n\nFrom this value, we found that different values of\n--gfe2_reloadable_flag_http2_add_hpack_overhead_bytes at various size() call\nsites could lead to inconsistent size estimate values, which would lead to\nissues when attempting to write.\n\nThe new regression test would have failed using the initial version of this\nflag: http://sponge2/ae76de9d-6a60-4031-bc9b-12a95ec6ae47 (failed).\n\nThis CL deprecates --gfe2_reloadable_flag_http2_add_hpack_overhead_bytes and\nrenames the flag with the new behavivor to latch in SpdyHeadersIR.\n\nThis CL also changes some Http2WriteQueue member types from size_t to ssize_t.\n\nProtected by FLAGS_gfe2_reloadable_flag_http2_add_hpack_overhead_bytes2.\n\nPiperOrigin-RevId: 619920782\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9666f815706748a98474e2b2fcc00b6117cd4faf",
      "old_mode": 33261,
      "old_path": "quiche/common/quiche_feature_flags_list.h",
      "new_id": "81f9da5dd0f18b2f063b2c6eeb4dd32a8177c764",
      "new_mode": 33261,
      "new_path": "quiche/common/quiche_feature_flags_list.h"
    },
    {
      "type": "modify",
      "old_id": "c489dbbbd89f84ff81876807a23fce717f7de655",
      "old_mode": 33188,
      "old_path": "quiche/quic/core/quic_flags_list.h",
      "new_id": "fbce5e8ef3aecb9e4e02840d1abf83bc140167ff",
      "new_mode": 33188,
      "new_path": "quiche/quic/core/quic_flags_list.h"
    },
    {
      "type": "modify",
      "old_id": "3f2d2f7be1e6857127bd318ef3214c67433b9e24",
      "old_mode": 33188,
      "old_path": "quiche/spdy/core/spdy_protocol.cc",
      "new_id": "fc3b971b2f8d200679ab74b480721d58ff45181f",
      "new_mode": 33188,
      "new_path": "quiche/spdy/core/spdy_protocol.cc"
    },
    {
      "type": "modify",
      "old_id": "8501c94fde566dab9fcf4dd68e4871319fe0b0de",
      "old_mode": 33188,
      "old_path": "quiche/spdy/core/spdy_protocol.h",
      "new_id": "09bc49e406bf1944b536d0bfd0fbb17cef9b079b",
      "new_mode": 33188,
      "new_path": "quiche/spdy/core/spdy_protocol.h"
    }
  ]
}