commit 744a8d60762acb1b7d73fc4f169bdf2258ca35d8
author bnc <bnc@google.com> Wed Sep 15 07:08:40 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 15 07:09:16 2021 -0700
tree bc792f6716896a10a0dc4380e15a1285a08bc742
parent 34188bf01dde3cccc0cad38071cc62af216539fb

Modify ToDebuggingValue for 1s, 1ms output

This change is imported from https://github.com/google/quiche/pull/1.
Author: yongw5

I verified that the author has signed the Contributor License Agreement.

PiperOrigin-RevId: 396828027

quic/core/quic_time.cc

diff --git a/quic/core/quic_time.cc b/quic/core/quic_time.cc
index daf8e29..08e0906 100644
--- a/quic/core/quic_time.cc
+++ b/quic/core/quic_time.cc
@@ -21,11 +21,11 @@
 
   // For debugging purposes, always display the value with the highest precision
   // available.
-  if (absolute_value > kSecondInMicroseconds &&
+  if (absolute_value >= kSecondInMicroseconds &&
       absolute_value % kSecondInMicroseconds == 0) {
     return absl::StrCat(time_offset_ / kSecondInMicroseconds, "s");
   }
-  if (absolute_value > kMillisecondInMicroseconds &&
+  if (absolute_value >= kMillisecondInMicroseconds &&
       absolute_value % kMillisecondInMicroseconds == 0) {
     return absl::StrCat(time_offset_ / kMillisecondInMicroseconds, "ms");
   }

quic/core/quic_time_test.cc

diff --git a/quic/core/quic_time_test.cc b/quic/core/quic_time_test.cc
index eaaf755..e5bb285 100644
--- a/quic/core/quic_time_test.cc
+++ b/quic/core/quic_time_test.cc
@@ -87,8 +87,11 @@
   const QuicTime::Delta one_ms = QuicTime::Delta::FromMilliseconds(1);
   const QuicTime::Delta one_s = QuicTime::Delta::FromSeconds(1);
 
+  EXPECT_EQ("1s", one_s.ToDebuggingValue());
   EXPECT_EQ("3s", (3 * one_s).ToDebuggingValue());
+  EXPECT_EQ("1ms", one_ms.ToDebuggingValue());
   EXPECT_EQ("3ms", (3 * one_ms).ToDebuggingValue());
+  EXPECT_EQ("1us", one_us.ToDebuggingValue());
   EXPECT_EQ("3us", (3 * one_us).ToDebuggingValue());
 
   EXPECT_EQ("3001us", (3 * one_ms + one_us).ToDebuggingValue());