commit 5258041c8581b8d8bcab5e12a0d1950a08d49dc2
author wub <wub@google.com> Mon Aug 09 08:33:32 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 09 08:35:08 2021 -0700
tree a175d12ffd46ff1836add3026c8dd64fe99a5827
parent be05fc05979fa5722ed326febb12106ded5d734d

Deprecate --gfe2_reloadable_flag_quic_run_default_signature_callback_once.

PiperOrigin-RevId: 389639960

quic/core/quic_flags_list.h

diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h
index 9bb54b2..aa6462b 100644
--- a/quic/core/quic_flags_list.h
+++ b/quic/core/quic_flags_list.h
@@ -27,8 +27,6 @@
 QUIC_FLAG(FLAGS_quic_restart_flag_quic_support_release_time_for_gso, false)
 // If true, QuicIdleNetworkDetector::SetAlarm will become a noop if dectection has been stopped by QuicIdleNetworkDetector::StopDetection.
 QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_idle_network_detector_no_alarm_after_stopped, true)
-// If true, TlsServerHandshaker::DefaultProofSourceHandle::DefaultSignatureCallback will run at most once.
-QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_run_default_signature_callback_once, true)
 // If true, abort async QPACK header decompression in QuicSpdyStream::Reset() and in QuicSpdyStream::OnStreamReset().
 QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_abort_qpack_on_stream_reset, true)
 // If true, ack frequency frame can be sent from server to client.

quic/core/tls_server_handshaker.h

diff --git a/quic/core/tls_server_handshaker.h b/quic/core/tls_server_handshaker.h
index 998cc15..515c813 100644
--- a/quic/core/tls_server_handshaker.h
+++ b/quic/core/tls_server_handshaker.h
@@ -259,22 +259,12 @@
           return;
         }
 
-        if (GetQuicReloadableFlag(quic_run_default_signature_callback_once)) {
-          QUIC_RELOADABLE_FLAG_COUNT(quic_run_default_signature_callback_once);
-          DefaultProofSourceHandle* handle = handle_;
-          handle_ = nullptr;
+        DefaultProofSourceHandle* handle = handle_;
+        handle_ = nullptr;
 
-          handle->signature_callback_ = nullptr;
-          if (handle->handshaker_ != nullptr) {
-            handle->handshaker_->OnComputeSignatureDone(
-                ok, is_sync_, std::move(signature), std::move(details));
-          }
-          return;
-        }
-
-        handle_->signature_callback_ = nullptr;
-        if (handle_->handshaker_ != nullptr) {
-          handle_->handshaker_->OnComputeSignatureDone(
+        handle->signature_callback_ = nullptr;
+        if (handle->handshaker_ != nullptr) {
+          handle->handshaker_->OnComputeSignatureDone(
               ok, is_sync_, std::move(signature), std::move(details));
         }
       }