Replace quic_enable_version_rfcv1 with quic_disable_version_rfcv1
This CL deprecates gfe2_reloadable_flag_quic_enable_version_rfcv1 now that it's been enabled by default across the fleet. It simultaneously replaces it with gfe2_reloadable_flag_quic_disable_version_rfcv1 to ensure we always have a way to disable this version at runtime if we ever find a serious version-specific issue. That flag is enabling_blocked_by because we don't plan on ever enabling it unless we find a major unexpected issue.
Protected by FLAGS_quic_reloadable_flag_quic_disable_version_rfcv1.
PiperOrigin-RevId: 383615793
diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h
index ce48d25..fe88bb8 100644
--- a/quic/core/quic_flags_list.h
+++ b/quic/core/quic_flags_list.h
@@ -45,6 +45,8 @@
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_disable_version_q046, false)
// If true, disable QUIC version Q050.
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_disable_version_q050, false)
+// If true, disable QUIC version h3 (RFCv1).
+QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_disable_version_rfcv1, false)
// If true, disable QUIC version h3-29.
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_disable_version_draft_29, false)
// If true, disable QUIC version h3-T051.
@@ -67,8 +69,6 @@
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_donot_write_mid_packet_processing, true)
// If true, drop unsent PATH_RESPONSEs and rely on peer\'s retry.
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_drop_unsent_path_response, true)
-// If true, enable QUIC version h3 (RFCv1).
-QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_enable_version_rfcv1, true)
// If true, enable server retransmittable on wire PING.
QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_enable_server_on_wire_ping, true)
// If true, ignore peer_max_ack_delay during handshake.
diff --git a/quic/core/quic_version_manager.cc b/quic/core/quic_version_manager.cc
index 1d4dcca..911370f 100644
--- a/quic/core/quic_version_manager.cc
+++ b/quic/core/quic_version_manager.cc
@@ -15,7 +15,7 @@
QuicVersionManager::QuicVersionManager(
ParsedQuicVersionVector supported_versions)
- : enable_version_rfcv1_(GetQuicReloadableFlag(quic_enable_version_rfcv1)),
+ : disable_version_rfcv1_(GetQuicReloadableFlag(quic_disable_version_rfcv1)),
disable_version_draft_29_(
GetQuicReloadableFlag(quic_disable_version_draft_29)),
disable_version_t051_(GetQuicReloadableFlag(quic_disable_version_t051)),
@@ -49,8 +49,8 @@
void QuicVersionManager::MaybeRefilterSupportedVersions() {
static_assert(SupportedVersions().size() == 6u,
"Supported versions out of sync");
- if (enable_version_rfcv1_ !=
- GetQuicReloadableFlag(quic_enable_version_rfcv1) ||
+ if (disable_version_rfcv1_ !=
+ GetQuicReloadableFlag(quic_disable_version_rfcv1) ||
disable_version_draft_29_ !=
GetQuicReloadableFlag(quic_disable_version_draft_29) ||
disable_version_t051_ !=
@@ -61,7 +61,7 @@
GetQuicReloadableFlag(quic_disable_version_q046) ||
disable_version_q043_ !=
GetQuicReloadableFlag(quic_disable_version_q043)) {
- enable_version_rfcv1_ = GetQuicReloadableFlag(quic_enable_version_rfcv1);
+ disable_version_rfcv1_ = GetQuicReloadableFlag(quic_disable_version_rfcv1);
disable_version_draft_29_ =
GetQuicReloadableFlag(quic_disable_version_draft_29);
disable_version_t051_ = GetQuicReloadableFlag(quic_disable_version_t051);
diff --git a/quic/core/quic_version_manager.h b/quic/core/quic_version_manager.h
index f443395..da73f37 100644
--- a/quic/core/quic_version_manager.h
+++ b/quic/core/quic_version_manager.h
@@ -50,8 +50,8 @@
private:
// Cached value of reloadable flags.
- // quic_enable_version_rfcv1 flag
- bool enable_version_rfcv1_;
+ // quic_disable_version_rfcv1 flag
+ bool disable_version_rfcv1_;
// quic_disable_version_draft_29 flag
bool disable_version_draft_29_;
// quic_disable_version_t051 flag
diff --git a/quic/core/quic_versions.cc b/quic/core/quic_versions.cc
index b0fd99b..717932f 100644
--- a/quic/core/quic_versions.cc
+++ b/quic/core/quic_versions.cc
@@ -47,7 +47,7 @@
const bool enable = should_enable;
const bool disable = !should_enable;
if (version == ParsedQuicVersion::RFCv1()) {
- SetQuicReloadableFlag(quic_enable_version_rfcv1, enable);
+ SetQuicReloadableFlag(quic_disable_version_rfcv1, disable);
} else if (version == ParsedQuicVersion::Draft29()) {
SetQuicReloadableFlag(quic_disable_version_draft_29, disable);
} else if (version == ParsedQuicVersion::T051()) {
@@ -407,7 +407,7 @@
filtered_versions.reserve(versions.size());
for (const ParsedQuicVersion& version : versions) {
if (version == ParsedQuicVersion::RFCv1()) {
- if (GetQuicReloadableFlag(quic_enable_version_rfcv1)) {
+ if (!GetQuicReloadableFlag(quic_disable_version_rfcv1)) {
filtered_versions.push_back(version);
}
} else if (version == ParsedQuicVersion::Draft29()) {
