Untangle dependencies for the default impl of quiche_default_proof_providers
PiperOrigin-RevId: 519624738
diff --git a/build/source_list.bzl b/build/source_list.bzl
index 0f6a8ac..7303216 100644
--- a/build/source_list.bzl
+++ b/build/source_list.bzl
@@ -1378,7 +1378,6 @@
"common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
- "common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"common/platform/default/quiche_platform_impl/quiche_event_loop_impl.h",
"common/platform/default/quiche_platform_impl/quiche_export_impl.h",
"common/platform/default/quiche_platform_impl/quiche_flag_utils_impl.h",
@@ -1407,12 +1406,14 @@
]
default_platform_impl_tool_support_hdrs = [
"common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.h",
+ "common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"common/platform/default/quiche_platform_impl/quiche_file_utils_impl.h",
"common/platform/default/quiche_platform_impl/quiche_stream_buffer_allocator_impl.h",
"common/platform/default/quiche_platform_impl/quiche_system_event_loop_impl.h",
]
default_platform_impl_tool_support_srcs = [
"common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.cc",
+ "common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc",
"common/platform/default/quiche_platform_impl/quiche_file_utils_impl.cc",
]
default_platform_impl_test_support_hdrs = [
diff --git a/build/source_list.gni b/build/source_list.gni
index 9191411..1cc5dce 100644
--- a/build/source_list.gni
+++ b/build/source_list.gni
@@ -1378,7 +1378,6 @@
"src/quiche/common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
- "src/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_event_loop_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_export_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_flag_utils_impl.h",
@@ -1407,12 +1406,14 @@
]
default_platform_impl_tool_support_hdrs = [
"src/quiche/common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.h",
+ "src/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_file_utils_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_stream_buffer_allocator_impl.h",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_system_event_loop_impl.h",
]
default_platform_impl_tool_support_srcs = [
"src/quiche/common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.cc",
+ "src/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc",
"src/quiche/common/platform/default/quiche_platform_impl/quiche_file_utils_impl.cc",
]
default_platform_impl_test_support_hdrs = [
diff --git a/build/source_list.json b/build/source_list.json
index bf23ac2..b70ed61 100644
--- a/build/source_list.json
+++ b/build/source_list.json
@@ -1377,7 +1377,6 @@
"quiche/common/platform/default/quiche_platform_impl/quiche_bug_tracker_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_client_stats_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_containers_impl.h",
- "quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_event_loop_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_export_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_flag_utils_impl.h",
@@ -1406,12 +1405,14 @@
],
"default_platform_impl_tool_support_hdrs": [
"quiche/common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.h",
+ "quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_file_utils_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_stream_buffer_allocator_impl.h",
"quiche/common/platform/default/quiche_platform_impl/quiche_system_event_loop_impl.h"
],
"default_platform_impl_tool_support_srcs": [
"quiche/common/platform/default/quiche_platform_impl/quiche_command_line_flags_impl.cc",
+ "quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc",
"quiche/common/platform/default/quiche_platform_impl/quiche_file_utils_impl.cc"
],
"default_platform_impl_test_support_hdrs": [
diff --git a/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc b/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc
new file mode 100644
index 0000000..bf6e60c
--- /dev/null
+++ b/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.cc
@@ -0,0 +1,19 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "quiche_platform_impl/quiche_default_proof_providers_impl.h"
+
+namespace quiche {
+
+// TODO(vasilvv): implement those in order for the CLI tools to work.
+std::unique_ptr<quic::ProofVerifier> CreateDefaultProofVerifierImpl(
+ const std::string& /*host*/) {
+ return nullptr;
+}
+
+std::unique_ptr<quic::ProofSource> CreateDefaultProofSourceImpl() {
+ return nullptr;
+}
+
+} // namespace quiche
diff --git a/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h b/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h
index 6727f65..208acc6 100644
--- a/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h
+++ b/quiche/common/platform/default/quiche_platform_impl/quiche_default_proof_providers_impl.h
@@ -12,14 +12,9 @@
namespace quiche {
-// TODO(vasilvv): implement those in order for the CLI tools to work.
-inline std::unique_ptr<quic::ProofVerifier> CreateDefaultProofVerifierImpl(
- const std::string& /*host*/) {
- return nullptr;
-}
-inline std::unique_ptr<quic::ProofSource> CreateDefaultProofSourceImpl() {
- return nullptr;
-}
+std::unique_ptr<quic::ProofVerifier> CreateDefaultProofVerifierImpl(
+ const std::string& host);
+std::unique_ptr<quic::ProofSource> CreateDefaultProofSourceImpl();
} // namespace quiche
