commit 3f55b5ef4a9d08eaa47a65bae607f890fc3f552f
author vasilvv <vasilvv@google.com> Thu Dec 08 23:43:56 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Dec 08 23:44:43 2022 -0800
tree e24a1f6ad82965f302916676dc79e58f00f67df9
parent 9e0811c49ce7fcab47ec2f3873f226b49e406cb3

In WebTransportBidirectionalEchoVisitor, retry sending FIN if we cannot send it immediately.

This has caused flaky tests in Chromium before, and is blocking a test I've been trying to add.

PiperOrigin-RevId: 494093482

quiche/quic/tools/web_transport_test_visitors.h

diff --git a/quiche/quic/tools/web_transport_test_visitors.h b/quiche/quic/tools/web_transport_test_visitors.h
index c7630e4..368e53a 100644
--- a/quiche/quic/tools/web_transport_test_visitors.h
+++ b/quiche/quic/tools/web_transport_test_visitors.h
@@ -74,9 +74,11 @@
       buffer_ = "";
     }
 
-    if (send_fin_) {
+    if (send_fin_ && !fin_sent_) {
       bool success = stream_->SendFin();
-      QUICHE_DCHECK(success);
+      if (success) {
+        fin_sent_ = true;
+      }
     }
   }
 
@@ -99,6 +101,7 @@
   WebTransportStream* stream_;
   std::string buffer_;
   bool send_fin_ = false;
+  bool fin_sent_ = false;
   bool stop_sending_received_ = false;
 };