commit 3edcae62469f31c7360976b7c18c6c6b12a7497c
author QUICHE team <quiche-dev@google.com> Wed Aug 11 04:49:12 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 23 14:00:56 2021 -0700
tree d8ac74b97ec30ae35ea66cc84d434bf49e3a2c9e
parent 85964d499d53b655ea45bd339e2547fe2fdd9be9

Make code -Wunused-but-set-variable clean

Currently, the crosstool disables the warning -Wunused-but-set-variable.  The
default copts for third_party/quic/core/build_config.bzl enables this warning,
but the warning itself will not be available until the next crosstool release.

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:390021594:BASE:389989385:1628643557015:7a5d694c
PiperOrigin-RevId: 390103143

quic/core/crypto/proof_source_x509_test.cc

diff --git a/quic/core/crypto/proof_source_x509_test.cc b/quic/core/crypto/proof_source_x509_test.cc
index 75a6099..0f5f4f2 100644
--- a/quic/core/crypto/proof_source_x509_test.cc
+++ b/quic/core/crypto/proof_source_x509_test.cc
@@ -58,8 +58,7 @@
       ProofSourceX509::Create(test_chain_, std::move(*test_key_));
   ASSERT_TRUE(proof_source != nullptr);
   test_key_ = CertificatePrivateKey::LoadFromDer(kTestCertificatePrivateKey);
-  bool result;
-  EXPECT_QUIC_BUG(result = proof_source->AddCertificateChain(
+  EXPECT_QUIC_BUG((void)proof_source->AddCertificateChain(
                       wildcard_chain_, std::move(*test_key_)),
                   "Private key does not match");
 }