commit 3c36b7a31bebe66c9515eebad4cafc6fa3e9d2e6
author QUICHE team <quiche-dev@google.com> Mon Aug 23 13:57:16 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 23 14:21:06 2021 -0700
tree 849df96af08fce7fb26132e9d972c1435a4e1cf5
parent 1713e42d8659beaf66ace4f88bf2ca307a3a9e13

Adds DCHECKs to invocations of on_frame_recv_callback(), verifying that these callbacks always return success.

PiperOrigin-RevId: 392512724

http2/adapter/callback_visitor.cc

diff --git a/http2/adapter/callback_visitor.cc b/http2/adapter/callback_visitor.cc
index 5f64707..b0a5bd1 100644
--- a/http2/adapter/callback_visitor.cc
+++ b/http2/adapter/callback_visitor.cc
@@ -121,7 +121,9 @@
   QUICHE_VLOG(1) << "OnSettingsEnd, received settings of size "
                  << current_frame_.settings.niv;
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
   settings_.clear();
 }
@@ -129,7 +131,9 @@
 void CallbackVisitor::OnSettingsAck() {
   // ACK is part of the flags, which were set in OnFrameHeader().
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
 }
 
@@ -225,7 +229,9 @@
                                   Http2ErrorCode error_code) {
   current_frame_.rst_stream.error_code = static_cast<uint32_t>(error_code);
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
 }
 
@@ -246,7 +252,9 @@
   current_frame_.priority.pri_spec.weight = weight;
   current_frame_.priority.pri_spec.exclusive = exclusive;
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
 }
 
@@ -256,7 +264,9 @@
   std::memcpy(current_frame_.ping.opaque_data, &network_order_opaque_data,
               sizeof(network_order_opaque_data));
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
 }
 
@@ -284,7 +294,9 @@
                                      int window_increment) {
   current_frame_.window_update.window_size_increment = window_increment;
   if (callbacks_->on_frame_recv_callback) {
-    callbacks_->on_frame_recv_callback(nullptr, &current_frame_, user_data_);
+    const int result = callbacks_->on_frame_recv_callback(
+        nullptr, &current_frame_, user_data_);
+    QUICHE_DCHECK_EQ(0, result);
   }
 }