Disable sending min_ack_delay in transport parameters on the client side. It is a no-op for google service and not flag protected.
Apparently, non-Google servers might react to this parameter and therefore it should be sent by default until it is fully tested.
PiperOrigin-RevId: 325226780
Change-Id: Id35c9862a1afcf8c94dce5ec8c2bf4617977890f
diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index 4d6ea0e..b2ac3ab 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -127,7 +127,6 @@
connection_->SetDataProducer(this);
connection_->SetFromConfig(config_);
if (perspective() == Perspective::IS_CLIENT && version().UsesTls()) {
- config_.SetMinAckDelayMs(kDefaultMinAckDelayTimeMs);
if (GetQuicReloadableFlag(quic_support_handshake_done_in_t050) &&
!version().HasHandshakeDone()) {
config_.SetSupportHandshakeDone();
diff --git a/quic/core/quic_session_test.cc b/quic/core/quic_session_test.cc
index 1a5a290..3973bd5 100644
--- a/quic/core/quic_session_test.cc
+++ b/quic/core/quic_session_test.cc
@@ -2208,14 +2208,6 @@
session_.OnStreamFrame(frame);
}
-TEST_P(QuicSessionTestClient, MinAckDelaySetOnTheClientQuicConfig) {
- if (!VersionUsesHttp3(transport_version())) {
- return;
- }
- ASSERT_EQ(session_.config()->GetMinAckDelayToSendMs(),
- kDefaultMinAckDelayTimeMs);
-}
-
TEST_P(QuicSessionTestClient, FailedToCreateStreamIfTooCloseToIdleTimeout) {
connection_->SetDefaultEncryptionLevel(ENCRYPTION_FORWARD_SECURE);
EXPECT_TRUE(session_.CanOpenNextOutgoingBidirectionalStream());
