LSC: Add GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST as needed.
http://go/are-your-tests-running
http://go/missing-test-whitelisting
In order to make it an error to define a TEST_P or TYPED_TEST_P but then never instantiate it, existing cases of that must first be white listed.
How to fix these issues (in order of how common they are):
For test suites defined and used only inside a single target
- Add INSTANTIATE_TEST_SUITE_P or INSTANTIATE_TYPED_TEST_SUITE_P to instantiate the test suite.
- Delete the test suite.
- Convert the test to a non-parameterized test (e.g. TEST_F).
For test suites defined in a library and used across several test targets:
- Remove the library from the dependencies of the targets that don't need it.
- Add INSTANTIATE_TEST_SUITE_P or INSTANTIATE_TYPED_TEST_SUITE_P to instantiate the test suite in the targets that are missing them.
- Split the library into multiple pieces so that the test can be only linked into test that actually need them.
For test suites that are only instantiated, but have no TEST_P defined:
- Delete the instantiation (e.g. if it's only ever used as a base class).
- Delete the suite?
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:290285040:BASE:290269339:1579282314889:a32da6cd
PiperOrigin-RevId: 290289392
Change-Id: I4080daa663d2d79da8accc5cdd1c51fd93135e01
diff --git a/quic/core/crypto/crypto_server_test.cc b/quic/core/crypto/crypto_server_test.cc
index 922ccc5..bddc7f3 100644
--- a/quic/core/crypto/crypto_server_test.cc
+++ b/quic/core/crypto/crypto_server_test.cc
@@ -1055,6 +1055,8 @@
// Deliberately don't add a config so that we can test this situation.
}
};
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(
+ CryptoServerTestNoConfig); // TODO(b/139702016) go/are-your-tests-running
TEST_P(CryptoServerTestNoConfig, DontCrash) {
CryptoHandshakeMessage msg = crypto_test_utils::CreateCHLO(
@@ -1076,6 +1078,8 @@
CryptoServerTest::SetUp();
}
};
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(
+ CryptoServerTestOldVersion); // TODO(b/139702016) go/are-your-tests-running
TEST_P(CryptoServerTestOldVersion, ServerIgnoresXlct) {
CryptoHandshakeMessage msg =
