commit 0e48f125c65cbc3f2523d6cc33c53d50365c64e2
author dschinazi <dschinazi@google.com> Wed Sep 04 11:56:03 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Sep 05 11:20:07 2019 -0700
tree a01762e494b6b65bd674bbd2eafd412bf873cb3e
parent 479fea3ba5c4a7733402efbecda788af75ff2e79

Prevent QuicToyClient crash on DNS failure

Before this fix, running quic_client would crash if DNS resolution fails. This change makes quic_client exit gracefully instead.

gfe-relnote: n/a, test-client-only
PiperOrigin-RevId: 267200347
Change-Id: I5272dbd646bfe9152061f1b3572483d7a3f8d40b

quic/tools/quic_toy_client.cc

diff --git a/quic/tools/quic_toy_client.cc b/quic/tools/quic_toy_client.cc
index 09e7a50..a55382a 100644
--- a/quic/tools/quic_toy_client.cc
+++ b/quic/tools/quic_toy_client.cc
@@ -218,6 +218,11 @@
   std::unique_ptr<QuicSpdyClientBase> client = client_factory_->CreateClient(
       url.host(), host, port, versions, std::move(proof_verifier));
 
+  if (client == nullptr) {
+    std::cerr << "Failed to create client." << std::endl;
+    return 1;
+  }
+
   int32_t initial_mtu = GetQuicFlag(FLAGS_initial_mtu);
   client->set_initial_max_packet_length(
       initial_mtu != 0 ? initial_mtu : quic::kDefaultMaxPacketSize);